tstromberg
f9b0c77de1
Include output in the error message
2019-10-24 13:16:59 -07:00
Medya Gh
45e5bebdb4
fixing pointer and teeSSH
2019-10-24 13:15:45 -07:00
tstromberg
82cb5a1728
Fix extra comma
2019-10-24 10:57:07 -07:00
Thomas Stromberg
8920a884c3
Minor improvements to the clarity of hypervisor errors
2019-10-24 07:45:40 -07:00
Kenta Iso
01f56844ed
Fix lint error: File is not `goimports` -ed
2019-10-24 21:32:41 +09:00
Thomas Stromberg
c925f65629
Warn about driver status, add more logging
2019-10-23 22:33:05 -07:00
Thomas Stromberg
c4fc450ad4
Add unit tests for driver
2019-10-23 20:24:03 -07:00
Thomas Stromberg
90ac694356
Add tests for new registry methods, split package into two files
2019-10-23 18:13:37 -07:00
Thomas Stromberg
118783cced
Remove dependency between minikube and kvm driver
2019-10-23 14:48:07 -07:00
Thomas Stromberg
4b63c0d973
Update hyperv driver for recent changes
2019-10-23 13:59:19 -07:00
Thomas Stromberg
86315878ae
Merge branch 'master' into drv-select2
2019-10-23 10:59:51 -07:00
Thomas Stromberg
443ae74719
Make unit tests pass again
2019-10-23 09:34:32 -07:00
Javis Zhou
68533aeccb
Fix golint failures
2019-10-23 21:15:04 +08:00
Thomas Stromberg
680b542823
Rename package files appropriately
2019-10-22 20:45:41 -07:00
Thomas Stromberg
1fc11f56f1
Add logic for picking the default driver on a host
2019-10-22 20:38:30 -07:00
Nanik T
80d20091e1
Add --config to instruct kubelet to use internal config file #5329
...
Kubelet startup parameters does not include the --config flag. This flag pass the
location of the configuration file. During minikube startup process this file
is copied over to the VM. Fix test cases.
2019-10-23 08:41:00 +11:00
Medya Gh
05bbcf733a
remove uneeded wrap output
2019-10-21 15:18:04 -07:00
Medya Gh
6e1c4f62ca
trying to fix logs
2019-10-21 13:50:00 -07:00
Medya Gh
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
Medya Gh
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
tstromberg
7581cf3e0c
Address merge conflicts
2019-10-21 11:12:06 -07:00
Medya Gh
48cd8620f2
fix stdout,stderr
2019-10-21 10:59:33 -07:00
Thomas Strömberg
cd9a6526d3
Merge pull request #5548 from blueelvis/5358-purge-flag-for-delete
...
Added flags to purge configuration with minikube delete
2019-10-21 10:26:36 -07:00
Thomas Strömberg
c8833827c1
Merge pull request #5624 from nanikjava/f-fix-4883
...
Add validation checking for minikube profile
2019-10-21 10:17:26 -07:00
Thomas Strömberg
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
tstromberg
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
tstromberg
27a23c5755
Add missing driver import
2019-10-21 09:49:09 -07:00
Thomas Strömberg
a9ca2a35cf
Merge pull request #5662 from govargo/fix-test-cache-binary-kubeadm
...
fix test case TestCacheBinary/ok_kubeadm to download linux kubeadm binary
2019-10-21 09:45:04 -07:00
Thomas Strömberg
967ce4867d
Merge pull request #5663 from afbjorklund/lint-again
...
Pick some lint from the recent master commits
2019-10-21 09:44:14 -07:00
Thomas Strömberg
dbe977d879
Merge pull request #5670 from cueo/sonar-code-smell
...
Reduce code smell reported by SonarCloud
2019-10-21 09:42:25 -07:00
Anders F Björklund
a41ac45fcc
Add missing dash before the image arch
...
This character (-) was removed by mistake, in 5fa6714
It is supposed to be "" for amd64, "-arm64" for arm64.
2019-10-20 16:07:06 +02:00
cueo
6533d9f2e8
Rename methods to match the convention
2019-10-20 19:11:31 +05:30
Pranav Jituri
b3ccd9ae46
Refactored Delete and fixed linting issues
2019-10-20 13:13:35 +05:30
Pranav Jituri
88fd869a81
Merge branch 'master' into 5358-purge-flag-for-delete
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/cluster/cluster.go
2019-10-20 12:14:44 +05:30
Pranav Jituri
2ba9cb4c1a
refactoring for delete
2019-10-20 02:19:18 +05:30
Anders F Björklund
96c39bf050
Pick some lint from the recent master commits
2019-10-19 09:37:20 +02:00
Kenta Iso
73035dcec0
fix test case ok kubeadm to download linux kubeadm binary
2019-10-19 16:09:06 +09:00
Thomas Strömberg
56a23cab4a
Merge pull request #5654 from tstromberg/delete-anyways
...
Ensure that delete succeeds even if cluster is unavailable
2019-10-18 16:06:12 -07:00
tstromberg
69e77d86d3
Fix logging strings
2019-10-18 15:50:04 -07:00
tstromberg
13cba07ec8
Fix broken cluster_test
2019-10-18 15:48:26 -07:00
tstromberg
440d0e85e6
Add driver registration back
2019-10-18 15:32:46 -07:00
tstromberg
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
tstromberg
15daa48ed7
Merge branch 'master' into drv-reorg
2019-10-18 13:01:10 -07:00
Thomas Stromberg
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
Thomas Strömberg
9db86d91fa
Merge pull request #5592 from tstromberg/sshcheck
...
Add networking validation to validateNetwork
2019-10-18 07:24:09 -07:00
Thomas Stromberg
2180c1405b
Ensure that delete succeeds even if cluster is unavailable
2019-10-17 16:23:21 -07:00
Sharif Elgamal
dc94405a34
Merge branch 'master' of github.com:kubernetes/minikube into auto-download-off
2019-10-17 15:32:09 -07:00
Thomas Strömberg
3f866515e9
Merge pull request #5563 from nanikjava/f-fix-5271
...
Make error message more human readable
2019-10-17 15:22:26 -07:00
Thomas Strömberg
ce2b0a3b9a
Merge pull request #5471 from xichengliudui/redundantCode
...
remove the redundant code in util.go
2019-10-17 15:16:40 -07:00
Thomas Strömberg
ccc2042861
Merge branch 'master' into remove-heapster
2019-10-17 15:14:49 -07:00
Thomas Strömberg
0cb5cafb59
Merge pull request #5639 from tstromberg/hyperkit-rnd
...
Speed up RNG initialization on new systemd
2019-10-17 14:54:12 -07:00
Thomas Strömberg
f679efbb8a
Merge pull request #5512 from n0npax/improve-machine-test-coverage
...
Improve machine test coverage
2019-10-17 14:51:28 -07:00
Thomas Strömberg
b89bfbe3d2
Merge pull request #5425 from n0npax/improve-translations-test-coverage
...
improve translations test coverage
2019-10-17 14:50:12 -07:00
Nanik T
824c911c42
Add validation checking for minikube profile
...
Fixes : #4883
New function ProfileNameInReservedKeywords(..) has been added inside
pkg/minikube/config/profile.go
The new function perform validation to make sure the profile name is not
in the list of keywords.
Following are the keywords that are used:
start, stop, status, delete, config, open, profile, addons, cache, logs
The checking is case insensitive to cover combo of upper and lower case
2019-10-18 08:40:18 +11:00
Thomas Strömberg
f74ac2095c
Merge pull request #5565 from RickyRajinder/enable-addons-when-minikube-not-running
...
Allow addon enabling and disabling when minikube is not running
2019-10-17 14:38:36 -07:00
Nanik T
10ff44e582
Modify output text to make it more readable as per PR comment
2019-10-18 06:28:24 +11:00
Sharif Elgamal
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
tstromberg
8ca74ef186
Use the value of --image-repository for connectivity check
2019-10-16 13:38:47 -07:00
Thomas Strömberg
7a7689bef3
Merge pull request #4780 from marekschwarz/DELETE_ALL_PROFILES
...
Added option to delete all profiles
2019-10-16 13:06:25 -07:00
Thomas Stromberg
d2f987adff
Speed up RNG initialization on hyperkit
2019-10-16 10:53:14 -07:00
tstromberg
3f6d9bbf18
Use sudo to get kubelet logs: required by permissions on v1.5 ISO
2019-10-16 10:22:38 -07:00
Medya Gh
74b7054b4a
fixing logs
2019-10-15 12:59:51 -07:00
Medya Gh
aace212e15
fix unit test, remove mount fake runner
2019-10-14 15:49:11 -07:00
Josh Woodcock
88ea55df49
Performance and security enhancment for ingress-dns addon
2019-10-13 18:04:06 -05:00
Medya Gh
390992571f
fix more stuf
2019-10-12 03:12:51 -07:00
Marcin Niemira
3dff822e8b
remove single test due to discussion on GH
2019-10-12 12:43:59 +11:00
Marcin Niemira
780112fc39
Merge branch 'master' of github.com:kubernetes/minikube into improve-machine-test-coverage
2019-10-12 12:37:06 +11:00
Marcin Niemira
b237471a17
add some tests to translate pkg
2019-10-12 12:27:38 +11:00
Marek Schwarz
d13f58fc3b
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-11 23:04:23 +02:00
Medya Gh
eac02204d9
add unit test for cmdToStr
2019-10-11 13:11:15 -07:00
Medya Gh
c71b6775d6
fix more commands to bin bash
2019-10-11 00:25:01 -07:00
RickyRajinder
96edacc0a9
Changed command runner
...
Fixed test
Print error message
Change minikube running check to after check if exists
Updates Set and adds test for disabling
Fix action for minikube not running
Fix import order
2019-10-11 00:09:28 -07:00
Medya Gh
466123aceb
fix some lint nad test
2019-10-10 13:45:59 -07:00
Thomas Strömberg
63f1a3ae27
Merge pull request #5593 from sharifelgamal/k8s-1.16.1
...
Update default Kubernetes version to 1.16.1
2019-10-10 13:40:26 -07:00
Sharif Elgamal
18966680a6
update kubeadm_test with new k8s version
2019-10-10 13:25:51 -07:00
Sharif Elgamal
2cbe4f7b71
Update default Kubernetes version to 1.16.1
2019-10-10 13:01:02 -07:00
Marek Schwarz
ae731d4393
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-10 21:22:45 +02:00
Marek Schwarz
a0c844e07e
Refactor
2019-10-10 21:22:17 +02:00
Medya Gh
f8b38d2e22
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-10 12:08:44 -07:00
Thomas Strömberg
d591d81bad
Merge branch 'master' into w/upgrade-linter
2019-10-10 09:37:56 -07:00
Medya Gh
fcf17fb42f
bin bash all the way
2019-10-10 09:23:26 -07:00
Ruslan Gustomiasov
64f1e73a25
Addon heaspter is not in use
...
Fixes #5017 . As per discussion, needed a rebase and this PR is rebased
to latest master.
2019-10-10 21:38:14 +05:30
Medya Gh
57ac160f9f
move everything to RunCmd
2019-10-10 00:03:45 -07:00
Medya Gh
7109b22249
refactor more
2019-10-09 16:06:13 -07:00
Cornelius Weig
c00d8b37c8
Fix issues found by new linter version
2019-10-09 22:42:17 +02:00
Nanik T
733f7bc3f3
Move the non-found-service test into separate function and modify the error text to include service name
2019-10-10 07:13:47 +11:00
Medya Ghazizadeh
c0e51aa37b
Merge pull request #5566 from nanikjava/f-fix-4963
...
Use configured DNS domain in bootstrapper kubeadm templates
2019-10-09 11:50:46 -07:00
Thomas Strömberg
db4ef8c714
Merge pull request #5508 from pucheGit/douga-termstyledetection
...
Adjusted Terminal Style Detection
2019-10-09 11:30:44 -07:00
Medya Gh
79e65c1b44
fix
2019-10-08 19:23:05 -07:00
Medya Gh
da5cae6af0
shellquoting more
2019-10-08 18:31:02 -07:00
Medya Gh
83f736d9ff
fix unit test for cert
2019-10-08 17:33:19 -07:00
Medya Gh
25e3d870e5
fixing with shelquote
2019-10-08 17:08:38 -07:00
Medya Gh
91618aa38b
get rid of ExecCmd all the way
2019-10-08 15:13:54 -07:00
Sharif Elgamal
4ba549a18a
Merge pull request #5487 from n0npax/improve-notify-test-coverage
...
Improve notify test coverage
2019-10-08 13:24:37 -07:00
Medya Gh
927146361c
get rid of ExecCmd2
2019-10-08 13:10:37 -07:00
Medya Gh
b8181a081f
move more to exec.Cmd2
2019-10-08 11:39:10 -07:00
Nanik T
2be877840c
Use configured DNS domain in bootstrapper kubeadm templates
...
Fixes #4963
Following are the file changes:
kubeadm.go --> Add DNSDomain as one the field
kubeadm_test.go --> Add new test case to test the dns changes
templates.go --> Add the new DNSDomain into the template
Add new testdata for the kubeadm_test.go
2019-10-08 19:30:10 +11:00
Medya Ghazizadeh
da8500a43f
Merge pull request #5492 from laozc/kubelet-systemd-perm
...
Change systemd unit files perm to 644
2019-10-07 22:46:37 -07:00
Medya Gh
0c435b050b
fix unit test for cert
2019-10-07 22:43:07 -07:00
Medya Gh
a78deab26f
adding a new ExecCmd2
2019-10-07 22:23:23 -07:00
Nanik T
75ce59d500
Fix linting
2019-10-08 10:12:35 +11:00
Nanik T
197215f85d
Make error message more human readable
...
Changes made:
* service.go - changes to the error string returned
* service_test.go - modify TestWaitAndMaybeOpenService test case to accomodate
for the new changes
2019-10-08 09:02:43 +11:00
Medya Gh
8fcdae926e
refactor
2019-10-06 22:06:29 -07:00
Medya Gh
9df56183fd
fix fakerunner runcmd unit test
2019-10-06 19:17:36 -07:00
Medya Gh
7709c77c8b
fix formatting
2019-10-06 17:07:54 -07:00
Marek Schwarz
c4107aeece
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-06 14:22:05 +02:00
Medya Ghazizadeh
63497aa383
Merge pull request #5507 from woodcockjosh/add-dns-ingress-addon
...
Add ingress-dns addon
2019-10-05 19:49:59 -07:00
Medya Gh
46442073e9
improve error wrap
2019-10-04 13:07:29 -07:00
Medya Gh
c7af9e78fa
remove extra error wrap
2019-10-04 12:57:21 -07:00
Medya Gh
36de216aa6
fixing fake_runner for interface
2019-10-04 12:51:18 -07:00
Medya Gh
27321d5f33
add ExecCmd and convert kubeadm,cert to new interface
2019-10-04 10:55:51 -07:00
Medya Gh
2f276e27ef
fix format type
2019-10-03 15:39:48 -07:00
Marek Schwarz
0c9cd491ce
Replaced driver "hyperkit" by "virtualbox" in testfiles
...
Removed debug code
2019-10-03 22:33:24 +02:00
Marek Schwarz
b8abe562b3
Added more debug code
2019-10-03 22:20:47 +02:00
Marek Schwarz
ee97b87ef9
Added debug code
2019-10-03 21:31:28 +02:00
Marek Schwarz
ae6f47d562
Appended "/.minikube" to testMinikubeDir for machine_test
2019-10-03 21:21:48 +02:00
Marek Schwarz
8a4b3b942f
Added more debug code
2019-10-03 18:41:49 +02:00
Marek Schwarz
280e11880d
Merge branch 'master' into DELETE_ALL_PROFILES
...
Explicitly unset viper MachineProfile in machine_test
2019-10-03 18:32:36 +02:00
Marek Schwarz
1efdf11abb
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-03 12:02:59 +02:00
Marcin Niemira
e73c104955
add requested comment
2019-10-03 15:30:31 +10:00
Marcin Niemira
c20fe509e3
revert filepath.Join due to discussion on GH
2019-10-03 15:25:22 +10:00
Doug A
58825d4492
Corrected Formatting Issue
...
Missing space.
2019-10-02 20:45:16 -04:00
Medya Gh
eaa01716ea
move unit tests from util to command_runner
2019-10-02 15:56:21 -07:00
Medya Gh
88183240ca
move teePrefix from util to ssh_runner
2019-10-02 15:09:42 -07:00
Medya Gh
809389c8d6
implementing new interface RunCmd for exec_runner & fake_runner
2019-10-02 14:29:14 -07:00
Marcin Niemira
5f1f109691
run goimports
2019-10-02 20:27:30 +10:00
Marcin Niemira
eff9be260f
remove unix specific files from tests
2019-10-02 18:30:08 +10:00
Marcin Niemira
079e9d75b9
fix review comments
2019-10-02 18:01:48 +10:00
Marcin Niemira
f0eb90d941
typofix
2019-10-02 17:52:31 +10:00
Marcin Niemira
a99d6e9345
msg improvement
2019-10-01 23:54:25 +10:00
Marcin Niemira
8d95d98348
self review fixes
2019-10-01 23:51:40 +10:00
Marcin Niemira
e3a84f5f60
add boilerplate
2019-10-01 23:46:07 +10:00
Marcin Niemira
6ef1ee3e17
improve test coverage in machine
2019-10-01 23:45:22 +10:00
Josh Woodcock
22cfacee29
Add ingress-dns addon
2019-10-01 04:55:16 -05:00
Doug A
c9765993c9
Adjusted Terminal Style Detection
...
Added check for COLORTERM environment variable.
2019-10-01 00:57:55 -04:00
Zhongcheng Lao
4ab0834309
Change systemd unit files perm to 644
...
systemd complains about the conf file is not world-inaccessible
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-29 23:47:49 +08:00
Marcin Niemira
a4da6a3e05
improve error msg
2019-09-29 22:55:40 +10:00
Zhongcheng Lao
f43690c92f
Fixes repository for storage-provisioner
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-29 09:07:56 +08:00
Marek Schwarz
3396f5b8ab
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-28 14:46:36 +02:00
Marcin Niemira
b4a647464b
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-notify-test-coverage
2019-09-28 20:34:55 +10:00
Zhongcheng Lao
a92493b800
Remove constant to make test happy
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 13:25:12 +08:00
Zhongcheng Lao
d891526cc0
Moves runtime constants to kubeadm package
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 12:27:46 +08:00
Zhongcheng Lao
baf0ba31ab
Rename config file const
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 12:26:06 +08:00
Zhongcheng Lao
630dba3af1
Merge remote-tracking branch 'origin/master' into crio-containerd-image-repo
2019-09-28 12:23:20 +08:00
Marek Schwarz
4551a17178
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-27 18:28:07 +02:00
xichengliudui
7ebef128f3
Remove the redundant code in util.go
...
update pull request
2019-09-27 09:35:59 +08:00
Y.Horie
291b60b4b7
move DefaultWait,DefaultInterval to service #5375
2019-09-27 07:59:46 +09:00
Y.Horie
ea60470a6c
Move ConfigFile var into localpath #5375
2019-09-27 07:59:46 +09:00
u5surf
32cae3b739
Add copyrights new file #5375
2019-09-27 07:59:46 +09:00
u5surf
8bae58695b
Move GithubMinikubeReleasesURL into notify #5375
2019-09-27 07:59:46 +09:00