Commit Graph

2412 Commits (38c6fc60f09077eb982364342b45ad38bb3c2a8e)

Author SHA1 Message Date
Yanshu Zhao 96104205af fix lint 2020-12-21 20:35:49 +00:00
Yanshu Zhao bb83ce154e Fix lint 2020-12-21 20:34:33 +00:00
Yanshu Zhao a31b851b31 docker-env cmd wait for api server to be up 2020-12-21 20:32:03 +00:00
Pablo Caderno dbbe06664c Added validation for --insecure-registry values
Fixes 8790
2020-12-20 10:00:17 +11:00
Sharif Elgamal 53d59d2c82 remove experimental warning for multinode 2020-12-17 11:13:46 -08:00
Thomas Strömberg 78163cfb90
Merge pull request #9630 from afbjorklund/ssh-host
Add ssh-host command for getting the ssh host keys
2020-12-17 08:09:29 -08:00
Priya Wadhwa 55f496492c fix merge conflict 2020-12-16 10:37:51 -08:00
Thomas Strömberg fdab252f4f
Merge pull request #9873 from lingsamuel/node-param-for-ip-and-ssh-key
Add --node option for command `ip` and `ssh-key`
2020-12-16 08:17:24 -08:00
Thomas Stromberg e5f06a1f13 Remove the vmwarefusion driver 2020-12-14 11:10:43 -08:00
AUT0R3V 375d25db07
Update start_flags.go
Using slicing technique in the place of an Array for line 141.
2020-12-14 15:12:12 +05:30
Anders F Björklund 7822a4e36e Add option to add the ssh-host key to known_hosts
This matches the ssh-add command for identity keys,
it will add the host key to the ssh known_hosts file.

If a ssh key for the host already exists in the file,
it will not be added again so can be run multiple times.
2020-12-12 18:54:33 +01:00
Anders F Björklund a387989c72 Add ssh-host command for getting the ssh host keys
This is similar to the existing minikube "ssh-key" command, but gets
the content of the host key instead of the path to the identity key.

The output of this command can be added to the ~/.ssh/known_hosts,
for strict host key authentication. For instance when using Docker.
2020-12-12 18:54:33 +01:00
Thomas Stromberg dbdbad6e69 Remove obsolete mention of kvm driver, fixes generate-docs issue 2020-12-11 12:43:18 -08:00
Thomas Strömberg 86b9397910
Merge pull request #9888 from tharun208/feat/kubeconfig_status_name
added statusName for kubeconfig
2020-12-11 10:20:33 -08:00
Medya Ghazizadeh e96b05e45e
Merge pull request #9875 from sadlil/kindnet-podcidr
Fix multi node two pods getting same IP and nodespec not having PodCIDR
2020-12-10 16:53:29 -08:00
Sadlil fc10bca4ae Enable KindNet CNI only if multi node is specified 2020-12-10 18:40:20 +00:00
Sharif Elgamal 48c5d2a03d
Merge pull request #9833 from lingsamuel/fix-node-start-master
Fix `node start` master node
2020-12-09 14:08:14 -08:00
Medya Ghazizadeh 877f1553d8
Merge pull request #9548 from afbjorklund/docker-env-ssh
Optionally use ssh for docker-env instead of tcp
2020-12-09 12:22:17 -08:00
Sharif Elgamal 6be118fc29
Merge pull request #9634 from dekkers/saving-extra-config
Fix --extra-config when starting an existing cluster
2020-12-09 11:27:03 -08:00
Thomas Strömberg c0a092e6af
Merge pull request #9379 from Git-Jiro/none_driver_nonroot
Make none driver work as regular user (use sudo on demand)
2020-12-09 10:21:49 -08:00
Tharun af3f1cfe38 added statusName for kubeconfig
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-09 11:08:15 +05:30
priyawadhwa 83f9bd1df3
Merge pull request #9793 from tharun208/feat/show_scheduled_stop_status
feat(minikube) display scheduledstop status in minikube status
2020-12-08 11:42:06 -08:00
Medya Ghazizadeh 3e670f24e0
Merge pull request #9789 from tharun208/fix/config_memory
fix unable to set memory in config
2020-12-08 10:29:11 -08:00
Medya Ghazizadeh 0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
Ling Samuel b9eedce002
Add -n, --node option for `ip` and `ssh-key` 2020-12-07 15:59:49 +08:00
Ling Samuel 278f44899e
Fix `node start` master node 2020-12-07 09:30:35 +08:00
Anders F Björklund 45befa0c1d Merge branch 'master' into docker-env-ssh 2020-12-05 13:07:29 +01:00
Tharun 4ca4491124 fixed review feedbacks on clusterstate field and tests
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:34:14 +05:30
Tharun 3f57033c60 added timetostop status in cluster layout 2020-12-05 14:33:39 +05:30
Tharun 81e27dd7b4 fixed review feedbacks
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
Tharun 1b2076122e feat(minikube) display scheduledstop status in minikube status
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
Anders F Björklund cd683b3ab5 Fix whitespace issues for goimports 2020-12-05 09:47:29 +01:00
Medya Ghazizadeh 114faa7d97
Merge pull request #9797 from msedzins/issue_9335
Ability to use a custom TLS certificate with the Ingress
2020-12-04 12:45:51 -08:00
Priya Wadhwa f373155d55 merge conflict 2020-12-03 10:56:41 -08:00
Ling Samuel 8c2e03b2a7
Fix missing InitialSetup in `node start`
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-12-03 11:22:44 +08:00
Medya Ghazizadeh 8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
msedzins e1aa07feb2 Ability to use a custom TLS certificate with the Ingress
Tutorial added
2020-11-30 22:53:27 +00:00
priyawadhwa d83b868b4f
Merge pull request #9774 from priyawadhwa/cancel-stop
Add --cancel-scheduled flag to cancel all existing scheduled stops
2020-11-30 10:03:48 -08:00
Anders F Björklund dae980a355 Add support for restoring existing podman env
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
Jeroen Dekkers 1490562c2a Fix --extra-config when starting an existing cluster 2020-11-29 12:44:15 +01:00
Tharun 5b8670c4e9 fix unable to set memory in config
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-11-27 01:22:02 +05:30
Martin Schimandl 64729fb03a Remove function 'NeedsRoot' 2020-11-26 19:54:13 +01:00
Sharif Elgamal 2a5289cd00 reintroduce crio hack for testing 2020-11-25 15:42:55 -08:00
Priya Wadhwa 70cb886a39 shorten flag name to --cancel-scheduled 2020-11-24 17:29:46 -08:00
Priya Wadhwa ad3e4a98d0 Add --cancel-scheduled-stop flag and add to integration test to make sure it works 2020-11-24 11:36:34 -08:00
Anders F Björklund 91890693ee Merge branch 'master' into docker-env-ssh 2020-11-24 20:21:21 +01:00
Priya Wadhwa 63e5021065 Merge branch 'master' of https://github.com/kubernetes/minikube into add-tracing 2020-11-24 10:29:06 -08:00
Medya Ghazizadeh 2dc88c58ea
Merge pull request #9756 from medyagh/docker_env_restart
docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container
2020-11-24 10:03:55 -08:00
Medya Ghazizadeh 02511f1c70
Merge pull request #9702 from daehyeok/print_node
Add number of nodes for cluster in `minikube profile list`
2020-11-24 09:57:03 -08:00
Sharif Elgamal ee9b5b4d49 remove restart hack for crio now that iso is fixed 2020-11-23 11:39:43 -08:00
Anders F Björklund 807bec0034 Merge branch 'master' into docker-env-ssh 2020-11-22 21:58:08 +01:00
Anders F Björklund fee0f5310a Add private network implementation for podman
Most of it the same as docker, except for the options.

i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Daehyeok Mun 97db8b5f4c Add number of nodes for cluster in `minikube profile list`
fixes \#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
2020-11-21 20:45:08 -08:00
Medya Gh 659e4ce1bd lint 2020-11-20 15:47:02 -08:00
Medya Gh 301b24ab2e lint 2020-11-20 15:45:39 -08:00
Medya Gh b498e6b288 typo 2020-11-20 15:35:04 -08:00
Medya Gh 5a443f09fb try reload dockerd first before restart 2020-11-20 15:31:05 -08:00
Anders F Björklund bf73bcc4fe Merge tag 'v1.15.1' into docker-env-ssh
1.15.1 Release
2020-11-19 17:11:02 +01:00
Priya Wadhwa 5a0ab905ed fix merge conflict 2020-11-17 15:11:23 -08:00
Medya Ghazizadeh 8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
Priya Wadhwa c4dd42a1d8 add --trace flag 2020-11-16 21:39:50 -08:00
Priya Wadhwa 0f23913f1b Tracing compiles 2020-11-16 20:31:13 -08:00
Anders F Björklund 05427245cd Merge tag 'v1.15.0' into docker-env-ssh
1.15.0 Release
2020-11-15 09:59:49 +01:00
Priya Wadhwa 1c682c6449 Merge branch 'master' of https://github.com/kubernetes/minikube into ss-windows 2020-11-13 16:34:45 -08:00
Medya Ghazizadeh 9b964853a9
Merge pull request #9672 from sadlil/driver-alias
Add Support for driver name alias
2020-11-13 16:18:05 -08:00
priyawadhwa 9438167b60
Merge pull request #9671 from Evalle/ISSUE-9664
Rename `out.T` to `out.Step`
2020-11-13 10:16:23 -08:00
Sadlil d6c0256b3e Add Support for driver name alias 2020-11-13 10:52:10 +00:00
Priya Wadhwa 21d5c01fc5 warn that this only works with docker right now 2020-11-12 14:32:23 -08:00
priyawadhwa 518ac7de56
Merge pull request #9503 from priyawadhwa/schedule-stop-unix
Implement schedule stop for unix
2020-11-12 14:20:20 -08:00
Priya Wadhwa 572e22d5a3 Merge branch 'master' of https://github.com/kubernetes/minikube into network-flag 2020-11-12 14:13:26 -08:00
Priya Wadhwa ad85a7a57e rename containernetwork to network 2020-11-12 10:36:41 -08:00
Evgeny Shmarnev f88040aad9
Merge branch 'master' into ISSUE-9664 2020-11-12 13:47:12 +01:00
Evgeny Shmarnev db93039f9c Addressing comments 2020-11-12 13:45:33 +01:00
priyawadhwa 8731ff9f23
Merge pull request #9621 from priyawadhwa/json-int-test
Fix failing TestJSONOutput/start test
2020-11-11 14:14:57 -08:00
Priya Wadhwa 9bb9355b50 fix merge conflict 2020-11-11 11:57:27 -08:00
Medya Ghazizadeh eb17495e5b
Merge pull request #9487 from prezha/status-add-watch-flag
add --watch flag for minikube status with optional interval duration
2020-11-11 11:50:43 -08:00
Sharif Elgamal 0f408d9d44
Merge pull request #9385 from bluestealth/8990
Improve parsing of start flag apiserver-names
2020-11-11 11:14:58 -08:00
Predrag Rogic 7cc4676d4a
move write statuses logic to a separate func 2020-11-11 00:29:25 +00:00
Predrag Rogic 95e6afb1b9
move write statuses logic to a separate func 2020-11-11 00:29:25 +00:00
Predrag Rogic f57d9bfa73
add --watch flag for minikube status 2020-11-11 00:25:32 +00:00
Priya Wadhwa 5569817c26 Address code review comments 2020-11-10 10:58:31 -08:00
Priya Wadhwa 291e5b6927 fix merge conflict 2020-11-10 10:49:37 -08:00
Thomas Strömberg b9615bf220
Merge pull request #9390 from prezha/json-output-cleanup
reword error message when cluster state exit code is not found
2020-11-10 10:27:25 -08:00
Thomas Strömberg ea74ac9c1b
Merge pull request #9534 from vinu2003/fix_invalid_profile_creation
stop: removed setEventLogPath for stop process
2020-11-10 10:24:10 -08:00
Priya Wadhwa 253b0bafb1 Merge branch 'master' of https://github.com/kubernetes/minikube into json-int-test 2020-11-09 17:53:52 -08:00
Ilya Zuyev 76c62afddb Fix unit tests for "podman-env --unset" 2020-11-09 14:21:42 -08:00
Ilya Zuyev 0f2c63881a Merge branch 'master' into gh_9463_non_dev_dockerhost 2020-11-09 14:11:20 -08:00
Priya Wadhwa 7570cbd904 fix merge 2020-11-09 13:53:05 -08:00
Priya Wadhwa 635f2a71b5 fix lint 2020-11-09 13:52:51 -08:00
Ilya Zuyev aa6a693142 Fix unit tests for "[docker|podman]-env --unset" 2020-11-09 13:44:52 -08:00
Priya Wadhwa cf1ee6b072 Address review comments 2020-11-09 13:33:18 -08:00
Anders F Björklund 88b884378e Show result from running the ssh-add command 2020-11-08 15:28:27 +01:00
Anders F Björklund d2e2ecaf40 Add option to add the ssh key to the ssh agent 2020-11-08 15:23:41 +01:00
Predrag Rogic 432762f9e3
Update generate-docs test to include --help flag 2020-11-07 23:40:41 +00:00
Predrag Rogic 1a9a54e458
Update generate-docs test to include --help flag 2020-11-07 23:07:35 +00:00
Predrag Rogic 0c3843bfc6
call 'strings.ToLower(output)' only once 2020-11-06 22:28:26 +00:00
Priya Wadhwa e050e8c9bd Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix 2020-11-06 13:41:53 -08:00
Priya Wadhwa ab98bbf858 Fix failing TestJSONOutput/start test 2020-11-06 13:34:50 -08:00
Medya Ghazizadeh 3bb967a0b4
Merge pull request #9506 from prezha/add-namespace-support
new flag  --namespace
2020-11-06 12:20:09 -08:00
Medya Ghazizadeh 7747655476
Merge pull request #9535 from afbjorklund/podman2-env
Add support for podman v2 to podman-env command
2020-11-06 12:17:52 -08:00
Priya Wadhwa cca624698e switch exit to warning 2020-11-06 12:17:48 -08:00
Priya Wadhwa a00b7a38e2 Use DurationVar instead of StringVar for flag 2020-11-06 11:58:21 -08:00
Priya Wadhwa 7788cb93d8 Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix 2020-11-06 11:38:26 -08:00
Predrag Rogic 7d99c66efa
fix help flag 'pflag: help requested' error 2020-11-06 02:42:52 +00:00
Priya Wadhwa 19b2be23bc fix merge conflict 2020-11-05 14:31:39 -08:00
Priya Wadhwa f869ca5e91 fix merge conflict 2020-11-05 09:44:47 -08:00
Predrag Rogic d49f4173b3
update --namespace flag description 2020-11-04 22:14:00 +00:00
Predrag Rogic 3427f078c3
add support for namespace 2020-11-04 22:13:45 +00:00
Michael Ryan Dempsey 7a133bd17e
improve parsing of start flag apiserver-names 2020-11-03 10:59:26 -08:00
vinu2003 ec8e2a4f9c Added check to verify profile path exists 2020-11-03 23:25:32 +11:00
Anders F Björklund 274be7f52d Split template for docker tcp and ssh in two vars 2020-11-01 15:15:06 +01:00
Anders F Björklund bfefa72815 Split template for podman v1 and v2 into two vars 2020-11-01 15:14:20 +01:00
Anders F Björklund b57bf9abcf Refactor dockerUnsetScript with a helper function 2020-11-01 15:07:02 +01:00
Martin Schimandl 4da751f5d7 Make none driver work as regular user (use sudo on demand) 2020-11-01 14:54:20 +01:00
Anders F Björklund 9f983a8f99 Refactor podmanUnsetScript with a helper function 2020-11-01 14:46:13 +01:00
Predrag Rogic 20a1274c7c
implement "--log_file" and "--log_dir" for klog 2020-10-31 19:57:25 +00:00
vinu2003 bfd2da1b65 removed setEventLogPath for stop process 2020-10-31 18:12:39 +11:00
Ilya Zuyev 69c2b01660 Fix shell arg parsing 2020-10-30 14:39:59 -07:00
Priya Wadhwa 3c8d3cad7c Merge branch 'master' of https://github.com/kubernetes/minikube into json-output-stop 2020-10-29 13:44:32 -07:00
Priya Wadhwa 39ab9ffc5b Add --output flags to pause and unpause as well 2020-10-28 13:16:17 -07:00
Sharif Elgamal 5c5a8e160a account for not setting context, remove debugging 2020-10-28 12:44:58 -07:00
Sharif Elgamal 4a1c9583bd initial attempt to account for profile in directly kubectl case 2020-10-28 12:16:02 -07:00
Priya Wadhwa 473120648f Add JSON output to minikube stop 2020-10-28 11:30:11 -07:00
Ilya Zuyev e0b4957fcc Fix docker-env -u shell detection 2020-10-27 16:48:20 -07:00
Priya Wadhwa 02f03af101 exit if using --schedule with windows as it is not yet supported 2020-10-26 15:17:24 -07:00
Sharif Elgamal 055de4edf8 return stopped profile status quickly 2020-10-26 13:20:03 -07:00
Priya Wadhwa ea6ca08d67 Change flag name to --network and exit if used without docker driver 2020-10-26 11:52:26 -07:00
Anders F Björklund 7841aea2db Optionally use ssh for docker-env instead of tcp
Since Docker 18.09, it supports ssh: as well as tcp:
for connecting to the docker daemon (in $DOCKER_HOST).

This avoids setting up certificates, but leaves key
handling (host keys and identity keys) to ssh config.
2020-10-25 14:16:28 +01:00
Priya Wadhwa 865d3a4a34 Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix 2020-10-23 18:15:07 -07:00
Priya Wadhwa fe2710705e Add --docker-network flag 2020-10-23 09:31:33 -07:00
Anders F Björklund 716d793990 Add support for podman v2 to podman-env command
Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.

Both are using ssh for their transport, but the
environment variables exported are different.
2020-10-23 11:46:45 +02:00
Predrag Rogic d0c0d8b54c
revert suppression of emitting errors to stderr 2020-10-22 09:28:31 +01:00
Thomas Strömberg dedf38b61f
Merge pull request #9368 from kadern0/issue-8445
Added deprecation warning for --network-plugin=cni
2020-10-21 08:53:50 -07:00
Ilya Zuyev 85d45be207 Fix docker-env command 2020-10-20 23:10:08 -07:00
Priya Wadhwa a54ea82e3b Implement schedule stop for unix 2020-10-20 13:45:59 -07:00
Predrag Rogic e7f9b3e954
don't pollute json output with errors
additionally:
 - issue warning insted of error if 'exitCode' is not found
 - rebase: use klog instead of glog

don't pollute status json output with errors
2020-10-18 19:56:28 +01:00
Medya Ghazizadeh 29f00628f5
Merge pull request #9459 from medyagh/stopped_kubelet
new --wait component "kubelet"
2020-10-15 12:25:11 -05:00
Sharif Elgamal 06a64de853
Merge pull request #9417 from joshmue/fix_ssh_native_toggle
Fix "--native-ssh" flag of "minikube ssh"
2020-10-14 10:30:51 -07:00
Medya Gh 63c4468fd5 address review comments 2020-10-13 16:01:59 -07:00
Pablo Caderno 1d85d6e123 Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-10-12 19:27:25 +11:00
Priya Modali 59548194bd Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-09 17:45:35 -07:00
Joshua Mühlfort 8cfe5c1a7b Fix "--native-ssh" flag of "minikube ssh"
In the previous state, the flag was discarded. This commit fixes
that and also makes sure that the SSH client is created after the
default client type is configured according to the flag.
2020-10-09 09:41:19 +02:00
Priya Modali 2985e8a21e Updating unit tests. 2020-10-08 15:10:50 -07:00
Medya Ghazizadeh c459fea74d
Merge pull request #9414 from prezha/delete-context-when-stopped
Delete context when stopped
2020-10-08 15:12:50 -05:00
Priya Modali ab4a0ab558 Cleaning up flags parsing. 2020-10-08 11:18:50 -07:00
Medya Ghazizadeh 32922f4184
Merge pull request #9412 from Asarew/fix-panic-on-updating-mount-after-creation
fix panic when updating mount-string with KiC driver after cluster creation without mount configuration
2020-10-08 13:07:31 -05:00
Priya Modali ef2090ac31 Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-08 10:27:04 -07:00
Predrag Rogic c63de60aba
add HostKubeconfigDeleteCtx Reason Exit 2020-10-07 22:58:20 +01:00
Priya Modali 85b722c7b6 Setting klog default flag values. 2020-10-07 14:19:35 -07:00
Predrag Rogic 65a2618485
delete context when minikube is stopped 2020-10-07 22:00:26 +01:00