535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
a767b64b41
fix merge conflict
2020-08-21 21:40:32 -04:00
88aece40d2
change name
2020-08-21 15:05:37 -04:00
97acf408e0
fix error wording
2020-08-21 13:34:06 -04:00
e9cfbd0098
add an new flag to stop command --keep-context-active
2020-08-21 10:27:28 -07:00
acd6589c5d
Remove debugging
2020-08-21 09:56:03 -04:00
44b93f4776
Change MemoryCapacity to StorageCapacity to be more accurate
2020-08-21 09:49:48 -04:00
482b2bf624
additional debugging
2020-08-20 17:23:04 -04:00
344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
...
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
7eda3a7711
Create new exit code for InsufficientStorage
2020-08-20 15:27:06 -04:00
83eba00d47
add deubgging
2020-08-20 14:42:55 -04:00
6e8f596eac
Fix --memory flag parsing in minikube start
...
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
906bcb9cab
fix typo miniube
...
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')
Fixes : #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
1783cc2939
Make sure minikube status shows status name and details
2020-08-19 13:32:36 -04:00
3dba974535
Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
...
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
2020-08-19 13:25:48 -04:00
9708036592
Updated default cmd string when minikube is run as kubectl
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 21:20:50 +10:00
10a3f2e2a8
Running internal kubectl command when minikube is called as 'kubectl'
...
Fixes issue #8857
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 20:52:58 +10:00
51110dbbe8
Merge pull request #8969 from priyawadhwa/cpu-limit
...
skip validations if --force is supplied
2020-08-11 18:16:13 -04:00
f122deeaf3
suggest --force for k8s version
2020-08-11 15:42:05 -04:00
506279c585
change function name
2020-08-11 15:38:42 -04:00
a69b41932c
improve error handling
2020-08-11 14:56:19 -04:00
74309a83e6
include memory check
2020-08-11 14:22:10 -04:00
789dfca804
skip vaildations if --force is supplied
2020-08-11 14:16:40 -04:00
b0afc85327
dont fail on memory check if cpu and disk checks fail
2020-08-11 10:40:40 -07:00
84d198d8b5
refresh cache if there was error
2020-08-11 10:40:40 -07:00
5cb47d75af
return list of errors for cached host info
2020-08-11 10:40:40 -07:00
2b7aaa3f49
avoid duplicate warnings
2020-08-11 10:40:40 -07:00
8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
...
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
9354d2c0e5
Removed extra flag add.
...
Set default value if not specified by the user.
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
ab77860c5e
fix typo
2020-08-10 16:21:58 -07:00
9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
...
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
37a1d3bc0b
Added startHostTimeout flag
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
e783af2bef
fill up cpu memory if config is missing
2020-08-04 13:26:33 -07:00
e87400db53
addres review comments
2020-08-04 13:26:33 -07:00
b71a7dceca
use cached hostinfo instead
2020-08-04 13:26:33 -07:00
d782f80e23
bring back check for dry run
2020-08-04 13:26:33 -07:00
e59a026450
update comments
2020-08-04 13:26:33 -07:00
71394c43e7
advice user when they allocate too much memory
2020-08-04 13:26:33 -07:00
5923634095
don't set event log on deletion
2020-08-03 14:22:13 -07:00
7ef3a8c11a
respect native-ssh flag
2020-08-03 09:48:30 -07:00
9b86b40536
misspelling
2020-07-30 22:16:32 -07:00
43d23b8937
change bad comment
2020-07-30 21:40:45 -07:00
6e9e0b7866
better message output
2020-07-30 16:43:59 -07:00
7a08028c1e
fix lint
2020-07-30 15:21:43 -07:00
61583d6249
upgrade crio to 1.18.3, ubuntu to 20.04 and add terrible hack to fix restarts for cri-o
2020-07-30 15:11:30 -07:00
bb57ae0c15
Ignore localhost proxy started with scheme. Fix start_test.
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-07-30 16:17:04 +08:00
47435d94a7
Merge pull request #8868 from tstromberg/minimal-transition-state
...
status: Add experimental cluster JSON status with state transition support
2020-07-29 16:00:39 -07:00
59d0d7335a
Add HTTP-like status codes, remove unused fields
2020-07-29 13:57:06 -07:00
245e37dd07
Merge pull request #8589 from alonyb/w/cleanup-unittest-improved
...
add new method to clean
2020-07-29 14:43:04 -04:00
649b3789d9
lint error
2020-07-28 13:53:18 -07:00
aa3d2a2a8a
Improve handling of pause/unpause/stop/delete steps
2020-07-28 13:26:09 -07:00
ac1f901160
Allow non-start steps
2020-07-28 13:07:37 -07:00
c539c82406
Merge branch 'master' into minimal-transition-state
2020-07-28 11:53:33 -07:00
e60cfa5d0d
Minimum viable transition status implementation
2020-07-28 11:53:30 -07:00
1f5fc25ae0
address review comments
2020-07-28 10:53:36 -07:00
1eaa6b4306
only suggest to user to enable metric addon and don't autoeanble
2020-07-28 09:20:51 -07:00
448ec75c8c
Add support for storing/retrieving transient status
2020-07-27 21:34:52 -07:00
f07a63cfe9
Merge pull request #8838 from angyvolin/fix-doc-typo
...
fix doc typo
2020-07-27 10:58:01 -07:00
8578e09d3f
Enabling metrics addon when someone enables dashboard
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-07-27 08:43:41 +10:00
1070bb5267
fix doc typo
2020-07-25 12:26:37 +03:00
8ec8d1cd82
Set preload=false if not using overlay2 as docker storage driver
2020-07-24 13:42:15 -04:00
a31e359b01
fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver
2020-07-23 11:47:16 +02:00
6ee3954336
Add extra validation to json output test
2020-07-22 12:52:15 -04:00
280c2511f7
Merge pull request #8782 from sharifelgamal/regen-config
...
regenerate config on retry
2020-07-21 13:29:32 -07:00
c4cad39fac
properly regenerate config
2020-07-21 12:02:09 -07:00
ae5f5216cb
fix typo
2020-07-21 14:46:37 -04:00
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
f33ac4c221
regenerate config on retry
2020-07-20 15:26:18 -07:00
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
46a4377498
Merge pull request #8738 from tstromberg/kic-image-upgrade2
...
Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade)
2020-07-17 09:56:27 -07:00
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
2fd7492377
Guard against nil panics
2020-07-16 19:50:00 -07:00
7d7b9d6fb9
Move KicBaseImage adjustment to upgradeExistingConfig
2020-07-16 19:44:07 -07:00
78f7b3cc66
Add upgradeExistingConfig to upgrade legacy configurations
2020-07-16 19:36:50 -07:00
51cc365898
Handle case where VMDriver is set, but Driver is not
2020-07-16 19:35:44 -07:00
0bca9bb84e
Fix v1.9.x upgrade by populating missing KicBaseImage configuration
2020-07-16 17:37:26 -07:00
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
b03ad456ef
spell
2020-07-15 14:10:56 -07:00
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
dbfd16f21e
add helper fucns for drivers
2020-07-14 15:02:54 -07:00
9acc975e17
put back vadidateMemorySize
2020-07-14 13:43:43 -07:00
41a1ba52e6
add cached kic system info
2020-07-14 13:40:13 -07:00
03e9cb7909
exit with less than 1 cpus
2020-07-13 17:15:38 -07:00
b45fd2df8b
docker podman drivers: warn if memory is above limit
2020-07-13 16:59:11 -07:00
e52cd9b366
use ds name
2020-07-13 13:29:06 -07:00
29c99cc221
imrove advice when driver was auto-selected
2020-07-13 13:17:51 -07:00
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
442bc138ce
Merge pull request #8676 from priyawadhwa/info
...
Add Infof function to out package
2020-07-10 17:08:30 -04:00
45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
...
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
589b6b0340
Add text option
2020-07-10 16:35:45 -04:00
d19754b2ca
Merge pull request #8591 from sunny-b/prevent-duplicate-k8s-upgrade-msg
...
Prevent start cmd from logging multiple k8s upgrade messages
2020-07-10 10:45:12 -07:00
87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
...
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
...
A few cleanup
2020-07-08 14:52:28 -04:00
290f48f98e
Add Infof function to out package
2020-07-08 11:00:32 -04:00
1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
...
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
f68716e2da
Set up logic for steps
2020-07-06 15:12:13 -04:00
10ba39cd3c
Add --output=json flag and hook it up to out package
2020-07-06 12:32:34 -04:00
42dd86fcd3
Update feedback when validation fails.
2020-07-05 12:20:24 +01:00
84eea2f487
recreate hosts on failed provisioning if delete-on-failure is specified
2020-07-01 12:57:59 -07:00
66314d87f3
add unit test for docker-env with none shell
2020-07-01 10:59:23 -07:00
f8e6ae6787
remove unnecessary comment
2020-06-30 20:01:13 -04:00
de4adc6d00
create validateKubernetesVersion check and move validation logic
2020-06-30 19:59:12 -04:00
1529a0d761
prevent start cmd from logging multiple k8s upgrade messages
2020-06-30 18:25:28 -04:00
52e19e1bc9
merge conflict typo
2020-06-30 10:11:06 +02:00
7bcae732bf
resolved merge conflicts
2020-06-30 10:00:52 +02:00
9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
...
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
28238150f5
ensure that 'crio' is used for k8s config
2020-06-29 19:52:30 -04:00
3bc3ce95de
refactor maybeExitWithAdvice
2020-06-29 14:38:37 -07:00
08df5e2de3
add solution message if kbueadm is not executble on linux
2020-06-29 12:50:32 -07:00
9bcc587def
update crio to cri-o in docs and help text
2020-06-29 14:11:20 -04:00
5f40f863a7
update docs
2020-06-28 20:43:12 -04:00
5da2fdd922
enable graceful exit if container runtime is misspelled
2020-06-28 18:57:03 -04:00
b470860a5a
fix condition check for extraOpts validation
2020-06-28 22:35:40 +03:00
ccffa40cfe
bsutil: extra-opts validation
2020-06-28 22:35:40 +03:00
23eff45faf
add cleanup in another test
2020-06-28 11:34:28 -05:00
c5021ead32
add err validation
2020-06-28 11:14:23 -05:00
5c7dd4d941
add new method to clean
2020-06-28 10:24:21 -05:00
42af47b909
Do not auto-set extra config that user wishes to override
2020-06-27 16:26:07 -07:00
ffcb14a6b2
Add support for Cilium CNI (--cni=cilium)
2020-06-26 11:55:30 -07:00
f901e638f2
Add support for Calico CNI (--cni=calico)
2020-06-26 11:21:15 -07:00
ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
...
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
2a39d993ea
Address lint comments, remove confusing multi-runner API
2020-06-25 14:36:39 -07:00
134ec1b144
changed `--docker-volume` flag logic to work from `--mount-string` and `--mount` flags
2020-06-25 09:16:04 +02:00
9e95435e00
Add --cni flag, fix --network-plugin=kubenet
2020-06-23 20:10:25 -07:00
0121b44175
add NeedsImprovement warnning for overlay kernel
2020-06-23 13:17:59 -07:00
ce33161eef
Merge pull request #8528 from tstromberg/docker-not-required
...
docker-env: Avoid container suicide if Docker is not installed locally
2020-06-22 17:45:47 -07:00
3d09d8e6ae
Merge pull request #8521 from afbjorklund/kubectl-path-log
...
The logging of the kubectl path was broken
2020-06-22 14:37:39 -07:00
47942be198
docker-env: Avoid container suicide if docker is not in $PATH
2020-06-22 12:27:18 -07:00
30e6660925
Better informaation for using kubectl inside minikube
...
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
add kubectl install link
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
add alias tip to the minikube docs
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
remove debug statements
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-20 18:20:28 +05:30
fe6687386d
The logging of the kubectl path was broken
...
After introducing the exec.Cmd parameter previously
2020-06-20 14:31:35 +02:00
fe9e0e8950
Merge pull request #8506 from Harkishen-Singh/unset-docker-podman-env-vars-without-machine-running
...
Adds support for unsetting of env vars
2020-06-18 11:57:29 -07:00
e91e11eeba
address review comments
2020-06-17 18:32:11 -07:00
ca2d0f97ec
move advice to its own file
2020-06-17 15:07:17 -07:00
d32b8d81fe
improve solution message
2020-06-17 14:26:31 -07:00
bdf7c196a1
add detailed suggestions when created container exists
2020-06-17 14:09:51 -07:00
e25445dea9
capitalize the Desktop word
2020-06-17 11:51:43 -07:00
8d1e4e2d26
adds support for unsetting of environment variables without the need of running container-machine
...
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-17 23:54:00 +05:30
e3ef5f9a95
address review comments
2020-06-16 15:03:56 -07:00
56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
c2e71996a8
Point multi-node *-env users to the registry addon
2020-06-15 12:38:28 -07:00
24b2a69981
fix disable heapster message
2020-06-13 01:06:57 +09:00
d7a9721712
Avoid SIGSEGV when heapster addon will be disabled
2020-06-13 00:46:12 +09:00
d76b58c3ae
Add heapster alias to metrics-server addon
2020-06-13 00:46:12 +09:00
Priya Wadhwa
Medya Gh
Thomas Strömberg
Anshul Sirur
Li Zhijian
Pablo Caderno
Medya Ghazizadeh
Sharif Elgamal
Ling Samuel
Andrii Volin
Asare Worae
James Lucktaylor
Sun-Li Beatteay
Sunny Beatteay
Ilya Danilkin
Alonyb
Prasad Katti
Harkishen-Singh
Anders F Björklund
Kenta Iso