Commit Graph

2240 Commits (3207b27c11ca8ad5c27d63773ee39ff57d86d3d7)

Author SHA1 Message Date
Medya Ghazizadeh 6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
Zhou Hao 7e0b89cc9d code optimization
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
Medya Ghazizadeh 444b36161b
Merge pull request #6193 from q384566678/oci-status
kic/oci: parse all kind of states
2020-01-07 14:54:42 -08:00
Medya Ghazizadeh be79843f75
Merge pull request #6214 from laozc/hostport-join
Fixes IPv6 address handling in kubeadm
2020-01-07 11:45:32 -08:00
Medya Ghazizadeh d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
Thomas Strömberg af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
Priya Wadhwa 6ad7e4a9a0 address code review comments
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
Anders F Björklund ea7a2d7e33 Improve reportcard by refactoring and commenting
golint: 99%
	pkg/minikube/localpath/localpath.go
		Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
	pkg/minikube/cluster/cluster.go
		Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
	cmd/minikube/cmd/start.go
		Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
		Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Kim Bao Long f388f69220 Remove duplicated words
Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-06 15:54:27 +07:00
Zhongcheng Lao 5f8a4503eb
Fixes IPv6 address handling in kubeadm
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-05 23:37:00 +08:00
Zhou Hao 62bfc39404 Fix comment
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-03 09:31:55 +08:00
Zhou Hao c1859c44e3 kic/oci: parse all kind of states
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
Medya Ghazizadeh e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
Priya Wadhwa e47cde6ae4 Rebased on master, moved istio addon into new package 2019-12-30 10:10:05 -05:00
Zhou Hao 9c4e3fbd3c pkg/drivers/kic: fix wrong command in Unpause
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
Zhou Hao ae61e56594 pkg/drivers/kic/oci: fix Status info
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
Zhou Hao aa52255be0 pkg/drivers/kic/oci: delete TODO info
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜  minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜  minikube git:(oci-remove-todo) ✗ echo $?
125

So delete this TODO info.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
Medya Ghazizadeh df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa c2ba574f2e generate istio document page and layout 2019-12-26 14:35:13 +08:00
Medya Ghazizadeh ce4b9503ae
Merge pull request #6137 from q384566678/add-constants-test
Add constants_test
2019-12-23 01:13:50 -08:00
Medya Gh d5f56477bc code review resolve 2019-12-20 17:14:14 -08:00
Medya Gh 3b2cfa6c32 rename funcs 2019-12-20 16:53:35 -08:00
Medya Gh 83cd426436 refactor more 2019-12-20 16:11:05 -08:00
Medya Gh cf6bde8eaf refactor image specific funcs to image package 2019-12-20 16:05:08 -08:00
Medya Gh cde5503d3e add two mechanism to find local image digest 2019-12-20 14:09:18 -08:00
Medya Gh 9d03e56ece resolve merge conflict 2019-12-20 12:44:09 -08:00
Medya Gh be8a1ad107 resolve code reviews 2019-12-20 12:43:13 -08:00
Priya Wadhwa 6c25cd3848 Rebased on master 2019-12-20 12:34:48 -08:00
Medya Gh 5eb384cf7d check error and fix logging msg 2019-12-20 12:24:05 -08:00
Medya Gh 502f3b7f8f use docker cli lib to get image id 2019-12-20 12:18:55 -08:00
Medya Gh 4d9e53389a improve logging 2019-12-20 12:12:48 -08:00
Medya Gh 2d1fffe1d1 better names 2019-12-20 12:06:26 -08:00
Medya Gh 679a9c114b more clear func names 2019-12-20 12:06:26 -08:00
Medya Gh 71a896fc0a unexport func cacheImage 2019-12-20 12:06:25 -08:00
Medya Ghazizadeh 031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
kic-xmas edition
2019-12-20 11:40:46 -08:00
Zhou Hao 2167655006 add unit test for GetDNSIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:32:50 +08:00
Zhou Hao 6a5497510a add unit test for GetServiceClusterIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:27:24 +08:00
Medya Gh f9e7a54eb8 rename kicdocker to docker 2019-12-20 01:26:38 -08:00
Medya Gh f39ba0deb0 add unit test for feature gate supports 2019-12-20 01:17:33 -08:00
Medya Gh 1014a57ea8 better names for bs type 2019-12-20 01:01:10 -08:00
tstromberg cae166e74c Merge branch 'master' into advice-refresh 2019-12-19 16:23:25 -08:00
tstromberg f438bb7ec8 Merge branch 'master' into less-catastrophic 2019-12-19 16:15:47 -08:00
tstromberg 512b3cb314 Refresh advice, flip hide vs show default for links 2019-12-19 16:04:34 -08:00
Medya Gh 7360edc8e0 add kic cni 2019-12-19 15:11:22 -08:00
Priya Wadhwa 83aca57dd4 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:20:12 -08:00
Priya Wadhwa 859420c083 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:06:07 -08:00
tstromberg 6cc860e911 Add build tags so that the test only runs on Darwin 2019-12-19 13:05:47 -08:00
tstromberg 0796d866df Further clarification 2019-12-19 12:51:02 -08:00
Thomas Strömberg 4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg 28c4c82bd7
Merge pull request #5833 from govargo/fix-without-hyperkit-errormsg
Add hyperkit version check whether user's hyperkit is newer
2019-12-19 11:44:58 -08:00