Commit Graph

2704 Commits (31d93367a313e6ed4445cb6ba02d6e4a13c0ab70)

Author SHA1 Message Date
Medya Ghazizadeh cd73e832dd
Merge pull request #11371 from afbjorklund/driver-alternate
Fix error picking non-default alternate drivers
2021-05-17 18:54:43 -07:00
Medya Gh f6a89cea06 goimport 2021-05-17 18:39:09 -07:00
Brian de Alwis 49fb17d9fc Add "resume" as an alias for "unpause" 2021-05-17 18:34:11 -07:00
Anders F Björklund 6d0763648e Keep original preference, for identical priority
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
Anders F Björklund dedfdfbfcf Sort rejected drivers by their preference order
Don't show drivers not being selected by default
2021-05-15 09:41:12 +02:00
ilya-zuyev 2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Evan Baker eca8a2d540
fix typo in flag documentation: sytemd -> systemd
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2021-05-14 17:00:03 -05:00
Medya Ghazizadeh 33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Daehyeok Mun 7c2e963392 Implement target node option for cp command 2021-05-13 10:47:09 -07:00
VigoTheHacker a086536f38 Merge branch 'kubernetes:master' into issue-11382 2021-05-13 15:15:12 +05:30
Peixuan Ding 7b98243ea3 Add missing apiserver-names config update 2021-05-13 02:02:34 -04:00
Peixuan Ding d156e5cbed Fix TestKubernetesUpgrade
Signed-off-by: Peixuan Ding <pding@freewheel.com>
2021-05-12 21:35:22 -04:00
VigoTheHacker 5246729910 use global variables in logFileName 2021-05-13 06:44:57 +05:30
Steven Powell 9d3ee7e2e1 use overwrite flag for local images 2021-05-12 14:26:34 -07:00
Steven Powell e59ced9029 updated flag description and renamed force arg to overwrite and made it non-optional 2021-05-12 14:26:34 -07:00
Steven Powell 826f1852ab replace over-write with overwrite 2021-05-12 14:26:34 -07:00
Steven Powell 83366b7929 added over-write flag for image load 2021-05-12 14:26:32 -07:00
Steven Powell 32a91d6eb2 image load loads image even if name:tag already exists 2021-05-12 14:24:49 -07:00
VigoTheHacker eca1d9e4f2 change the funnction param value from a global variable to a locally set variable 2021-05-12 23:58:35 +05:30
Anders F Björklund 6ea3ffee1f Show suggestion for rejected unhealthy drivers
Normally how to add root permissions for the user, to be able to
run the "docker" or "podman" driver (through group or through sudo)
2021-05-12 07:15:26 +02:00
VigoTheHacker 5f3b63fb30 read the first non flag argument for the lag file name 2021-05-12 08:50:16 +05:30
Medya Ghazizadeh c214b040e6
Merge pull request #11381 from sharifelgamal/test-doc
Make sure all tests have comments
2021-05-11 18:05:36 -07:00
Sharif Elgamal 8b67bf15e5 fix error message 2021-05-11 15:26:23 -07:00
Sharif Elgamal 971c74f381 fix spelling 2021-05-11 15:23:07 -07:00
Sharif Elgamal 972dae8133 Make sure all tests have comments 2021-05-11 15:17:43 -07:00
Medya Ghazizadeh c136fe3cfd
Merge pull request #11060 from afbjorklund/retro-arch
Allow building minikube for outdated architectures
2021-05-11 12:22:03 -07:00
ilya-zuyev 1f2d50f297
Merge pull request #11247 from hex0punk/goroutine-leak-fix
Goroutine leak fix
2021-05-11 12:02:54 -07:00
Anders F Björklund 97b152f9a8 Fix error picking non-default alternate drivers
We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...
2021-05-11 18:00:39 +02:00
Anders F Björklund fb728a8893 Switch place of minikube image ls and list
Just to make it more similar to the docker image commands.

Both ls/list and rm/remove are equivalent commands, though.
2021-05-09 09:37:02 +02:00
Medya Ghazizadeh 8f167f4213
Merge pull request #10899 from daehyeok/overwrite_flag
Refactoring generate/update config file code.
2021-05-07 16:30:15 -07:00
Medya Ghazizadeh a2d62511d2
Merge pull request #11191 from zhijianli88/shell-completion
completion: add specific shell completion
2021-05-07 16:16:54 -07:00
Daehyeok Mun 50637dd149 clean up `updateExistingConfigFromFlags` function.
Add missing flags to overwrite.
Reuse validate/set function from `generateNewClusterConfig`
2021-05-06 14:07:43 -07:00
Daehyeok Mun afc9ed5222 Clean up `generateNewConfigFromFlags` function
split validate/set code with helper function to reuse later.
2021-05-06 14:07:43 -07:00
Medya Ghazizadeh 65692f3181
Merge pull request #11294 from andriyDev/UsernameMixin
Add the current user's name to log file hashes to prevent collision.
2021-05-06 10:22:46 -07:00
Andriy Dzikh 5776597eb3 Move deferred close to before error exit. 2021-05-05 16:18:15 -07:00
Andriy Dzikh 98f4d4706b Add --file flag to 'minikube logs' to automatically put logs into a file. 2021-05-05 16:18:15 -07:00
Andriy Dzikh 65c0f0ff35 Add the current user's name to log file hashes to prevent collision. 2021-05-05 12:38:47 -07:00
Sharif Elgamal e27e9a1e1b return pointer to k8sissue 2021-05-03 12:25:17 -07:00
Sharif Elgamal 9dbe957234 Merge branch 'master' of github.com:kubernetes/minikube into warn-k8s 2021-05-03 12:22:34 -07:00
hex0punk 2474931ab3 prevents a goroutine from being leaked in call to readByteWithTimeout 2021-04-29 22:48:05 -07:00
hex0punk f0226e50a9 Revert "prevents a goroutine from being leaked in call to readByteWithTimeout"
This reverts commit 8810120de6.
2021-04-29 22:45:39 -07:00
hex0punk 8810120de6 prevents a goroutine from being leaked in call to readByteWithTimeout 2021-04-29 22:42:33 -07:00
Predrag Rogic 394def7a74
identify appropriate cni then configure cruntime accordingly 2021-04-29 23:36:46 +01:00
ilya-zuyev 9947c61a83
Merge pull request #11185 from prezha/workout-cni-and-cruntimes
improve how cni and cruntimes work together
2021-04-29 15:01:18 -07:00
Medya Ghazizadeh ac2b98d744
Merge pull request #11169 from spowelljr/addBetaNotifications
Add opt-in notifications for beta releases
2021-04-29 14:03:59 -07:00
Li Zhijian 5943260780 completion: add specific shell completion
Previously, `minikube completion` is unable to auto-complete the
specific shell as other go-lang applications. For example, when user
type below command:
```
minikube$ minikube completion <tab> <tab>
```
In minikube, there is no candidate shells coming up, which is different
from kubectl:
```
$ kubectl completion <tab> <tab>
bash  zsh
```

After this patch, as following, the candidata shell appears:
```
minikube$ minikube completion <tab> <tab>
bash  fish  zsh
```

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2021-04-29 18:30:27 +08:00
Sharif Elgamal 8657b72645 address comments 2021-04-28 17:29:28 -07:00
Sharif Elgamal fb5f275baa abstract kubernetes issues away 2021-04-28 16:01:59 -07:00
Steven Powell c9ccfece9b removed get prefix from funcs 2021-04-28 15:34:48 -07:00
Sharif Elgamal 7afe98b855 add 1.21.0 2021-04-28 08:59:15 -07:00
Sharif Elgamal 661e62aacd warn about performance for certain versions of kubernetes 2021-04-27 13:54:06 -07:00
csiepka ae450f6c7b
Correct typo in start_flags.go
Steps to reproduce the issue:
minikube start --memory=2G

Current Output (truncated):
smile minikube v1.14.1 on Linuxmint 19.3
sparkles Using the docker driver based on existing profile
exclamation You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster.

Correction:
"exiting" to "existing" in output:

Expected output:
exclamation You cannot change the memory size for an existing minikube cluster. Please first delete the cluster.
2021-04-26 11:59:17 -07:00
Medya Ghazizadeh cbe11ca8ff
Merge pull request #11003 from tklauser/x-term
Use golang.org/x/term
2021-04-25 22:56:14 -07:00
Medya Ghazizadeh d6e011bf77
Merge pull request #10918 from afbjorklund/kicbase-cache
Add code for downloading kicbase image to cache
2021-04-25 22:25:06 -07:00
Predrag Rogic e3b45667a6
improve how cni and cruntimes work together 2021-04-25 17:40:34 +01:00
Medya Ghazizadeh 41bbb4f6c5
Merge pull request #11164 from afbjorklund/build-rebase
Add re-implementation of the build command
2021-04-24 21:03:30 -07:00
Anders F Björklund 974268092f Merge branch 'master' into kicbase-cache 2021-04-24 08:36:45 +02:00
Anders F Björklund d50845903f url.Parse treats DOS volumes as URL schemes
So need to be on the lookout for "C:\\path"
2021-04-23 23:04:30 +02:00
Steven Powell 29745438da add opt-in notifications for beta releases 2021-04-22 14:35:19 -07:00
Andriy Dzikh 810f7ab108 Change 'minikube version --short' to only print the version without a prompt. 2021-04-21 19:01:55 -07:00
Anders F Björklund 943561b24d Clean up the order of the image commands 2021-04-21 20:26:28 +02:00
Anders F Björklund f7e07770c0 Clean up duplicated function etc after merge 2021-04-21 20:26:28 +02:00
Anders F Björklund 9516122d70 Add example parameters to the usage help text 2021-04-21 20:26:28 +02:00
Anders F Björklund c961190ed8 Allow passing environ and options to build 2021-04-21 20:26:28 +02:00
Anders F Björklund db203cd0e2 Allow building tarball from stdin stream 2021-04-21 20:26:28 +02:00
Anders F Björklund 9f9958f7ea Allow building image from an url as well 2021-04-21 20:26:28 +02:00
Anders F Björklund 40cbe652ea Improve comments and remove docker daemon 2021-04-21 20:26:28 +02:00
Anders F Björklund 02b4267fd0 Add option for pushing image to registry 2021-04-21 20:26:28 +02:00
Anders F Björklund c94a6d7968 Make sure to pass any file param to build 2021-04-21 20:26:28 +02:00
Anders F Björklund 6cfbf2cc3d Move minikube build cmd to minikube image build
Use the long name also for examples and usage
2021-04-21 20:26:28 +02:00
Anders F Björklund 9ef5d255d2 Add support for build directory and Dockerfile
Will create a temporary tarball, if given a dir

Some code from github.com/fsouza/go-dockerclient
(but not exported as a library, for some reason)

Upgrade docker client and cherry-pick windows

From v18.09.0 to v19.03.15, plus c3a0a37446
Update go-dockerclient and remove internal deps
2021-04-21 20:26:06 +02:00
Anders F Björklund a2744827c3 Add some basic support for setting the image tag 2021-04-21 19:56:58 +02:00
Anders F Björklund af5828dff9 Add initial re-implementation of the build command
Currently only handles tarballs, not directories
2021-04-21 19:56:55 +02:00
Tobias Klauser 112792fba0 Use golang.org/x/term
The golang.org/x/crypto/ssh/terminal package is deprecated and merely a
wrapper around golang.org/x/term. Thus, use the latter directly.
2021-04-21 12:50:48 +02:00
Anders F Björklund ef036e9297 Mock the docker call when calling it from tests 2021-04-20 22:13:26 +02:00
Medya Ghazizadeh f5035b5c28
Merge pull request #11122 from lilongfeng0902/minikube-lilf
Better to use "0777" than "0o777",instead of only in Go
2021-04-20 10:07:21 -07:00
李龙峰 84e7ea6d14 0777 better than 0o777 2021-04-20 15:04:44 +08:00
Anders F Björklund a618655bb3 Make golint clean again by adding comments 2021-04-20 08:23:26 +02:00
李龙峰 0c093da67f revert because of IDE bug 2021-04-20 08:56:17 +08:00
Medya Gh 1207de734b bump golang lint ci to latest 2021-04-19 15:16:31 -07:00
Medya Ghazizadeh d4c1c2a79f
Merge pull request #11127 from afbjorklund/image-pull
new command "image pull: allow to load remote images directly without cache
2021-04-19 14:57:48 -07:00
Anders F Björklund d8050ee03c Add documentation to the public image functions 2021-04-19 21:55:43 +02:00
Medya Ghazizadeh 19ea60f843
Merge pull request #11120 from sharifelgamal/gen-test-docs
site: Automatically generate integration test documentation
2021-04-19 12:40:40 -07:00
Anders F Björklund 9c1a4f4fc0 Allow to load remote images directly without cache 2021-04-19 20:24:06 +02:00
Anders F Björklund fbef53209a Add helper for runtime OS as well as for Arch 2021-04-18 12:51:30 +02:00
李龙峰 9cbfb9b841 filemode is not correct,0o777 to 0777 2021-04-17 10:08:28 +08:00
Sharif Elgamal 245f44da66 write to a file and move code around for clarity 2021-04-16 15:33:50 -07:00
Sharif Elgamal 1319b6e398 refactor checkRepository to make mocking easier 2021-04-14 12:51:16 -07:00
Sharif Elgamal f95c0eb709 avoid network calls for mirror unit tests 2021-04-12 15:24:46 -07:00
Anders F Björklund 0d22fe24ae Make lint happy by not using else statement 2021-04-10 16:00:00 +02:00
Anders F Björklund bc62a9f1bd Check for supported kubectl architecture too 2021-04-10 15:40:55 +02:00
Anders F Björklund 623b1a8639 Check for supported runtime architecture too 2021-04-10 15:30:17 +02:00
Anders F Björklund 1e3e8c9587 Only show the guest system, not the host system 2021-04-10 14:40:24 +02:00
Ilya Zuyev 193e4d5497 fix error message 2021-04-09 16:35:44 -07:00
Ilya Zuyev 6aa7e11923 fix imports 2021-04-08 11:50:03 -07:00
Ilya Zuyev 8d8f95305b Merge branch 'master' into ilyaz/do_not_run_amd64_on_m1 2021-04-08 11:44:52 -07:00
Ilya Zuyev b2aa1e56aa make linter happy 2021-04-08 11:14:03 -07:00
Ilya Zuyev 9a3157950f add download link 2021-04-08 10:25:12 -07:00
Medya Ghazizadeh 78288f87f3
Merge pull request #10976 from wangchenglong01/wangchl01
define a variable instead of duplicating "kube-system"
2021-04-07 18:05:27 -07:00
Ilya Zuyev d1431f67a6 exit if run amd64 binary on M1 cpu 2021-04-07 15:44:03 -07:00