60fde94e9f
parallelize updating cluster and setting up certs
2020-04-02 16:46:58 -07:00
eba137da6d
Merge pull request #7390 from tstromberg/solution-msgs
...
Update err map for v1.9.x
2020-04-02 16:36:27 -07:00
4476cf12d3
Remove testing dict
2020-04-02 16:04:32 -07:00
e089c0c0f8
Replace 120 with \d
2020-04-02 15:53:04 -07:00
a305b651d0
Merge pull request #7388 from tstromberg/none-root-check2
...
none: check for docker and root uid
2020-04-02 15:43:05 -07:00
7296c2687b
Update err map for v1.9.x
2020-04-02 15:31:58 -07:00
af8d01d83d
Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback
2020-04-02 14:40:33 -07:00
4ace23cd2c
error message lint
2020-04-02 14:36:57 -07:00
26c747137e
failback to alternate drivers if startup fails with automatic choice
2020-04-02 14:36:46 -07:00
37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
...
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00
78ecf53d40
Merge pull request #7360 from tstromberg/wrong-url
...
Correct assumptions for forwarded hostname & IP handling
2020-04-02 14:33:48 -07:00
5b3834ec63
Merge to master
2020-04-02 12:39:32 -07:00
6276c1cb1d
none: check for docker and root
2020-04-02 12:33:13 -07:00
f3392f4034
Merge pull request #7386 from tstromberg/none-advice
...
"Point 'none' users toward the more user-friendly 'docker' driver
2020-04-02 12:32:07 -07:00
e937a60ab0
Merge pull request #7379 from tstromberg/driver-msg
...
Add rejection reason to 'unable to find driver' error
2020-04-02 12:25:15 -07:00
7004c398b0
Don't generate documentation for hidden commands
2020-04-02 12:05:27 -07:00
a3d729db6b
Point 'none' users toward the more user-friendly 'docker' driver
2020-04-02 11:44:44 -07:00
63ffbd952e
Rewrite --mount-string since it depends on host
2020-04-02 11:29:43 -07:00
cd81888a22
Merge branch 'master' of https://github.com/kubernetes/minikube into generate-docs
2020-04-02 11:09:56 -07:00
7988704bed
fixups
2020-04-02 11:01:26 -07:00
270d4cf5c0
include newline
2020-04-02 10:57:05 -07:00
2e9ad822fe
Run goimports
2020-04-02 10:53:12 -07:00
6fdecf2ebf
Add unit test to check that docs are up to date
...
This requires the following changes:
1. We need to pass in -ldflags to `go test`, since we need to know the curren iso version to correctly generate the description for --iso-url
2. We need to rewrite the description of the --driver flag on `minikube start` because it is operating system specific, which doesn't make sense for our documentation
2020-04-02 10:48:47 -07:00
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
a71edc3920
Merge branch 'master' into wrong-url
2020-04-02 08:32:54 -07:00
bf0bb60b59
Merge pull request #7364 from medyagh/disk_pressure
...
add missing kubelet eviction for v1beta2
2020-04-02 06:48:34 -07:00
8f3ef2d69e
Update tests
2020-04-02 06:28:21 -07:00
e09a1221bb
Add rejection reason to 'unable to find driver' error
2020-04-02 06:20:35 -07:00
9b2176298c
get rid of evicition soft
2020-04-01 18:21:20 -07:00
5806bb01f2
Merge pull request #7345 from sharifelgamal/delete-on-failure
...
add delete-on-failure flag
2020-04-01 17:53:46 -07:00
071b2c11a4
disable disk resource management by default
2020-04-01 17:44:19 -07:00
e66cc3c68b
Merge pull request #7362 from tstromberg/cache-add-race
...
Make live cache pushes non-fatal in case of stop/delete race
2020-04-01 17:07:36 -07:00
72cc9cb7c1
fix v1.19 unit test
2020-04-01 16:36:08 -07:00
8bcda5c7ee
fix v1.18 unit test
2020-04-01 16:33:27 -07:00
2af012fbe3
fix v1.17 unit test
2020-04-01 16:31:12 -07:00
84d469ab84
fix unit test _v1.16
2020-04-01 16:26:38 -07:00
d4853b0d9d
fix v1.15 unit tests
2020-04-01 16:24:37 -07:00
c409c4c91c
Add unit tests to make sure docs are up to date
2020-04-01 16:13:54 -07:00
a9dcfe82fe
Update generate-docs command
...
Now, generate-docs will compile all subcommands for one command into one document instead of creating a document per subcommand.
For example, instead of creating:
minikbue_addons_enable.md
minikbue_addons_disable.md
it will now create
addons.md
which will include subsections for `minikube addons enable` and `minikube addons disable`.
2020-04-01 15:59:33 -07:00
5505ad8858
fix v.1.14 unit tst
2020-04-01 15:55:45 -07:00
6af355c08e
fix unit test for v1.13
2020-04-01 15:53:56 -07:00
8350674c40
fix v12 tests
2020-04-01 15:47:03 -07:00
44e7338489
fix some unit tests
2020-04-01 15:28:44 -07:00
4df145518a
Merge branch 'master' of github.com:kubernetes/minikube into delete-on-failure
2020-04-01 15:24:38 -07:00
0f3b1d5da0
lowercase
2020-04-01 14:53:18 -07:00
2e19e9902a
remove duplicate paste
2020-04-01 14:52:07 -07:00
7af6adfefd
adjust eviction hard and soft for both v1beta1 and v1beta2
2020-04-01 14:48:43 -07:00
2207974d87
Merge pull request #7294 from n0npax/improve-localpath-test-coverage
...
Improve localpath test coverage
2020-04-01 14:46:28 -07:00
478de7b4a9
Fix lint error
2020-04-01 14:44:57 -07:00
62adc6761d
Merge pull request #7279 from tstromberg/unable-err
...
Improve display of host startup errors
2020-04-01 14:29:52 -07:00
af8fdc650a
Make live cache pushes non-fatal in case of stop/delete race
2020-04-01 14:18:39 -07:00
a7106b4498
Add missing endpoint file
2020-04-01 13:04:58 -07:00
c76fac7d74
Standardize port-forwarding and kubeconfig hostname logic, fix Docker Linux IP
2020-04-01 11:57:32 -07:00
d8151730f4
retry anytime node.Start fails, not just in minikube start
2020-04-01 11:00:39 -07:00
592bb2e9eb
Merge pull request #7310 from tstromberg/wrong-url
...
mustload: Replace DriverIP with Forwarded(IP|Port)
2020-04-01 08:29:12 -07:00
673922c8d3
code comments
2020-03-31 15:38:59 -07:00
8dbd08a7c9
Merge pull request #7340 from tstromberg/faster-lookup-fail
...
Make tryRegistry non-blocking, remove tryLookup, add timeout
2020-03-31 15:11:02 -07:00
fcb5c462f4
add delete-on-failure flag
2020-03-31 15:06:16 -07:00
f7f94982d8
Merge and address test breakage
2020-03-31 13:08:19 -07:00
4f891d515c
Merge pull request #7309 from linkvt/fix-embed-certs
...
Fix embed certs by updating kubeconfig after certs are populated
2020-03-31 12:55:32 -07:00
ca8b4ccddb
Merge pull request #7338 from dlorenc/rm
...
Remove unused code.
2020-03-31 10:45:01 -07:00
b23bddb242
Make tryRegistry non-blocking, remove tryLookup, add timeout
2020-03-31 10:44:32 -07:00
d8db21478c
Remove unused code.
...
I was looking for an example of reflect and noticed that this code was unused.
2020-03-31 10:37:04 -05:00
2b68cb72d8
glorb
2020-03-30 15:36:11 -07:00
fd3e0f505a
clean up minikube start output
2020-03-30 15:31:17 -07:00
7f5f12c5f4
Get rid of DriverIP attr to prevent future misuse
2020-03-29 11:44:25 -07:00
063077c712
mustload: Check apiserver status using forwarded IP/port
2020-03-29 11:34:21 -07:00
7debdacf5b
Write the kubeconfig after generating certs
...
The content of the kubeconfig is defined before certs are generated by
the bootstrapper. When certs are embedded via --embed-certs writing the
kubeconfig fails if the certificates are not generated so it must run
after the bootstrap process which generates them.
2020-03-29 20:29:06 +02:00
417081aeb6
move defer outside of for loop
2020-03-29 15:08:30 +11:00
73dd9914f6
Fix gofmt and golint on master, after merges
2020-03-28 12:25:32 +01:00
546b26e695
implement CR suggestions
2020-03-28 20:16:48 +11:00
356e203ed4
Merge pull request #7270 from tstromberg/cerrt-err
...
Add more debugging for certificate issues
2020-03-27 22:16:48 -07:00
29e2f73842
Merge pull request #7275 from tstromberg/freebsd
...
Add files missing for FreeBSD compilation
2020-03-27 22:14:54 -07:00
da1d411e30
Merge pull request #6879 from prasadkatti/populate_target_port_in_svc_list
...
service list: populate target port
2020-03-27 22:12:18 -07:00
93d6829905
typofix
2020-03-28 13:49:39 +11:00
83504badbb
Merge branch 'master' of github.com:kubernetes/minikube into improve-localpath-test-coverage
2020-03-28 13:46:40 +11:00
c985a7287a
test properties
2020-03-28 13:46:16 +11:00
5535242764
Merge pull request #7278 from tstromberg/null-deref
...
Fix null deref in start host err
2020-03-27 19:21:35 -07:00
31c6c5f36e
use table testing for property testing
2020-03-28 12:11:41 +11:00
d430581467
Merge branch 'master' into unable-err
2020-03-27 10:31:58 -07:00
d8ca4966aa
Merge pull request #7280 from sharifelgamal/bleh
...
translations facelift
2020-03-27 08:45:40 -07:00
3f74cb61ef
Fixed typo
2020-03-27 08:16:48 +01:00
2d825d6498
translations facelift
2020-03-26 18:04:49 -07:00
f00ac2c05a
Fix null deref in start host err
2020-03-26 17:36:05 -07:00
c9a6d8dcf4
Improve display of host startup errors
2020-03-26 17:33:56 -07:00
d0fb1fd44c
Merge pull request #7277 from tstromberg/unable-err
...
Fix StartHost error formatting mistake, improve err msg
2020-03-26 17:32:16 -07:00
d3435f421d
Merge branch 'master' into unable-err
2020-03-26 17:05:34 -07:00
5a3d4f2870
Fix StartHost error formatting mistake, improve err msg
2020-03-26 17:01:30 -07:00
5a020c9577
Merge pull request #7268 from tstromberg/docker-timeout
...
Increase Docker "slow" timeouts to 15s
2020-03-26 16:57:02 -07:00
e3472b6da0
Add files missing for FreeBSD compilation
2020-03-26 16:23:53 -07:00
c6bca4d105
Add more debugging for certificate issues
2020-03-26 14:53:05 -07:00
11ba7c6eb3
Set minLogCheckTime to 60 until we can cut down on spam
2020-03-26 14:27:51 -07:00
2f2dccd30c
Remove test values
2020-03-26 14:05:02 -07:00
46f31480df
Make slow command detection consistent across kic/oci
2020-03-26 14:03:22 -07:00
721a57c25a
Rebased
2020-03-26 11:01:28 -07:00
6ef3faf6a2
Merge pull request #7262 from priyawadhwa/preload-error-logging
...
Add more logging to preload
2020-03-26 10:57:01 -07:00
1fac168ca3
Merge pull request #7244 from tstromberg/none-detect
...
Avoid provision.Detector when possible
2020-03-26 10:18:08 -07:00
73bdb79ed5
Merge pull request #7260 from tstromberg/block-on-upgrade2
...
Wait for control-plane to upgrade before proceeding
2020-03-26 10:17:55 -07:00
efbe113a94
Add more logging to preload
2020-03-26 10:15:02 -07:00
eef1526e37
Merge pull request #7235 from tstromberg/v1.18.0
...
Update DefaultKubernetesVersion to v1.18.0
2020-03-26 10:10:39 -07:00
daffae3793
Wait for control-plane to upgrade before proceeding
2020-03-26 09:07:14 -07:00
1db93ee20e
Merge branch 'master' into none-detect
2020-03-26 06:30:23 -07:00
3adfa8304c
Turn log message back into comment
2020-03-26 06:30:20 -07:00
095ccbe562
Merge pull request #7234 from tstromberg/init-retry-port-conflict
...
Re-initalize failed Kubernetes clusters
2020-03-25 18:57:30 -07:00
46e87ba054
Merge pull request #7219 from sharifelgamal/cluster-name
...
Get rid of ClusterNameFromMachine
2020-03-25 18:33:48 -07:00
53b9d720e7
Merge pull request #7230 from tstromberg/hugo-switch
...
Make recreateIfNeeded more robust, improve UX
2020-03-25 18:28:07 -07:00
dc3b842d41
Avoid provision.Detector when possible
2020-03-25 17:11:22 -07:00
f52df44fd5
If preload fails on hot restart, log warning instead of erroring out
2020-03-25 16:43:35 -07:00
dc7bdecda4
Merge branch 'master' of github.com:kubernetes/minikube into cluster-name
2020-03-25 15:43:12 -07:00
71003531c3
Merge pull request #7238 from sharifelgamal/honor-override
...
do not override hostname if extraConfig is specified
2020-03-25 15:24:14 -07:00
8f3e480d4e
Merge pull request #7241 from sharifelgamal/styyyle
...
replace emoji with spacing issues
2020-03-25 15:18:37 -07:00
fd1897ddae
replace emoji with spacing issues
2020-03-25 15:01:57 -07:00
1ee125e688
lint err
2020-03-25 14:50:13 -07:00
f84569aab0
Make crazy cluster_test / mock_driver combination pass tests
2020-03-25 14:46:44 -07:00
6417e85f5b
fix ordering
2020-03-25 14:40:40 -07:00
c3fba065a9
do not override hostname if extraConfig is specified
2020-03-25 14:07:39 -07:00
ea9aa72984
Retry addon application
2020-03-25 13:44:28 -07:00
30a00afcfc
Merge branch 'master' into v1.18.0
2020-03-25 13:06:15 -07:00
442a7869d3
Re-initalize failed Kubernetes clusters
2020-03-25 12:48:51 -07:00
5a316b3bf9
Merge pull request #7068 from vikkyomkar/issue-7067
...
Add --vm flag for users who want to autoselect only VM's
2020-03-25 12:44:16 -07:00
8afe879c56
remove unnecessary check; we check this when cr.Preload is called
2020-03-25 10:09:22 -07:00
9d75c7c35a
Rebased, resolved merge conflicts
2020-03-25 10:07:58 -07:00
755d4100a2
Merge branch 'master' into v1.18.0
2020-03-25 09:12:05 -07:00
d33684d7eb
Make private stop/delete functions to avoid wheel reinvention
2020-03-25 08:10:08 -07:00
4383a4883c
Improve host recreation experience
2020-03-25 07:28:23 -07:00
f42572f29c
Add TestMiniPath test
2020-03-25 22:44:40 +11:00
1be46bceec
implement Preload check for crio and containerd
2020-03-25 01:12:27 -07:00
5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
...
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
1f30cfcdbb
Merge pull request #7221 from kubernetes/windows-out
...
Use correct preload paths on Windows, announce base image pull
2020-03-24 22:37:07 -07:00
646609ec30
review comments
2020-03-24 21:24:43 -07:00
9f15f8d0cd
Merge pull request #7220 from kubernetes/flush-glug
...
Flush logs before writing to stdout
2020-03-24 21:13:41 -07:00
1b4f6efe63
Use runtime.GOARCH since we want amd64, not runtime.GOOS
2020-03-24 20:12:49 -07:00
2e9054f495
add unit test for pkg/drivers/hyperkit/iso.go
...
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-03-25 11:08:27 +08:00
d3fcd40feb
Use correct preload paths on Windows, announce base image pull
2020-03-24 17:37:59 -07:00
ab4b7d92b3
Flush logs before writing to stdout
2020-03-24 17:36:04 -07:00
898fe0e8bf
Merge pull request #7206 from linkvt/interpret-disk-size-and-memory-parameters-as-binary-values
...
Parse --disk-size and --memory sizes with binary suffixes
2020-03-24 17:15:03 -07:00
bc00b6f838
Merge pull request #7205 from tstromberg/retry-driver-start
...
Retry driver start
2020-03-24 16:49:39 -07:00
d2171be291
rebased'
2020-03-24 16:39:54 -07:00
0e897f8448
Only run preload if it exists
2020-03-24 16:25:57 -07:00
06dca45553
lint
2020-03-24 16:10:20 -07:00
4a24cfcf30
add cluster name to provisioner object directly
2020-03-24 15:54:39 -07:00
1d72a1c826
don't extract volume if tarball doesn't exist
2020-03-24 15:01:31 -07:00
28672dec78
remove ClusterNameFromMachine
2020-03-24 14:43:11 -07:00
b5e088ad59
run preload on hot restarts as well, in case kubernetes version has been upgraded
2020-03-24 13:44:51 -07:00
972ff3cc00
Update DefaultKubernetesVersion to v1.18.0
2020-03-24 12:21:27 -07:00
0d76e2a684
Avoid dereferencing nil, in case of an error
2020-03-24 20:19:01 +01:00
5ef83f35e2
Add --preload flag to optionally turn off preload
2020-03-24 10:53:02 -07:00
f00f5ff600
remove extra if
2020-03-24 10:21:32 -07:00
b5d5aa1d52
Parse --disk-size and --memory sizes with binary suffixes
2020-03-24 17:20:59 +01:00
e9e9a41049
Use ExampleCmd now that it is available
2020-03-24 08:58:15 -07:00
18f4593d8e
Merge branch 'master' into retry-driver-start
2020-03-24 08:53:54 -07:00
940baa09ea
fix comment
2020-03-24 07:31:22 -07:00
41b16b1568
fail if container is not running
2020-03-24 07:27:07 -07:00
83cc28e082
add logging for when container status is running
2020-03-24 07:11:22 -07:00
587154196e
Merge pull request #7173 from medyagh/stop_kic
...
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
20991ac336
Merge pull request #7183 from sharifelgamal/conntrack-msg
...
add friendly error message for missing conntrack
2020-03-23 23:03:09 -07:00
67bd258465
remove extra line
2020-03-23 23:02:27 -07:00
afa09ad5d4
Merge pull request #7182 from priyawadhwa/issue-7172
...
Upgrade podman and add libglib2.0-0 to kicbase image v0.0.8
2020-03-23 23:01:53 -07:00
aec6fdc25a
initialize kic runner in stop
2020-03-23 21:01:12 -07:00
7619a5075a
fix logging
2020-03-23 21:01:12 -07:00
36f3f657af
force stop if cant stop for none
2020-03-23 21:01:12 -07:00
545348341a
for none let it stop all containers
2020-03-23 21:01:12 -07:00
47c8e9c87b
dont return on error kic sto
2020-03-23 21:01:12 -07:00
5f90a319bd
stop k8s in kic and none
2020-03-23 21:01:12 -07:00
fae3e34319
add stop force stop
2020-03-23 20:59:21 -07:00
298be78e5f
remove duplicate code
2020-03-23 20:59:21 -07:00
beec3b1ce1
stop kubelet on docker stop
2020-03-23 20:59:21 -07:00
8b58738491
check for conntrack at start time, remove useless solution message
2020-03-24 02:54:47 +00:00
9e81e06e61
fix regex
2020-03-23 18:04:29 -07:00
091059b886
Add timeout on needsTransfer function
...
needsTransfer requires a network connection as it tries to get the digest of the image it is verifying. When running `TestOffline/group/crio`, LoadImages takes 6m30s to complete because it's waiting for i/o timeout. With this timeout, LoadImages takes ~45 seconds when running that integratin test.
2020-03-23 17:57:00 -07:00
4f3c4dee06
add nice error message for missing conntrack
2020-03-23 17:48:26 -07:00
abf35cfbc1
Upgrade podman and add libglib2.0-0 to kicbase image
...
The `TestOffline/group/crio` integration test was failing with the error:
```
crio load image: sudo podman load -i /var/lib/minikube/images/storage-provisioner_v1.8.1: exit status 125
```
I tried SSH'ing into minikube and running the command myself, and got the error:
```
Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version
```
I then tried updating conmon, but got the error:
```
conmon: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
```
I then tried adding the libglib2.0-0 library to the kic base image and upgrading podman, which seems to have resolved the issue.
2020-03-23 17:41:06 -07:00
fcb8736cf7
merge to master
2020-03-23 17:30:06 -07:00
82eafa57d4
Smoothly retry host startup
2020-03-23 17:25:25 -07:00
93021fbfda
Merge pull request #7174 from afbjorklund/xdg-open
...
Centralize the handling of browser.OpenURL
2020-03-23 17:12:38 -07:00
16e18724e2
Dedup ExampleCmd, fix command flag ordering
2020-03-23 16:28:39 -07:00
b99e943684
Improve minikubeCmd, promote to public function
2020-03-23 16:00:53 -07:00
679b0c6c72
Merge pull request #7160 from kubernetes/stop-retry
...
hyperv Delete: call StopHost before removing VM
2020-03-23 15:48:40 -07:00
29f5007f46
Use correct machine name for status check
2020-03-23 14:25:47 -07:00
54bbdde812
Print the URL, instead of return an error
...
Let the terminal user open it themselves
2020-03-23 22:11:43 +01:00
0ce81acbf4
Centralize the handling of browser.OpenURL
...
So we can catch when xdg-open not installed
2020-03-23 21:49:19 +01:00
77f97a58f4
Fix uninitalized variable
2020-03-23 13:16:37 -07:00
5bf84cc282
Merge branch 'master' into down-detect
2020-03-23 12:52:09 -07:00
8f9a2b9413
Consolidate cluster loading from cmd
2020-03-23 12:51:49 -07:00
bfe8aee3b5
Pass in container runtime to preload tarball name
...
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
0e5974367f
rebased on master'
2020-03-23 10:59:02 -07:00
14f8ee3984
hyperv Delete: call StopHost before removing VM
2020-03-23 09:41:00 -07:00
6ee7e6fa67
updated as per suggestion
2020-03-22 19:25:03 +05:30
43b5f7c86d
Move KubeNodeName out of driver package
2020-03-22 15:11:03 +08:00
15b1647b42
Revert "Make node name registered in K8s part of Node type"
...
This reverts commit 6ff82c6246
2020-03-22 15:06:38 +08:00
6ff82c6246
Make node name registered in K8s part of Node type
2020-03-22 14:31:37 +08:00
63aef4ab54
Merge remote-tracking branch 'origin/master' into fix-hostname
2020-03-22 11:08:37 +08:00
f76cdea82a
Run gofmt
2020-03-21 16:05:00 -07:00
7e3b8c6355
Merge branch 'master' into stale-fix
2020-03-21 15:52:31 -07:00
a59750627e
Improve stale endpoint detection and resolution in Kubernetes configs
2020-03-21 15:51:31 -07:00
cf887e7a1a
Merge pull request #7105 from prasadkatti/add_desc_node_to_minikube_logs
...
Add kubectl desc nodes to minikube logs
2020-03-21 15:13:12 -07:00
376271afca
Merge branch 'master' into add_desc_node_to_minikube_logs
2020-03-21 12:27:17 -07:00
ba6dbc57c2
Update the call to logProblems in node/start.go
2020-03-21 12:18:50 -07:00
151db5ffe6
Use hostname as node name for 'none' driver
2020-03-22 02:11:27 +08:00
001f7fde92
Merge to master
2020-03-21 10:56:52 -07:00
Priya Wadhwa
Thomas Strömberg
Sharif Elgamal
Medya Gh
Medya Ghazizadeh
Dan Lorenc
Vincent Link
Marcin Niemira
Anders F Björklund
Eberhard Wolff
Thomas Stromberg
ZouYu
vikkyomkar
Zhongcheng Lao
Prasad Katti