813094bafb
Merge branch 'master' into ilyaz/multiarch_kicbase
2021-01-12 10:48:01 -08:00
7ca15031e8
fix kicbase sha1
2021-01-11 18:30:39 -08:00
1663a030ed
Only add docker group for the docker runtime
2021-01-11 18:12:06 +01:00
b2121eae39
Rename the generic driver to the ssh driver
...
Now that we have forked the machine driver
2021-01-09 14:36:32 +01:00
e53f537b39
Merge branch 'master' into generic
2021-01-09 14:11:09 +01:00
2622e9583c
bump kicbase version to v0.0.16-snapshot1
2021-01-08 13:49:27 -08:00
921306d88a
fix fallback kicbaseimages list
2021-01-08 13:31:13 -08:00
40ec0e8015
Avoid the hard-coded dependency on systemctl
2021-01-08 18:31:15 +01:00
fb6cf6b6b6
Add placeholder for docs for the generic driver
...
But most of it is identical to the "none" driver
2021-01-08 18:16:58 +01:00
e4ebaeabf6
Complete the container runtime and config change
2021-01-08 17:36:23 +01:00
b856a475e6
Remove systemd dependency from none driver
...
Use the minikube "sysinit" module instead
2021-01-08 09:12:54 +01:00
1d6c86c8b5
Also remove unused machine SetConfigFromFlags
...
Setting the config directly instead in minikube
2021-01-06 21:05:53 +01:00
a120c543bf
Change meaning of Stop/Start/Restart to minikube
...
The "none" driver has redefined stop and start to mean the
kubelet rather than the host itself. Use the same API here.
Killing actual containers remotely remains to be implemented.
Only stop the kubelet service for now, and assuming systemd.
2021-01-06 20:09:25 +01:00
a77e3de85f
Use CommonDrivers and drop machine GetCreateFlags
...
This makes the machine driver specific to minikube
2021-01-06 18:42:19 +01:00
fa05fcd6d0
Fork the generic driver to the minikube code base
2021-01-06 18:35:09 +01:00
65cf998d6f
Merge branch 'master' into ilyaz/multiarch_kicbase
2021-01-05 16:30:26 -08:00
6335658103
Revert single-arch kicbase fallback support
2021-01-05 16:29:48 -08:00
f22a3802c7
Handle podman installations without default bridge
2021-01-05 17:06:52 +01:00
0f734e6339
Change function name
2020-12-31 00:03:34 +00:00
f94b1674b1
Change tests into a loop
2020-12-30 23:27:37 +00:00
f044b1fa91
Add unit test for docker network inspect
2020-12-30 02:28:44 +00:00
4a940d0079
Fix docker inspect network go template
2020-12-27 08:38:39 +00:00
a3b80e1fff
add log
2020-12-22 14:57:04 -08:00
bd413794c2
Avoid creating network if it is the default
2020-12-22 14:56:27 -08:00
55f496492c
fix merge conflict
2020-12-16 10:37:51 -08:00
f85bed1150
Merge pull request #9753 from blueelvis/'bug/9078-tunnel-windows-docker'
...
Fix minikube tunnel for Docker on Windows
2020-12-15 07:59:44 -08:00
a8463f3453
fix linting errors
2020-12-15 18:25:10 +05:30
ce17200bd8
address review comment
2020-12-15 18:09:43 +05:30
6044006afe
add multi-arch images to kic driver list
2020-12-13 22:29:17 -08:00
b4bf2bde33
Merge pull request #9866 from afbjorklund/podman-network-fix
...
Fix podman network inspect format and error
2020-12-11 10:20:46 -08:00
442a9cf2d3
Merge pull request #9911 from medyagh/update_kicbase_16_1
...
Update kicbase 15 snapshot4 on head
2020-12-10 16:55:28 -08:00
6b079476c6
Merge pull request #9918 from lingsamuel/remove-verbose-options
...
Remove verbose options
2020-12-10 15:58:01 -08:00
c3d0621d97
Only use sudo with the none driver when on linux
2020-12-10 21:07:10 +01:00
a6941f21ca
Fix podman network inspect format and error
...
Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?
2020-12-10 07:32:34 +01:00
634f0ae0a9
Remove verbose options
2020-12-10 14:29:38 +08:00
d3c375420e
bump kicbase on head v0.0.15-snapshot4
2020-12-09 17:32:46 -08:00
a55a0b0286
bump kicbase on head
2020-12-09 17:20:09 -08:00
6eadee30b8
Merge pull request #9802 from afbjorklund/podman-host-cleanup
...
Some more cleanup of missing code for podman-env
2020-12-09 15:00:37 -08:00
74cdda9e9a
Resolve review comments
2020-12-09 16:54:19 +05:30
0e85b1819a
bump kic base on head
2020-12-08 13:49:17 -08:00
0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
...
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
f373155d55
merge conflict
2020-12-03 10:56:41 -08:00
8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
...
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
da778ea870
Some more cleanup of missing code for podman-env
...
There is a lot of code duplication from docker-env
Most of it also applies for podman (CONTAINER_HOST)
2020-11-29 23:35:37 +01:00
dae980a355
Add support for restoring existing podman env
...
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
7bc81b1cbd
add imagesha
2020-11-25 14:22:29 -08:00
8639a067e6
bump kic image on head
2020-11-25 14:07:24 -08:00
5d5a12c60f
Merge pull request #9734 from priyawadhwa/updae-iso-kic
...
Update ISO and kicbase to include scheduled stop
2020-11-24 10:10:59 -08:00
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
131d7248c4
Merge pull request #9710 from valaparthvi/issue9690
...
convert dockerNetworkInspect to a struct
2020-11-20 14:16:01 -08:00
197f2a25ae
Removed unused debugging lines
2020-11-21 00:30:05 +05:30
bf7b09f484
Fix permissions for key file on Windows
2020-11-21 00:27:19 +05:30
63c186bb05
convert dockerNetworkInspect to a struct
2020-11-20 12:29:37 +05:30
e83ba9df9c
Update ISO and kicbase to include scheduled stop so we can test them
2020-11-18 10:54:41 -08:00
0def75cbc9
Work in progress for SSH key file fix
2020-11-18 01:46:28 +05:30
14db0debef
review comments
2020-11-17 12:15:42 -08:00
8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
...
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
7955a891cb
bump kicbase
2020-11-12 16:04:26 -08:00
9bb9355b50
fix merge conflict
2020-11-11 11:57:27 -08:00
0f5a2ca4a4
Merge pull request #9641 from prezha/fix-kvm-minikube-net
...
Fix minikube-net network failures for KVM driver
2020-11-10 12:43:20 -08:00
9e114139dc
retry instead of sleep; gc cleanup
2020-11-10 16:28:14 +00:00
8ebc828eb1
Fix minikube-net network failures for KVM driver
2020-11-10 16:27:51 +00:00
37914938e5
bump kicbase to include crio changes
2020-11-09 17:39:19 -08:00
c2bfd58be3
bump snapshot
2020-11-09 17:16:47 -08:00
0f2c63881a
Merge branch 'master' into gh_9463_non_dev_dockerhost
2020-11-09 14:11:20 -08:00
e58d538903
Fix linter warning
2020-11-09 12:52:27 -08:00
80566956d6
bump kicbase
2020-11-05 12:36:40 -08:00
d5a092c3c7
Add unit tests for oci.DaemonHost()
2020-10-30 14:00:52 -07:00
c97cd912f1
Rename oci.RuntimeHost() -> oci.DaemonHost()
2020-10-30 13:44:34 -07:00
72b710af03
Fix warning about listening to 0.0.0.0
2020-10-30 13:41:06 -07:00
43a4b62b68
Remove excessive logging
2020-10-30 13:27:29 -07:00
acbdafa4e1
Fix func naming
2020-10-27 16:07:50 -07:00
ea6ca08d67
Change flag name to --network and exit if used without docker driver
2020-10-26 11:52:26 -07:00
ebf612254c
Fix merge conflict
2020-10-26 09:31:59 -07:00
9f729ac041
readability
2020-10-23 15:04:13 -07:00
43c2a5cd0c
dont pass mtu if 0
2020-10-23 14:54:49 -07:00
4993dc6ed7
log
2020-10-23 14:25:00 -07:00
1dd5583ce3
template
2020-10-23 14:07:20 -07:00
aa97aca2ff
make struct for netinfo
2020-10-23 13:45:25 -07:00
20db128cb8
add warning
2020-10-23 13:10:01 -07:00
94485d5a19
lint
2020-10-23 12:47:51 -07:00
cde546ed80
detect MTU from docker brdige
2020-10-23 12:41:29 -07:00
8b4c48143b
implement --docker-network flag
2020-10-23 09:50:23 -07:00
fe2710705e
Add --docker-network flag
2020-10-23 09:31:33 -07:00
6e02753204
Forward ports for docker machine on Linux
2020-10-22 22:41:58 -07:00
89bf9ac01c
Update certs and API endpoints
2020-10-22 22:10:07 -07:00
50a04a49d4
try
2020-10-22 17:33:33 -07:00
bfa83ff602
fix option
2020-10-22 16:56:13 -07:00
a6e5fb89d5
lower mtu for cloud shell
2020-10-22 16:05:06 -07:00
eaa9ecfd31
Experiments
2020-10-22 13:41:01 -07:00
34a2dc7686
Delete test file
2020-10-22 13:37:05 -07:00
85d45be207
Fix docker-env command
2020-10-20 23:10:08 -07:00
d384343c39
When configuring docker environment, use MINIKUBE_EXISTING_* variables if set
2020-10-19 22:02:42 -07:00
63c4468fd5
address review comments
2020-10-13 16:01:59 -07:00
fd15e50dbe
Fix typo (cointainer -> container)
2020-10-13 14:20:35 -07:00
59548194bd
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-09 17:45:35 -07:00
567d2f2f65
Merge pull request #9426 from priyawadhwa/drv-cp-endpoint
...
Add further debugging for DRV_CP_ENDPOINT failure
2020-10-09 16:55:38 -05:00
acd5a7a4c8
address review comments
2020-10-09 14:16:35 -04:00
0985957032
Add further debugging for DRV_CP_ENDPOINT failure
2020-10-08 18:00:11 -04:00
4d743b2f3d
bump kicbase imge
2020-10-08 13:45:54 -07:00
ef2090ac31
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-08 10:27:04 -07:00
e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
...
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
61048eedbe
fix typo
2020-10-07 19:41:57 +02:00
3703f69c25
Applying klogFlags set via cobra.
2020-10-06 11:20:51 -07:00
b538bc0f56
add extra args
2020-10-06 13:34:20 +02:00
d6acf7f4cb
fix issues
2020-10-05 11:49:28 -04:00
4cff79008c
fixed merge conflict
2020-10-05 11:47:53 -04:00
43cc1a2581
Resolved merg conflicts.
2020-10-02 14:10:55 -07:00
0fc0c82337
Merge pull request #9294 from medyagh/docker_network
...
add dedicated network for docker driver
2020-10-01 14:11:42 -05:00
73d77e2463
address review comments
2020-09-30 16:42:42 -07:00
f807bcf8c9
remove kic test
2020-09-30 14:58:20 -07:00
db23825bfc
Move exit.Message function so that we aren't exiting from a library
2020-09-30 15:19:06 -04:00
5815ef835c
Merge pull request #9353 from medyagh/update_kicbase_ub
...
update kicbase image to ubuntu-based
2020-09-30 12:07:58 -05:00
8d5eb81d38
Fied lint.
2020-09-29 17:10:30 -07:00
43ea47f4e0
Fixed merge conflicts.
2020-09-29 16:17:31 -07:00
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
82f39d1387
clarify comment
2020-09-29 14:29:34 -07:00
31e175c6f8
move index machine to driver package
2020-09-29 14:27:37 -07:00
058adb775c
address review comments
2020-09-29 14:14:25 -07:00
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
f163cf9e15
update with new logic
2020-09-29 14:14:25 -07:00
2766235a5c
try alternate if no network
2020-09-29 14:14:25 -07:00
fa0afb220d
lint
2020-09-29 14:14:25 -07:00
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
9cd42163b1
add network create funcs
2020-09-29 14:14:24 -07:00
0d6b6fcce7
Merge pull request #9343 from tstromberg/docker-detect
...
Add 'docker status' check, improve deadline-exceeded error message
2020-09-29 15:24:43 -05:00
b3401405f0
update kicbase image to ubuntu-based
2020-09-29 13:03:11 -07:00
91a32541e8
Use %d for exit code
2020-09-29 09:49:30 -07:00
8eaa3ee4f3
Use oci.CachedDaemonInfo for status check
2020-09-29 09:19:14 -07:00
647c857fe1
Fix error in unittest, as pointed out by warning
...
"conversion from int to string yields a string of one rune,
not a string of digits (did you mean fmt.Sprint(x)?)"
2020-09-28 21:40:14 +02:00
75332f7c89
Merge pull request #8901 from bluestealth/MiB
...
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
c005cda301
Print solution message when there is no space left on device
...
during preload extraction.
2020-09-24 13:03:57 -04:00
f097a0de12
dates, take two
2020-09-17 13:20:35 -07:00
775e047517
dates
2020-09-17 13:18:53 -07:00
3cb6ba0f75
actually add unit tests
2020-09-17 13:16:07 -07:00
84ee6d351b
unit tests
2020-09-17 13:11:01 -07:00
39ae4fbdd2
check for windows style pathing with a regex
2020-09-17 12:15:54 -07:00
23e7989c07
Merge branch 'master' of github.com:kubernetes/minikube into windows-mount
2020-09-17 11:12:35 -07:00
b98580c820
fix up if statement
2020-09-17 10:31:10 -07:00
eab92dc455
Reduce cyclotomic complexity of CreateContainerNode to fix lint
2020-09-17 10:22:28 -07:00
4a004dd58e
simplify more
2020-09-16 16:39:03 -07:00
14a5b0b264
simplify append
2020-09-16 16:04:10 -07:00
6e9b1b7bc0
fix mounting for docker driver in windows
2020-09-16 14:55:40 -07:00
44c6f36362
Merge pull request #9255 from afbjorklund/cpus-cfs
...
Make sure CFS_BANDWIDTH is available for --cpus
2020-09-15 16:07:12 -07:00
f718e39ab9
Make sure CFS_BANDWIDTH is available for --cpus
2020-09-15 12:54:39 +02:00
af5d6d060b
Fix ForwardedPort for podman version 2.0.1 and up
...
Increasing Docker compatibility broke Podman v1
2020-09-13 22:17:36 +02:00
ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
...
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
3c86db01f4
Merge pull request #9166 from priyawadhwa/revert-static-ip
...
Revert static IP for docker
2020-09-02 15:49:40 -07:00
914f10b458
Merge pull request #9149 from tstromberg/docker-no-swap
...
Disable swap in Docker & podman containers
2020-09-02 14:55:44 -07:00
22b40e215a
revert static IP
2020-09-02 16:33:38 -04:00
ea5af644ec
fix merge conflict
2020-09-02 09:31:42 -04:00
1859274e8a
refactor conversion functions into util
2020-09-01 21:21:07 -07:00
6ad47f9560
use MiB for raw disk allocations
2020-09-01 21:20:08 -07:00
9ff030942d
use MiB with kvm driver
2020-09-01 21:20:02 -07:00
2dac55abf4
Merge pull request #9062 from kadern0/issue-8131
...
docker: Choose the appropriate bridge interface when multiple exist
2020-09-01 16:46:01 -07:00
8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
...
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
0408d3ba1a
Added code to inspect docker networks to get the bridgeID correctly
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-09-02 08:44:07 +10:00
7fc0299c6f
Disable swap in Docker/podman by setting --memory-swap to --memory
2020-09-01 13:57:52 -07:00
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
b053267a81
update kic version to incorporate /kubepods change
2020-08-25 15:59:04 -07:00
2ead04aea0
bump kic base changes
2020-08-24 15:10:53 -07:00
d634a85ff9
use daemon info so this works for docker and podman
2020-08-24 17:50:09 -04:00
535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
56691f839c
add swarm and storage driver to DaemonInfo
2020-08-19 15:38:56 -07:00
e0d0ae1e19
correct comit sha
2020-08-17 16:56:25 -07:00
20dd3e8ade
update kicbase to snapshot
2020-08-17 14:28:02 -07:00
52953bac93
Merge branch 'master' of github.com:kubernetes/minikube into kic-add-static-ip
2020-08-12 14:03:43 -07:00
a949f9ca7b
improvement
2020-08-12 12:58:21 -07:00
bdb59c2598
lint
2020-08-12 12:56:07 -07:00
dfa05d714e
include gateway when creating custom network
2020-08-12 12:54:06 -07:00
af94e0a0c5
add logging
2020-08-12 10:57:48 -07:00
2400d1b850
remove network correctly
2020-08-12 10:08:46 -07:00
69d21df7c5
make sure we use custom network if it exists
2020-08-12 12:45:49 -04:00
3b5f973459
make sure we delete networks correctly
2020-08-12 12:36:57 -04:00
51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
...
add unit test for daemon info
2020-08-11 15:50:02 -07:00
f20d3bddf0
add boilerplate
2020-08-11 15:13:16 -07:00
25dc0cd0f7
lint
2020-08-11 15:03:10 -07:00
f8d932e697
use mock funcs
2020-08-11 14:55:30 -07:00
4c0334d91f
add one more case
2020-08-11 13:10:17 -07:00
a9eec3ca7b
add unit test for daemon info
2020-08-11 13:06:50 -07:00
7463eda122
remvoe comment
2020-08-11 10:40:40 -07:00
1d94fa911a
ensure nil error is returned
2020-08-11 10:40:40 -07:00
bbc58fa194
refresh daemon info cache if there is error
2020-08-11 10:40:40 -07:00
fb1bc3afbb
fix network name
2020-08-10 17:33:32 -04:00
21789d8c4e
compile
2020-08-10 17:18:42 -04:00
dfcfd6f2f0
cleanup
2020-08-10 17:15:26 -04:00
9dcb0c5478
fix merge conflict
2020-08-10 17:12:56 -04:00
5799b47ddb
Implement some checks and reorganize code
2020-08-10 17:04:41 -04:00
d83b4a9654
Upgrade kicbase to v0.0.11
2020-07-31 10:46:11 -07:00
9680237277
WIP
2020-07-27 14:24:40 -04:00
47ed4bc23c
update lint version
2020-07-24 14:45:15 -07:00
9c0618f102
Merge to master
2020-07-24 11:22:59 -07:00
bd713ffd45
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 09:02:32 -07:00
dee9c0b427
Show 'docker logs' excerpt if container dies
2020-07-24 08:58:09 -07:00
f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
...
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Ilya Zuyev
Anders F Björklund
Yanshu Zhao
Priya Wadhwa
Thomas Strömberg
Jituri, Pranav
Medya Ghazizadeh
Ling Samuel
Medya Gh
Parthvi Vala
Predrag Rogic
Nick Kubala
Priya Modali
ToonvanStrijp
Sharif Elgamal
Michael Ryan Dempsey
Pablo Caderno