ilya-zuyev
2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
...
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Medya Ghazizadeh
33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
...
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Medya Ghazizadeh
01328781b3
Merge pull request #11223 from andriyDev/DownloadLocks
...
Add locks to download functions.
2021-05-13 18:54:37 -07:00
Steven Powell
e1fabfd358
only throw error if not a "no such image" error returned from remove
2021-05-13 17:23:00 -07:00
Medya Ghazizadeh
9e3a66268f
Merge pull request #11384 from dinever/kicbase-tools
...
Add useful tools in the Kicbase Docker image
2021-05-13 14:14:59 -07:00
Andriy Dzikh
268e91f830
Make download.imageExistsInDaemon public to fix bad compilation.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
c0a492b879
Improve comments for ImageToCache and ImageToDaemon.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
0626bb0455
Add comment to explain lock wait timeout.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
9191d03c99
Check releaser is valid before deferring release.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
e9c4c93afa
Remove no longer relevant comment.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
118eae4311
Add function comment to lockDownload.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
248d030d73
Reword test fail message.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
f4b142c42f
Rename downloads to downloadNum.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
fbc041d2a1
Ensure directory exists in CreateDstDownloadMock and add comments.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
5e48738097
Remove SetDownloadMock and rename mockDownload to DownloadMock.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
ad356d5508
Move defer lock release to before error check so the lock is guaranteed to be released.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
a7cbc76d88
Refactor repeated mock sleep function into a single function.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
4fc0ac5c8a
Make download_test run tests in serial.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
fa0803d81e
Refactor download.go to allow more complex download mocking. Modify download_test to prevent using logging.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
5af0dcf3aa
Use spinner for lock message.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
e0a6887bab
Add message saying when download is waiting for a file lock.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
1cc80e1e7b
Move locking code to download.go.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
b57022d2c8
Make functions not used outside the download package private.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
0a44408ce8
Add locks to binary, image, and preload downloads.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
458d1d5102
Add tests for ImageToCache/Daemon that they prevent multiple downloads.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
dba9076cc3
Add mock mode check for ImageToCache and ImageToDaemon, similar to download.download.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
fd7cd15a27
Add test to check that preload prevents concurrent downloads.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
4e8451af95
Create download_test and add test for Binary downloads not colliding.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
d6f60bbd4a
Move image existence checks into downloading functions.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
26634c18a8
Move image functions related to downloading to the download package.
2021-05-13 11:57:00 -07:00
Medya Ghazizadeh
c97984a4b9
Merge pull request #11392 from dinever/fix-docker-version-test
...
Fix TestCheckDockerVersion on macOS
2021-05-13 11:44:31 -07:00
Daehyeok Mun
7c2e963392
Implement target node option for cp command
2021-05-13 10:47:09 -07:00
Peixuan Ding
6bfbb7c33a
Fix TestCheckDockerVersion on macOS
2021-05-12 17:30:29 -04:00
Steven Powell
16dbac1f66
check if image exists before trying to remove it
2021-05-12 14:26:34 -07:00
Steven Powell
e59ced9029
updated flag description and renamed force arg to overwrite and made it non-optional
2021-05-12 14:26:34 -07:00
Steven Powell
32a91d6eb2
image load loads image even if name:tag already exists
2021-05-12 14:24:49 -07:00
Anders F Björklund
6ea3ffee1f
Show suggestion for rejected unhealthy drivers
...
Normally how to add root permissions for the user, to be able to
run the "docker" or "podman" driver (through group or through sudo)
2021-05-12 07:15:26 +02:00
minikube-bot
e8b16a5247
Updating kicbase image to v0.0.22-1620785771-11384
2021-05-12 02:25:58 +00:00
Medya Ghazizadeh
c214b040e6
Merge pull request #11381 from sharifelgamal/test-doc
...
Make sure all tests have comments
2021-05-11 18:05:36 -07:00
Sharif Elgamal
7982396834
remove unnecessary logging from extract
2021-05-11 16:56:15 -07:00
Sharif Elgamal
80bb2999e4
remove last newline
2021-05-11 15:32:57 -07:00
Sharif Elgamal
972dae8133
Make sure all tests have comments
2021-05-11 15:17:43 -07:00
Medya Ghazizadeh
c136fe3cfd
Merge pull request #11060 from afbjorklund/retro-arch
...
Allow building minikube for outdated architectures
2021-05-11 12:22:03 -07:00
Anders F Björklund
acadaa6736
Don't reload from tarball if image exists in daemon
2021-05-10 12:57:37 +02:00
Medya Ghazizadeh
d9482f68e0
Revert "base-image: Allow using podman as well as docker daemon"
2021-05-09 10:43:53 -07:00
Medya Ghazizadeh
807440a8a9
Merge pull request #11063 from afbjorklund/daemon-podman
...
Allow using podman as well as docker daemon
2021-05-07 17:01:06 -07:00
Medya Gh
3aef16647a
finish french trasnlation
2021-05-07 16:04:37 -07:00
Akihiro Suda
86c7271088
docker driver: propagate NeedsImprovement and Fix to the caller
...
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-05-07 22:02:55 +09:00
Akihiro Suda
2cae14829d
docker driver: relax version constraint
...
When Docker (Moby) was installed from the source code, the version string is typically set to "dev", or "library-import".
Previously, minikube could not start with these versions.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-05-07 19:11:40 +09:00
Akihiro Suda
95e81551c9
docker driver: remove "+build darwin" from docker_test.go
...
No test in the file was specific to Darwin.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-05-07 18:14:44 +09:00