Anders F Björklund
f57faf8036
Only remount the /var/lib/minikube directory
2020-04-19 09:45:16 +02:00
Anders F Björklund
22aa1aff22
Handle more state and status for the podman driver
2020-04-19 09:45:16 +02:00
Anders F Björklund
f264ac171e
Remove extra single-quotes from format parameter
...
podman
Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
Anders F Björklund
d7dc7bf7b2
The podman driver should not be run as root
...
Use sudo for the podman commands instead
Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Medya Ghazizadeh
825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
...
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
Alonyb
bfa45ef79a
delete unnecesary func
2020-04-16 19:49:26 -05:00
Medya Gh
891e7a6520
spell
2020-04-16 16:53:04 -07:00
Medya Gh
bf15f9a00c
fix build err
2020-04-16 16:20:04 -07:00
Medya Gh
934f900f16
improve kic start and kill
2020-04-16 16:10:44 -07:00
Medya Gh
1c125e78da
address review comments
2020-04-15 10:17:23 -07:00
Alonyb
62904e5dcc
fix lint
2020-04-15 09:30:10 -05:00
Medya Gh
34fafc783f
fine tune
2020-04-14 22:20:28 -07:00
Medya Gh
29280ceff6
lint
2020-04-14 21:33:21 -07:00
Medya Gh
7303ccf07d
lint
2020-04-14 21:31:12 -07:00
Medya Gh
54aa958f01
use oci to delete
2020-04-14 20:51:18 -07:00
Medya Gh
b2bcd9a5cb
allow SSH commands to run in kic driver
2020-04-14 20:26:10 -07:00
Medya Gh
f22a36332e
add shut down to stop
2020-04-14 20:21:40 -07:00
Medya Ghazizadeh
b913981fd9
Merge pull request #7658 from medyagh/kic_apparmor
...
unconfine apparmor for kic
2020-04-14 19:39:35 -07:00
Medya Gh
d4b48e1e05
clean up after test dirs
2020-04-14 19:33:26 -07:00
Medya Gh
b7f0bfc369
unconfine apparmor for kic
2020-04-13 16:44:17 -07:00
Ruben Baez
d372027b03
Merge pull request #4 from alonyb/patch-1
...
documentation
2020-04-10 20:11:42 -05:00
Alonyb
201a2bbc62
remove driver and use clusterConfig
2020-04-10 18:50:57 -05:00
Alonyb
c4ef1b3798
add return port logic
2020-04-10 14:46:31 -05:00
Alonyb
50c2ec4eaf
add oci port mapping of registery
2020-04-10 08:20:12 -05:00
Medya Gh
4dd2152fae
update crio version in kicbase
2020-04-10 01:42:58 -07:00
Medya Gh
1eb6ce1710
build error
2020-04-09 21:56:00 -07:00
Medya Gh
e7e9f3ca1c
address review comments
2020-04-09 21:50:09 -07:00
Medya Gh
983808f956
lint
2020-04-09 21:01:49 -07:00
Medya Gh
f7f04a83c2
add killing apiserver proc to both kic and none
2020-04-09 20:53:15 -07:00
Medya Gh
ded8273a2e
add kill containers to kic stop
2020-04-09 20:01:11 -07:00
Priya Wadhwa
3a12fbd1f5
Fix spelling
2020-04-09 10:50:20 -07:00
Thomas Strömberg
6d05265a2e
Merge pull request #7539 from tstromberg/openrc
...
none: Add support for OpenRC init (Google CloudShell)
2020-04-09 04:55:57 -07:00
Thomas Strömberg
a37ec2ecd7
Merge pull request #7189 from Hellcatlk/UnitTest
...
add unit test for pkg/drivers/hyperkit/iso.go
2020-04-09 04:22:58 -07:00
Thomas Stromberg
16a8c38682
none: Add support for OpenRC init (Google CloudShell)
2020-04-08 18:20:30 -07:00
Priya Wadhwa
70329bf51d
Code review comments
2020-04-08 13:44:04 -07:00
Priya Wadhwa
accba6aa7f
code review comments
2020-04-07 15:00:28 -07:00
Priya Wadhwa
b509d69182
Extract preloaded tarball as soon as minikube volume is created
...
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.
This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
Medya Gh
a0263c2513
adjust more
2020-04-03 20:59:03 -07:00
Medya Gh
a62d611e0b
adjust kill time
2020-04-03 20:59:03 -07:00
Medya Gh
8f51d7de58
adjust warn if slow for ps and volume
2020-04-03 20:59:03 -07:00
Thomas Strömberg
37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
...
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00
Thomas Stromberg
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
Thomas Stromberg
c76fac7d74
Standardize port-forwarding and kubeconfig hostname logic, fix Docker Linux IP
2020-04-01 11:57:32 -07:00
Thomas Stromberg
2f2dccd30c
Remove test values
2020-03-26 14:05:02 -07:00
Thomas Stromberg
46f31480df
Make slow command detection consistent across kic/oci
2020-03-26 14:03:22 -07:00
Priya Wadhwa
9d75c7c35a
Rebased, resolved merge conflicts
2020-03-25 10:07:58 -07:00
Medya Ghazizadeh
5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
...
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
ZouYu
2e9054f495
add unit test for pkg/drivers/hyperkit/iso.go
...
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-03-25 11:08:27 +08:00
Priya Wadhwa
d2171be291
rebased'
2020-03-24 16:39:54 -07:00
Priya Wadhwa
1d72a1c826
don't extract volume if tarball doesn't exist
2020-03-24 15:01:31 -07:00
Medya Ghazizadeh
f00f5ff600
remove extra if
2020-03-24 10:21:32 -07:00
Medya Gh
940baa09ea
fix comment
2020-03-24 07:31:22 -07:00
Medya Gh
41b16b1568
fail if container is not running
2020-03-24 07:27:07 -07:00
Medya Gh
83cc28e082
add logging for when container status is running
2020-03-24 07:11:22 -07:00
Medya Ghazizadeh
587154196e
Merge pull request #7173 from medyagh/stop_kic
...
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
Medya Gh
67bd258465
remove extra line
2020-03-23 23:02:27 -07:00
Medya Gh
aec6fdc25a
initialize kic runner in stop
2020-03-23 21:01:12 -07:00
Medya Gh
7619a5075a
fix logging
2020-03-23 21:01:12 -07:00
Medya Gh
36f3f657af
force stop if cant stop for none
2020-03-23 21:01:12 -07:00
Medya Gh
545348341a
for none let it stop all containers
2020-03-23 21:01:12 -07:00
Medya Gh
47c8e9c87b
dont return on error kic sto
2020-03-23 21:01:12 -07:00
Medya Gh
5f90a319bd
stop k8s in kic and none
2020-03-23 21:01:12 -07:00
Medya Gh
fae3e34319
add stop force stop
2020-03-23 20:59:21 -07:00
Medya Gh
298be78e5f
remove duplicate code
2020-03-23 20:59:21 -07:00
Medya Gh
beec3b1ce1
stop kubelet on docker stop
2020-03-23 20:59:21 -07:00
Priya Wadhwa
abf35cfbc1
Upgrade podman and add libglib2.0-0 to kicbase image
...
The `TestOffline/group/crio` integration test was failing with the error:
```
crio load image: sudo podman load -i /var/lib/minikube/images/storage-provisioner_v1.8.1: exit status 125
```
I tried SSH'ing into minikube and running the command myself, and got the error:
```
Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version
```
I then tried updating conmon, but got the error:
```
conmon: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
```
I then tried adding the libglib2.0-0 library to the kic base image and upgrading podman, which seems to have resolved the issue.
2020-03-23 17:41:06 -07:00
Priya Wadhwa
bfe8aee3b5
Pass in container runtime to preload tarball name
...
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
Priya Wadhwa
0e5974367f
rebased on master'
2020-03-23 10:59:02 -07:00
vikkyomkar
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
Priya Wadhwa
89c6c72adb
Skip preload if not running on amd64
...
Also make sure that preload is available before attempting to run preload.
2020-03-13 16:24:28 -07:00
Thomas Stromberg
895967235a
Improve error message output
2020-03-13 16:18:14 -07:00
Thomas Stromberg
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
Medya Gh
70c9304724
code review comments
2020-03-13 10:37:29 -07:00
Medya Gh
99ba89c2dd
ip
2020-03-12 16:01:49 -07:00
Medya Gh
084da0c46a
fix maybe
2020-03-12 15:31:38 -07:00
Thomas Stromberg
43ce409e79
Extra debugging for preload generation process
2020-03-11 13:09:55 -07:00
Medya Gh
b5681d52c5
lint
2020-03-10 18:45:56 -07:00
Medya Gh
9ff0dc0ebc
pass api server port to kic create container
2020-03-10 18:33:59 -07:00
Thomas Stromberg
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
Thomas Stromberg
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
Thomas Stromberg
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
Medya Gh
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
Medya Gh
cb14468b44
english
2020-03-06 15:11:42 -08:00
Medya Gh
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
Thomas Stromberg
6f46393123
Remove blank line
2020-03-06 12:15:58 -08:00
Thomas Stromberg
120dce7b56
Remove extraneous calls to oci.PointToHostDockerDaemon
2020-03-06 12:13:51 -08:00
Medya Gh
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
Medya Gh
1c37fc5505
lint
2020-03-05 22:45:38 -08:00
Medya Gh
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
Medya Gh
2a37317a72
improve comment
2020-03-05 22:34:10 -08:00
Medya Gh
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
Medya Gh
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
Thomas Stromberg
1f7ae5b35b
Merge to master
2020-03-05 09:57:46 -08:00
Thomas Stromberg
a1ebcbd031
Merge conflicts
2020-03-04 18:01:41 -08:00
Sharif Elgamal
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
Sharif Elgamal
a3e000d850
addressing comments
2020-03-04 14:09:15 -08:00
Medya Gh
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00
Medya Gh
db5903d3ed
lint
2020-03-04 10:40:32 -08:00
Medya Gh
54df61d677
point to host daemon more places
2020-03-04 10:37:10 -08:00
Medya Gh
6a62046e62
add warning and point to right docker
2020-03-04 10:22:20 -08:00