Commit Graph

11318 Commits (258c3c102a9b1852c3063628152ce1cf906c7576)

Author SHA1 Message Date
Sharif Elgamal ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Medya Ghazizadeh 80d9d40b59
Merge pull request #8795 from medyagh/start_docker_windows
ci: Ensure docker desktop is running in windows
2020-07-21 15:50:29 -07:00
Medya Ghazizadeh 515095a2d2
Merge pull request #8780 from afbjorklund/kic-automount
Add minimal minikube-automount to the kic image
2020-07-21 15:50:16 -07:00
Thomas Stromberg b18aa2a57c Apply stderrAllowRe to non-error log statements 2020-07-21 15:47:22 -07:00
Thomas Stromberg 935ea862c6 Merge branch 'master' into noisy-spam 2020-07-21 15:43:22 -07:00
Sharif Elgamal 58d4b0c32f add less restrictive interface name matching 2020-07-21 15:32:38 -07:00
Priya Wadhwa 9627b586bf fix merge conflict 2020-07-21 18:30:02 -04:00
Priya Wadhwa bb00f361ca check for correct # of tests 2020-07-21 18:29:29 -04:00
Priya Wadhwa 6a33c03df2 fix unit test 2020-07-21 18:23:22 -04:00
Priya Wadhwa 8bc875d520 Rebased on master; fixed json_output integration test 2020-07-21 18:20:02 -04:00
priyawadhwa 6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Priya Wadhwa 5c09250429 Add integration test for error 2020-07-21 17:13:59 -04:00
Medya Ghazizadeh 24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Medya Gh 1784be7e0f add start docker desktop on windows jobs 2020-07-21 13:48:15 -07:00
Sharif Elgamal 280c2511f7
Merge pull request #8782 from sharifelgamal/regen-config
regenerate config on retry
2020-07-21 13:29:32 -07:00
Priya Wadhwa 6ca72229bb add json unit tests 2020-07-21 15:56:26 -04:00
Priya Wadhwa b4b9013057 Add unit test for problem.DisplayJSON() 2020-07-21 15:51:47 -04:00
Priya Wadhwa 482b9befd6 implement errors in JSON 2020-07-21 15:43:19 -04:00
Medya Gh 0a63084ccf try starting dokcer service in windows 2020-07-21 12:32:58 -07:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Medya Ghazizadeh e091b5d31f
Merge pull request #8786 from medyagh/sorted_duration_gopogh
update gopogh to have sorted test duration
2020-07-21 12:20:03 -07:00
Sharif Elgamal c4cad39fac properly regenerate config 2020-07-21 12:02:09 -07:00
Medya Ghazizadeh 92b771f148
Merge pull request #8794 from priyawadhwa/typo
fix typo
2020-07-21 11:50:47 -07:00
Priya Wadhwa ae5f5216cb fix typo 2020-07-21 14:46:37 -04:00
Priya Wadhwa c60e754624 Implement warning type for JSON output 2020-07-21 14:40:31 -04:00
Medya Gh 87bd99c6c7 bump gopogh 2020-07-21 11:23:35 -07:00
Priya Wadhwa 1d48d43605 make sure minikube binary is available on PATH for skaffold binary to call 2020-07-21 14:09:43 -04:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Dean Coakley 328dbc1f97 Improve fix message 2020-07-21 12:29:53 +01:00
Dean Coakley 66f03b89c3 Update formatting Podman->Podman v2 2020-07-21 12:24:03 +01:00
Anders F Björklund 84ed6d1358 Dummy commit to rerun the unit tests in travis 2020-07-21 09:35:21 +02:00
Anders F Björklund 59bf848e54 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
Medya Gh 3b0b4dc505 update 2020-07-20 21:19:42 -07:00
Medya Gh 801cb6dd1a add gopogh with duration with latest golang 2020-07-20 20:42:02 -07:00
Medya Gh 1e526fa300 update gopogh to have sorted test duration 2020-07-20 20:18:49 -07:00
dddddai 196789f965 Use RWMutex instead of Mutex 2020-07-21 10:39:45 +08:00
Dean Coakley 0d78fe56af lint 2020-07-21 03:00:13 +01:00
Dean Coakley 622e33b7ab Fix typo 2020-07-21 02:55:37 +01:00
Dean Coakley 62683c9b42 Exit with error on podman2 drivers 2020-07-21 02:39:46 +01:00
priyawadhwa aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh 2183c90de0
Merge pull request #8781 from medyagh/update_go_ver
update golang version
2020-07-20 16:02:24 -07:00
Medya Ghazizadeh 79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal f33ac4c221 regenerate config on retry 2020-07-20 15:26:18 -07:00
Medya Ghazizadeh c6000e6c30
Merge pull request #8777 from afbjorklund/kic-var
Make sure to prepare the kic volume after creation
2020-07-20 14:48:29 -07:00
Medya Gh 77c94988eb update golang version 2020-07-20 14:45:26 -07:00
Priya Wadhwa 0941f0f65c update profile name to be 'minikube' 2020-07-20 17:43:31 -04:00
Priya Wadhwa c14e024fa5 Add push:false to skaffold.yaml
Since skaffold only knows you are running a local cluster if that cluster's profile name is 'minikube'
2020-07-20 17:26:55 -04:00