Commit Graph

120 Commits (23bc9bb4baebce4baeb0ca3c00d4a5e7fd85ac53)

Author SHA1 Message Date
Medya Gh 8ca3d1f799 remove debug 2021-05-17 18:54:02 -07:00
Medya Gh 0068f92327 add port to addons templates 2021-05-17 18:50:12 -07:00
Steven Powell cd93ee9eb4 added message to box 2021-04-21 16:43:06 -07:00
Medya Ghazizadeh 660cc42e88
Merge pull request #10823 from azhao155/yzhao/feature/auto-hook
Add auto-pause webhook to inject env into pods for redirecting in-cluster kubectl request to reverse proxy of api server.
2021-03-29 09:53:14 -07:00
Yanshu Zhao 9ea99ae129 Add skip into label object of web hook, clean up code 2021-03-23 07:03:42 +00:00
Medya Ghazizadeh 141a7da152
Merge pull request #10818 from afbjorklund/box-cli
Add a red box around docker desktop registry port
2021-03-22 18:48:51 -07:00
Kent Iso fb216ddc93 Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0) 2021-03-20 04:07:21 +09:00
Yanshu Zhao 107331275c Add template for reverse proxy ip 2021-03-17 18:52:55 +00:00
Anders F Björklund 9b8eac8380 Moved Boxed output to a new helper in out module
And remove the extra newline inside the box,
plus remove the color if not using the emoji.
2021-03-16 21:58:11 +01:00
Anders F Björklund 5cf8dce944 Add a red box around docker desktop registry port
To make it harder to miss the notice, with the rest of the emojis

Also remove some stray "on" text, but do add "driver" and "port"
2021-03-14 16:18:53 +01:00
tripolkaandrey e2acd0d657 added check for enabled registry addon 2021-03-12 12:24:25 +02:00
Medya Gh ee74d42eba merge conflict 2021-03-11 01:14:06 -08:00
Sharif Elgamal aee9afe223 move constants to proper file 2021-03-09 15:20:02 -08:00
Sharif Elgamal d314d73c3a pull out addon specific code into their own files 2021-03-09 14:59:54 -08:00
Sharif Elgamal eb1ee1f931 account for GCE in addons test 2021-03-09 14:32:02 -08:00
Sharif Elgamal 15c44bf7ac reorganize addons to make force flag more generic 2021-03-09 13:32:09 -08:00
Steven Powell a2989a119e reverted actions from Styled to Step 2021-03-02 17:23:43 -07:00
Steven Powell e9d16eb42d replaced non-step logging with Styled 2021-03-02 17:23:43 -07:00
Medya Gh f272822d15 bump kic base 2021-02-24 13:45:53 -08:00
Medya Gh 7f3b2c2a7b addres review comments 2021-02-24 12:48:39 -08:00
Medya Gh 43cf3fa826 fix build 2021-02-24 12:30:06 -08:00
Medya Gh 50642f4bba fix kubecontext 2021-02-24 12:30:06 -08:00
Medya Gh 1bd0b6daae add final touch 2021-02-24 12:30:06 -08:00
Medya Gh 8a652887ef add helpers to enable disable autopause 2021-02-24 12:30:06 -08:00
Sharif Elgamal b71728b27f fix syntax 2021-02-10 12:16:06 -08:00
Sharif Elgamal adf6f91ee3 Merge branch 'master' of github.com:kubernetes/minikube into ingress-none 2021-02-10 11:42:21 -08:00
Kent Iso b1030dc28a Fix configuration of the metallb with empty load balancing IP range 2021-02-07 23:43:05 +09:00
Ling Samuel b949034e1a
Manage addon images in code, support custom addon images
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00
Daehyeok Mun 36d94a2d88 Migrate MachineName function.
Migrate MachineName function from driver package to config package.
2021-01-08 11:26:10 -08:00
Jituri, Pranav 0ae11fd5c8
fix linting error 2020-12-15 18:22:36 +05:30
Sharif Elgamal ad330b21ad Merge branch 'master' of github.com:kubernetes/minikube into ingress-none 2020-12-09 11:12:23 -08:00
Jituri, Pranav 6bbc5f986b
Enable Ingress Addon for Docker Windows 2020-11-21 16:01:06 +05:30
Evgeny Shmarnev db93039f9c Addressing comments 2020-11-12 13:45:33 +01:00
Sharif Elgamal cda2d13d21 Turn on ingress addon on linux baremetal 2020-10-28 12:19:26 -07:00
Thomas Stromberg e2fdc077f8 Use 6 minutes, to use the philosophy of doubling timeouts you hit 2020-10-21 09:54:01 -07:00
Thomas Stromberg 20d1645ce7 Wait up to 5 minutes for addon pods, improve error message 2020-10-21 09:44:39 -07:00
Priya Modali 8936a8c7f8 Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-13 09:08:27 -07:00
Sharif Elgamal b04610ef9b simplify addon code by fixing gcp-auth failure policy 2020-10-06 16:14:44 -07:00
Priya Modali 43ea47f4e0 Fixed merge conflicts. 2020-09-29 16:17:31 -07:00
Priya Modali 97d96bf925 Switching from glob library to klog library. 2020-09-29 15:49:41 -07:00
Sharif Elgamal ff051f9a33
Make sure gcp-auth addon can be enabled on startup (#9318)
* fix documentation for gcp-auth addon

* make sure kube-system pods are up before enabling gcp-auth

* fix lint

* add failurePolicy for webhook

* only install addons if asked

* better comment

* slightly less hacky code

* defer addons properly

* simplify code for performance
2020-09-29 13:29:14 -07:00
Thomas Strömberg fba4de74cf
Merge pull request #8787 from saltbo/master
fix error usage for the WaitGroup in the pkg addons
2020-09-01 16:21:51 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
Dean Coakley 9c23485dfb Remove list of alternative drivers 2020-07-29 09:40:43 +01:00
Dean Coakley 4b2974472d Improve error message text 2020-07-28 22:40:55 +01:00
Dean Coakley b27440d4ae Add warning for ingress addon with driver of none 2020-07-28 22:40:15 +01:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Ambor e00cf6c1e1 fix error usage for the WaitGroup in the pkg addons 2020-07-21 11:57:06 +08:00