20fc95724e
Rearrange whitespace to make goimports happy
2020-10-04 16:05:30 +02:00
e36c937a34
Do some simple cleanup of the golint complaints
...
The "magic strings" and enums still needs another approach
Simply echoing everything twice doesn't seem very useful ?
2020-10-04 13:40:33 +02:00
237591376d
Run gofmt on pkg/minikube/driver/driver_test.go
2020-10-04 09:49:58 +02:00
0fc0c82337
Merge pull request #9294 from medyagh/docker_network
...
add dedicated network for docker driver
2020-10-01 14:11:42 -05:00
73d77e2463
address review comments
2020-09-30 16:42:42 -07:00
f807bcf8c9
remove kic test
2020-09-30 14:58:20 -07:00
5815ef835c
Merge pull request #9353 from medyagh/update_kicbase_ub
...
update kicbase image to ubuntu-based
2020-09-30 12:07:58 -05:00
790dd24836
pkg machine: correct 'deleting' spelling errors
2020-09-30 09:56:33 +08:00
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
c48e8e5ec9
add more unit tests
2020-09-29 15:00:44 -07:00
82f39d1387
clarify comment
2020-09-29 14:29:34 -07:00
31e175c6f8
move index machine to driver package
2020-09-29 14:27:37 -07:00
058adb775c
address review comments
2020-09-29 14:14:25 -07:00
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
f163cf9e15
update with new logic
2020-09-29 14:14:25 -07:00
2766235a5c
try alternate if no network
2020-09-29 14:14:25 -07:00
fa0afb220d
lint
2020-09-29 14:14:25 -07:00
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
9cd42163b1
add network create funcs
2020-09-29 14:14:24 -07:00
ff051f9a33
Make sure gcp-auth addon can be enabled on startup ( #9318 )
...
* fix documentation for gcp-auth addon
* make sure kube-system pods are up before enabling gcp-auth
* fix lint
* add failurePolicy for webhook
* only install addons if asked
* better comment
* slightly less hacky code
* defer addons properly
* simplify code for performance
2020-09-29 13:29:14 -07:00
09dd4b748d
Merge pull request #9342 from tstromberg/logs-api
...
hyperv: Make interface search name match case-insensitive
2020-09-29 15:26:34 -05:00
0d6b6fcce7
Merge pull request #9343 from tstromberg/docker-detect
...
Add 'docker status' check, improve deadline-exceeded error message
2020-09-29 15:24:43 -05:00
b3401405f0
update kicbase image to ubuntu-based
2020-09-29 13:03:11 -07:00
91a32541e8
Use %d for exit code
2020-09-29 09:49:30 -07:00
8eaa3ee4f3
Use oci.CachedDaemonInfo for status check
2020-09-29 09:19:14 -07:00
be496e1053
Merge pull request #9346 from afbjorklund/gofmt-register
...
Run gofmt on code, to avoid modified workspace
2020-09-29 11:15:43 -05:00
3b26a646e8
Merge pull request #9348 from priyawadhwa/unable-to-download
...
Compare fully qualified image names when pulling kic base image
2020-09-29 11:14:12 -05:00
c2642c3a5c
Compare fully qualified image names when pulling kic
...
Fixes a small bug where we were comparing one fully qualified image (tag+digest) to an image that had only tag specified. This resulted in an unnecessary warning, which only showed up when the base image was loaded from a tarball. This happens on Cloud Shell.
2020-09-28 16:35:33 -04:00
cf7df774a1
Run gofmt on code, to avoid modified workspace
2020-09-28 21:42:55 +02:00
647c857fe1
Fix error in unittest, as pointed out by warning
...
"conversion from int to string yields a string of one rune,
not a string of digits (did you mean fmt.Sprint(x)?)"
2020-09-28 21:40:14 +02:00
4fa2e414fb
Merge branch 'master' into docker-detect
2020-09-28 11:36:18 -07:00
1ffd800c29
Add comment
2020-09-28 11:27:05 -07:00
96e35e0d70
Add 'docker status' check, improve deadline-exceeded error message
2020-09-28 11:17:59 -07:00
d34a24020f
hyperv: Make interface search name match case-insensitive
2020-09-28 09:56:19 -07:00
e6b510543e
Don't trim whitespace while extracting strings
...
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.
But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
fb878f6f62
Merge pull request #9324 from sharifelgamal/time-cmd
...
give the logs test a little wiggle room
2020-09-25 12:23:32 -07:00
75332f7c89
Merge pull request #8901 from bluestealth/MiB
...
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
...
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
b4b181b647
give the logs test a little wiggle room
2020-09-25 10:06:45 -07:00
183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
...
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
02cdb59184
Use HostHomePermission variable in known_issues.go
2020-09-22 21:40:26 +02:00
3f457dbdc1
fix error handling
2020-09-22 14:14:04 -04:00
3d547a937f
Fix Makefile rule to build bot
2020-09-22 14:00:27 -04:00
3f44d470eb
Add performance monitor code
2020-09-22 13:54:23 -04:00
8f4127b202
Use HOST_HOME_PERMISSION kind for insufficient permissions
2020-09-22 18:04:24 +02:00
603ae8fc6d
Return ExHostPermission for insufficient config file permissions
2020-09-22 10:16:27 +02:00
f6b524b372
add profile arg
2020-09-21 19:05:58 -04:00
98591a6656
Add advice for the DRV_CP_ENDPOINT error
2020-09-21 16:35:50 -04:00
615b05bf9e
Merge pull request #9265 from tstromberg/v1.19.2
...
Update DefaultKubernetesVersion to v1.19.2
2020-09-18 16:14:17 -07:00
464a742a7e
Merge branch 'master' into v1.19.2
2020-09-18 11:48:03 -07:00
Anders F Björklund
Medya Ghazizadeh
Medya Gh
zhanwang
Sharif Elgamal
Thomas Stromberg
Priya Wadhwa
Dominik Braun