2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
193d16dd0c
rename funcs for more clarity
2019-12-20 12:06:25 -08:00
03c717c7b0
unexport cacheImagesInConfigFile func
2019-12-20 12:06:25 -08:00
031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
...
kic-xmas edition
2019-12-20 11:40:46 -08:00
1014a57ea8
better names for bs type
2019-12-20 01:01:10 -08:00
bf183603c5
Disable StartHost retry. It caused more problems than it solved
2019-12-19 16:10:44 -08:00
b64a33a6e9
updated dashboard command to use new addons library
2019-12-19 15:39:29 -08:00
fa08e18e8d
goimports
2019-12-19 13:33:19 -08:00
859420c083
Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor
2019-12-19 13:06:07 -08:00
f6c61b7a80
Make sure minikube start --addons works
2019-12-19 12:44:32 -08:00
4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
...
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
aca49067fa
Merge pull request #6110 from digitalcoyote/master
...
Fixed IPv6 format for SSH
2019-12-19 11:51:55 -08:00
4c7b94971c
Address review comments
...
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
6316959739
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-19 00:28:39 -08:00
921fee7432
Moved unit tests to addons package and refactored them
2019-12-18 22:02:10 -08:00
e72cb80cbf
Enable/disable addons works per profile
...
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
b8d07daef3
move reusabe parts of kubeadm to a package
2019-12-18 17:22:42 -08:00
31ad90d3cb
Add place holder bootstrapper for kicbs
2019-12-18 16:11:50 -08:00
83374f4371
add querytype to nslookup
2019-12-18 15:54:36 -08:00
19560a631b
Add kic specific machine creation message
2019-12-18 15:53:34 -08:00
2243847f98
add kic command runner to machine
2019-12-18 13:57:32 -08:00
c627f58fbb
add default image
2019-12-18 13:04:09 -08:00
ba8b723978
Move addon related logic to pkg/addons for better organization
2019-12-18 11:31:29 -08:00
98508253a5
--download-only should download drivers
2019-12-18 09:46:36 -08:00
b6dbf3bd0d
add auto-set container-runtime for kic
2019-12-17 22:19:39 -08:00
119d95cb31
Fixed format of IPV6 address and port
2019-12-17 13:23:30 -06:00
a840cb7289
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-17 00:58:45 +09:00
661ebf843f
Merge master
2019-12-10 14:07:02 -08:00
349f414dee
Merge pull request #5987 from medyagh/cache_fix2
...
cache add: load images to all profiles & skip previously cached images
2019-12-10 13:58:57 -08:00
14b805d494
Remove unused vars
2019-12-10 08:17:08 -08:00
8b7aaba627
Sync correct Kubernetes versions from kubeadm constants
2019-12-10 08:12:15 -08:00
434648c6fc
Merge pull request #5773 from priyawadhwa/pr-bot
...
Add skeleton for performance analysis service
2019-12-09 18:26:45 -08:00
60346821d6
move machine path to localpath package
2019-12-09 14:51:10 -08:00
35ad8e2915
make profile name mandatory for config.Load
2019-12-09 14:47:20 -08:00
a6c749f905
Merge pull request #5798 from nanikjava/f-fix-2570
...
Make Kubernetes version sticky for a cluster instead of auto-upgrading
2019-12-09 13:47:44 -08:00
1f36a42203
Merge pull request #5912 from tstromberg/user-mutex2
...
Make lock names uid and path specific to avoid conflicts
2019-12-09 13:34:56 -08:00
4b78f7bd48
Rebased on head, resolved merge conflict
2019-12-09 12:03:37 -08:00
d7b6e66038
fix unit tests and improve naming
2019-11-26 20:07:56 -08:00
95717c4793
add status to profile list
2019-11-26 19:53:27 -08:00
cdb68a139e
refactor config to allow load profile config
2019-11-26 18:32:59 -08:00
6c08fedf97
remove cyclic depdenecy and make cluster pkg smaller
2019-11-26 17:48:37 -08:00
72e973027d
Merge pull request #5955 from cheeseandcereal/fix_profile_list_json
...
Fix profile list json command output
2019-11-25 14:59:11 -08:00
c462862a38
Merge pull request #5964 from afbjorklund/config-runtime
...
Fix validation of container-runtime config
2019-11-25 13:19:23 -08:00
3451320ad2
Fix validation of container-runtime config
...
It was trying to load (non-existing) config,
and also confusingly looking for containerd.
Add a unit test as well.
2019-11-23 10:35:12 +01:00
fbb1d97cf1
feat(virtualbox): Users and set nat-nic-type and host-only-nic-type
2019-11-22 13:50:12 -05:00
f8a2d1da07
fix profile list json command output
...
Signed-off-by: Adam Crowder <adam@adamcrowder.net>
2019-11-20 13:58:05 -08:00
f680d1b1fc
Fix --kubernetes-version for upgrading cluster to correct version
...
This PR fix the issue of checking kubernetes-version and upgrading it. The fix now
will do the following
* Not specifying the --kubernetes-version flag means just use the currently deployed version.
* If an update is available inform the user that they may use --kubernetes-version=<version>.
* When --kubernetes-version is specifically set, upgrade the cluster.
Also add integration testing to test upgrading and downgrading
2019-11-16 21:12:54 +11:00
557339acc2
Recover from aborted kubeadm runs by checking for file existence
2019-11-14 15:00:56 -08:00
1c46502f35
Merge pull request #5848 from hypnoglow/try-ssh-retry
...
Add retry to SSH connectivity check
2019-11-14 14:08:41 -08:00
a750524774
Fix test that made assumption that minikube was valid
2019-11-14 10:56:44 -08:00
33293ed689
Retry on SSH connectivity check
2019-11-13 22:23:50 +03:00
2411895715
Clarify restart code, remove duplicate health check
2019-11-12 21:29:53 -08:00
4ae939244c
Clarify help text for --wait, take #2
2019-11-12 14:23:39 -08:00
55a7002ed7
Clarify help text for --wait
2019-11-12 14:22:53 -08:00
dc3a50e026
Make --wait=false wait for nothing again, change default to --wait=true
2019-11-12 13:38:48 -08:00
c03aee8322
Refactor config.Config to prepare for multinode ( #5889 )
...
* Refactor config.Config to prepare for multinode
* merge conflict
2019-11-11 17:52:15 -08:00
fb5430fd97
Getting rid of GetMachineName() ( #5868 )
...
* removing GetMachineName()
* replacing GetMachineName with a config lookup
* fix tests
* making unit tests happy
* fixing concurrent map writes, only right to viper once
* debugging
* one last test fix
* DeleteAlwaysSucceeds should actually always succeed
* prevent panic when deleting nonexistant cluster
* remove last GetMachineName reference
2019-11-11 14:47:47 -08:00
3f98e12fa9
Remove redundant return
2019-11-11 12:16:13 -08:00
82231dc0ee
Merge
2019-11-11 08:38:29 -08:00
1d0ca6cd68
Merge pull request #5854 from tstromberg/driver-compat-msg
...
Improve message when selected driver is incompatible with existing cluster
2019-11-11 08:22:57 -08:00
108fd082b5
change name monitor to pr-bot
2019-11-07 10:48:55 -08:00
79fcf7172d
Merge pull request #5845 from tstromberg/none-memory
...
none driver: Warn about --cpus, --memory, and --container-runtime settings
2019-11-07 06:54:45 -08:00
9d0c3eda8e
Remove extra word
2019-11-06 15:56:11 -08:00
1b9955f3d6
Improve message when selected driver is incompatible with existing cluster
2019-11-06 15:53:42 -08:00
b02b4e158a
Avoid panic and output correct driver name
2019-11-06 14:18:28 -08:00
6ff68709dd
Merge pull request #5243 from rajalokan/remove-heapster
...
Remove heapster addon
2019-11-06 11:35:35 -08:00
0af762e51f
none driver: Add warnings about --cpus, --memory, and --container-runtime
2019-11-06 10:29:02 -08:00
fb3360da06
Check health of drivers from existing configs
2019-11-05 17:16:23 -08:00
9c2b554ce7
Merge branch 'master' into better-existing-start
2019-11-05 15:04:22 -08:00
8809ab113a
Validate existing drivers too
2019-11-05 14:59:12 -08:00
47fe5b2822
Remove ping, was added in merge conflict
...
Supposed to be removed in 361222f
2019-11-02 08:59:19 +01:00
df1175f51f
Merge branch 'master' into reportcard-again
2019-11-01 18:32:37 +01:00
d7569b375c
Merge pull request #5803 from tstromberg/allow-force
...
Allow CPU count check to be disabled using --force
2019-10-31 12:03:13 -07:00
9cfd2073ba
Allow CPU count check to be disabled using --force
2019-10-31 11:28:34 -07:00
361222f606
Make network validation friendlier, especially to corp networks
2019-10-31 09:49:41 -07:00
c34e865ab6
Improve warning message
2019-10-30 14:06:39 -07:00
e8be75c74a
Warning -> Warningf
2019-10-30 14:06:05 -07:00
4ce2f784f1
Fix failure issues with integration testing for service command
2019-10-30 13:57:08 -07:00
2c0f2a42dd
Append newline to --url output
2019-10-30 12:35:25 -07:00
f60764b07f
service: fix --url mode, add integration tests
2019-10-30 10:44:54 -07:00
ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
...
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
169c3e7479
Add skeleton for performance scanning service
...
This service runs in a VM and is responsible for:
1. Determining which PRs need to be analyzed
2. Running mkcmp against each PR
3. Commenting the results on the PR via minikube-bot
This PR also moves the mkcmp code into its own directory.
2019-10-29 13:53:49 -07:00
74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
...
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
...
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
994d093766
Add boolean to disable opening browser during test
...
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.
The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
bd5840aacf
improve comments
2019-10-28 18:02:45 -07:00
f3b1a09c36
Clean up bootstrapper interface to accept list of pods to wait for
...
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
5f12e9afa1
Update docs and add error message to generate-docs
2019-10-28 17:12:03 -07:00
29a015b63f
remove more bin bash c
2019-10-28 14:10:22 -07:00
f5ad9014ae
Merge pull request #5758 from tstromberg/inverted-ssh
...
Do not check sshd for the none driver
2019-10-28 10:56:30 -07:00
f92b308f9a
Rebased on master
2019-10-28 10:46:35 -07:00
cf62ff62b2
Remove extra log
2019-10-28 10:46:14 -07:00
7900b63d2b
Wait for only apiserver by default
...
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.
Ref #5681
2019-10-28 10:45:57 -07:00
b1fd21e118
Do not check sshd for the none driver
2019-10-28 10:35:20 -07:00
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
d635b8dfc7
Add comments as requested by golint
2019-10-26 13:16:29 +02:00
c3498c593b
Decrease cyclomatic complexity
...
Mostly by using the "extract method" pattern.
Here is the report (from gocyclo), before:
21 cmd runStart cmd/minikube/cmd/start.go:272:1
18 cmd validateNetwork cmd/minikube/cmd/start.go:982:1
16 cmd runDelete cmd/minikube/cmd/delete.go:90:1
16 cmd deleteProfile cmd/minikube/cmd/delete.go:177:1
2019-10-26 13:08:23 +02:00
991d84e9f5
Merge pull request #5732 from tstromberg/config-avail
...
Hide innocuous viper ConfigFileNotFoundError
2019-10-25 12:45:20 -07:00
Medya Gh
Medya Ghazizadeh
tstromberg
Priya Wadhwa
Kenta Iso
Curtis Carter
Anders F Björklund
David Newman
Adam Crowder
Nanik T
Igor Zibarev
Sharif Elgamal