Commit Graph

2108 Commits (20d3fb06508205ff1f74a466cd647ce7550ffc2e)

Author SHA1 Message Date
Medya Ghazizadeh b9f3638f2a
Merge pull request #9233 from afbjorklund/nic-type
Fix copy/paste error in virtualbox nic-type help
2020-09-15 16:05:52 -07:00
Anders F Björklund 48d44221a9 Don't validate Docker storage driver for Podman
For podman, "overlay" and "overlay2" are the same
2020-09-13 22:28:17 +02:00
Anders F Björklund 37e521272c Fix copy/paste error in virtualbox nic-type help
It used type "host only" twice, instead of "nat".
2020-09-13 17:25:02 +02:00
Sharif Elgamal ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
Thomas Strömberg c4663b8417
Merge pull request #9181 from tstromberg/m1
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-08 14:25:13 -07:00
priyawadhwa b4400ad70a
Merge pull request #8904 from Xcalizorz/master
fixes(#8301): --help: bool flags which default to 'false' yield confusing output
2020-09-08 13:50:10 -04:00
Thomas Stromberg f15fd81333 Add Docker Desktop instructions if memory is >minimum but <recommended 2020-09-03 11:39:14 -07:00
Thomas Stromberg 54443bd337 Update min*Mem constants to use MiB instead of MB 2020-09-03 11:34:40 -07:00
Asare Worae e20223d598 quote variables in GuestMountConflict warning 2020-09-03 18:39:31 +02:00
Asare Worae 4e772347d4 exit on existing cluster start with KiC driver mount configuration change 2020-09-03 18:25:10 +02:00
Asare Worae 229969aa54 fix grammer 2020-09-03 10:02:07 +02:00
Asare Worae 5ae5be7141 fixed misuse of template variable 2020-09-03 10:01:19 +02:00
Asare Worae 2b2220ac8b added warning for changing mount configuration with KiC dirver on existing cluster 2020-09-03 09:51:11 +02:00
Thomas Strömberg dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
Thomas Strömberg d1431fe0e5
Merge pull request #9167 from tstromberg/kubectl-advice
Simplify kubectl advice messaging
2020-09-02 14:12:17 -07:00
Sharif Elgamal 830af29223
Merge pull request #9144 from tstromberg/confusing-warning
Remove conflicting & inaccurate Docker Desktop memory warning
2020-09-02 14:01:33 -07:00
Thomas Stromberg 4e9a3975df Simplify kubectl advice messaging 2020-09-02 13:35:40 -07:00
Thomas Stromberg 0d4ef00210 Use out.T for a simpler layout 2020-09-02 10:56:06 -07:00
Thomas Stromberg 08d874a4a2 Reduce performance-advice message to a single line 2020-09-02 10:38:45 -07:00
Priya Wadhwa ea5af644ec fix merge conflict 2020-09-02 09:31:42 -04:00
vinu2003 2b8c48cc59 start: fixed the type value for kubectl version mismatch to warning 2020-09-02 21:17:13 +10:00
Zadjad Rezai eff63d7382 chore(#8301): Changes https-flag description 2020-09-02 10:24:12 +02:00
Thomas Strömberg dc5951451b
Merge pull request #8872 from kadern0/issue-8857
Running internal kubectl command when minikube is called as 'kubectl'
2020-09-01 22:44:44 -07:00
Thomas Strömberg d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
respect native-ssh flag
2020-09-01 22:37:37 -07:00
Thomas Strömberg 8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
Thomas Stromberg f69c6c5773 Remove conflicting & possibly inaccurate Docker Desktop specific memory warning 2020-09-01 08:40:00 -07:00
Thomas Stromberg 8ef7410066 Shorten Docker memory warning 2020-08-30 21:04:10 -07:00
Thomas Stromberg cd91fb8470 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:20 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
vinu2003 ac604f25a1 feature: added shorthand for start command output option 2020-08-27 10:07:25 +10:00
Priya Wadhwa d634a85ff9 use daemon info so this works for docker and podman 2020-08-24 17:50:09 -04:00
Priya Wadhwa 535294e523 fixed merge conflict 2020-08-24 17:35:03 -04:00
Priya Wadhwa a767b64b41 fix merge conflict 2020-08-21 21:40:32 -04:00
Priya Wadhwa 88aece40d2 change name 2020-08-21 15:05:37 -04:00
Priya Wadhwa 97acf408e0 fix error wording 2020-08-21 13:34:06 -04:00
Medya Gh e9cfbd0098 add an new flag to stop command --keep-context-active 2020-08-21 10:27:28 -07:00
Priya Wadhwa acd6589c5d Remove debugging 2020-08-21 09:56:03 -04:00
Priya Wadhwa 44b93f4776 Change MemoryCapacity to StorageCapacity to be more accurate 2020-08-21 09:49:48 -04:00
Priya Wadhwa 482b2bf624 additional debugging 2020-08-20 17:23:04 -04:00
Thomas Strömberg 344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
Priya Wadhwa 7eda3a7711 Create new exit code for InsufficientStorage 2020-08-20 15:27:06 -04:00
Priya Wadhwa 83eba00d47 add deubgging 2020-08-20 14:42:55 -04:00
Anshul Sirur 6e8f596eac Fix --memory flag parsing in minikube start
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
Li Zhijian 906bcb9cab fix typo miniube
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')

Fixes: #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
Priya Wadhwa 1783cc2939 Make sure minikube status shows status name and details 2020-08-19 13:32:36 -04:00
Priya Wadhwa 3dba974535 Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
if there is insufficient storage. Output now looks like:

```
{
  "Name": "minikube",
  "StatusCode": 507,
  "StatusName": "InsufficientStorage",
  "StatusDetail": "/var is almost out of disk space",
  "Step": "Starting Node",
  "StepDetail": "Updating the running docker \"minikube\" container ...",
  "BinaryVersion": "v1.12.3",
  "Components": {
    "kubeconfig": {
      "Name": "kubeconfig",
      "StatusCode": 500,
      "StatusName": ""
    }
  },
  "Nodes": [
    {
      "Name": "minikube",
      "StatusCode": 507,
      "StatusName": "InsufficientStorage",
      "Components": {
        "apiserver": {
          "Name": "apiserver",
          "StatusCode": 405,
          "StatusName": "Stopped"
        },
        "kubelet": {
          "Name": "kubelet",
          "StatusCode": 405,
          "StatusName": "Stopped"
        }
      }
    }
  ]
}
```
2020-08-19 13:25:48 -04:00
Pablo Caderno 9708036592 Updated default cmd string when minikube is run as kubectl
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 21:20:50 +10:00
Pablo Caderno 10a3f2e2a8 Running internal kubectl command when minikube is called as 'kubectl'
Fixes issue #8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 20:52:58 +10:00
priyawadhwa 51110dbbe8
Merge pull request #8969 from priyawadhwa/cpu-limit
skip validations if --force is supplied
2020-08-11 18:16:13 -04:00
Priya Wadhwa f122deeaf3 suggest --force for k8s version 2020-08-11 15:42:05 -04:00