Commit Graph

439 Commits (1ddd835a6e38e0b19fe5e068d728a4bde30e606d)

Author SHA1 Message Date
priyawadhwa 77942bbf94 Restart containerd after stopping alternate runtimes (#3343)
After stopping any runtimes that aren't being used, if we're using
containerd then we need to restart it. This is because it competes with
cri-o to listen on port 10010, causing a necesary plugin to not be
installed. After stopping cri-o, we need to restart containerd so that
the plugin is installed.

I also added some preflight checks when using alternative runtimes.
kubeadm checks to make sure the Docker service is running, so I disabled
that. It also checks if a few ports are available; these are ports that
containerd uses, so I also added them to the ignore list.

This should finish the work started in #3211, which stopped alternative
runtimes but didn't restart containerd. I was able to run "minikube
start" with containerd locally with this change.
2018-11-16 11:48:24 -08:00
dlorenc 4e5623e4fa Fix error formatting 2018-11-15 16:36:30 -06:00
Anders Björklund b69fc99d62 Stop docker daemon, when running cri-o (#3211)
* Stop extra container runtimes, before bootstrapper

The minikube.iso starts every runtime, by default

* Disable docker-env output, if docker isn't running

Might be running an alternative container runtime
2018-11-14 16:43:07 -08:00
Anders Björklund 2ceec0d084 Add config parameter for the cri socket path (#3154)
* Add config parameter for the cri socket path

Closes #3153

* Remove stray newline, when not using criSocket

* Add the --cri-socket parameter to configuration

Also fix the syntax for CRI-O, adding unix://
2018-11-14 16:36:02 -08:00
Thomas Stromberg a9d7c41056 One last rune->byte switch 2018-11-09 15:16:36 -08:00
Thomas Stromberg 810a6c70ef Update strings to reflect that a byte is returned instead of a rune 2018-11-09 15:16:05 -08:00
Thomas Stromberg 81815182c7 Use io.ByteReader interface 2018-11-09 15:11:58 -08:00
Thomas Stromberg 9013a57e58 Timeout when reading host:port from older kubectl versions.
kubectl releases older than August 2017 don't include a newline, which
means there is effectively no hint that the output has completed. I
believe this is why tests have been failing on the macOS.

Should resolve test timeout panics such as #3203
2018-11-09 15:03:08 -08:00
Bartel Sielski dd196abe30 Remove newline at the start of zsh completion file
Signed-off-by: Bartel Sielski <bsielski@nalys-group.com>
2018-10-30 11:23:46 +01:00
Thomas Stromberg 72e596507a Merge branch 'master' into consistent_err_formatting 2018-10-19 14:08:35 -07:00
Balint Pato ae9f4b20c7
minikube tunnel (#3015)
This commit introduces a new command, `minikube tunnel`, a LoadBalancer emulator functionality, that must be run with root permissions.

This command:

* Establishes networking routes from the host into the VM for all IP ranges used by Kubernetes.
* Enables a cluster controller that allocates IPs to services external `LoadBalancer` IPs.
* Cleans up routes and IPs when stopped (Ctrl+C), when `minikube` stops, and when `minikube tunnel` is ran with the `--cleanup` flag
2018-10-18 11:01:47 -07:00
Thomas Stromberg fd0d46680e Respect the -p flag to set the appropriate profile. 2018-10-04 11:35:24 -07:00
Thomas Stromberg 534325e88f Use %v for errors instead of %s 2018-10-03 21:57:17 -07:00
Thomas Stromberg c079bb1934 Update integration tests to handle newly persistant dashboard. 2018-10-03 15:06:30 -07:00
Thomas Stromberg d38705a42b Fix overzealous replacement of namespace -> ns that broke URL generation 2018-10-03 13:58:25 -07:00
Thomas Stromberg 2956621c20 Add function comments, improve proxy stdout log message 2018-10-03 13:30:09 -07:00
Thomas Stromberg 4c35c505f6 Double HTTP wait time and make error messages more readable. 2018-10-03 13:22:36 -07:00
Thomas Stromberg ac6dacff4a Address lint issues resulting from the dashboard proxy refactor. 2018-10-03 13:14:47 -07:00
Thomas Stromberg 8fd45bc751 Block until the proxy URL is healthy.
This is necessary now that there is no proper service endpoint to block
on.
2018-10-03 13:00:13 -07:00
Thomas Stromberg df54c6a5b4 Use "kubectl proxy" instead of a NodePort to expose the dashboard.
This provides an additional level of security, by enforcing host checking, applying port randomization, and requiring explicit user intent to expose the service to the host.
2018-10-02 22:25:45 -07:00
Thomas Stromberg 3706b3b8ac Fix dangling format issues. 2018-09-28 16:48:37 -07:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
Arijit Basu bed9aabaf8 Stay in same line 2018-09-10 12:15:28 -05:00
Jason Stangroome 9b21d3c7e4 Allow certificates to be optionally embedded in .kube/config
Opt-in with `minikube config set embed-certs true`. Similar to the
behaviour of `kubectl config set-credentials --embed-certs`.

Enables Minikube on Windows to produce a .kube/config file that
can be shared directly with kubectl inside the Windows Subsystem
for Linux (WSL) without needing to perform additional translation
of the certificate paths within the configuration file.
2018-09-03 15:34:50 -05:00
Asbjørn Apeland 5a78ac92f6 Change Linux install method
Previously, files installed to /usr/local/bin/ would be owned by the
user executing the command, not root. This change makes these installed
files owned by root instead. Improving security is the goal.
2018-07-31 10:55:22 -07:00
dlorenc deb2ded956 Add back version flag. 2018-07-24 12:36:42 -07:00
dlorenc a3b7a56ae0 Remove the call to validatek8sversion. 2018-07-24 12:36:42 -07:00
Aaron Prindle 8264dc0a12 fix issue where version was not being set 2018-07-24 12:36:42 -07:00
Aaron Prindle a4606583e4 remove all localkube references from code, change /var/lib/localkube to /var/lib/minikube 2018-07-24 12:36:42 -07:00
dlorenc 15b035748c Manual changes to remove localkube. 2018-07-24 12:36:42 -07:00
Dusty Rip 2dea4e1051 Allow zsh completion to be autoloaded by compinit 2018-07-18 09:44:35 -07:00
kairen ad576faae9 Reuse the FeatureGates field to parse kubeadm and component feature gates 2018-07-16 08:09:09 -07:00
kairen ccaec1db0e Add feature gates support for Kubeadm 2018-07-16 08:09:09 -07:00
Rohit Agarwal 96079478a7 Add nvidia-driver-installer and nvidia-gpu-device-plugin addons. 2018-07-08 22:25:48 -07:00
Rohit Agarwal 268c932240 Add GPU support to minikube. 2018-07-08 22:25:48 -07:00
Peter Trotman 3dfea62fd4 Changed the nodes within the VM to use a NodeName variable that is
seperate from the VM Machine Name to ensure proper functionality when
using different profile names.
2018-06-18 08:39:11 -07:00
dlorenc 305e803316 Bump Docker API Verson. 2018-06-05 13:45:01 -07:00
seborama ee73cbde6b Added hyperkit options for enterprise VPN support
The purpose of these changes is to enhance Hyperkit support from the
minikube command line for better integration with enterprise networks
behind a VPN.

uuid: Provide VM UUID to restore MAC address (only supported with
      Hyperkit driver).
vpnkitSock: Location of the VPNKit socket used for networking. If empty,
            disables Hyperkit VPNKitSock, if 'auto' uses Docker for Mac
            VPNKit connection, otherwise uses the specified VSock."
vsockPorts: List of guest VSock ports that should be exposed as sockets
            on the host (Only supported on with hyperkit now).

Note:
tests pass but file:
`vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go`
has to be edited to correct an issue - not committed since this is in
the vendor directory.
2018-06-04 09:46:20 -07:00
Mark Gibbons 5ed8a7ef91 Made caching async with block for completion before copy of images into cluster. Default imageing caching to false 2018-06-04 08:15:12 -07:00
mlgibbons 0519b237a2 Addressed race condition caused by async image caching with no wait which resulted in unreliable image loading and prevented offline execution of "minikube start". 2018-06-04 08:15:12 -07:00
Li Yi 9198b04386 Fix error messages for enabling/disabling addon
Signed-off-by: Li Yi <denverdino@gmail.com>
2018-04-29 18:06:48 -07:00
AdamDang 12f1833ea9
Typo fix: Seperated list->Separated list
Seperated list->Separated list
2018-04-29 16:27:11 +08:00
dlorenc 0bf5166e14 Deprecate localkube. 2018-04-09 13:24:07 -07:00
Yongkun Anfernee Gui 0fa64b3bd8 Reorganize the minikube drivers
- Add registry to register all supported drivers in different platforms.
- Add DriverDef to define driver's metadata.
- All driver support logic moved to pkg/minikube/drivers, removed all
  driver name switches scattered in different packages.
2018-03-11 13:41:30 -07:00
David Muckle adb30393d1 Add metrics-server as an addon 2018-02-21 15:33:27 -05:00
Yongkun Anfernee Gui c07258b45a Fix more permissions 2018-02-09 14:32:53 -08:00
Steve Sloka 4d060d3bdb Bump registry-creds version 2018-02-07 20:09:20 -08:00
Chen Li 82ea016de7 Redirect command Stdout & Stderr for command_runner
CombinedOutput function return after command complete.
When we run a long run command, such as continuously get
new log entries, it failed to get run results.

Fixes: https://github.com/kubernetes/minikube/issues/2447
2018-02-05 09:18:49 -08:00
Remi FUSSIEN dde00ebfa3 Fix the description in the completion command 2018-02-02 18:57:29 +01:00
Matt Rickard c76b210393
Merge pull request #2486 from langyxxl/localkube-add-root-check
localkube add ROOT permission check
2018-02-01 16:42:26 -08:00