Commit Graph

1758 Commits (1b85d484a99f1bba794ba3fcf5b11f46a0295f4e)

Author SHA1 Message Date
Thomas Stromberg c3ffe98943 Merge master 2020-03-20 20:21:57 -07:00
Thomas Strömberg 986679bc8d
Merge pull request #6787 from sharifelgamal/m2
Implement multi-node cluster capabilities
2020-03-20 19:26:56 -07:00
Prasad Katti df80a60622 Merge branch 'master' into add_desc_node_to_minikube_logs 2020-03-20 16:46:34 -07:00
Thomas Stromberg 6de56d3a7a Merge branch 'master' into better-fixhost 2020-03-20 15:37:07 -07:00
Prasad Katti 4faa31ebcf Add logic to get desc node output in bootstrapper LogCommands func 2020-03-20 14:56:04 -07:00
Sharif Elgamal 35aec77fe4 code comments 2020-03-20 14:07:43 -07:00
Sharif Elgamal 4c00ae01ed Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-20 12:43:11 -07:00
Sharif Elgamal bb387039d1 move panic out of library 2020-03-20 11:29:36 -07:00
Thomas Stromberg bb0511c5c8 Merge branch 'master' into better-fixhost 2020-03-20 07:30:48 -07:00
Thomas Strömberg 729642ef33
Merge pull request #7112 from tstromberg/apiserver-always
Improve error when docker-env is used with non-docker runtime
2020-03-19 20:24:31 -07:00
Sharif Elgamal 6a6b77a161 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-19 18:18:03 -07:00
Thomas Stromberg 5cd7660d1e fixHost: only reprovision if necessary, and only once 2020-03-19 17:44:21 -07:00
Thomas Stromberg dadf4bd35d Improve error message when docker-env is used with an incompatible runtime 2020-03-19 14:04:40 -07:00
Priya Wadhwa 39b5c534ab Add warning if both vm-driver and driver are specified 2020-03-19 12:08:34 -07:00
Sharif Elgamal f9b38dc04e clean up status output and have multinode survive cluster restarts 2020-03-18 21:28:03 -07:00
Thomas Stromberg 9420a941f9 Remove false positives 2020-03-18 16:22:23 -07:00
Sharif Elgamal a24aa5dff7 dramatically simplify start code path 2020-03-18 15:04:56 -07:00
Priya Wadhwa ff8ae7311c If user doesn't specify driver, don't validate against existing cluster 2020-03-18 12:27:17 -07:00
Thomas Strömberg ce1cc8d34c
Merge pull request #7054 from afbjorklund/image-mirror-version-parse
Strip the version prefix before calling semver
2020-03-18 08:10:38 -07:00
Thomas Strömberg 3f6d32aff8
Merge pull request #7080 from priyawadhwa/ignores-driver
Move some of the driver validation before driver selection
2020-03-18 07:56:25 -07:00
Priya Wadhwa dd707820fc If memory is specified in config, suggest that for memory allocation 2020-03-17 18:07:48 -07:00
Priya Wadhwa d5490a8fb8 Move driver validation before driver selection
If a user passes in a driver via --vm-driver or --driver, then we should make sure it matches the preexisting cluster (if one exists) before we try and get information about the driver. This avoids confusing logs where we tell the user we're using the preexisting driver but then error out because they specified a different driver.
2020-03-17 16:04:43 -07:00
Sharif Elgamal 66a6f4e906 fix docker status 2020-03-17 12:28:44 -07:00
vikkyomkar e053e4f235 Add --vm flag for users who want to autoselect only VM's 2020-03-17 13:21:05 +05:30
Sharif Elgamal f99d335fed fix docker driver 2020-03-16 15:36:05 -07:00
Sharif Elgamal 74b1f34715 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-16 10:01:38 -07:00
Anders F Björklund dc6b9bae2b Add basic unit test for image mirror country 2020-03-15 13:47:56 +01:00
Anders F Björklund e7af223d72 Strip the version prefix before calling semver 2020-03-15 12:31:14 +01:00
Medya Ghazizadeh bf1b6d799c
Merge pull request #7048 from afbjorklund/reportcard-1.8.2
Improve reportcard for the v1.8.2 release
2020-03-14 19:22:24 -07:00
vikkyomkar f54af5d684 function name HostPortBinding changed to ForwardedPort 2020-03-14 21:28:12 +05:30
Anders F Björklund 5987a390e7 Improve reportcard for the v1.8.2 release
gofmt: 99%
	pkg/minikube/docker/store_test.go
		Line 1: warning: file is not gofmted with -s (gofmt)
golint: 99%
	pkg/minikube/cruntime/docker.go
		Line 40: warning: exported type ErrISOFeature should have comment or be unexported (golint)
		Line 44: warning: exported function NewErrISOFeature should have comment or be unexported (golint)
gocyclo: 99%
	cmd/minikube/cmd/start.go
		Line 801: warning: cyclomatic complexity 18 of function generateCfgFromFlags() is high (> 15) (gocyclo)
2020-03-14 14:25:50 +01:00
Medya Ghazizadeh 75ba4c27df
Merge pull request #7043 from tstromberg/lz4-missing
Delete: output underlying status failure, better machine function names
2020-03-13 18:38:24 -07:00
Sharif Elgamal c3b56b6466 let's rearrange a bunch of code 2020-03-13 18:08:10 -07:00
Thomas Stromberg b0e4b32805 Correct name variable 2020-03-13 16:00:30 -07:00
Thomas Stromberg 9fa98a834b status: properly state if cluster does not exist 2020-03-13 15:58:14 -07:00
Thomas Stromberg 196a8d7b82 Delete: output underlying status failure, refactor wordy code 2020-03-13 15:51:03 -07:00
Sharif Elgamal d98ebcfb68 lint 2020-03-13 15:32:14 -07:00
Sharif Elgamal 36089037d9 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-13 15:24:07 -07:00
Sharif Elgamal a9b73b8ba3 fixing up minikube start path 2020-03-13 15:03:19 -07:00
Anders F Björklund d81ba5b5cb Don't skip the check for too old versions for new
Even when starting a new profile, we still need to check the
k8s version parameter against the oldest supported version...

This helps guard against accidental errors like confusing the
kubernetes version (v1.17.3) with the minikube version (v1.8.1)
2020-03-13 12:39:32 +01:00
Sharif Elgamal 3ed818c488 cosmetic fixes 2020-03-12 15:40:13 -07:00
Thomas Strömberg a29c5739ab
Merge pull request #6988 from tstromberg/v1.18.0-beta
Update NewestKubernetesVersion to 1.18.0-beta.2
2020-03-11 17:00:35 -07:00
Thomas Strömberg 2412dd5331
Merge pull request #6998 from tstromberg/kubectl-mismatch
Improve kubectl mismatch UI for clarity
2020-03-11 15:42:12 -07:00
Thomas Stromberg aaf115b592 Use a more specific output example! 2020-03-11 12:47:54 -07:00
Thomas Stromberg db32326873 Improve kubectl mismatch representation 2020-03-10 20:55:22 -07:00
Thomas Stromberg 12fd0b007e Revert kubectl mismatch UI change 2020-03-10 20:52:54 -07:00
Thomas Stromberg 71a22787c3 Update Kubernetes image mapping to match v1.18 2020-03-10 20:48:38 -07:00
Thomas Stromberg d98bddac15 Set viper default in a better place 2020-03-10 17:45:43 -07:00
Thomas Stromberg c6333b95aa Test fixes: Add viper.SetDefault back, and make CalculateSizeInMB return an error instead of exit early 2020-03-10 17:43:56 -07:00
Thomas Stromberg f1d2127498 Only parse memory if set 2020-03-10 16:44:50 -07:00
Thomas Stromberg 4788b75fcf Round suggested memory alloc by 100MB for VM's 2020-03-10 16:06:11 -07:00
Medya Ghazizadeh ec5dfbb17f
Merge pull request #6959 from afbjorklund/reportcard-cleanup
Improve the go reportcard for minikube
2020-03-10 15:11:00 -07:00
Sharif Elgamal e3227a2ded Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-10 15:02:38 -07:00
Thomas Stromberg b99304eac3 WarningType -> Warning 2020-03-10 09:07:42 -07:00
Thomas Strömberg 4f5c882ca4
Merge pull request #6969 from sharifelgamal/cp-bc
Allow backwards compatibility with 1.6 and earlier configs
2020-03-10 07:19:03 -07:00
Sharif Elgamal 05116abb1f more fallout for the merge-pocalypse 2020-03-09 19:29:29 -07:00
Sharif Elgamal 64ca925d6c Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-03-09 16:32:54 -07:00
Sharif Elgamal 3b900cb308
minor fix 2020-03-09 12:39:58 -07:00
Sharif Elgamal 424b5170f7
Allow backwards compatibility with 1.6 and earlier configs 2020-03-09 12:01:07 -07:00
Kenta Iso 5ee6f77f72 make the stopped node output clarify 2020-03-09 21:55:49 +09:00
Anders F Björklund bdbc7c00a5 Improve the go reportcard for minikube
Fix gofmt, golint, and most of gocyclo
(but not the integration tests just yet)
2020-03-08 21:48:26 +01:00
rajula96reddy 3ffdaf3c1c Deleted unnecessary comments 2020-03-07 23:48:13 +05:30
rajula96reddy 40c1c80b42 Created new error type & made corresponding changes 2020-03-07 23:48:13 +05:30
rajula96reddy 8b2289836a Modified the previous commit using Erros.New() function 2020-03-07 23:47:18 +05:30
rajula96reddy 061b159991 Formatted the error output 2020-03-07 23:47:18 +05:30
rajula96reddy 5a32eb7c4c Updated error handling when service or namespace doesn't exist 2020-03-07 23:47:18 +05:30
Medya Ghazizadeh c17e998923
Merge pull request #6915 from tstromberg/fish-2x
docker-env: Add semicolons back for fish, required for fish 2.x users
2020-03-06 13:41:02 -08:00
Thomas Stromberg 882d1aeab3 Universally point to the host docker daemon 2020-03-06 12:04:32 -08:00
Thomas Stromberg 13da35ced2 Add semicolons back to fish env, required for fish 2.x users 2020-03-06 11:44:30 -08:00
tstromberg 1f61f39bae Merge conflict 2020-03-05 15:33:46 -08:00
Medya Ghazizadeh f702821c9d
Merge pull request #6903 from tstromberg/downgrade-spacing
Improve downgrade messaging
2020-03-05 14:30:47 -08:00
tstromberg b6c96eef30 Skip ISO checksum validation if custom URL is specified 2020-03-05 13:49:48 -08:00
tstromberg a336bc9f76 Improve downgrade messaging 2020-03-05 13:30:07 -08:00
Thomas Stromberg 044ff571e6 Merge master 2020-03-05 12:05:49 -08:00
Thomas Stromberg c2c1807c93 Automatically scale the default memory allocation 2020-03-05 11:59:22 -08:00
Medya Ghazizadeh d96edd4e8e
Merge pull request #6892 from tstromberg/iso-fallback
Unify downloaders, add GitHub and Alibaba ISO fallbacks
2020-03-05 11:07:35 -08:00
Thomas Stromberg 1f7ae5b35b Merge to master 2020-03-05 09:57:46 -08:00
Sharif Elgamal 625592920e fallback to vm-driver 2020-03-05 09:41:51 -08:00
Sharif Elgamal 1327f9d3a5
Merge pull request #6836 from sharifelgamal/machinename
Decouple machine name from profile/cluster name
2020-03-04 21:06:28 -08:00
Thomas Stromberg 3e772d0048 Merge master 2020-03-04 20:18:16 -08:00
Medya Ghazizadeh d5bc3fdc65
Merge pull request #6888 from sharifelgamal/driver
Switch --vm-driver paramter to --driver
2020-03-04 19:04:43 -08:00
Thomas Stromberg a1ebcbd031 Merge conflicts 2020-03-04 18:01:41 -08:00
Thomas Stromberg 39670fc06f Add download package & support URL fallback 2020-03-04 17:07:49 -08:00
Sharif Elgamal 0ff12cafac Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-04 16:37:54 -08:00
Sharif Elgamal 2db0b8cea2 fix search/replace errors 2020-03-04 14:10:39 -08:00
Sharif Elgamal ac0c1bad42 missing files 2020-03-04 13:48:21 -08:00
Sharif Elgamal e2ce45c6f0 Switch --vm-driver paramter to --driver 2020-03-04 13:32:43 -08:00
Sharif Elgamal 7fbabd4798 Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-04 09:24:17 -08:00
Naveen Kumar Sangi f183a79a2d
profile_list: Do not throw error for unready clusters 2020-03-04 11:13:51 -06:00
Prasad Katti 9f41fd42e1 populate target port in service list 2020-03-03 22:50:58 -08:00
Medya Ghazizadeh aa02c106c3
Merge pull request #6875 from josedonizetti/fix-delete-all-cmd
Fix delete --all if using non default profile
2020-03-03 17:59:07 -08:00
Jose Donizetti a269de762f Fix delete --all if using non default profile 2020-03-03 20:41:24 -03:00
Sharif Elgamal daf8363961
fix logs and delete command 2020-03-03 14:23:35 -08:00
Sharif Elgamal 3bb111a6fc
make sure machine name is properly backwards compatible 2020-03-03 13:49:01 -08:00
Sharif Elgamal 95dd21d115
unit tests pass holy cow 2020-03-03 13:20:21 -08:00
Sharif Elgamal 28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-03 12:16:47 -08:00
Sharif Elgamal 2618c32b27
fixing unit tests 2020-03-03 12:14:22 -08:00
Medya Ghazizadeh 6affbc3209
Merge pull request #6867 from josedonizetti/fix-kic-service-warn-message
kic: Fix service warn message on docker/osx
2020-03-03 10:16:19 -08:00
Jose Donizetti f679db1d09 kic: Fix service warn message on docker/osx 2020-03-03 10:03:52 -03:00
Sharif Elgamal 31a42ce672
address comments 2020-03-02 17:30:08 -08:00
Sharif Elgamal 4cd3ef81a5
more changes 2020-03-02 15:21:37 -08:00
Anders F Björklund fd99260ae7 Fix native-ssh flag for the ssh command 2020-03-02 19:12:04 +01:00
Sharif Elgamal 4b902f7e9f
more changes 2020-02-28 15:58:05 -08:00
Jose Donizetti 954f5a6b74 kic: fix service list for docker on osx 2020-02-28 14:57:53 -03:00
Sharif Elgamal 3b04a8d85e initial machine name refactor 2020-02-28 09:50:55 -08:00
Medya Ghazizadeh 3f34e68404
Merge pull request #6774 from vikkyomkar/issue-6767
Fix: do not change the profile to a none existing profile
2020-02-28 09:21:32 -08:00
Jose Donizetti c412a8ae44 Fix start for existing profile 2020-02-28 12:53:51 -03:00
Sharif Elgamal a349b865d8 correct machine name for selectDriver 2020-02-27 15:09:05 -08:00
Sharif Elgamal 0cc0a25c28 passing correct machine name around 2020-02-27 14:37:15 -08:00
Sharif Elgamal 2bf3b9a9f9 move caching code to cluster 2020-02-27 11:40:51 -08:00
Jose Donizetti 5e30d2f8c9 Fix linter 2020-02-26 22:29:28 -03:00
Jose Donizetti 5d8f2541f6 kic on mac: add service warn 2020-02-26 22:16:50 -03:00
Sharif Elgamal 9f82d6855b
actually cache images on cluster startup 2020-02-26 15:51:14 -08:00
Jose Donizetti f390d4bf30 kic on mac: add service cmd support 2020-02-26 20:49:58 -03:00
Sharif Elgamal d7df027fb8
fix delete and stop 2020-02-26 15:26:05 -08:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
Sharif Elgamal 676588f6b6 refactor machine name creation into a function 2020-02-25 23:47:08 -08:00
Sharif Elgamal e3826a5e47 fix ip command 2020-02-25 17:18:25 -08:00
Sharif Elgamal 0fadf91d2c i think it works? 2020-02-25 16:36:53 -08:00
vikkyomkar 9d87d64441 added suggestion message 2020-02-25 11:24:25 +05:30
Sharif Elgamal 3d72152953 fixing lint and other random incorrect stuff 2020-02-24 17:28:10 -08:00
Sharif Elgamal be9c5f4761 pass in the node object into add 2020-02-24 15:58:35 -08:00
Medya Gh 7596b39607 addres PR review 2020-02-24 15:10:34 -08:00
Sharif Elgamal 9a3ecab61a fixed more stuff 2020-02-24 15:09:04 -08:00
Medya Gh 850169764c improve message 2020-02-24 14:51:45 -08:00
Medya Gh 2e261d3d00 add not implemented messages for docker on mac service 2020-02-24 14:41:34 -08:00
Medya Gh d7ee8bfd37 patch 2020-02-24 11:31:53 -08:00
Medya Ghazizadeh 5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
vikkyomkar 8cfc825641 fixes profile switch to non-existing one 2020-02-24 17:49:25 +05:30
Sharif Elgamal f22efd871a mostly moving code around and adding UpdateNode 2020-02-23 22:41:08 -08:00
Sharif Elgamal 4af82913e1 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-02-23 09:31:00 -08:00
Medya Ghazizadeh 727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
Anders F Björklund fa9f7f9794 Add comments to avoid warnings from go lint 2020-02-22 16:12:42 +01:00
Kevin Pullin 8d78c95aea Generate fish compatible docker-env hint
`fish`'s eval handling does not properly process multiple lines.

Instead the recommendation is to pipe the output to `source`.

This PR updates the usage hint of the `docker-env` command
when running on `fish`:

```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```

Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
Sharif Elgamal 6e9cf2de2f Change MachineConfig to ClusterConfig 2020-02-21 16:09:05 -08:00
Sharif Elgamal ec191119df let's move some start code around 2020-02-21 15:46:02 -08:00
sayboras bc2a7aec8b Adjust assert statements 2020-02-22 07:31:49 +11:00
Tam Mach 1d0267f23c Fix unit test 2020-02-22 07:18:16 +11:00
Medya Gh 4d9730137f improve logging 2020-02-20 21:56:23 -08:00
Medya Gh 7c1c0ebb02 more error logging 2020-02-20 21:41:21 -08:00
Medya Gh 67e9c9ab85 log errors in unit test 2020-02-20 21:41:21 -08:00
Medya Gh e6d70210af add error wrpaps for config set 2020-02-20 21:41:21 -08:00
Medya Ghazizadeh 7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
Medya Gh c6313bb7ff better error message 2020-02-20 09:47:45 -08:00
Medya Gh 31cf3f2d79 missing err check 2020-02-20 09:47:10 -08:00
Medya Gh 78c192cb40 lint 2020-02-20 00:07:36 -08:00
Medya Gh dcff758753 lint 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh 8d45b236de less ambigous error log 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh d3b86cfeb9 improve logging 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Medya Ghazizadeh 8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
Medya Ghazizadeh 0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
Medya Gh cc0caac415 mount display bind address to user 2020-02-19 22:08:50 -08:00
Medya Gh b65c2fef09 fix typo 2020-02-19 22:01:46 -08:00
Medya Gh ce89a04278 specify localhost mount for binding for docker on mac 2020-02-19 22:01:46 -08:00
Medya Gh ec7c6ba4fa fix inverted logic 2020-02-19 21:33:24 -08:00
Priya Wadhwa 5ad4d6ebf5 Fix bug in --install-addons flag
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
Sharif Elgamal 8536fb7641 changes and things 2020-02-19 12:53:59 -08:00
aallbright 089deef706 Do not create profiles that do not exist 2020-02-18 05:59:37 -05:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Jose Donizetti 2bfcb72b96 Remove not used code 2020-02-17 10:22:11 -03:00
Medya Gh 23ef3f6d16 lint 2020-02-16 19:51:59 -08:00
Jose Donizetti b0d19e51b5 Refactor kic ssh tunnel 2020-02-14 21:01:32 -03:00
Jose Donizetti 0d11e4e348 Add error checking to kic cmd/tunnel 2020-02-14 13:22:56 -03:00
Jose Donizetti c421e156b6 Fix tunnel cmd to pass context to kic tunnel 2020-02-14 12:51:04 -03:00
Medya Gh a007c0790c Delete volumes created by kic 2020-02-14 01:39:16 -08:00
Sharif Elgamal c1a3e4348d fix unit tests and fix merge conflicts 2020-02-13 10:30:12 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Medya Ghazizadeh 25167e1b75
Fix docker-env and add unit and integration tests (#6604)
* Fix docker cert env in docker-env for docker driver

* add unit tests

* add integration tests for docker-env cmd

* lint

* fix lint

* merge conflict

* improve docker-env integraiton test

* linting
2020-02-13 02:17:11 -07:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
priyawadhwa af353314e0
Separate cached kubernetes binaries by OS on host machine (#6586)
* Separate cached kubernetes binaries by OS on host machine

This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.

* Review comment

* Update integration test

* Make sure --download-only includes OS specific kubectl

Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
Sharif Elgamal b427dc5663 fixed commands, they mostly work now 2020-02-11 21:11:22 -08:00
Sharif Elgamal 9830d91c09 linting nonsense 2020-02-11 18:39:59 -08:00
Sharif Elgamal 744efaa330 REFACTOR COMPLETE? 2020-02-11 17:06:59 -08:00
Sharif Elgamal b6a429dc9d hey did you want more files? good 2020-02-11 15:45:49 -08:00
Sharif Elgamal f2ebbb9c67 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-11 09:44:10 -08:00
Sharif Elgamal 69aa54ff82
begin start refactor 2020-02-11 09:38:15 -08:00
Anders Björklund ff763db1e7
Add podman-env for connecting with podman-remote (#6351)
* Refactor: add the docker vars after the shell vars

* Move shell handling functions to separate package

* Rename env source file to docker-env like command

* Add podman-env for connecting with podman-remote

* Remove leading Shell prefix from the shell package

* Add some documentation describing podman service

* Address some podman-env issues pointed out by lint
2020-02-10 22:59:37 -07:00
anencore94 a283fd695a
Fix to kubeConfigPath could be set from env (#6568)
* Fix to kubeConfigPath could be set from env

Fix to use kubeConfigPath by using kubeconfig.PathFromEnv
function not from just $HOME/.kube/config

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

* Delete redundant logic to get kubeConfigPath

- change to use already present util function
 to set up kubeConfigPath

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

Co-authored-by: SOPHAL HONG <hongsophal.hsp@gmail.com>
Co-authored-by: Woohyung Han <woohhan@gmail.com>
2020-02-10 16:08:07 -07:00
go_vargo e18e4d083b
Fix `minikube start` in order to be able to start VM even if machine does not exist (#5730)
* fix startHost in order to be able to  start VM even if machine does not exist

* Update func StartHost() and its unit test no to use config.GetMachineName()

* Add handle case when the kic image isn't pulled
2020-02-10 11:37:30 -07:00
Zhongcheng Lao 239be7ed94 Create Hyper-V External Switch (#6264)
* Create and manager Hyper-V switch
* Adds new flag for Hyper-V driver
* Move switch creation out of chooseSwitch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-07 21:22:19 -07:00
Sharif Elgamal e1fc3ce734
let's rearrange some stuff 2020-02-07 17:00:24 -08:00
Thomas Strömberg 8762c48921
Merge pull request #6541 from anencore94/deleteContext
Fix to delete context when delete minikube
2020-02-07 16:15:56 -08:00
Thomas Strömberg 2c08f62ed2
Let DeleteContext determine the KUBECONFIG path 2020-02-07 15:34:31 -08:00
priyawadhwa 914e7de860
Merge pull request #6536 from tstromberg/wait-nada2
Add --install-addons toggle for users who don't want them
2020-02-07 11:47:24 -08:00
anencore94 460f8d0187 Fix bug to delete context when delete minikube
- when `minikube delete`, minikube must delete its config which
  are set when `minikube start`.
- But, there was some mistakes in the function that does this
  logic

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-02-07 20:00:08 +09:00
Thomas Stromberg c195d5a55f Merge branch 'master' into powershell-env-bugfixes 2020-02-06 23:17:26 -08:00
Thomas Strömberg 10ef863f7d
Merge pull request #6527 from tstromberg/powershell-env
Bug-compatible refactor of docker-env + output tests
2020-02-06 21:57:25 -08:00
Thomas Stromberg 63954700d7 Address review comments 2020-02-06 17:32:08 -08:00
Thomas Stromberg 4ba0f52f57 Add flag to toggle installation of addons 2020-02-06 17:29:19 -08:00
Thomas Stromberg 5d59e83b64 Rewrite unsetScript to fix a variety of bugs 2020-02-06 17:01:05 -08:00
Thomas Stromberg 0cac457126 Transition TestGetNodeDockerEnvIPv6 to env_test 2020-02-06 16:05:05 -08:00
Thomas Stromberg 6e19c62896 Update tests to include all current output quirks 2020-02-06 15:54:57 -08:00
Thomas Stromberg b478fbaa1a Minimize changes 2020-02-06 15:40:24 -08:00
Thomas Stromberg 32bc0ff76a Refactor docker-env for testability 2020-02-06 15:32:00 -08:00