Commit Graph

1197 Commits (1a176c398edc70d0302952d3d0c497135b8e38a5)

Author SHA1 Message Date
Pablo Caderno f31a1d5020 fix: conditional compiling for cgroups code 2022-05-09 19:41:28 +10:00
Pablo Caderno 947ff0435b fix: small code refactor 2022-05-08 19:46:17 +10:00
Pablo Caderno 7d9eca5eff fix: improved memory cgroup checks
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2022-05-08 19:46:17 +10:00
Sharif Elgamal 930427f847 revert kvm domain def for bios iso 2022-05-03 21:39:12 -07:00
Sharif Elgamal 5b39a46773 Merge branch 'master' of github.com:kubernetes/minikube into anders-qemu2 2022-05-03 14:01:09 -07:00
Sharif Elgamal 1c31b6cb81 typo 2022-04-21 19:13:22 -07:00
Sharif Elgamal 28083d9235 keep nvram on minikube delete 2022-04-18 12:37:32 -07:00
Sharif Elgamal c82be99d3b fix nvram location for aarch64 kvm driver 2022-04-15 12:32:47 -07:00
Sharif Elgamal 8130eda339 Merge branch 'master' of github.com:sharifelgamal/minikube into iso-arm64 2022-04-12 13:07:13 -07:00
Sharif Elgamal ad5c964e6b
Merge pull request #13829 from AkihiroSuda/rootless-podman-take2
Support rootless Podman driver, take 2 (Usage: `minikube config set rootless true`)
2022-04-12 11:19:30 -07:00
Sharif Elgamal f6c2f5bb79 Merge branch 'master' of github.com:kubernetes/minikube into iso-arm64 2022-04-11 14:25:53 -07:00
Anders F Björklund ae40c57623 Add parameters needed for vde networking 2022-04-11 19:40:32 +02:00
Sharif Elgamal 684c2b4ac4 fix undefining kvm domain 2022-04-07 13:33:01 -07:00
Medya Ghazizadeh 1b366615d3
Merge pull request #13901 from spowelljr/removeIoutil
remove uses of ioutil & use t.TempDir for tests
2022-04-05 14:41:22 -07:00
Sharif Elgamal dc0b193b74 fix kvm stuff 2022-04-05 10:30:40 -07:00
Akihiro Suda 92ab555928
Support rootless Podman driver, take 2
Usage:
```
minikube config set rootless true
minikube start --driver=podman --container-runtime=(cri-o|containerd)`
```

Tested on Podman 4.0.2, Ubuntu 21.10.

Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also `site/content/en/docs/drivers/includes/podman_usage.inc`

Fix issue 8719
Fix issue 12460
Replace PR 12901

Changes from PR 12901: `rootless` is now a config property.
In the previous PR, `--rootless` was implemented as a flag for `minikube start`

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-04-05 18:49:40 +09:00
Anders F Björklund d38789a37b Add the parameters required for qemu arm64 2022-04-04 20:50:08 +02:00
Anders F Björklund af07b2b563 Remove fluff from the qemu driver for lint 2022-04-04 20:23:32 +02:00
Anders F Björklund 77ed383578 Fork the machine qemu driver into minikube qemu2
This is an internal driver, with the new driver config
rather than the machine flags of the external driver.
2022-04-04 20:16:48 +02:00
Steven Powell 2e4ea3c259 replace MkdirTemp with t.TempDir in tests 2022-04-01 19:18:20 -07:00
Steven Powell 070e5335e0 remove unecessary icacls check 2022-03-31 15:46:37 -07:00
Steven Powell ad4d80e955
Merge pull request #13881 from AkihiroSuda/fix-podman-v4-network-inspect
Podman: fix `minikube delete` for Podman v4
2022-03-31 14:15:06 -07:00
Steven Powell 1aa1f04e9b remove old build tags 2022-03-30 16:43:29 -07:00
Sharif Elgamal 31d1fdae3b
Merge pull request #13730 from presztak/subnet_flag
Add 'subnet' flag for docker/podman driver
2022-03-30 16:02:54 -07:00
Akihiro Suda 28fdc99086
Podman: fix `minikube delete` for Podman v4
The "minikube" network was not deleted due to the breaking change of
`podman network inspect` in Podman v4.

Fix issue 13861

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-03-30 18:29:14 +09:00
Sharif Elgamal eb14277c3d Merge branch 'master' of github.com:kubernetes/minikube into iso-arm64 2022-03-28 16:21:05 -07:00
Akihiro Suda 7204b1db3e
KIC rootless: drop fuse-overlayfs; bump kernel requirement to 5.11
minikube 1.23 (PR 12359) added fuse-overlayfs snapshotter for rootless Docker driver,
but got broken in minikube 1.25 (issue 13534).

We can drop fuse-overlayfs for kernel >= 5.11.

Fix issue 13534

We may add back fuse-overlayfs later if there is a huge demand to
support kernel < 5.11.
That will require packing preloadable tarballs for fuse-overlayfs
snapshotter.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-03-22 18:08:14 +09:00
Sharif Elgamal bef8eb0aec Merge branch 'master' of github.com:sharifelgamal/minikube into iso-arm64 2022-03-21 15:05:33 -07:00
minikube-bot 100852bbf8 Updating kicbase image to v0.0.30-1647797120-13815 2022-03-20 19:06:44 +00:00
Sharif Elgamal f8658543fd Merge branch 'master' of github.com:kubernetes/minikube into iso-arm64 2022-03-17 17:08:33 -07:00
Sharif Elgamal 692c8a445f one last file name fix 2022-03-17 16:59:37 -07:00
Sharif Elgamal 0ebb6d4424 simplify life by changing file names 2022-03-17 16:57:42 -07:00
Steven Powell 535cd5201e improve icacls error messaging 2022-03-16 11:48:41 -07:00
Piotr Resztak f3c9198134 add support for 'subnet' flag 2022-03-15 21:42:09 +01:00
Sharif Elgamal b7954683b9 more replacements 2022-03-09 22:29:59 -08:00
Sharif Elgamal 325ab07516 shuffling many things around 2022-03-09 15:24:06 -08:00
Sharif Elgamal 0f633902d8 name stuff arm64 2022-03-03 16:29:38 -08:00
Sharif Elgamal 5f29ddfe07 Merge branch 'uefi2' of github.com:klaases/minikube into iso-arm64 2022-03-02 14:15:05 -08:00
minikube-bot 4046a967b9 Update kicbase to v0.0.30 2022-02-23 19:46:44 +00:00
klaases 1be70185bd Update KVM2 configuration for UEFI 2022-02-16 21:03:30 +00:00
minikube-bot c9290bd8c0 Updating kicbase image to v0.0.29-1644344181-13531 2022-02-08 19:53:09 +00:00
minikube-bot d696170374 Updating kicbase image to v0.0.29-1644071658-13563 2022-02-05 16:09:05 +00:00
Sharif Elgamal 3a923b245e
Merge pull request #13302 from afbjorklund/cri-dockerd-rel
KIC: Upgrade cri-dockerd
2022-02-03 11:23:27 -08:00
Medya Ghazizadeh 969b5cddf1
Merge pull request #13520 from minikube-bot/auto_bump_golint_version
bump golint version to v1.44.0
2022-02-02 15:57:24 -08:00
minikube-bot 429347e99c Updating kicbase image to v0.0.29-1643823806-13302 2022-02-02 19:23:02 +00:00
Medya Gh c24818d9b7 lint 2022-02-01 13:21:53 -08:00
Medya Gh 8c6f9f64c7 lint 2022-01-31 15:18:04 -08:00
Anoop C S 061fd88d2e drivers/kvm: Use ARP for retrieving interface ip addresses
On platforms where dhcp lease status is not updated immediately after
domain creation it fails to list ip addresses until next refresh
happens resulting in the following error:

8<----------8<----------8<----------8<----------8<----------8<----------

Creating kvm2 VM (CPUs=2, Memory=4096MB, Disk=20480MB) ...
Failed to start kvm2 VM. Running "minikube delete" may fix it: creating
  host: create: Error creating machine: Error in driver during machine
  creation: IP not available after waiting: machine minikube didn't
  return IP after 1 minute

Exiting due to GUEST_PROVISION: Failed to start host: creating host:
  create: Error creating machine: Error in driver during machine
  creation: IP not available after waiting: machine minikube didn't
  return IP after 1 minute

8<----------8<----------8<----------8<----------8<----------8<----------

Using ARP instead of LEASE for ip address query is justifiable as
listing is done following the domain creation. In case of failure we
fallback to listing via LEASE source.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
2022-01-29 09:57:56 +05:30
Steven Powell c5b1c56f57
Merge pull request #12835 from presztak/remove_kicbase_image_info
Print a message about preserving kicbase image when `minkube delete --purge --all` used
2022-01-27 21:23:27 -08:00
Predrag Rogic a23f8381f7
upgrade-libvirt to 8th gen 2022-01-23 02:58:49 +00:00
Sharif Elgamal 8c3a3537c0 remove reference to nonexistent file for hyperkit driver 2022-01-20 15:03:00 -08:00
minikube-bot bfd94658fb Update kicbase to v0.0.29 2022-01-18 21:29:55 +00:00
Medya Ghazizadeh b2fcd0a729
Merge pull request #13227 from afbjorklund/cri-dockerd-kic
KIC: Add building of cri-dockerd
2021-12-24 08:20:04 -08:00
minikube-bot 2bd63b55aa Updating kicbase image to v0.0.28-1640212998-13227 2021-12-23 00:19:12 +00:00
klaases 2c712452f8 Merge branch 'master' of github.com:kubernetes/minikube into boot1 2021-12-16 14:48:49 -08:00
Steven Powell e43ead0043 add quote to Windows env 2021-12-16 10:02:59 -08:00
Steven Powell 9200267c04
Merge pull request #13168 from spowelljr/supressDockerPerformance
Added env to suppress Docker performance messages
2021-12-15 16:41:28 -08:00
Steven Powell 5a66196a20 update message 2021-12-15 15:58:00 -08:00
Sharif Elgamal 5de765023a
Merge pull request #13124 from sharifelgamal/kicbase-arch
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-15 14:08:07 -08:00
minikube-bot a6ef730eb7 Updating kicbase image to v0.0.28-1639515145-13124 2021-12-14 21:54:37 +00:00
Steven Powell b17834c96b added env to suppress Docker performance messages 2021-12-14 13:46:52 -08:00
minikube-bot efe0dd71b4 Updating kicbase image to v0.0.28-1639444036-13124 2021-12-14 02:08:03 +00:00
klaases 9eaf95415e Merge branch 'master' of github.com:kubernetes/minikube into boot1 2021-12-13 11:17:38 -08:00
Steven Powell 8d7a636bfe don't output Docker performance issues when user wants JSON 2021-12-09 14:38:18 -08:00
klaases 694c9cc0ef Bootloader ISO EFI Support 2021-12-07 15:56:07 -08:00
Sharif Elgamal 41546a03e5
Merge pull request #13104 from klaases/kic1
Update BUILD KIT version to latest, 0.9.3.
2021-12-07 11:02:40 -08:00
minikube-bot 3e901caf92 Updating kicbase image to v0.0.28-1638824847-13104 2021-12-06 21:36:10 +00:00
Piotr Resztak 7b3860388c Print a message about preserving kicbase image
Print additional info about preserving kicbase image and generates
image deletion command for user when running `minikube delete`.
Message is printed only when `--purge` option is used.
2021-11-25 23:36:59 +01:00
James Yin 54be390bba fix: check err before preload 2021-11-03 15:27:15 +08:00
minikube-bot 3bc369459b Update kicbase to v0.0.28 2021-10-27 19:53:03 +00:00
Steven Powell 016b3ac40a trim space earlier 2021-10-21 13:28:52 -07:00
Steven Powell fbd4d27582 fix podman network inspect index check 2021-10-21 10:01:10 -07:00
Anders F Björklund 75804c43ad Match the lower case of the podman error message
Turns out that Docker says "No such network",
but Podman says "no such network". Little nuances.
2021-10-10 12:25:18 +02:00
KallyDev 70022d9b2e
Move from deprecated ioutil to os and io packages 2021-10-08 08:57:19 +08:00
Steven Powell 1a4160e60d
Merge pull request #12081 from spowelljr/buildkitSocket
buildkit socket: Add systemd unit
2021-10-01 20:49:41 -04:00
minikube-bot 39eb5cb53c Updating kicbase image to v0.0.27-1633027942-12081 2021-09-30 19:21:11 +00:00
Steven Powell dafbe6aac3 add created by label for podman 2021-09-29 13:47:59 -07:00
minikube-bot 1976e1b296 Update kicbase to v0.0.27 2021-09-16 18:55:00 +00:00
minikube-bot 030b3837ab Updating kicbase image to v0.0.26-1631295795-12425 2021-09-14 09:50:53 -07:00
Steven Powell 145f9fc9ab run `go fmt` 2021-09-13 11:58:43 -07:00
minikube-bot 67b82f3fe1 Update kicbase to v0.0.26 2021-09-03 02:18:31 +00:00
minikube-bot 703324b7c7 Updating kicbase image to v0.0.25-1630631232-12398 2021-09-03 01:36:51 +00:00
Medya Ghazizadeh 3469c77ffa
Merge pull request #12351 from raghavendra-talur/rtalur-add-disks-kvm2
Add `--extra-disks` capability to kvm2 driver
2021-08-30 16:50:58 -07:00
Akihiro Suda 323225483e
Support Rootless Docker
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/

Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.

Closes issue 10836 ("add support for rootless Docker").

Support for rootless Podman (issue 8719) is not covered in this commit.

---

Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
  instead of `overlayfs` snapshotter

- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
  Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint

- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless

- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host

- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Raghavendra Talur dceb676527 Add extra disks capability to kvm2 driver
Having additional disks on the nodes is a requirement for developers
working on the storage components in Kubernetes. This commit adds the
extra-disks feature to the kvm2 driver.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2021-08-25 00:15:02 -04:00
Medya Ghazizadeh 559048f83d
Merge pull request #11768 from ilya-zuyev/arm_kvm_driver
KVM2 driver for linux/aarch64
2021-08-13 13:27:59 -07:00
Medya Ghazizadeh adbeae1763
Merge pull request #12032 from spowelljr/updateBuildkit
Upgrade buildkit from 0.8.2 to 0.9.0
2021-08-13 12:43:49 -07:00
Medya Gh ccf4af0997 change depricated golint to revive and fix lint issues 2021-08-12 18:11:16 -07:00
minikube-bot 6cecbf6fe5 Updating kicbase image to v0.0.25-1628619379-12032 2021-08-10 18:33:49 +00:00
Blaine Gardner 8f05ee00e1
Add ability to create extra disks on hyperkit vms
Add the ability to create and attach extra disks to hyperkit vms.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
なつき 4040311f1e Use fully qualified image name for docker hub fallback image 2021-07-13 16:09:55 -07:00
Medya Ghazizadeh 81c2bb2796
Merge pull request #11708 from afbjorklund/info-klog
Make sure to log errors from DaemonInfo
2021-07-07 13:29:05 -04:00
minikube-bot 4db717a5eb Update kicbase to v0.0.25 2021-07-01 23:38:36 +00:00
minikube-bot 202e2fa36f Updating kicbase image to v0.0.24-1625170572-11834 2021-07-01 20:31:45 +00:00
Medya Ghazizadeh 05b64d1a74
Merge pull request #11824 from andriyDev/fix-auto-pause
Make kicbase copy auto-pause binary instead of auto-pause folder
2021-07-01 16:10:33 -04:00
minikube-bot 2bf9076527 Updating kicbase image to v0.0.24-1625086337-11824 2021-06-30 21:07:40 +00:00
Medya Gh 89c7853601 bump go mod libs manually 2021-06-29 15:24:59 -04:00
minikube-bot bce90e5037 Update kicbase to v0.0.24 2021-06-25 23:41:39 +00:00
Ilya Zuyev e3b5c2f8cf fix linter error 2021-06-25 13:49:54 -07:00
Ilya Zuyev 58754c910c update domain definition 2021-06-24 23:06:56 -07:00
Anders F Björklund 3b533a07cb Make sure to log errors from DaemonInfo 2021-06-22 07:56:11 +02:00
Ilya Zuyev e48c8d289f fix domain definition 2021-06-21 21:16:04 -07:00
Ilya Zuyev 952b28e3b7 log out xml domain definition 2021-06-21 21:15:47 -07:00
Ilya Zuyev 37faf73207 improve logs 2021-06-21 17:56:14 -07:00
Ilya Zuyev a59e6a7341 remove acpi config from amd64 libvirt domain 2021-06-21 16:26:37 -07:00
Ilya Zuyev 84feb87502 fix arm64 libvirt domain definition 2021-06-21 16:16:10 -07:00
Ilya Zuyev 6de16a406e Add libvirt domain definition for arm64 2021-06-21 15:26:35 -07:00
minikube-bot 64a41824c5 Update kicbase to v0.0.23 2021-06-09 00:28:52 +00:00
Sharif Elgamal d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
Medya Gh 853f1cb4db first try gcr 2021-06-01 15:16:17 -07:00
Medya Gh 2f4b7985c0 try image without sha before failing 2021-06-01 15:11:01 -07:00
Andriy Dzikh f9f3ef9a09 Pass driverName into Preload and PreloadExists to report no preload for BareMetal. 2021-05-27 15:02:00 -07:00
Medya Gh 6cb7c2166c spell 2021-05-21 14:09:42 -07:00
Medya Gh 9c9934879c break guest provision when container exists prematurely 2021-05-21 13:34:34 -07:00
Daehyeok Mun d6691e796c Add `Close() error` function into assets.CopyableFile
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Medya Ghazizadeh 707af502f3
Merge pull request #11300 from ilya-zuyev/ilyaz/gh_11293
Fix getting of gateway IP for podman driver
2021-05-14 17:04:24 -07:00
Ilya Zuyev dcadd32624 Add comment, improve template 2021-05-14 14:38:29 -07:00
minikube-bot e8b16a5247 Updating kicbase image to v0.0.22-1620785771-11384 2021-05-12 02:25:58 +00:00
Ilya Zuyev a1ae930d2f Simplify the code 2021-05-06 11:17:43 -07:00
Ilya Zuyev 6e2eae0d0a Simplify the code 2021-05-06 11:13:10 -07:00
Ilya Zuyev f4e142d442 Simplify the code 2021-05-06 10:35:22 -07:00
Ilya Zuyev 8d2b811fcf Remove debug logs 2021-05-05 22:01:21 -07:00
Ilya Zuyev 6cf6ba2ff2 Fix network settings parsing 2021-05-05 19:31:12 -07:00
Ilya Zuyev 829cc42a65 Fix network settings parsing 2021-05-05 19:11:56 -07:00
Ilya Zuyev 618d09ab76 Fix network settings parsing 2021-05-05 17:14:33 -07:00
Ilya Zuyev 01f76f7d4f Add debug logs 2021-05-05 16:29:11 -07:00
Ilya Zuyev adc53aa677 Fix error handling 2021-05-05 15:58:16 -07:00
Ilya Zuyev 61c1b301be Fix linter errors 2021-05-05 15:31:11 -07:00
Ilya Zuyev fe392b4233 When getting a gateway IP for podman container inspect per-network data as well 2021-05-05 15:09:46 -07:00
minikube-bot 625a06ce6d Update kicbase to v0.0.22 2021-05-05 21:18:37 +00:00
minikube-bot c5b65cab51 Update kicbase to v0.0.21 2021-04-30 18:08:55 +00:00
minikube-bot fff23925e0 Updating kicbase image to v0.0.20-1619543236-11212 2021-04-27 17:16:43 +00:00
Medya Ghazizadeh 30d659c635
Merge pull request #11055 from afbjorklund/kic-os-update
Update kicbase base image
2021-04-24 21:09:32 -07:00
Medya Gh 1207de734b bump golang lint ci to latest 2021-04-19 15:16:31 -07:00
Medya Ghazizadeh 60d8401f59
Merge pull request #11086 from sharifelgamal/mock-mirror
avoid network calls for mirror unit tests
2021-04-16 13:46:31 -07:00
Sharif Elgamal 1319b6e398 refactor checkRepository to make mocking easier 2021-04-14 12:51:16 -07:00
minikube-bot 0e1fd72042 Updating kicbase image to v0.0.20-1618262794-11055 2021-04-12 21:36:41 +00:00
Anders F Björklund f527fb675a Address security concerns with the go code
As flagged by the github code scanning
2021-04-12 20:38:21 +02:00
minikube-bot f7c204d907 Update kicbase to v0.0.20 2021-04-09 19:23:04 +00:00
minikube-bot 831c3dfdbd Updating kicbase image to v0.0.19-1617905290-11019 2021-04-08 18:17:37 +00:00
Medya Ghazizadeh 1e3370298a
Merge pull request #11001 from lilongfeng0902/minikube-lilf
minor spelling errors
2021-04-07 17:35:39 -07:00
Anders F Björklund db3fd51194 Rename ListOptions to ListContainersOptions 2021-04-06 22:39:43 +02:00
李龙峰 7ae82c573b Propagation not Propogation 2021-04-06 14:52:52 +08:00
minikube-bot 53babcc152 Update kicbase to v0.0.19 2021-04-05 22:22:23 +00:00
Predrag Rogic 387ad774bb
multinode: fix kindnet and dns issues 2021-04-05 16:18:37 +01:00
Predrag Rogic 06d4313f3f
kvm2 driver: add static ip 2021-03-27 23:33:24 +00:00
Medya Ghazizadeh 894ca125cb
Merge pull request #10858 from prezha/fix-create-network-race
create network: use locks and reservations to solve race condition
2021-03-24 17:47:21 -07:00
Daehyeok Mun 9b23841ee3 Add solution message if Docker is rootless 2021-03-20 13:20:30 -07:00
Predrag Rogic f4a375181a
create network: use locks and reservations to solve race condition 2021-03-18 18:38:06 +00:00
Predrag Rogic 474f6734b1
create network: use locks to solve race conditions 2021-03-17 22:56:22 +00:00
Predrag Rogic 223792b993
create network: use locks to solve race conditions 2021-03-17 14:32:39 +00:00
Daehyeok Mun fae67405e9 Update outdated moby/hyperkit package in minikube code 2021-03-05 22:27:23 -08:00
Medya Ghazizadeh d2cb052fca
Merge pull request #10653 from Loyen/add-listen-address-flag
Add flag "--listen-address" for docker and podman driver
2021-03-05 12:56:22 -08:00
Patrik Freij 3110bd15fc Lowercase minikube in information message 2021-03-05 15:50:52 +01:00
Patrik Freij 0d1d169bf6 Set non-local traffic message as a Tip message
To stay consistent with other messages. Also moved it above the warning
message regarding what IP is set as listen-address to make more sense in
the message flow.
2021-03-03 17:07:23 +01:00
Patrik Freij bb5bf9546c Add info message about not using it for production
To add more context to the warning message for --listen-address
2021-03-02 20:21:39 +01:00
phantooom 529881e01c fix: fix kvm2 numa simulate ut&lint 2021-03-02 22:40:42 +08:00
phantooom badc5d4532 add more check for kvm2 support simulate numa node 2021-03-02 22:27:26 +08:00
phantooom e11f23a4c9 kvm2 driver support simulate numa node 2021-03-02 22:27:26 +08:00
Patrik Freij 9b5a96e76d Make warning more informative for --listen-address 2021-03-01 23:10:58 +01:00
Patrik Freij bad8561d0d Skip custom listenAddress if equal to default 2021-03-01 23:06:13 +01:00
Patrik Freij cb116e4c1c Add --listen-address for docker driver 2021-02-28 23:14:08 +01:00
minikube-bot 2c292cca75 Update kicbase to v0.0.18 2021-02-25 23:14:51 +00:00
Medya Gh f272822d15 bump kic base 2021-02-24 13:45:53 -08:00
Medya Gh e9e81cef25 bump kicbase 2021-02-24 13:29:10 -08:00
Medya Gh 549bb10a52 update kicbase with pause 2021-02-24 12:30:06 -08:00
Medya Gh 72135d70d9 add auto pause proxy 2021-02-24 12:30:06 -08:00
Medya Ghazizadeh 460342a5f2
Merge pull request #10575 from hetong07/issue_10519
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
Sharif Elgamal 7f75dfffda drop support for github packages for kicbase 2021-02-23 14:16:02 -08:00
hetong07 9a30756d38 Improve the error message of setting cgroup memory limit. 2021-02-22 20:18:22 -08:00
Jiefeng He d6e9174435 update new tag, SHA, and doc due to new kicbase image 2021-02-21 17:27:24 -08:00
Medya Gh d120656161 update image 2021-02-20 10:55:56 -08:00
Medya Gh 712ab628a6 update kicbase 2021-02-20 10:11:35 -08:00
Medya Ghazizadeh 5c6c20f68e
Merge pull request #10528 from sharifelgamal/crio-storage
fix crio by hardcoding mountopt
2021-02-19 22:54:33 -08:00
Sharif Elgamal 9abb3bed51 update kicbase image 2021-02-19 18:08:41 -08:00
Medya Ghazizadeh 6bf3c23699
Merge pull request #10479 from prezha/fix-kvm-network-cleanup
improve kvm network delete/cleanup
2021-02-19 16:31:26 -08:00
Medya Ghazizadeh fb27ab7e7f
Merge pull request #10439 from prezha/prevent-oci-overlapping-net
prevent oci try to create overlapping network
2021-02-19 16:23:18 -08:00
Medya Ghazizadeh 629926a2bd
Merge pull request #10418 from afbjorklund/kicbase-210119
Update kicbase base image and sync with kind
2021-02-19 11:33:11 -08:00
Sharif Elgamal 17af0f999b update kicbase image for testing 2021-02-18 19:20:17 -08:00
Medya Ghazizadeh 0edb126f13
Merge pull request #10512 from hetong07/cgroup_memory_fix
cgroup v2: skip setting --memory limits when not configurable.
2021-02-18 18:56:57 -08:00
Sharif Elgamal 96c5b6a0d4
Merge pull request #10408 from sharifelgamal/kic-test
populate kic.txt properly in kicbase
2021-02-18 18:42:17 -08:00
Sharif Elgamal 74e2127a87 update kicbase image for the last time 2021-02-18 18:28:02 -08:00
hetong07 556a8d7930 Move the user facing warning inside hasMemoryCgroup(). 2021-02-18 16:43:19 -08:00
Sharif Elgamal 114364409d add github packages to script 2021-02-18 16:17:09 -08:00
hetong07 e8c2a23398 Provide an advice for users on how to modify Grub setting. 2021-02-18 16:09:51 -08:00
hetong07 7b0bf57f4c Stop using --memory for cgroup v2. 2021-02-18 15:43:26 -08:00
Sharif Elgamal 31ea98ca50 update kicbase to newest build 2021-02-18 15:04:34 -08:00
Medya Ghazizadeh 369f93f393
Merge pull request #10468 from afbjorklund/cgroups-warning
Make sure to show debian warning also for cgroup 2
2021-02-18 14:25:59 -08:00
Sharif Elgamal f11498046b messed up boilerplate 2021-02-18 11:52:38 -08:00
Sharif Elgamal 3f04535045 add dockerhub to autopush 2021-02-18 11:47:59 -08:00
Medya Ghazizadeh 75be14d2ce
Merge pull request #10507 from afbjorklund/docker-memswap
Stop using --memory-swap if it is not available
2021-02-18 11:15:32 -08:00
Anders F Björklund eabc02d3c4 Stop using --memory-swap if it is not available
With Debian and Ubuntu kernels, it needs to be configured.

And now with cgroups v2, it starts throwing errors at run.
2021-02-18 18:54:36 +01:00
Sharif Elgamal fd897f4f23 fix up repo stuff 2021-02-17 10:32:48 -08:00
Sharif Elgamal ea16737271 syntax 2021-02-17 09:37:34 -08:00
Sharif Elgamal 9aeb4a75fa update kicbase image 2021-02-17 09:35:32 -08:00
Predrag Rogic 6d61795352
simplify free subnet query for oci net create 2021-02-17 03:04:47 +00:00
Predrag Rogic 4018ee3682
move to separate network package and fix naming 2021-02-17 03:04:47 +00:00
Predrag Rogic d48b0a58e8
add ip conflict auto-resolution also to kvm and consolidate 2021-02-17 03:04:47 +00:00
Predrag Rogic c6446e5fbd
prevent oci try to create overlapping network 2021-02-17 03:04:47 +00:00
Predrag Rogic a5f75b4a29
fix wording 2021-02-17 02:45:22 +00:00
Predrag Rogic fc07cfd395
fix wording 2021-02-17 02:45:22 +00:00
Predrag Rogic 1f50c63adb
fix wording 2021-02-17 02:45:22 +00:00
Predrag Rogic 5c8ea8dc5b
improve kvm network delete/cleanup 2021-02-17 02:45:03 +00:00
Kent Iso 5bffb823b2 Add ProfileLableKey to make sure that preload side car will be target of deletion. minikube delete doesn't check CreatedByLabelKey 2021-02-17 10:27:54 +09:00
Kent Iso fd58d0fc90 Add CreatedByLabelKey to make sure that preload side car will be target of deletion 2021-02-17 10:06:12 +09:00
Kent Iso e3cd93aa1a Change prepareVolume func to add container name for preload side car 2021-02-17 10:06:12 +09:00
Anders F Björklund 2c87f6e1ad Make sure to show debian warning also for cgroup 2
Move check to function, to cut down on complexity
2021-02-13 18:37:54 +01:00
Medya Ghazizadeh ee6283ecf1
Merge pull request #10293 from afbjorklund/ssh-validate
ssh: validate the ssh-key parameter if given
2021-02-11 15:05:19 -08:00
Anders F Björklund b7de621033 Explicitly remove podman volume and network
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
Priya Wadhwa 51169d68ea Add context to remaining necessary functions 2021-02-08 15:19:01 -08:00
Priya Wadhwa a6372b35a3 Add 5 minute timeout to deleting leftover cvolumes and containers 2021-02-08 15:15:08 -08:00
Anders F Björklund f316c0fdce Clean up accumulated golint with missing godoc 2021-02-08 20:10:31 +01:00
Predrag Rogic f519ec50cc
support ancient versions of docker again (template parsing issue) 2021-02-05 01:54:09 +00:00
Yanshu Zhao 67458418ca Change test naming 2021-02-02 21:39:34 +00:00
Yanshu Zhao 84e7c47e8a reduce lock scope 2021-02-02 21:20:31 +00:00
Yanshu Zhao 8009a5b3a8 change naming 2021-02-02 20:59:29 +00:00
Yanshu Zhao 4665993109 Add header file for the test 2021-02-02 16:57:47 +00:00
Yanshu Zhao 397b7b2286 Use global flag and only print one warning for the same cmd per binaray
run
2021-02-02 16:28:04 +00:00
Daehyeok Mun 4500be129f Validate minimum docker version 2021-02-01 13:54:20 -08:00
Anders F Björklund 40e4521bb2 ssh: validate the ssh-key parameter if given 2021-01-28 08:48:40 +01:00
Medya Gh 70253a9c87 update kicbase and iso to last build 2021-01-20 16:41:10 -08:00
Medya Gh 91a7436617 bump kicbase version 2021-01-20 15:46:14 -08:00
Anders F Björklund 541193c945 Address review comments, rename to ssh-ip-address 2021-01-16 14:44:56 +01:00
Anders F Björklund abb556f7f5 Merge branch 'master' into generic 2021-01-13 20:15:17 +01:00
Ilya Zuyev 813094bafb Merge branch 'master' into ilyaz/multiarch_kicbase 2021-01-12 10:48:01 -08:00
Ilya Zuyev 7ca15031e8 fix kicbase sha1 2021-01-11 18:30:39 -08:00
Anders F Björklund 1663a030ed Only add docker group for the docker runtime 2021-01-11 18:12:06 +01:00
Anders F Björklund b2121eae39 Rename the generic driver to the ssh driver
Now that we have forked the machine driver
2021-01-09 14:36:32 +01:00
Anders F Björklund e53f537b39 Merge branch 'master' into generic 2021-01-09 14:11:09 +01:00
Ilya Zuyev 2622e9583c bump kicbase version to v0.0.16-snapshot1 2021-01-08 13:49:27 -08:00
Ilya Zuyev 921306d88a fix fallback kicbaseimages list 2021-01-08 13:31:13 -08:00
Anders F Björklund 40ec0e8015 Avoid the hard-coded dependency on systemctl 2021-01-08 18:31:15 +01:00
Anders F Björklund fb6cf6b6b6 Add placeholder for docs for the generic driver
But most of it is identical to the "none" driver
2021-01-08 18:16:58 +01:00
Anders F Björklund e4ebaeabf6 Complete the container runtime and config change 2021-01-08 17:36:23 +01:00
Anders F Björklund b856a475e6 Remove systemd dependency from none driver
Use the minikube "sysinit" module instead
2021-01-08 09:12:54 +01:00
Anders F Björklund 1d6c86c8b5 Also remove unused machine SetConfigFromFlags
Setting the config directly instead in minikube
2021-01-06 21:05:53 +01:00
Anders F Björklund a120c543bf Change meaning of Stop/Start/Restart to minikube
The "none" driver has redefined stop and start to mean the
kubelet rather than the host itself. Use the same API here.

Killing actual containers remotely remains to be implemented.
Only stop the kubelet service for now, and assuming systemd.
2021-01-06 20:09:25 +01:00
Anders F Björklund a77e3de85f Use CommonDrivers and drop machine GetCreateFlags
This makes the machine driver specific to minikube
2021-01-06 18:42:19 +01:00
Anders F Björklund fa05fcd6d0 Fork the generic driver to the minikube code base 2021-01-06 18:35:09 +01:00
Ilya Zuyev 65cf998d6f Merge branch 'master' into ilyaz/multiarch_kicbase 2021-01-05 16:30:26 -08:00
Ilya Zuyev 6335658103 Revert single-arch kicbase fallback support 2021-01-05 16:29:48 -08:00
Anders F Björklund f22a3802c7 Handle podman installations without default bridge 2021-01-05 17:06:52 +01:00
Yanshu Zhao 0f734e6339 Change function name 2020-12-31 00:03:34 +00:00
Yanshu Zhao f94b1674b1 Change tests into a loop 2020-12-30 23:27:37 +00:00
Yanshu Zhao f044b1fa91 Add unit test for docker network inspect 2020-12-30 02:28:44 +00:00
Yanshu Zhao 4a940d0079 Fix docker inspect network go template 2020-12-27 08:38:39 +00:00
Priya Wadhwa a3b80e1fff add log 2020-12-22 14:57:04 -08:00
Priya Wadhwa bd413794c2 Avoid creating network if it is the default 2020-12-22 14:56:27 -08:00
Priya Wadhwa 55f496492c fix merge conflict 2020-12-16 10:37:51 -08:00
Thomas Strömberg f85bed1150
Merge pull request #9753 from blueelvis/'bug/9078-tunnel-windows-docker'
Fix minikube tunnel for Docker on Windows
2020-12-15 07:59:44 -08:00
Jituri, Pranav a8463f3453
fix linting errors 2020-12-15 18:25:10 +05:30
Jituri, Pranav ce17200bd8
address review comment 2020-12-15 18:09:43 +05:30
Ilya Zuyev 6044006afe add multi-arch images to kic driver list 2020-12-13 22:29:17 -08:00
Thomas Strömberg b4bf2bde33
Merge pull request #9866 from afbjorklund/podman-network-fix
Fix podman network inspect format and error
2020-12-11 10:20:46 -08:00
Medya Ghazizadeh 442a9cf2d3
Merge pull request #9911 from medyagh/update_kicbase_16_1
Update kicbase 15 snapshot4 on head
2020-12-10 16:55:28 -08:00
Medya Ghazizadeh 6b079476c6
Merge pull request #9918 from lingsamuel/remove-verbose-options
Remove verbose options
2020-12-10 15:58:01 -08:00
Anders F Björklund c3d0621d97 Only use sudo with the none driver when on linux 2020-12-10 21:07:10 +01:00
Anders F Björklund a6941f21ca Fix podman network inspect format and error
Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?
2020-12-10 07:32:34 +01:00
Ling Samuel 634f0ae0a9
Remove verbose options 2020-12-10 14:29:38 +08:00
Medya Gh d3c375420e bump kicbase on head v0.0.15-snapshot4 2020-12-09 17:32:46 -08:00
Medya Gh a55a0b0286 bump kicbase on head 2020-12-09 17:20:09 -08:00
Medya Ghazizadeh 6eadee30b8
Merge pull request #9802 from afbjorklund/podman-host-cleanup
Some more cleanup of missing code for podman-env
2020-12-09 15:00:37 -08:00
Jituri, Pranav 74cdda9e9a
Resolve review comments 2020-12-09 16:54:19 +05:30
Medya Gh 0e85b1819a bump kic base on head 2020-12-08 13:49:17 -08:00
Medya Ghazizadeh 0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
Priya Wadhwa f373155d55 merge conflict 2020-12-03 10:56:41 -08:00
Medya Ghazizadeh 8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
Anders F Björklund da778ea870 Some more cleanup of missing code for podman-env
There is a lot of code duplication from docker-env

Most of it also applies for podman (CONTAINER_HOST)
2020-11-29 23:35:37 +01:00
Anders F Björklund dae980a355 Add support for restoring existing podman env
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
Medya Gh 7bc81b1cbd add imagesha 2020-11-25 14:22:29 -08:00
Medya Gh 8639a067e6 bump kic image on head 2020-11-25 14:07:24 -08:00
Medya Ghazizadeh 5d5a12c60f
Merge pull request #9734 from priyawadhwa/updae-iso-kic
Update ISO and kicbase to include scheduled stop
2020-11-24 10:10:59 -08:00
Anders F Björklund fee0f5310a Add private network implementation for podman
Most of it the same as docker, except for the options.

i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Medya Ghazizadeh 131d7248c4
Merge pull request #9710 from valaparthvi/issue9690
convert dockerNetworkInspect to a struct
2020-11-20 14:16:01 -08:00
Jituri, Pranav 197f2a25ae
Removed unused debugging lines 2020-11-21 00:30:05 +05:30
Jituri, Pranav bf7b09f484
Fix permissions for key file on Windows 2020-11-21 00:27:19 +05:30
Parthvi Vala 63c186bb05 convert dockerNetworkInspect to a struct 2020-11-20 12:29:37 +05:30
Priya Wadhwa e83ba9df9c Update ISO and kicbase to include scheduled stop so we can test them 2020-11-18 10:54:41 -08:00
Jituri, Pranav 0def75cbc9
Work in progress for SSH key file fix 2020-11-18 01:46:28 +05:30
Priya Wadhwa 14db0debef review comments 2020-11-17 12:15:42 -08:00
Medya Ghazizadeh 8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
Medya Gh 7955a891cb bump kicbase 2020-11-12 16:04:26 -08:00
Priya Wadhwa 9bb9355b50 fix merge conflict 2020-11-11 11:57:27 -08:00
Medya Ghazizadeh 0f5a2ca4a4
Merge pull request #9641 from prezha/fix-kvm-minikube-net
Fix minikube-net network failures for KVM driver
2020-11-10 12:43:20 -08:00
Predrag Rogic 9e114139dc
retry instead of sleep; gc cleanup 2020-11-10 16:28:14 +00:00
Predrag Rogic 8ebc828eb1
Fix minikube-net network failures for KVM driver 2020-11-10 16:27:51 +00:00
Medya Gh 37914938e5 bump kicbase to include crio changes 2020-11-09 17:39:19 -08:00
Medya Gh c2bfd58be3 bump snapshot 2020-11-09 17:16:47 -08:00
Ilya Zuyev 0f2c63881a Merge branch 'master' into gh_9463_non_dev_dockerhost 2020-11-09 14:11:20 -08:00
Ilya Zuyev e58d538903 Fix linter warning 2020-11-09 12:52:27 -08:00
Medya Gh 80566956d6 bump kicbase 2020-11-05 12:36:40 -08:00
Ilya Zuyev d5a092c3c7 Add unit tests for oci.DaemonHost() 2020-10-30 14:00:52 -07:00
Ilya Zuyev c97cd912f1 Rename oci.RuntimeHost() -> oci.DaemonHost() 2020-10-30 13:44:34 -07:00
Ilya Zuyev 72b710af03 Fix warning about listening to 0.0.0.0 2020-10-30 13:41:06 -07:00
Ilya Zuyev 43a4b62b68 Remove excessive logging 2020-10-30 13:27:29 -07:00
Ilya Zuyev acbdafa4e1 Fix func naming 2020-10-27 16:07:50 -07:00
Priya Wadhwa ea6ca08d67 Change flag name to --network and exit if used without docker driver 2020-10-26 11:52:26 -07:00
Priya Wadhwa ebf612254c Fix merge conflict 2020-10-26 09:31:59 -07:00
Medya Gh 9f729ac041 readability 2020-10-23 15:04:13 -07:00
Medya Gh 43c2a5cd0c dont pass mtu if 0 2020-10-23 14:54:49 -07:00