70c9304724
code review comments
2020-03-13 10:37:29 -07:00
6533d9f2e8
Rename methods to match the convention
2019-10-20 19:11:31 +05:30
84242bf2c1
cleanup: fix words in logging message
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-15 20:53:28 +08:00
e8824b76b2
Merge pull request #5052 from tstromberg/doc-redirect
...
Update code references to new documentation URL's
2019-08-12 18:26:01 -07:00
f2acb4a33e
Update code references to new documentation URL's
2019-08-12 14:51:41 -07:00
a817bffab1
Remove all minikube dependencies from drivers ( #4933 )
...
* Remove all minikube dependencies in driver code
* removing all default config
* okay we need some defaults
* code comments
* hyperkit builds now
* sleep for an appropriate amount of time
* remove constant in favor of string
* try goproxy for travis
* try goproxy for travis
* try goproxy for travis
* let's not try goproxy for now
* let's try goproxy once again
* maybe use the correct url for the proxy
* fix go mod
2019-08-12 14:42:11 -07:00
c5f695e8a0
Better comment syntax
2019-07-05 11:17:10 +08:00
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
...
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
4d00a093d1
Fix error naming convention
2019-06-29 11:28:54 -03:00
23ae121f2b
kvm2: simplify connection error message
2019-06-29 10:53:13 -03:00
9dfe660c64
Add support to custom qemu uri on kvm2 driver
2019-06-28 14:12:58 -07:00
8acf4824df
Add commit id to docker-machine-driver-kvm2 version
2019-06-28 13:45:54 -07:00
d6a839b20a
Fix kvm2 vm driver remove domain
2019-06-26 18:36:52 -07:00
6ba1725c08
Added Memory Size Checking
2019-06-26 00:22:41 +05:30
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
f20f223c02
Decrease cyclomatic complexity
...
Here is the report (from gocyclo), before:
21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
...
Add kvm2 --version
2019-06-20 07:41:18 +08:00
a2d844ef51
Add kvm network name validation
...
closes for #3581
2019-06-15 13:56:12 -07:00
a024c6d22a
Add kvm2 --version
2019-06-04 16:45:14 -03:00
986c61d15e
Fix kvm gpu log
2019-05-30 14:56:46 -03:00
dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
...
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
...
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
c09913070d
Fix kvm remove when domain is not defined
2019-05-25 09:23:40 -03:00
8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
...
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
...
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
48237d95b8
Clean up kvm Remove code
2019-05-24 14:27:55 -03:00
b65c7403cf
Add error warp to destroyRunningDomain
2019-05-24 14:27:55 -03:00
3124f11e1b
Fix kvm remove when domain is not running
2019-05-24 14:27:55 -03:00
81f0d9ba37
Fix kvm remove warn message
2019-05-24 12:38:00 -03:00
1852a72caf
Refactor kvm lookupIPFromStatusFile
2019-05-23 15:38:02 -03:00
fc2e2e52c5
Skip kvm network deletion if private network doesn't exist
2019-05-23 06:17:12 -03:00
93329f1619
Remove obsolete comment
2019-05-22 17:25:27 -03:00
e3bf4bd7ec
Fix kvm ensureNetwork
2019-05-22 16:19:09 -03:00
e9a450df66
Validate kvm network exists
2019-05-21 16:19:15 -03:00
e53c0339ea
This is my testament to Chesterton's Fence
2019-05-15 11:44:16 -07:00
340c8faced
Remove crazy recursive permissions check that was chowning /home
2019-05-15 10:17:44 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
7ba01b40a9
Hide KVM signature
2018-12-15 21:47:41 +11:00
3706b3b8ac
Fix dangling format issues.
2018-09-28 16:48:37 -07:00
055c8002b1
Replace %s format directives with %v for errors.
...
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
5d0e12327a
turning error into a warning log message
2018-09-26 13:53:57 -07:00
4eb2cdb120
inlining deleteNetwork into if statement
2018-09-24 14:04:01 -07:00
5e38bf4819
kvm2 driver: fixed documentation link in error text
2018-09-21 10:28:52 -07:00
34ee59192b
kvm2 driver: be more robust with creating of the network, don't delete the network if it is in use
2018-09-21 10:28:47 -07:00
b35e908dec
kvm2 driver: generate separate random MACs for default and private network NICs
2018-09-21 10:28:43 -07:00
Medya Gh
cueo
Guangming Wang
Thomas Strömberg
Sharif Elgamal
Kyle Bai
Medya Ghazizadeh
josedonizetti
Pranav Jituri
Anders F Björklund
Alasdair Tran
Marcus Heese