Commit Graph

4117 Commits (196789f965f46f706966b4edb652658b7193e247)

Author SHA1 Message Date
Priya Wadhwa 4eddbc5225 Fix lint 2020-05-12 16:38:41 -07:00
Medya Ghazizadeh 8a4e2610f9
Merge pull request #8104 from medyagh/unit_test_machine
make deleting orphaned kics optional
2020-05-12 23:36:17 +00:00
Medya Gh bb2607aab8 fix unit test 2020-05-12 16:25:46 -07:00
Medya Gh 97d5251b02 update oldest support version patch 2020-05-12 16:11:05 -07:00
Medya Gh 2de9f442bb update oldest kuberentes version to latest minior 12.9.10 2020-05-12 16:10:54 -07:00
Medya Gh e457618d71 make deleting orphaned kics optional 2020-05-12 16:00:02 -07:00
Sharif Elgamal e65486a017 retrieve virtual switch name from driver object directly 2020-05-12 15:45:18 -07:00
Medya Gh 05cd86925e update newest 2020-05-12 15:22:01 -07:00
Medya Gh 7dbbbc66cf update kuberentes version to v1.18.2 2020-05-12 15:17:55 -07:00
Sharif Elgamal d7813e9199 ControlPaneEndpoint -> ControlPlaneEndpoint 2020-05-12 12:01:42 -07:00
Sharif Elgamal 09698e4638 only copy apiserver certs to control plane 2020-05-12 11:53:38 -07:00
Priya Wadhwa 6147ad350d Add support for timing per log and printing out timings per log to mkcmp 2020-05-12 11:07:25 -07:00
Sharif Elgamal 335379dc59 it works 2020-05-11 19:25:53 -07:00
Medya Ghazizadeh afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
Anders F Björklund e892829155 Missing period character in the error template 2020-05-11 22:38:36 +02:00
Medya Ghazizadeh 12122f7dc6
Merge pull request #8053 from medyagh/arm64_docker_solution
docker/podman solution message for non-amd64 archs
2020-05-11 19:41:31 +00:00
Medya Gh 5a4d3279be address review comments 2020-05-11 12:28:48 -07:00
Medya Ghazizadeh d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
Sharif Elgamal d4639c52b9 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-11 11:52:22 -07:00
Sharif Elgamal 4886030486 pass everything by reference since we actively change node IP 2020-05-11 11:50:51 -07:00
Medya Ghazizadeh 6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
Medya Ghazizadeh d89d40c374
Merge pull request #8060 from afbjorklund/podman-cp
The podman cp command is not in podman-remote
2020-05-11 17:55:38 +00:00
Anders F Björklund 16af75ed24 Add fix warning for active podman-env as well 2020-05-11 12:15:22 +02:00
Anders F Björklund c578a7aa1e Add a PointToHost function for podman as well
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
Anders F Björklund 541fb9cf98 The podman cp command is not in podman-remote
So use podman exec stdin/stdout as a workaround.
2020-05-10 18:35:41 +02:00
Medya Ghazizadeh 7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
Anders F Björklund cac41495cf Don't run the extraction tar container for podman
The preloaded images will be extracted anyway, using ssh.

But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.

Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
Anders F Björklund 46025eccf5 Use the runCmd wrapper for start to not miss error 2020-05-09 14:07:18 +02:00
Anders F Björklund ac01e92012 Add comment about why podman looks at runtime.GOOS 2020-05-09 14:05:57 +02:00
Anders F Björklund a7a5148ff6 Don't add cgroup manager param for podman-remote
Since it doesn't work for either "run" or "start"

	Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
Anders F Björklund 85fae62d4a Wrap the start command with cgroup manager too
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Anders F Björklund 1bd56a40cf Don't use cached credentials for sudo podman
We want to verify that "NOPASSWD" has been set up properly

Otherwise the sudo timestamp might time out (after 15 mins)
2020-05-09 13:52:58 +02:00
Anders F Björklund 934ad06a82 Use noninteractive sudo when running podman
To avoid asking for a password in the middle of minikube commands.

The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
Medya Gh 45acf71459 lint 2020-05-08 19:57:45 -07:00
Medya Gh 24971a5ff5 docker/podman fail on non-amd64 systems 2020-05-08 19:56:38 -07:00
Priya Wadhwa bfef99b63d Copy files directly now that we control kubeadm 2020-05-08 14:12:13 -07:00
Priya Wadhwa 753dc44706 Remove unnecessary function 2020-05-08 13:57:11 -07:00
Priya Wadhwa 6d1d07c857 Remove unnecessary restart 2020-05-08 13:55:30 -07:00
Sharif Elgamal 6bb8371459 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-08 13:53:20 -07:00
Sharif Elgamal ad9b4c1a38 save config 2020-05-08 13:53:16 -07:00
Priya Wadhwa cb4dc30bab Add unit test 2020-05-08 12:49:54 -07:00
Priya Wadhwa ba267702af Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs 2020-05-08 12:38:02 -07:00
Priya Wadhwa f574852125 make it impossible to enable the kubelet service 2020-05-08 12:37:28 -07:00
Priya Wadhwa 0fa24990c9 Remove Enable(kubelet) from unpause
This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`
2020-05-08 12:33:45 -07:00
Priya Wadhwa 826fb2bbf3 Restart kubelet after updating config files
This makes sure the kubelet picks up the correct IP
2020-05-08 12:32:27 -07:00
Priya Wadhwa 73d15fc275 Start kubelet after host aliases have been set in /etc/hosts
kubelet manages the value of `/etc/hosts` within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:

1. Us updating /etc/hosts with aliases on IP changes
1. kubelet starting k8s with current value of /etc/hosts

This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to `/etc/hosts`
2020-05-08 12:30:06 -07:00
Medya Ghazizadeh 34e833511b
Merge pull request #8027 from tstromberg/quiet-ssh2
virtualbox: Quiet initial ssh timeout warning
2020-05-08 00:00:39 +00:00
Priya Wadhwa 9348667351 Add host alias back after restarting kubelet 2020-05-07 17:00:37 -07:00
Sharif Elgamal 5e981137a4 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-07 16:13:25 -07:00
Thomas Stromberg 436cee2d84 Fix minikube/kubernetes capitalization, make short help consistent 2020-05-07 14:12:10 -07:00
Priya Wadhwa 80960945af move into separate function 2020-05-07 13:45:34 -07:00
Priya Wadhwa ced1914fed remove unnecessary code 2020-05-07 13:43:03 -07:00
Priya Wadhwa 69a39c100c Add kic 2020-05-07 13:41:37 -07:00
Priya Wadhwa 8ac42815aa Restart kubelet if soft start 2020-05-07 13:40:26 -07:00
Priya Wadhwa 163ab88408 Restart kubelet in a function that is called on soft start 2020-05-07 13:22:09 -07:00
Priya Wadhwa a353d564dd Add comments 2020-05-07 13:03:07 -07:00
Priya Wadhwa c037a97392 Restart kubeadm on soft `minikube start`
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Thomas Stromberg 68cd6f96db Merge branch 'master' into quiet-ssh2 2020-05-07 11:30:31 -07:00
Sharif Elgamal 358f167ae8 keepContext 2020-05-07 11:21:58 -07:00
Medya Ghazizadeh 269b938945
Merge pull request #8022 from tstromberg/better-restart
restart: validate configs with new hostname, add logging
2020-05-07 18:12:52 +00:00
Thomas Stromberg 32e4e64bc4 Quiet initial ssh timeout message 2020-05-06 17:58:21 -07:00
Sharif Elgamal 65c5d5725a Merge branch 'better-restart' of github.com:tstromberg/minikube into restart 2020-05-06 17:14:58 -07:00
Giacomo Mr. Wolf Furlan 9c43c47b06 Podman: disable selinux labels when extracting the tarball to prevent permission errors 2020-05-07 02:09:09 +02:00
Thomas Stromberg e9eabf1bda Log an error if we can't read the response body 2020-05-06 15:55:49 -07:00
Thomas Stromberg 7de8ae3f54 Log existing configuration files, fix validateStartNoReset test 2020-05-06 15:25:27 -07:00
Thomas Stromberg 55cbbd3e4c Remove test panic 2020-05-06 14:47:56 -07:00
Thomas Stromberg d31a4bd561 Fix cluster reconfiguration issues, improve behavior 2020-05-06 14:39:15 -07:00
Sharif Elgamal 464d4259ce assign proper internal IPs for nodes 2020-05-06 09:35:48 -07:00
Sharif Elgamal 494710616b let's change a bunch of stuff 2020-05-05 14:42:07 -07:00
Priya Wadhwa ec74a37e9c Add env variable to configure force-systemd
Also add an integration test for the env variable
2020-05-05 12:10:03 -07:00
Medya Ghazizadeh ca5353742e
Merge pull request #7943 from medyagh/kicbase_gh_package
docker/podman: add alternative image repo for base image to fallback
2020-05-04 23:12:28 +00:00
Sharif Elgamal 2ec26658a6 check kubelet status explicitly 2020-05-04 15:58:01 -07:00
Medya Gh 041a452a16 add todo comment 2020-05-04 15:22:50 -07:00
Sharif Elgamal bd2c4d8f6c Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-04 14:49:51 -07:00
Thomas Strömberg 250594d83d
Merge pull request #7998 from tstromberg/no-ssh-test
Remove sshutil_test - it offers no value
2020-05-04 14:43:08 -07:00
Thomas Strömberg d363ca9dd7
Merge pull request #7999 from tstromberg/addon-retry-more
addons: fix initial retry delay, double maximum limit
2020-05-04 14:36:40 -07:00
Medya Gh 0189b10624 improve log 2020-05-04 13:47:07 -07:00
Medya Gh 7654c1b058 address review comments 2020-05-04 13:22:48 -07:00
Medya Gh 1ee8cabd6f add TODO with issue link 2020-05-04 13:12:50 -07:00
Medya Gh 7914d057d1 fall back to github if gcr.io is not available 2020-05-04 13:12:50 -07:00
Medya Ghazizadeh 6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
Medya Ghazizadeh 1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
Medya Ghazizadeh e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
Thomas Stromberg 6969200dd7 addons: fix initial retry delay, double maximum limit 2020-05-04 12:44:30 -07:00
Thomas Stromberg 4eef342690 Remove sshutil_test - it offers no value 2020-05-04 12:31:15 -07:00
Sharif Elgamal 5589f01926 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-04 10:43:16 -07:00
Anders F Björklund cc6506d2c9 Remove logging statement from containerGateway 2020-05-03 09:42:32 +02:00
Medya Gh 85aa9709da lint 2020-05-02 20:30:50 -07:00
Medya Gh f68f45a30a flip debug if 2020-05-02 20:20:58 -07:00
Medya Gh d887259153 add to registry 2020-05-02 20:19:17 -07:00
Medya Gh 6b09d4ebe5 misspell 2020-05-02 19:34:52 -07:00
Medya Gh ddd3c72f9d add kic base image to the cluster config 2020-05-02 19:29:54 -07:00
Medya Gh bcecda8e20 add comment for error type 2020-05-02 18:48:52 -07:00
Medya Gh 2102a20605 wrap errors 2020-05-02 18:38:23 -07:00
Medya Gh 4572d0634f exit with usage if container type is windows 2020-05-02 18:29:33 -07:00
Medya Gh ee9004f93b add os type to DaemonInfo 2020-05-02 17:02:19 -07:00
Sharif Elgamal 4cb2d0f34a Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-01 17:02:19 -07:00
Sharif Elgamal 76349e19b2 more changes 2020-05-01 17:02:11 -07:00
Anders F Björklund 743f9f7efc Don't show any podman hint about restarting sudo 2020-05-01 22:21:32 +02:00
Anders F Björklund e2d7d94dfc Use the correct binary for unpacking the preload
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
Anders F Björklund 3531efda7b Get the gateway by inspecting container network 2020-05-01 15:05:21 +02:00
Sharif Elgamal 94a9c03b91 initial commit for restartWorker 2020-04-30 16:02:43 -07:00
Thomas Strömberg c65225d2e6
Merge pull request #7896 from tstromberg/download-tests-suck
download: unify handling, refuse while under test
2020-04-30 11:21:32 -07:00
Thomas Strömberg 147fd9e2b1
Merge pull request #7714 from tstromberg/k8s-v1.18.1
Upgrade default Kubernetes to v1.18.1
2020-04-29 10:29:00 -07:00
Thomas Stromberg e9bf83d5f0 Make a better mock interface, detect integration tests 2020-04-29 09:46:20 -07:00
Thomas Stromberg 0cd6a01180 Merge branch 'master' into download-tests-suck 2020-04-29 09:17:43 -07:00
Thomas Strömberg 7b39b102d6
Merge pull request #7930 from sharifelgamal/cni
Automatically apply CNI on multinode clusters
2020-04-29 09:14:38 -07:00
Thomas Strömberg 7dc28f6af7
Merge pull request #7247 from tstromberg/control-plane-host
Add `(host|control-plane).minikube.internal` to /etc/hosts
2020-04-29 09:10:49 -07:00
Thomas Strömberg dc4e85f77b
Merge pull request #7839 from Hellcatlk/master
Add unit test for function ChownR&MaybeChownDirRecursiveToMinikubeUser
2020-04-29 08:54:58 -07:00
Thomas Strömberg dee6d518ce
Merge pull request #7631 from afbjorklund/podman-sudo
Add "sudo" to podman calls
2020-04-29 08:53:41 -07:00
Thomas Strömberg 2f78bff4ed
Merge pull request #7858 from priyawadhwa/upgrade-kic
Upgrade docker driver base image to v0.0.10
2020-04-29 08:48:45 -07:00
Medya Ghazizadeh c739d3f564
Merge pull request #7928 from sharifelgamal/mem
improve auto-select memory for multinode clusters
2020-04-28 21:22:22 -07:00
Sharif Elgamal 17d7c2a0f8 finish comment 2020-04-28 12:45:01 -07:00
Sharif Elgamal 19705a481e remove debugging 2020-04-28 12:40:42 -07:00
Sharif Elgamal 747b18a955 lint 2020-04-28 12:10:27 -07:00
Sharif Elgamal 2d95ec9222 check for multinode 2020-04-28 11:42:51 -07:00
Sharif Elgamal d637698b60 Merge branch 'master' of github.com:kubernetes/minikube into cni 2020-04-28 11:19:07 -07:00
priyawadhwa 6f6ac3aeb2
Merge pull request #7880 from n0npax/improve-perf-test-coverage
Improve perf test coverage
2020-04-28 10:23:05 -07:00
Sharif Elgamal e61a18cbaa be smarter about allocating memory for multinode clusters 2020-04-28 10:10:02 -07:00
Thomas Stromberg 798fb930b0 Merge branch 'master' into k8s-v1.18.1 2020-04-28 08:11:34 -07:00
Thomas Stromberg 878fc6a5f0 Merge branch 'master' into control-plane-host 2020-04-28 08:09:24 -07:00
Anders F Björklund 78a22f5056 Remove prefix parameter and add prefix command
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
Kubernetes Prow Robot f33de7fd11
Merge pull request #7902 from radeksm/bugfix/7792
sort styles constant and style' map - continuation of bugfix/7792
2020-04-28 02:10:05 -07:00
Anders F Björklund f78e00e99b Merge branch 'master' into podman-sudo 2020-04-28 07:55:38 +02:00
Sharif Elgamal e2467b2081 just always apply overlay 2020-04-27 17:53:55 -07:00
Sharif Elgamal 5848bbe011 Merge branch 'master' of github.com:kubernetes/minikube into cni 2020-04-27 14:15:19 -07:00
Sharif Elgamal 228c1b092c automatically apply kic overlay when detecting multinode clusters 2020-04-27 14:15:12 -07:00
Anders F Björklund 1744ffe773 Restore the configured state added for podman
Reverted 22aa1aff22 by accident
2020-04-27 22:27:53 +02:00
Anders F Björklund bf4aa78ca6 Log the version used of the two KIC runtimes 2020-04-27 21:58:42 +02:00
Priya Wadhwa 2459caea75 update SHA 2020-04-27 10:47:10 -07:00
Priya Wadhwa e3397d559f Merge branch 'master' of https://github.com/kubernetes/minikube into systemd 2020-04-27 10:33:12 -07:00
Anders F Björklund a041f4012a Podman allows setting --cpus and --memory now 2020-04-27 17:02:13 +02:00
Anders F Björklund 95c95599c2 Align podman driver with docker and improve check
Make sure to use "sudo podman version" on Linux
(need user namespace support for "podman version")

And improve error output handling for podman-remote
(when the remote service is not running properly)
2020-04-27 12:43:02 +02:00
Anders F Björklund 998ab840fb Use simple version of podman info format parameter
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
Anders F Björklund 795128131f Remove old Copy function added in merge conflict 2020-04-26 22:52:10 +02:00
Anders F Björklund 28106fa2d7 Use constants instead of the KIC prefix strings 2020-04-26 15:22:57 +02:00
Anders F Björklund d96d9d34ed Include any output from podman version in the log 2020-04-26 15:12:04 +02:00
Anders F Björklund 88c8a24d55 Pass the container implementation on to systemd 2020-04-25 22:43:40 +02:00
Anders F Björklund 7185140c57 Remove extra quotes added in conflict resolution
Reverted f264ac171e by accident
2020-04-25 22:09:52 +02:00
Anders F Björklund 7647b1f998 Don't try to limit podman memory without cgroup
Podman requires both memcg and memcg_swap for it (--memory).

Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
Anders F Björklund bb37c7098c Fix log message to say driver and not cruntime 2020-04-25 21:57:41 +02:00
Anders F Björklund 6644c5cc64 Merge branch 'master' into podman-sudo 2020-04-25 18:05:33 +02:00
Radoslaw Smigielski d42a0a145c Fix lint error 2020-04-25 07:32:40 +01:00
Radoslaw Smigielski fe59e38748 Sort map of styles' names to style struct 2020-04-25 07:15:29 +01:00
Radoslaw Smigielski 7462bb5568 Sort available style constants
We have a number of style constant names defined in completly random
order, let's make a little bit of cleanup here.
2020-04-25 06:54:02 +01:00
Thomas Stromberg d98a484f87 Ensure that there is an output file to operate on 2020-04-24 17:11:52 -07:00
Thomas Strömberg e3a3b1e743
Merge pull request #7308 from laozc/metallb
Add Metal LB addon
2020-04-24 16:59:50 -07:00
Thomas Stromberg 1cbbb6ac0b Merge to master 2020-04-24 16:58:15 -07:00
Thomas Strömberg 47b769b9cc
Merge pull request #7867 from kubernetes/hyperv-cleanup
hyperv: Check for Get-Wmiobject err before parsing output
2020-04-24 16:56:02 -07:00
Thomas Stromberg e6054fc927 download: refuse to download actual files while under test 2020-04-24 16:40:48 -07:00
Medya Ghazizadeh e3afeb35e4
Merge pull request #7862 from medyagh/oci_err_type
clean up: refactor oci package exec calls
2020-04-24 15:57:38 -07:00
Priya Wadhwa 71ca99b926 Merge branch 'master' of https://github.com/kubernetes/minikube into systemd 2020-04-24 15:33:50 -07:00
Thomas Strömberg cd3317f0ee
Merge pull request #7882 from kubernetes/errmap
Fix sysctl fs.protected_regular=1 typo
2020-04-24 15:09:12 -07:00
Medya Gh 63f9bfbb61
addres review comments 2020-04-24 14:07:54 -07:00
Priya Wadhwa 1825546757 Restart docker if we've changed the daemon config 2020-04-24 14:05:35 -07:00
Medya Gh 51655af562
Merge branch 'master' of github.com:kubernetes/minikube into oci_err_type 2020-04-24 13:53:28 -07:00
Medya Ghazizadeh c6e0f7ffd7
Merge pull request #7876 from tstromberg/ssh-flaky-flaky
ssh_mock: Use sync.WaitGroup to defend against deferred mutations
2020-04-24 13:19:54 -07:00
Sharif Elgamal f3d4db330a adding ability to detect multinode clusters 2020-04-24 12:07:49 -07:00
priyawadhwa 43948fac30
Merge pull request #7835 from radeksm/bugdix/7792
change emoji for:  notifying new kubernetes version is available
2020-04-24 10:45:09 -07:00
Priya Wadhwa 29dc41e5ab Merge branch 'master' of https://github.com/kubernetes/minikube into systemd 2020-04-24 10:08:50 -07:00
Priya Wadhwa 8479ba047c Merge branch 'master' of https://github.com/kubernetes/minikube into upgrade-kic 2020-04-24 10:08:23 -07:00
Kenta Iso fe69cdaeaf update dashboard image v2.0.0 2020-04-24 12:32:25 +09:00
Thomas Stromberg 644b41989d Fix sysctl fs.protected_regular=1 typo 2020-04-23 20:11:31 -07:00
Marcin Niemira 9994f287e0
boilerplate fix 2020-04-24 10:33:24 +10:00
Marcin Niemira a687a721ec
keep imports syntax coherent 2020-04-24 10:27:16 +10:00
Marcin Niemira c247e6f2ee
add tests for binary(perf package 2020-04-24 10:24:31 +10:00
Priya Wadhwa 52b57374fc make forceSystemd private 2020-04-23 16:56:30 -07:00
Thomas Stromberg ec19ddaff9 Less fatal, more error to prevent whack-a-mole debugging 2020-04-23 16:27:22 -07:00
Priya Wadhwa cfb1d21982 fix lint 2020-04-23 16:10:20 -07:00
Priya Wadhwa cb6cd27f64 Merge branch 'master' of https://github.com/kubernetes/minikube into systemd 2020-04-23 15:57:14 -07:00
Medya Gh 804c531f5a
Merge branch 'master' of github.com:kubernetes/minikube into oci_err_type 2020-04-23 15:55:03 -07:00
Medya Ghazizadeh d845c5de3e
Merge pull request #7875 from medyagh/containerd_mystrie
contained cni: rename default cni file to have higher priority
2020-04-23 15:50:15 -07:00
Thomas Stromberg 964abf8f65 Use sync.WaitGroup to defend against deferred connection changes 2020-04-23 15:30:14 -07:00
Priya Wadhwa 746d225bfb remove unused code 2020-04-23 15:15:57 -07:00
Priya Wadhwa 1087f56b7a Pass forceSystemd into cRuntime lib to avoid errors with cobra 2020-04-23 15:11:40 -07:00
Priya Wadhwa 9f680d41aa Merge branch 'master' of https://github.com/kubernetes/minikube into upgrade-kic 2020-04-23 14:59:10 -07:00
Priya Wadhwa dc14146f8d resolve merge conflict 2020-04-23 14:53:28 -07:00
Medya Gh ef01ed481c
get rid of global CliRunner 2020-04-23 14:37:03 -07:00
Thomas Stromberg e5cc661733 Merge master 2020-04-23 14:31:47 -07:00
Medya Gh 7aad0576cc
rename default cni file to have higher priority 2020-04-23 13:41:43 -07:00
Thomas Strömberg e6669b8891
Merge branch 'master' into hyperv-cleanup 2020-04-23 13:20:17 -07:00
Thomas Strömberg f9e121efce
Merge branch 'master' into hush-puppies-34 2020-04-23 13:18:47 -07:00
Thomas Stromberg 277a331f6b Skip if empty, turn inability to poll other clusters into a warning 2020-04-23 12:38:05 -07:00
Medya Gh 1c83f56f79
Merge branch 'master' of github.com:kubernetes/minikube into oci_err_type 2020-04-23 11:42:53 -07:00
Priya Wadhwa 96e03d68e8 Merge branch 'master' of https://github.com/kubernetes/minikube into upgrade-kic 2020-04-23 10:55:07 -07:00
priyawadhwa 8f42f380c0
Merge pull request #7856 from priyawadhwa/devkic
Add --base-image flag for docker driver local dev
2020-04-23 10:52:38 -07:00
Thomas Stromberg 8f0f1a7d76 Check for Get-Wmiobject err before parsing output 2020-04-23 10:06:21 -07:00
Thomas Strömberg fba211d176
Merge pull request #7790 from regulskimichal/7789
hyperv: Use 'Get-Wmiobject HyperVisorPresent' instead of 'Get-WindowsOptionalFeature'
2020-04-23 09:48:45 -07:00
Marcin Niemira d81547ed45
add test file 2020-04-23 23:42:59 +10:00
Medya Gh 17f420cc71
warn slow part of cli runner 2020-04-23 01:23:49 -07:00
Medya Gh d9f1b532d0
unexport warnIfSlow func 2020-04-23 00:33:59 -07:00
Medya Gh 038aef6b48
unexport warnIfSlow func 2020-04-23 00:33:40 -07:00
Medya Gh 8a0a210763
convert more funcs to use cli runner 2020-04-23 00:29:37 -07:00
Medya Gh c6e1445ccb
convert more to cli runner 2020-04-23 00:12:41 -07:00
Medya Gh 29df4260ef
make all oci volume calls go through runner 2020-04-22 23:27:54 -07:00
Medya Gh 915058ef8e
lint 2020-04-22 23:01:04 -07:00
Medya Gh 72baa1dad2
convert execs to cliRunner 2020-04-22 22:49:48 -07:00
Medya Gh c6895c2058
add cli runner to info 2020-04-22 22:34:11 -07:00
Medya Gh fad745f607
adding runner for oci package 2020-04-22 22:16:18 -07:00
Priya Wadhwa ca5c8953e8 change flag name to --base-image 2020-04-22 15:28:39 -07:00
Priya Wadhwa d39b822a3c upgrade to v0.0.10 2020-04-22 14:44:24 -07:00
Priya Wadhwa da4119e33a Add --docker-base-image flag for kic development 2020-04-22 14:28:21 -07:00
Priya Wadhwa 9bba297cf1 revert unneeded changes 2020-04-22 14:19:52 -07:00
Priya Wadhwa ae388d0edb Add --force-systemd flag to force container runtime to use systemd 2020-04-22 14:10:55 -07:00
Radoslaw Smigielski eae39ea9a0 Notify user when new kubernetes version is available
Change emoji for telling that new kubernetes is available.
2020-04-22 21:51:05 +02:00
Pierre Ugaz 334d026271
update description 2020-04-22 12:55:42 -04:00
Pierre Ugaz ff63525da4
update from upstream 2020-04-22 12:53:15 -04:00
ZouYu 1b2707d086 Add unit test for function ChownR&MaybeChownDirRecursiveToMinikubeUser
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-04-22 10:06:57 +08:00
Thomas Stromberg e185606d94 Merge branch 'master' into k8s-v1.18.1 2020-04-21 15:25:58 -07:00
Priya Wadhwa 3ae85a1f62 Update kic to v0.0.10, upgrade crio and podman so that the kic base image builds 2020-04-21 14:17:48 -07:00
Priya Wadhwa 80b331c6cd Set systemd in kicbase Dockerfile 2020-04-21 13:46:17 -07:00
Priya Wadhwa 89ba35deff Merge branch 'master' of https://github.com/kubernetes/minikube into systemd 2020-04-21 13:14:12 -07:00
Thomas Stromberg bb6200516c Update examples 2020-04-21 11:21:19 -07:00
Thomas Stromberg 6e2d086721 Address lint errors 2020-04-21 11:18:44 -07:00
Thomas Stromberg 23fa28f739 Add HostIP support for none, reduce tech debt 2020-04-21 11:15:04 -07:00
Thomas Stromberg b50e816d10 Make inability to add host IP non-fatal 2020-04-21 11:14:50 -07:00
Thomas Stromberg 83364882f4 Merge branch 'master' into control-plane-host 2020-04-21 11:04:17 -07:00
priyawadhwa 38b54da842
Merge pull request #7707 from prasadkatti/fix/skip_preload_if_image_repo_set
Skip preload download if --image-repository is set
2020-04-21 09:59:59 -07:00
Medya Gh b639c6112d
fix delete and add integeration test 2020-04-20 20:38:31 -07:00
Priya Wadhwa a2d180ec07 Docker driver: force docker to use systemd as cgroup manager
Since minikube is running systemd, kubeadm expects kubeadm to be the cgroup manager. If docker is using a different cgroup manager like cgroupfs, this can cause unstable resource allocation. We were seeing this in Cloud Shell, and forcing docker to use systemd resolved the issue.
2020-04-20 17:45:28 -07:00
priyawadhwa 311547ac9b
Merge pull request #7793 from medyagh/preload_containerd
add preload feature for containerd
2020-04-20 15:43:35 -07:00
Medya Ghazizadeh 9662ad869a
Merge pull request #7785 from afbjorklund/kubeadm-ignore
Add kubeadm SystemVerification for non-kic and non-azure
2020-04-20 15:23:24 -07:00
Medya Gh 49fa90a384
fix file name 2020-04-20 14:57:10 -07:00
Medya Gh b9592badd7
Merge branch 'master' of github.com:kubernetes/minikube into preload_containerd 2020-04-20 14:56:41 -07:00
Medya Ghazizadeh 7fb9f39cbb
Merge pull request #7780 from afbjorklund/kubeadm-reset-cri-socket
Pass the cri socket path to kubeadm reset command
2020-04-20 14:39:03 -07:00
Medya Ghazizadeh 7cee7d9368
Merge pull request #7689 from afbjorklund/translations-strings
Write all empty translations strings to a file
2020-04-20 14:28:19 -07:00
Anders F Björklund 573152f674 Improve logging of skipped k8s and docker versions 2020-04-20 22:54:02 +02:00
Medya Ghazizadeh 7a3f624b1b
Merge pull request #7803 from priyawadhwa/ui
Improve minikube verifying UI
2020-04-20 13:53:39 -07:00
Medya Gh ba2e27025f
make funcs private 2020-04-20 13:37:46 -07:00
Medya Gh 16c2077106
add helpers and unit test 2020-04-20 13:32:55 -07:00
Medya Gh 366dc8d127
add helper for img plull command 2020-04-20 13:13:37 -07:00
Anders F Björklund 2cb7126f8c Skip verification of docker used in GitHub Actions
[ERROR SystemVerification]: unsupported docker version: 3.0.11+azure
2020-04-20 22:12:42 +02:00
Anders F Björklund e1f864b198 Refactor: reason for skipping SystemVerification 2020-04-20 22:12:42 +02:00
Anders F Björklund 08345e74fb Don't skip SystemVerification for non-KIC drivers
It was added as a default by mistake in 0b2d8051
2020-04-20 22:12:42 +02:00
Anders F Björklund 863b27d260 Return error from Enable if anything went wrong 2020-04-20 21:40:27 +02:00
Priya Wadhwa 4a414fa872 Improve minikube start UI 2020-04-20 12:06:16 -07:00
Medya Gh bc36eb2de9
add todo comment 2020-04-19 21:13:46 -07:00
Medya Gh d2415d778e
add json parser for critcl images 2020-04-19 20:36:22 -07:00
Medya Gh ac66bf2f90
first working version 2020-04-19 19:59:50 -07:00
Medya Gh c017c98e81
add preload funcs for containerd 2020-04-19 19:33:11 -07:00
Michał Regulski db6ed7c7d4 Hyper-V usable by members of Hyper-V admins group 2020-04-20 02:51:51 +02:00
Thomas Stromberg b78c5bc429 Merge to master 2020-04-19 16:31:07 -07:00
Anders F Björklund 49ebcc87d3 Enable docker and kubelet units after adding them
This avoids warnings from `kubeadm init` later:

[WARNING Service-Docker]
[WARNING Service-Kubelet]
2020-04-19 17:31:00 +02:00
Anders F Björklund e726215974 Handle default cri socket path in docker
Use /var/run/dockershim.sock for default
2020-04-19 16:07:09 +02:00
Anders F Björklund e99340b4ac Improve podman status when checking for sudo
Only use sudo for info and running on linux
2020-04-19 09:45:16 +02:00
Anders F Björklund 19be5619d6 Resource limits seem to work ok when not rootless 2020-04-19 09:45:16 +02:00
Anders F Björklund 024cd6b108 Use the same kind of named /var mount for podman
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
Anders F Björklund 8987b1067a Also persist the kubelet and the cni state dirs 2020-04-19 09:45:16 +02:00
Anders F Björklund 223424652c Also create and mount the container runtime dirs 2020-04-19 09:45:16 +02:00
Anders F Björklund df3aec6b0a Missed to wrap one podman inspect in sudo proper 2020-04-19 09:45:16 +02:00
Anders F Björklund f57faf8036 Only remount the /var/lib/minikube directory 2020-04-19 09:45:16 +02:00
Anders F Björklund 22aa1aff22 Handle more state and status for the podman driver 2020-04-19 09:45:16 +02:00
Anders F Björklund 401e94c854 Don't download podman images to docker daemon 2020-04-19 09:45:16 +02:00
Anders F Björklund f264ac171e Remove extra single-quotes from format parameter
podman
	Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
Anders F Björklund d7dc7bf7b2 The podman driver should not be run as root
Use sudo for the podman commands instead

Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Anders F Björklund 5f86da5b54 Pass the cri socket path to kubeadm reset command
Avoids error: "Found multiple CRI sockets"
2020-04-19 09:29:52 +02:00
Medya Gh 23f7fb0b9b
lint 2020-04-18 14:52:45 -07:00
Medya Gh 24dd9861e0
change loglevel for freezer 2020-04-18 14:37:58 -07:00
Medya Ghazizadeh 3276ed4387
Merge pull request #7753 from tstromberg/dns-permissions
tunnel: Fix resolver file permissions, add DNS forwarding test
2020-04-17 19:56:20 -07:00
Medya Ghazizadeh 825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
Medya Ghazizadeh fe4fdeec6c
Merge pull request #7752 from medyagh/node_pressure_redo
Check node pressure & new option "node_ready" for --wait flag
2020-04-17 19:45:40 -07:00
Medya Gh 21ad12fb44 lint 2020-04-17 16:50:12 -07:00
Medya Gh 5e36969ab9 run NodePressure after api server is up 2020-04-17 16:15:12 -07:00
Sharif Elgamal f8c1f05e9a Merge branch 'master' of github.com:kubernetes/minikube into multi-vm 2020-04-17 15:32:50 -07:00
Medya Gh 70cbc67983 add todo comment 2020-04-17 15:21:34 -07:00
Medya Ghazizadeh 14b6582c7b
Merge pull request #7749 from tstromberg/storageclass-kapi
Unify Kubernetes client creation around kapi.Client
2020-04-17 14:54:27 -07:00
Medya Gh 775a91cc1a make node pressure happen after all other waits 2020-04-17 14:35:36 -07:00
Medya Gh cd99a47ad2 address review comments 2020-04-17 14:10:13 -07:00
Medya Gh 4e7429695d address review comments 2020-04-17 14:07:41 -07:00
Medya Gh 4f04427326 rename icon 2020-04-17 13:50:33 -07:00
Medya Gh a18e27d807 lint 2020-04-17 13:12:51 -07:00
Medya Gh 100bc08dd1 add advise 2020-04-17 12:45:31 -07:00
Medya Gh 786801dd43 add required verifying node conditions 2020-04-17 12:40:00 -07:00
Priya Wadhwa dac65664b6 remove testing for v1.11 2020-04-17 12:33:37 -07:00
Thomas Stromberg 8fc8abb6df Remove viper from service package 2020-04-17 12:26:52 -07:00
Priya Wadhwa 7a1de72d2e remove v1alpha1 since we no longer supports k8s versio < 1.12 2020-04-17 12:25:55 -07:00
Priya Wadhwa 02bafac2a8 Fix unit test 2020-04-17 12:24:31 -07:00
Medya Gh 710b289993 remove duplicate checking ShouldWait 2020-04-17 12:18:30 -07:00
Medya Gh ad00988d50 add node_ready for WaitForNode 2020-04-17 12:14:09 -07:00
Medya Gh ffebe51e00 add styles for verifying 2020-04-17 12:06:46 -07:00
Priya Wadhwa 3d05a43c8b Upgrade oldest supported k8s version to v1.12.0 2020-04-17 11:58:09 -07:00
Thomas Stromberg b2efff6d59 Make resolver file world-readable, improve logging and errors 2020-04-17 11:44:04 -07:00
Medya Gh 76ca5e0f20 add node conditions and error types 2020-04-17 11:42:20 -07:00
Medya Gh 991c97a738 rename appsrunning key to match others 2020-04-17 11:33:08 -07:00
Medya Gh 44ff50f144 add WaitForNodeReady 2020-04-17 11:32:41 -07:00
Priya Wadhwa 156558c236 Merge branch 'master' of https://github.com/kubernetes/minikube into flake 2020-04-17 11:17:24 -07:00
Medya Ghazizadeh d3801136eb
Revert "Pass the cri socket path to kubeadm reset command" 2020-04-17 11:02:21 -07:00
Medya Ghazizadeh b0378e9362
Merge pull request #7724 from afbjorklund/kubeadm-reset-cri-socket
Pass the cri socket path to kubeadm reset command
2020-04-17 11:01:19 -07:00
Sharif Elgamal f415802b50 don't use mustload to avoid panic 2020-04-17 10:25:20 -07:00
Thomas Stromberg e45af6d78f Make context-name explicit in GetCoreClient 2020-04-17 10:20:44 -07:00
Thomas Stromberg 99165fd73a Fix tests 2020-04-17 10:09:22 -07:00
Thomas Stromberg 3a5406f79e Unify client creation around kapi.Client 2020-04-17 09:58:14 -07:00
Alonyb bfa45ef79a delete unnecesary func 2020-04-16 19:49:26 -05:00
Medya Gh 891e7a6520 spell 2020-04-16 16:53:04 -07:00
Medya Gh bf15f9a00c fix build err 2020-04-16 16:20:04 -07:00
Medya Gh 934f900f16 improve kic start and kill 2020-04-16 16:10:44 -07:00
Medya Ghazizadeh 3afa3d6970
Merge pull request #7726 from medyagh/retry_unification
use wait.poll for waiting on default sa
2020-04-16 15:58:45 -07:00
Medya Gh bb327e250d adjust try 2020-04-16 15:14:59 -07:00
Medya Ghazizadeh 1d7d6679ee
Merge pull request #7717 from govargo/fix-update-context
Fix update-context in order to recover kubeconfig even if it's missing
2020-04-16 14:18:43 -07:00
Medya Ghazizadeh 469f075e21
Merge pull request #7565 from tstromberg/fail-slower
Increase host creation timeout
2020-04-16 14:18:01 -07:00
Medya Gh 0d6713a875 fix retry 2020-04-16 13:48:50 -07:00
Medya Gh 0687e2adc0 defer print addon 2020-04-16 13:39:59 -07:00
Medya Gh a023de61a7 defer printing enabling addons 2020-04-16 13:38:17 -07:00
Anders F Björklund 32dace62ae Pass the cri socket path to kubeadm reset command
Avoids error: "Found multiple CRI sockets"
2020-04-16 21:48:35 +02:00
priyawadhwa abaa998913
Merge pull request #7558 from priyawadhwa/monitor-1
Add support for specifying pr when running mkcmp
2020-04-16 12:28:21 -07:00
Priya Wadhwa b6410050ae reintroduce unit test 2020-04-16 12:19:13 -07:00
Priya Wadhwa 3c46aa1aee fix lint 2020-04-16 12:08:28 -07:00
Priya Wadhwa 39e41297c8 Remove parallelization between updating cluster and setting up certs
I think this may be creating a race condition and causing TestStartStop to fail, since we seem to be copying over some certs in UpdateCluster.
2020-04-16 11:58:13 -07:00
Medya Gh 528346e26d add test for second start no reset 2020-04-16 11:22:00 -07:00
Sharif Elgamal 4bb2a491c5 Merge branch 'master' of github.com:kubernetes/minikube into multi-vm 2020-04-16 09:13:14 -07:00
Kenta Iso 3695e5e9d6 Fix update-context in order to recover kubeconfig even if it's missing 2020-04-17 00:41:15 +09:00
Prasad Katti c75e3936bf Add a TODO note to remove the imageRepository check once preload is accessible 2020-04-16 08:19:14 -07:00
Thomas Stromberg fdb3bd9d60 Upgrade default Kubernetes to v1.18.1 2020-04-16 07:23:53 -07:00
Medya Gh c44655c733 revert unrelated changes 2020-04-16 00:57:50 -07:00
Medya Gh d0facbf2ee revert addon change for another PR 2020-04-16 00:55:02 -07:00
Medya Gh 058b29dd6a use wait lib 2020-04-15 23:27:16 -07:00
Medya Gh 66d48edddf lint 2020-04-15 23:12:06 -07:00
Medya Gh a604c7c2df revert unrelated changes 2020-04-15 23:03:13 -07:00
Medya Gh 1289de2bf6 robust creation of cluster role binding 2020-04-15 22:57:18 -07:00
Prasad Katti 06fadf8213 Skip preload download if --image-repository is set 2020-04-15 22:24:24 -07:00
Medya Gh ad8003239c wait for default sa for containerd 2020-04-15 21:52:03 -07:00
Medya Gh 63417a9123 enable addons after waiting for cluster up 2020-04-15 21:20:54 -07:00
Medya Gh 4b94687cf5 lint 2020-04-15 17:49:13 -07:00
Medya Gh e4ac2f6d98 fix build error 2020-04-15 17:46:35 -07:00
Sharif Elgamal 0012763d18 Merge branch 'master' of github.com:kubernetes/minikube into multi-vm 2020-04-15 17:32:51 -07:00
Sharif Elgamal 0e221450f9 generate join token on control plane 2020-04-15 17:00:08 -07:00
Medya Ghazizadeh 786b78f390
Merge pull request #7683 from afbjorklund/docker-pull
Only show pulling base image when actually pulling
2020-04-15 15:13:27 -07:00
Medya Ghazizadeh 3f49871459
Merge pull request #7690 from afbjorklund/remote-os
Log the remote OS also for the KIC drivers
2020-04-15 15:09:18 -07:00
Medya Ghazizadeh 2954a9e08a
Merge pull request #7693 from sharifelgamal/proxy-url
update reference URL for proxies and VPNs
2020-04-15 14:46:30 -07:00
Medya Ghazizadeh 17f6cdedb5
Merge pull request #7696 from afbjorklund/translations-statistics
Show statistics when extracting the translations
2020-04-15 14:45:57 -07:00
Medya Ghazizadeh db9f6a9107
Merge pull request #7694 from tstromberg/docker-msg
docker on Linux: Add "Permission Denied" advice
2020-04-15 14:45:23 -07:00
Anders F Björklund 4c4f2c0a8e Show statistics when extracting the translations 2020-04-15 23:05:09 +02:00
Thomas Stromberg 73baf36eaa Try something more specific 2020-04-15 13:26:57 -07:00
Thomas Stromberg 1ef941ba0f Give advice for permission denied on Linux 2020-04-15 13:24:53 -07:00
Sharif Elgamal 4d494f418e update reference URL for proxies and VPNs 2020-04-15 13:06:04 -07:00
Medya Ghazizadeh 4ddc1eabed
Merge pull request #7242 from afbjorklund/image-ref
Add digest to image in daemon after pulling it
2020-04-15 12:54:40 -07:00
Medya Ghazizadeh ad44b8825f
Merge pull request #7688 from tstromberg/override
Turn stale ClientConfig error into warning
2020-04-15 12:12:08 -07:00
Anders F Björklund c235e23f24 Log the remote OS also for the KIC drivers
Currently Ubuntu 19.10, from kindest/base
2020-04-15 20:54:27 +02:00
Anders F Björklund a8a80f5e27 Write all empty translations strings to a file
Useful for seeing which strings have been removed

Use .txt instead of .json, to avoid including it
2020-04-15 20:26:17 +02:00
Thomas Stromberg 97dd0a31f1 Turn stale ClientConfig error into warning 2020-04-15 11:25:14 -07:00
Anders F Björklund 9a47cf378c Only show pulling base image when actually pulling 2020-04-15 19:43:24 +02:00
Medya Gh 1c125e78da address review comments 2020-04-15 10:17:23 -07:00
Alonyb 62904e5dcc fix lint 2020-04-15 09:30:10 -05:00
Medya Gh 34fafc783f fine tune 2020-04-14 22:20:28 -07:00
Medya Gh 29280ceff6 lint 2020-04-14 21:33:21 -07:00
Medya Gh 7303ccf07d lint 2020-04-14 21:31:12 -07:00
Medya Gh 54aa958f01 use oci to delete 2020-04-14 20:51:18 -07:00
Medya Gh b2bcd9a5cb allow SSH commands to run in kic driver 2020-04-14 20:26:10 -07:00
Medya Gh f22a36332e add shut down to stop 2020-04-14 20:21:40 -07:00
Medya Gh 892162d11c add driver helper NeedsShutdown 2020-04-14 19:59:00 -07:00