Commit Graph

1482 Commits (1752d7c004f225ac9c4e0167c7a452e1e9a07006)

Author SHA1 Message Date
Jose Donizetti f390d4bf30 kic on mac: add service cmd support 2020-02-26 20:49:58 -03:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
Medya Gh 7596b39607 addres PR review 2020-02-24 15:10:34 -08:00
Medya Gh 850169764c improve message 2020-02-24 14:51:45 -08:00
Medya Gh 2e261d3d00 add not implemented messages for docker on mac service 2020-02-24 14:41:34 -08:00
Medya Gh d7ee8bfd37 patch 2020-02-24 11:31:53 -08:00
Medya Ghazizadeh 5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
Medya Ghazizadeh 727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
Anders F Björklund fa9f7f9794 Add comments to avoid warnings from go lint 2020-02-22 16:12:42 +01:00
Kevin Pullin 8d78c95aea Generate fish compatible docker-env hint
`fish`'s eval handling does not properly process multiple lines.

Instead the recommendation is to pipe the output to `source`.

This PR updates the usage hint of the `docker-env` command
when running on `fish`:

```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```

Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
Sharif Elgamal 6e9cf2de2f Change MachineConfig to ClusterConfig 2020-02-21 16:09:05 -08:00
sayboras bc2a7aec8b Adjust assert statements 2020-02-22 07:31:49 +11:00
Tam Mach 1d0267f23c Fix unit test 2020-02-22 07:18:16 +11:00
Medya Gh 4d9730137f improve logging 2020-02-20 21:56:23 -08:00
Medya Gh 7c1c0ebb02 more error logging 2020-02-20 21:41:21 -08:00
Medya Gh 67e9c9ab85 log errors in unit test 2020-02-20 21:41:21 -08:00
Medya Gh e6d70210af add error wrpaps for config set 2020-02-20 21:41:21 -08:00
Medya Ghazizadeh 7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
Medya Gh c6313bb7ff better error message 2020-02-20 09:47:45 -08:00
Medya Gh 31cf3f2d79 missing err check 2020-02-20 09:47:10 -08:00
Medya Gh 78c192cb40 lint 2020-02-20 00:07:36 -08:00
Medya Gh dcff758753 lint 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh 8d45b236de less ambigous error log 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh d3b86cfeb9 improve logging 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Medya Ghazizadeh 8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
Medya Ghazizadeh 0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
Medya Gh cc0caac415 mount display bind address to user 2020-02-19 22:08:50 -08:00
Medya Gh b65c2fef09 fix typo 2020-02-19 22:01:46 -08:00
Medya Gh ce89a04278 specify localhost mount for binding for docker on mac 2020-02-19 22:01:46 -08:00
Medya Gh ec7c6ba4fa fix inverted logic 2020-02-19 21:33:24 -08:00
Priya Wadhwa 5ad4d6ebf5 Fix bug in --install-addons flag
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
aallbright 089deef706 Do not create profiles that do not exist 2020-02-18 05:59:37 -05:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Jose Donizetti 2bfcb72b96 Remove not used code 2020-02-17 10:22:11 -03:00
Medya Gh 23ef3f6d16 lint 2020-02-16 19:51:59 -08:00
Jose Donizetti b0d19e51b5 Refactor kic ssh tunnel 2020-02-14 21:01:32 -03:00
Jose Donizetti 0d11e4e348 Add error checking to kic cmd/tunnel 2020-02-14 13:22:56 -03:00
Jose Donizetti c421e156b6 Fix tunnel cmd to pass context to kic tunnel 2020-02-14 12:51:04 -03:00
Medya Gh a007c0790c Delete volumes created by kic 2020-02-14 01:39:16 -08:00
Sharif Elgamal c1a3e4348d fix unit tests and fix merge conflicts 2020-02-13 10:30:12 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Medya Ghazizadeh 25167e1b75
Fix docker-env and add unit and integration tests (#6604)
* Fix docker cert env in docker-env for docker driver

* add unit tests

* add integration tests for docker-env cmd

* lint

* fix lint

* merge conflict

* improve docker-env integraiton test

* linting
2020-02-13 02:17:11 -07:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
priyawadhwa af353314e0
Separate cached kubernetes binaries by OS on host machine (#6586)
* Separate cached kubernetes binaries by OS on host machine

This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.

* Review comment

* Update integration test

* Make sure --download-only includes OS specific kubectl

Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00