328dbc1f97
Improve fix message
2020-07-21 12:29:53 +01:00
66f03b89c3
Update formatting Podman->Podman v2
2020-07-21 12:24:03 +01:00
59bf848e54
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
196789f965
Use RWMutex instead of Mutex
2020-07-21 10:39:45 +08:00
0d78fe56af
lint
2020-07-21 03:00:13 +01:00
622e33b7ab
Fix typo
2020-07-21 02:55:37 +01:00
62683c9b42
Exit with error on podman2 drivers
2020-07-21 02:39:46 +01:00
aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
...
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
...
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
f92015df9b
allow for prefix interace names for hyperv
2020-07-20 13:07:13 -07:00
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
cd17c872d3
Fix documentation typo
2020-07-18 15:02:09 -03:00
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
...
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
f89094dcf8
Adjust comment
2020-07-17 09:46:53 -07:00
2b614ae856
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:45:16 -07:00
3b1dc975d0
legacy client certs: simplify logic
2020-07-17 07:23:48 -07:00
c219b60b05
Add error handling for os.RemoveAll
...
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-07-17 15:44:04 +08:00
b72eee4e36
Turn Errorf into Infof
2020-07-16 23:07:37 -07:00
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
798196d0ad
Remove stray log line
2020-07-16 19:37:28 -07:00
be2c27efe0
Find and copy legacy certificate/key paths
2020-07-16 19:37:15 -07:00
bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
...
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
8f47e32d7c
use pathlib
2020-07-16 18:46:21 +10:00
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
3aac9a3fff
remove duplicate return statement
2020-07-15 14:24:42 -07:00
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
7bbb0b6250
spell
2020-07-15 14:09:35 -07:00
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
af99a13e8f
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-15 11:32:48 -07:00
1467e8f7c4
Merge pull request #8576 from afbjorklund/image-client
...
cache: Only use docker client for docker runtime
2020-07-15 11:12:52 -07:00
dbfd16f21e
add helper fucns for drivers
2020-07-14 15:02:54 -07:00
c2e63844db
Merge pull request #8709 from priyawadhwa/json-output-download
...
Implement Download and DownloadProgress types for JSON output
2020-07-14 15:56:56 -04:00
cb03f56b1b
remove todo
2020-07-14 13:39:33 -04:00
f15b0d6e35
Merge pull request #8468 from prasadkatti/mv_kubelet_params_to_cfg_file
...
Move kubelet params to config file
2020-07-14 09:56:26 -04:00
9f2f604b93
several fixes
2020-07-13 18:54:40 -07:00
bd721de0cf
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-13 15:00:38 -07:00
e4ce27abda
Add unit tests for register package
2020-07-13 12:08:06 -04:00
e771b72a82
fix lint
2020-07-13 10:05:06 -04:00
9784ce3051
Rebased on master
2020-07-13 09:57:42 -04:00
d26cd72d36
Implement Info type so that integration tests pass
2020-07-10 19:18:25 -04:00
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
aa4f7b3b21
update control plane properly on multinode restart
2020-07-10 15:40:21 -07:00
17f44f69e3
impove applyying default service account
2020-07-10 15:01:06 -07:00
442bc138ce
Merge pull request #8676 from priyawadhwa/info
...
Add Infof function to out package
2020-07-10 17:08:30 -04:00
45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
...
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
3c9e96ea6b
Merge pull request #8684 from tstromberg/none-cni
...
none CNI: error if portmap plug-in is required but unavailable
2020-07-10 13:50:54 -07:00
6d9922b430
address review comments
2020-07-10 13:19:22 -07:00
4bce402a3b
remove debug seconds
2020-07-10 13:18:25 -07:00
11674e830f
spell
2020-07-10 13:13:45 -07:00
c240fa97bc
add timeout for node label too
2020-07-10 13:06:43 -07:00
f805be635a
add timeout for node label too
2020-07-10 13:04:11 -07:00
f36da5f044
add timeout for node label too
2020-07-10 13:03:50 -07:00
770f7aeeb4
adjust itmeout
2020-07-10 13:02:06 -07:00
7088653d33
max 13 min for kubeadm
2020-07-10 13:01:08 -07:00
6c702e1d29
add timeout for kubeadm init
2020-07-10 12:49:29 -07:00
87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
...
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
3d105ef98f
Download and DownloadProgress implemented
2020-07-10 12:31:08 -04:00
d29a9dca67
Add Download and DownloadProgress types implementations
2020-07-10 11:58:23 -04:00
7bc10bb308
Set cgroupDriver and clientCAFile (for 1.16+) via kubelet config
2020-07-09 15:21:26 -07:00
c483714cbc
Move kubelet params to config file
2020-07-09 15:21:25 -07:00
332c3bd14f
Add unit tests for Exists in extra_options.go
2020-07-09 15:17:00 -07:00
ca9040b42b
Merge pull request #8664 from tstromberg/none-timeout
...
none: Fix 'minikube delete' issues when the apiserver is down
2020-07-09 14:16:14 -07:00
d0d3973a13
restrict apparmor security opt to docker
2020-07-09 12:58:01 -07:00
0b3e2ae79b
none CNI: error if portmap plug-in is required but unavailable. Make testable
2020-07-08 14:30:48 -07:00
f8068d06f7
Merge branch 'master' into none-timeout
2020-07-08 13:48:34 -07:00
b9cd0caa7c
only out.T should be used to convert steps to JSON
2020-07-08 16:30:48 -04:00
6d95edda7b
remove empty test
2020-07-08 16:28:51 -04:00
b6f0829d7d
Merge pull request #8505 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
2020-07-08 14:53:51 -04:00
7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
...
A few cleanup
2020-07-08 14:52:28 -04:00
3e6ef0b37a
fix unit test
2020-07-08 11:10:47 -04:00
290f48f98e
Add Infof function to out package
2020-07-08 11:00:32 -04:00
1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
...
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
...
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
7df4075297
Don't propagate stopped as an error, so that 'delete' works on stopped none clusters
2020-07-07 15:23:26 -07:00
53ce804cff
retry.Local should respect the maxTime argument
2020-07-07 15:10:30 -07:00
f82d5c6bb2
Reduce apiserver health timeout from 8s to 5s
2020-07-07 15:10:05 -07:00
1980e066dd
fix lint and generate-docs
2020-07-07 15:57:07 -04:00
6367f71867
Make sure each step is unique
2020-07-07 15:39:47 -04:00
bd94872a10
add additional steps
2020-07-07 14:25:27 -04:00
ddecfd77e7
Include Ln as a Step
2020-07-07 13:24:53 -04:00
1ac2f6ddc0
cleanup
2020-07-07 13:19:33 -04:00
dd60fa85cc
Remove emojis from json output
2020-07-06 15:28:51 -04:00
f68716e2da
Set up logic for steps
2020-07-06 15:12:13 -04:00
10ba39cd3c
Add --output=json flag and hook it up to out package
2020-07-06 12:32:34 -04:00
515616d1aa
Add register of steps for 'minikube start'
2020-07-06 12:24:10 -04:00
b72b1239ba
Add function to print data in cloud events format
2020-07-06 12:23:59 -04:00
85a641177e
Resequence test cases for better readability.
2020-07-06 13:07:14 +01:00
2cf72f7ca8
Update profile name validation pattern. #8493
...
- prevents some incompatible characters from making their way into
profile names and causing DNS/hostnames issues
2020-07-05 12:16:31 +01:00
2660b92109
Update test coverage around ProfileNameValid func.
...
- preparing to update the ProfileNameValid func
- adding some more test cases to check against new profile name limits
2020-07-05 12:06:14 +01:00
a4b647f19b
Merge pull request #8629 from medyagh/sol_msg_docker_ssh_port
...
add solution message when container create is stuck
2020-07-01 13:41:21 -07:00
084df67df1
Merge pull request #8628 from sharifelgamal/del-on-failure
...
ensure deleting failed hosts if --delete-on-failure is specified
2020-07-01 13:40:43 -07:00
fd2912340a
improve wording
2020-07-01 13:33:51 -07:00
881ed1df1c
add link
2020-07-01 13:28:52 -07:00
4a321a6b1e
add solution message when docker container create is stuck
2020-07-01 13:26:56 -07:00
84eea2f487
recreate hosts on failed provisioning if delete-on-failure is specified
2020-07-01 12:57:59 -07:00
7564651d50
make docker driver highly prefered
2020-07-01 10:09:18 -07:00
4968ff5e75
Run gofmt on pkg/minikube/shell/shell.go
2020-06-30 19:19:44 +02:00
b0b3a1ac8c
Change indentation from gofmt to goimports
2020-06-30 19:12:11 +02:00
73fccf04f8
Update external-provisioner for storage provisioner
2020-06-30 18:31:06 +02:00
9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
...
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
2b5254cf91
Merge pull request #8598 from afbjorklund/modprobe-br_netfilter
...
Don't verify nf_conntrack for br_netfilter
2020-06-29 21:13:13 -07:00
28238150f5
ensure that 'crio' is used for k8s config
2020-06-29 19:52:30 -04:00
3bc3ce95de
refactor maybeExitWithAdvice
2020-06-29 14:38:37 -07:00
a9273beec7
Don't verify nf_conntrack for br_netfilter
...
We need to make sure that the br_netfilter kernel module
has been loaded, when using non-Docker container runtimes.
But the code was verifying the nf_conntrack kernel module
instead, so it could still cause the "not loaded" error.
[ERROR FileContent--proc-sys-net-bridge-bridge-nf-call-iptables]
2020-06-29 22:30:13 +02:00
08df5e2de3
add solution message if kbueadm is not executble on linux
2020-06-29 12:50:32 -07:00
9bcc587def
update crio to cri-o in docs and help text
2020-06-29 14:11:20 -04:00
5da2fdd922
enable graceful exit if container runtime is misspelled
2020-06-28 18:57:03 -04:00
e1f443e121
bsutil: add 'etcd' to the KubeadmExtraConfigOpts
2020-06-28 23:29:25 +03:00
83bb1e32d2
reoder extra-config consts
2020-06-28 22:51:29 +03:00
b470860a5a
fix condition check for extraOpts validation
2020-06-28 22:35:40 +03:00
ccffa40cfe
bsutil: extra-opts validation
2020-06-28 22:35:40 +03:00
d1ab5312d5
bsutil: list valid keys as slice instead of a map
2020-06-28 22:33:36 +03:00
79eaa8778a
bsutil: fix error msg for `--extra-config` parsing
2020-06-28 22:33:36 +03:00
eaeb5f6060
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
(cherry picked from commit d9fb2e05420c8f3526d1b1079ee129842ea5522c)
2020-06-28 16:46:54 +02:00
f23bbea995
Support more error messages for container inspect
...
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.
Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
51b4d2eb24
Normalize name of the container runtime param
2020-06-28 13:45:22 +02:00
b87a837f2e
Use the actual storage driver name for cri-o
2020-06-28 09:49:50 +02:00
42af47b909
Do not auto-set extra config that user wishes to override
2020-06-27 16:26:07 -07:00
cdc456a19b
Merge pull request #8570 from tstromberg/cni-split2
...
CNI: Update CRIO netconfig with matching subnet
2020-06-26 17:13:49 -07:00
e829341b9d
improve logging
2020-06-26 15:12:15 -07:00
64553e281b
revert debugging
2020-06-26 15:11:03 -07:00
742dcd6b00
add addon status verification for 3 addons
2020-06-26 15:08:38 -07:00
66421a6492
wait for ingress pod be running
2020-06-26 14:22:17 -07:00
52f4e130b5
lint
2020-06-26 13:20:31 -07:00
5fbf197b18
remove unrelated changes
2020-06-26 13:20:31 -07:00
96781c61a2
remove unrelated changes
2020-06-26 13:20:30 -07:00
058a732909
ingress addon validate deployment after enable
2020-06-26 13:20:30 -07:00
c47854b8fd
add validate ingress
2020-06-26 13:20:30 -07:00
a0c33f82c1
ingress addon wait for it
2020-06-26 13:20:30 -07:00
a1991e596d
Only use docker client for docker runtime
...
Previously _always_ asking the docker daemon
Including for other runtimes, such as podman
2020-06-26 22:12:43 +02:00
e8cebe0330
Merge pull request #8575 from afbjorklund/podman-dev
...
Support prerelease versions of podman binary
2020-06-26 12:49:50 -07:00
9d98e858a3
Support prerelease versions of podman binary
...
It was trying to parse the newline character
2020-06-26 21:37:44 +02:00
7c2cac612d
Fix bug in FailFastError and add unit test
...
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.
This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'
Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
ffcb14a6b2
Add support for Cilium CNI (--cni=cilium)
2020-06-26 11:55:30 -07:00
7d79241ea5
Merge pull request #8565 from priyawadhwa/update-alternatives
...
Check for iptables file before determining container is running
2020-06-26 11:29:52 -07:00
f901e638f2
Add support for Calico CNI (--cni=calico)
2020-06-26 11:21:15 -07:00
f192df8ec5
Update podman/crio CNI netconf files to match CNI subnet
2020-06-26 11:01:13 -07:00
7fb09bb63b
Merge pull request #8562 from tstromberg/patient-status
...
apiserverHealthz: wait up to 8s before declaring failure
2020-06-26 10:10:48 -07:00
ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
...
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
e32e2135ed
review comments
2020-06-25 19:39:59 -07:00
903686172d
Check for iptables file before determining container is running
2020-06-25 17:58:22 -07:00
0b53e9054a
Merge pull request #8541 from medyagh/modprob_overlay
...
docker driver on linux: Give warning if overlay module is not enabled
2020-06-25 15:39:39 -07:00
Dean Coakley
Anders F Björklund
dddddai
priyawadhwa
Medya Ghazizadeh
Sharif Elgamal
Medya Gh
Jose Donizetti
Thomas Stromberg
Lu Fengqi
Marcin Niemira
Prasad Katti
James Lucktaylor
Johannes M. Scheuermann
Sunny Beatteay
Ilya Danilkin