7619a5075a
fix logging
2020-03-23 21:01:12 -07:00
36f3f657af
force stop if cant stop for none
2020-03-23 21:01:12 -07:00
545348341a
for none let it stop all containers
2020-03-23 21:01:12 -07:00
47c8e9c87b
dont return on error kic sto
2020-03-23 21:01:12 -07:00
5f90a319bd
stop k8s in kic and none
2020-03-23 21:01:12 -07:00
fae3e34319
add stop force stop
2020-03-23 20:59:21 -07:00
298be78e5f
remove duplicate code
2020-03-23 20:59:21 -07:00
beec3b1ce1
stop kubelet on docker stop
2020-03-23 20:59:21 -07:00
abf35cfbc1
Upgrade podman and add libglib2.0-0 to kicbase image
...
The `TestOffline/group/crio` integration test was failing with the error:
```
crio load image: sudo podman load -i /var/lib/minikube/images/storage-provisioner_v1.8.1: exit status 125
```
I tried SSH'ing into minikube and running the command myself, and got the error:
```
Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version
```
I then tried updating conmon, but got the error:
```
conmon: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
```
I then tried adding the libglib2.0-0 library to the kic base image and upgrading podman, which seems to have resolved the issue.
2020-03-23 17:41:06 -07:00
bfe8aee3b5
Pass in container runtime to preload tarball name
...
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
0e5974367f
rebased on master'
2020-03-23 10:59:02 -07:00
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
89c6c72adb
Skip preload if not running on amd64
...
Also make sure that preload is available before attempting to run preload.
2020-03-13 16:24:28 -07:00
895967235a
Improve error message output
2020-03-13 16:18:14 -07:00
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
70c9304724
code review comments
2020-03-13 10:37:29 -07:00
99ba89c2dd
ip
2020-03-12 16:01:49 -07:00
084da0c46a
fix maybe
2020-03-12 15:31:38 -07:00
43ce409e79
Extra debugging for preload generation process
2020-03-11 13:09:55 -07:00
b5681d52c5
lint
2020-03-10 18:45:56 -07:00
9ff0dc0ebc
pass api server port to kic create container
2020-03-10 18:33:59 -07:00
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
cb14468b44
english
2020-03-06 15:11:42 -08:00
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
6f46393123
Remove blank line
2020-03-06 12:15:58 -08:00
120dce7b56
Remove extraneous calls to oci.PointToHostDockerDaemon
2020-03-06 12:13:51 -08:00
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
1c37fc5505
lint
2020-03-05 22:45:38 -08:00
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
2a37317a72
improve comment
2020-03-05 22:34:10 -08:00
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
1f7ae5b35b
Merge to master
2020-03-05 09:57:46 -08:00
a1ebcbd031
Merge conflicts
2020-03-04 18:01:41 -08:00
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
a3e000d850
addressing comments
2020-03-04 14:09:15 -08:00
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00
db5903d3ed
lint
2020-03-04 10:40:32 -08:00
54df61d677
point to host daemon more places
2020-03-04 10:37:10 -08:00
6a62046e62
add warning and point to right docker
2020-03-04 10:22:20 -08:00
28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-03 12:16:47 -08:00
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
05a46f6526
remove unnecessary PreloadedVolume
2020-03-02 16:17:35 -08:00
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
481010d8dc
added overlay2 to preloaded images tarball name
2020-03-02 14:10:41 -08:00
d6e94c1ee4
remove unused functions
2020-03-02 13:54:35 -08:00
474561d082
remove unused functions
2020-03-02 13:48:18 -08:00
697359b4f3
Fixed lint
2020-03-02 13:37:22 -08:00
6b0e942e7e
Rebased on master
2020-03-02 13:33:27 -08:00
3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
...
warn about "stuck docker" in minikube delete
2020-02-26 14:32:18 -08:00
8d0c41392b
continue instead of nest
2020-02-26 13:50:42 -08:00
4709af55df
resolve review comments
2020-02-26 12:44:25 -08:00
e8c85543f7
limit time waiting for delete
2020-02-26 10:57:46 -08:00
6651e0b5a5
docker podman sysinfo
2020-02-26 09:15:25 -08:00
f3c171eaa3
show info for docker damemon
2020-02-25 17:34:03 -08:00
e60b034c84
Add Daemon Info func to oci
2020-02-25 17:16:49 -08:00
aefbf2cd18
Rebased on master
2020-02-24 13:41:06 -08:00
5f8740a15e
update kic sha
2020-02-22 15:41:12 -08:00
988a1b983a
fix sha format
2020-02-22 14:23:43 -08:00
73c4c4c323
bump kic version to 7
2020-02-22 14:07:43 -08:00
95402af363
bump kic version
2020-02-22 13:51:42 -08:00
9b91ef7590
Add CIO-o runtime to kic drivers and improve kic image
2020-02-22 13:46:17 -08:00
fa9f7f9794
Add comments to avoid warnings from go lint
2020-02-22 16:12:42 +01:00
97bf128703
only use preloaded volumes for docker runtime
2020-02-21 12:53:24 -08:00
328466f1e1
Check if preloaded volume is attached before skipping binary transfer
2020-02-21 12:41:33 -08:00
cc1a6f11f0
Delete volume if it isn't extracted properly so future runs don't try to use it
2020-02-21 12:13:34 -08:00
c99bf76ee4
Add checksum verification
2020-02-21 12:03:31 -08:00
4201bbcfe3
Address one simple linter error
2020-02-21 14:55:22 +11:00
86df9ffb2c
Rebased on master
2020-02-20 16:20:54 -08:00
dcbf242192
Add SHA as constant
2020-02-20 15:56:00 -08:00
94737b4a14
Add lz4 to kic base image and upgrade to v0.0.6
2020-02-20 15:53:09 -08:00
55dd40efc5
Debugging
2020-02-20 15:05:07 -08:00
5ac8520ab8
skip transferring binaries and transferring imagse if using preloaded volume
2020-02-20 14:59:43 -08:00
b0f685c072
Move all preloading code into preload package
2020-02-20 14:43:24 -08:00
7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
...
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
19fa296625
Compress with lz4
2020-02-20 14:07:03 -08:00
0e88697f16
Delete container once it has finished executing
2020-02-20 10:06:15 -08:00
055e4bb618
Add run to docker command
2020-02-20 09:57:19 -08:00
335637f4a3
Name tarball by k8s version name
2020-02-20 09:42:04 -08:00
b8bc461157
Rebased on master
2020-02-20 09:18:12 -08:00
30a38e5a9d
wrap error
2020-02-20 00:07:36 -08:00
4fe9ca5f05
break done delete and prune into two funcs better error handling
2020-02-20 00:07:36 -08:00
e1ffa5fb0f
return error instead of logging
2020-02-20 00:07:36 -08:00
354ff6256d
improve comments
2020-02-20 00:07:36 -08:00
6c94880149
dont list empty ones
2020-02-20 00:07:36 -08:00
d84aa9f447
lint
2020-02-20 00:07:36 -08:00
b1d139c24b
code review comments
2020-02-20 00:07:35 -08:00
efd4aabde4
clean up containers first then delete volume
2020-02-20 00:07:35 -08:00
b235255196
fix volume clean up
2020-02-20 00:07:35 -08:00
bb11bc666b
Create volume of preloaded images and mount it in
2020-02-19 23:02:36 -08:00
597798395f
lint
2020-02-19 22:01:45 -08:00
3a7041c3b2
add logging
2020-02-19 22:01:45 -08:00
d548eabdc6
added kic mount
2020-02-19 22:01:45 -08:00
1ee08c7517
add funcs to get routable host ip from inside container
2020-02-19 22:01:45 -08:00
d506aa18b4
Download preloaded images tarball with --download-only flag
2020-02-19 21:53:44 -08:00
1da0a370ff
code review comments
2020-02-17 10:55:53 -08:00
3ce0164281
add logging for prune
2020-02-16 11:54:56 -08:00
a007c0790c
Delete volumes created by kic
2020-02-14 01:39:16 -08:00
a4ee4186bd
create docker volumes explictily with a label
2020-02-14 01:01:53 -08:00
4c6b435f68
revert docker volume host path ( #6616 )
2020-02-13 10:57:23 -07:00
398c7ef00b
Add podman driver ( #6515 )
2020-02-12 19:11:44 -07:00
97f926eeb1
Use vmpath constants where possible
2020-02-07 13:06:00 -08:00
4b9d15a34c
point to host docker
2020-02-04 16:09:43 -08:00
c86b20ade2
add option to exec runner to point to host docker daemon
2020-02-04 15:33:04 -08:00
6c95a28c10
remove default crictl setting
2020-02-03 23:25:55 -08:00
e231e7ae96
rever dockefile changes
2020-02-03 22:32:08 -08:00
a2f2df9f81
add options to docker service for kic
2020-02-03 20:21:41 -08:00
901cb520b9
Merge pull request #6452 from tstromberg/none-paused
...
Fix none driver bugs with "pause"
2020-02-03 16:16:34 -08:00
3dd5495d2f
trim kic base image ( #6478 )
2020-02-03 16:31:52 -07:00
4124fbdb69
Consider a paused apiserver to be controlled by a running host
2020-02-03 14:20:57 -08:00
1176aa468f
More status logging
2020-01-31 19:00:59 -08:00
cee9448fa0
Make none.GetState more intelligent to fix stop issues
2020-01-31 18:54:27 -08:00
7f0e83508a
Add more logging
2020-01-31 18:44:00 -08:00
dd4ad10b83
Improve handling of paused none clusters.
2020-01-31 16:23:25 -08:00
0e5059ddd0
log warning if docker is stuck
2020-01-30 21:36:56 -08:00
a6ec05e35a
unexport noderolekey
2020-01-30 21:05:51 -08:00
968fe86869
unexport more funcs
2020-01-30 21:01:27 -08:00
006c781fbc
remove unused kic code
2020-01-30 20:44:32 -08:00
23e125649d
rename createConfig
2020-01-30 18:13:11 -08:00
b20322a8c2
rename funcs
2020-01-30 18:12:04 -08:00
5b055d7ff8
add comment
2020-01-30 16:57:53 -08:00
58b637b05f
delete all cleans up stale kic profiles
2020-01-30 16:42:14 -08:00
8e0ffdf1cf
resolve conflict
2020-01-30 16:20:55 -08:00
4bf3fc422a
Add docker run-time for kic driver ( #6436 )
...
* Add docker container run time for kic
2020-01-30 14:30:04 -08:00
b3404a70e6
patch node refactor for kic
2020-01-24 19:03:50 -08:00
82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
...
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
ba3965b076
specify SSH username
2020-01-24 14:42:28 -08:00
83dd9fc4ff
Bump kic base image for ssh
2020-01-24 14:20:49 -08:00
c6c0046c57
let docker/podman choose hostbind port
2020-01-24 14:15:48 -08:00
35f1e58583
Merge conflict
2020-01-24 10:40:26 -08:00
2bd169f508
add config fields for kic SSH and API ports
2020-01-23 23:51:41 -08:00
ca0f4c7e20
generate ssh keys for kic container
2020-01-23 19:20:44 -08:00
09d9d05c6b
generate ssh certs for kic during creation
2020-01-23 18:43:26 -08:00
3d5c9ae870
implement SSHPortName for kic
2020-01-23 18:28:32 -08:00
1e05b11703
Add ssh to kic image
2020-01-23 18:24:51 -08:00
773510b9c1
Add ssh to kic container image
2020-01-23 17:45:50 -08:00
5191659ff2
bind ip use const instead of string
2020-01-23 17:28:30 -08:00
b81960e37c
Fix none driver
2020-01-22 14:28:18 -08:00
c83ee09417
Update Kubernetes libraries to v1.17.2
2020-01-22 14:10:53 -08:00
5f0420f72e
Merge branch 'master' into pause
2020-01-22 09:48:26 -08:00
7e2e9eb15b
Merge conflicts
2020-01-21 20:00:21 -08:00
5a3c13815e
network overlay only for kic
2020-01-21 15:14:51 -08:00
19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
...
Experimental verison of kic
2020-01-10 00:42:01 -08:00
40a011c49a
use api port for host binding port
2020-01-08 16:09:24 -08:00
cf9e6e512f
fix ineffectual assignment
2020-01-08 15:21:57 -08:00
de0d603c7f
convert base image to a const
2020-01-08 13:56:23 -08:00
ddf5ab027a
add extra option fail swap for kic
2020-01-08 12:53:29 -08:00
6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
...
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
7e0b89cc9d
code optimization
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
f80572bb4c
code review
2020-01-07 13:59:41 -08:00
77394db9aa
add Dockerfile for kic images
2020-01-07 13:54:00 -08:00
a64a2721d5
Add localhost to ca cert
2020-01-07 13:54:00 -08:00
e9b7451278
auto set podsubnet for kic improve none auto set
2020-01-07 13:54:00 -08:00
c7bc61af2c
Add overlay network for kic
2020-01-07 13:54:00 -08:00
6cf2554877
add flag for kic host binding port
2020-01-07 13:54:00 -08:00
ac97b51058
implement setup certs for kicbs
2020-01-07 13:52:47 -08:00
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
c1859c44e3
kic/oci: parse all kind of states
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
...
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
9c4e3fbd3c
pkg/drivers/kic: fix wrong command in Unpause
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
ae61e56594
pkg/drivers/kic/oci: fix Status info
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
aa52255be0
pkg/drivers/kic/oci: delete TODO info
...
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜ minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜ minikube git:(oci-remove-todo) ✗ echo $?
125
So delete this TODO info.
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
f39ba0deb0
add unit test for feature gate supports
2019-12-20 01:17:33 -08:00
cce503033d
rename CreateParam to CreateConfig
2019-12-19 11:12:49 -08:00
e1d5704170
get rid of default oci
2019-12-19 11:08:05 -08:00
6cbdfe3961
remove more codefrom node
2019-12-19 10:47:07 -08:00
310cef80de
get rid of node cache
2019-12-19 10:37:15 -08:00
f001dd703a
convert kic restart to case switch
2019-12-19 10:01:18 -08:00
80b15e8e6c
Add comment for config structs
2019-12-19 09:52:53 -08:00
19560a631b
Add kic specific machine creation message
2019-12-18 15:53:34 -08:00
2243847f98
add kic command runner to machine
2019-12-18 13:57:32 -08:00
c627f58fbb
add default image
2019-12-18 13:04:09 -08:00
71b260292c
remove more code
2019-12-17 21:53:36 -08:00
12df013810
simplify overlaping structs
2019-12-17 21:36:37 -08:00
ca68beae6a
remove not needed code
2019-12-17 19:33:54 -08:00
7a433cc6a9
Add kic specifc fields to machine config
2019-12-17 17:47:37 -08:00
379bf2ac0c
fix boilerplate formats
2019-12-17 16:38:56 -08:00
46df68ca4b
move cri to oci package
2019-12-17 16:04:03 -08:00
d7273d36c9
Add kic driver
2019-12-17 15:18:31 -08:00
337db1707d
First pass at multi-runtime pause/unpause
2019-11-22 15:11:51 -08:00
773c525ae7
fix test and remove extra code
2019-10-29 16:36:10 -07:00
cd9e413852
resolve code review
2019-10-29 14:11:21 -07:00
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
792de2b0a1
resolve code review
2019-10-25 17:12:55 -07:00
187dfe29f8
getting rid of some of bin bash -c
2019-10-24 14:13:51 -07:00
05bbcf733a
remove uneeded wrap output
2019-10-21 15:18:04 -07:00
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
6533d9f2e8
Rename methods to match the convention
2019-10-20 19:11:31 +05:30
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
fcf17fb42f
bin bash all the way
2019-10-10 09:23:26 -07:00
25e3d870e5
fixing with shelquote
2019-10-08 17:08:38 -07:00
91618aa38b
get rid of ExecCmd all the way
2019-10-08 15:13:54 -07:00
b8181a081f
move more to exec.Cmd2
2019-10-08 11:39:10 -07:00
8fcdae926e
refactor
2019-10-06 22:06:29 -07:00
7709c77c8b
fix formatting
2019-10-06 17:07:54 -07:00
36de216aa6
fixing fake_runner for interface
2019-10-04 12:51:18 -07:00
668146d102
Move guest constants to vmpath package #5375
2019-09-27 07:59:46 +09:00
67c7a7a81c
Reduce cyclometric complexity by refactoring
...
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
19f3533c93
Use find instead of syscall_t because Go
2019-09-18 14:24:18 -07:00
197039c23d
Fix tests
2019-09-18 13:46:10 -07:00
c0874e2a7e
Add --interactive flag support
2019-09-18 13:18:15 -07:00
4135b6fce0
Improve visibility of sudo commands
2019-09-17 17:55:10 -07:00
5ce4ca0a1b
Merge branch 'driver-dl' of github.com:tstromberg/minikube into driver-dl
2019-09-16 20:20:42 -07:00
6142969467
Add version argument to download to prevent v0.0.0 download error
2019-09-16 20:20:16 -07:00
f97b2c5462
Merge branch 'master' into driver-dl
2019-09-16 19:15:41 -07:00
ae500729fc
Include URL in log message
2019-09-16 19:10:23 -07:00
c4a4f53b45
Download version appropriate driver, add sha256 checksum check
2019-09-16 15:38:58 -07:00
2aacc68549
Add colon, more appropriate emoji selection to driver download
2019-09-16 14:55:56 -07:00
fb43666d7d
Add installOrUpdate hyperkit support
2019-09-14 00:37:08 -03:00
c434797f59
Remove debug logs
2019-09-11 11:34:29 -03:00
219109c98e
Add log lines to debug test
2019-09-11 11:34:29 -03:00
85778d36a4
Remove deggubing information
2019-09-11 11:34:29 -03:00
e30fe10737
Add debugging information
2019-09-11 11:34:29 -03:00
0cf4921c14
Add drivers.InstallOrUpdate acceptance tests
2019-09-11 11:34:29 -03:00
30e75c3c39
Download kvm2 driver
2019-09-11 11:34:29 -03:00
48d2ace5cc
Remove broken default disk size test that didn't make sense
2019-08-22 11:41:41 -07:00
45c3219470
none reliability: --force does not work in v1.10, allow failed kubelet
2019-08-21 17:31:39 -07:00
282dcc9503
Merge branch 'master' into persistent
2019-08-16 16:38:56 -07:00
84242bf2c1
cleanup: fix words in logging message
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-15 20:53:28 +08:00
b983c47145
Merge branch 'master' into persistent
2019-08-14 08:12:25 -07:00
f17f3408a8
convert all RetryAfter to retry.Expo
2019-08-13 23:48:30 -07:00
e8824b76b2
Merge pull request #5052 from tstromberg/doc-redirect
...
Update code references to new documentation URL's
2019-08-12 18:26:01 -07:00
f2acb4a33e
Update code references to new documentation URL's
2019-08-12 14:51:41 -07:00
a817bffab1
Remove all minikube dependencies from drivers ( #4933 )
...
* Remove all minikube dependencies in driver code
* removing all default config
* okay we need some defaults
* code comments
* hyperkit builds now
* sleep for an appropriate amount of time
* remove constant in favor of string
* try goproxy for travis
* try goproxy for travis
* try goproxy for travis
* let's not try goproxy for now
* let's try goproxy once again
* maybe use the correct url for the proxy
* fix go mod
2019-08-12 14:42:11 -07:00
2f1a11d8d3
Move reusable files (images, binaries, certs) to /data
2019-08-09 15:04:07 -07:00
fdc3b39e49
lower case errors
2019-08-01 13:52:46 -07:00
1c8a655154
make none stop work on old systemd
2019-08-01 13:52:16 -07:00
c603300781
more reliable stop for none driver ( #4871 )
...
* more reliable stop for none driver
* print stop error
* better error logging
* misspell
* error formatting
* Passing lint interfacer nag
2019-07-25 13:19:21 -07:00
82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
...
Add space after // comments
2019-07-11 11:53:15 -07:00
c5f695e8a0
Better comment syntax
2019-07-05 11:17:10 +08:00
99ac1a81e7
moving command runner to its own package
2019-07-04 16:31:07 -07:00
2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
...
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
...
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
4d00a093d1
Fix error naming convention
2019-06-29 11:28:54 -03:00
23ae121f2b
kvm2: simplify connection error message
2019-06-29 10:53:13 -03:00
4812761f05
Add gitCommitID to hyperkit version
2019-06-29 09:32:21 -03:00
931a0a557b
Add hyperkit version
2019-06-29 09:22:51 -03:00
7fe2247692
Improve hyperkit vm stop
2019-06-28 16:36:36 -07:00
9dfe660c64
Add support to custom qemu uri on kvm2 driver
2019-06-28 14:12:58 -07:00
8acf4824df
Add commit id to docker-machine-driver-kvm2 version
2019-06-28 13:45:54 -07:00
6222e74267
Add hyperkit doc
2019-06-28 13:44:15 -07:00
d6a839b20a
Fix kvm2 vm driver remove domain
2019-06-26 18:36:52 -07:00
380883dee3
Fix failing Hyperkit test
2019-06-26 01:45:12 +05:30
6ba1725c08
Added Memory Size Checking
2019-06-26 00:22:41 +05:30
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
f20f223c02
Decrease cyclomatic complexity
...
Here is the report (from gocyclo), before:
21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
02b8032b59
Merge pull request #4385 from josedonizetti/refactor-drivers-restart
...
Refactor: improve readability drivers.Restart
2019-06-21 08:07:35 +08:00
4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
...
Add kvm2 --version
2019-06-20 07:41:18 +08:00
a2d844ef51
Add kvm network name validation
...
closes for #3581
2019-06-15 13:56:12 -07:00
a024c6d22a
Add kvm2 --version
2019-06-04 16:45:14 -03:00
6d57b28fdd
changing string driver name to checked type
2019-06-03 20:27:26 -07:00
0e633533c2
Refactor: improve readability drivers.Restart
2019-05-30 17:24:28 -03:00
986c61d15e
Fix kvm gpu log
2019-05-30 14:56:46 -03:00
dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
...
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
...
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
c09913070d
Fix kvm remove when domain is not defined
2019-05-25 09:23:40 -03:00
8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
...
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
...
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
48237d95b8
Clean up kvm Remove code
2019-05-24 14:27:55 -03:00
b65c7403cf
Add error warp to destroyRunningDomain
2019-05-24 14:27:55 -03:00
3124f11e1b
Fix kvm remove when domain is not running
2019-05-24 14:27:55 -03:00
81f0d9ba37
Fix kvm remove warn message
2019-05-24 12:38:00 -03:00
1852a72caf
Refactor kvm lookupIPFromStatusFile
2019-05-23 15:38:02 -03:00
fc2e2e52c5
Skip kvm network deletion if private network doesn't exist
2019-05-23 06:17:12 -03:00
93329f1619
Remove obsolete comment
2019-05-22 17:25:27 -03:00
e3bf4bd7ec
Fix kvm ensureNetwork
2019-05-22 16:19:09 -03:00
e9a450df66
Validate kvm network exists
2019-05-21 16:19:15 -03:00
e53c0339ea
This is my testament to Chesterton's Fence
2019-05-15 11:44:16 -07:00
88f34bd0e3
Pass up better error messages
2019-05-15 10:25:34 -07:00
340c8faced
Remove crazy recursive permissions check that was chowning /home
2019-05-15 10:17:44 -07:00
f8c5fad437
Mark as darwin only, to match network.go
2019-05-14 09:05:34 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
df5bbc3c8a
Fix minikube logs for other container runtimes
...
It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.
Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
2019-03-01 20:56:45 +01:00
cd156b3f98
Merge branch 'master' into container-killing2
2019-02-15 09:10:19 -08:00
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
c3db098d4a
ListContainers should return empty list when no containers match
2019-02-14 16:10:33 -08:00
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
ba9492c314
Merge branch 'master' into hyperkit-debugging
2019-02-14 14:03:52 -08:00
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
473f5983cb
Allow driver name to be com.docker.hyper, as seen in integration testing
2019-02-13 13:36:45 -08:00
4b875ddd7f
Run goimports
2019-02-13 13:35:28 -08:00
2045dc9ba4
Lint cleanup
2019-02-13 13:35:08 -08:00
5f65dc80fa
Remove error uploads, consolidate fatal error handling into exit package
2019-02-13 12:37:44 -08:00
888978c3a9
Improve VM re-use reliability: detect crashing and/or badly installed hyperkit
2019-02-12 13:58:18 -08:00
f346e5628b
Add logging around the DHCP discovery process
2019-02-12 13:57:02 -08:00
d57d8d1a1e
Fix broken tests: hyperkit driver format mismatch, console spacing mismatch
2019-02-08 13:58:02 -08:00
9f09f02e39
Address PR comments, make sure PullImages code path is exercised
2019-02-07 15:39:31 -08:00
966b245dc6
Refactor and centralize container runtime code into a cruntime package
2019-02-05 14:42:12 -08:00
17c0244cf7
reverting unnecessary change
2019-01-28 17:28:57 -08:00
5af2f1eafc
formatting / removed extra comment
2019-01-28 13:47:24 -08:00
f70e6a0385
fixing review remarks
2019-01-28 13:42:43 -08:00
933356e477
lint
2019-01-25 17:20:57 -08:00
9b97a85a8f
fix stale hyperkit.pid making minikube start hang
2019-01-25 17:08:31 -08:00
0687fea66a
Added defaultDiskSize setup to hyperkit driver
...
fmt fix
2019-01-14 17:04:07 +02:00
7ba01b40a9
Hide KVM signature
2018-12-15 21:47:41 +11:00
57f4d9247e
Only require docker for the docker runtime ( #3303 )
...
Closes #3295
2018-11-27 14:15:08 -08:00
3706b3b8ac
Fix dangling format issues.
2018-09-28 16:48:37 -07:00
055c8002b1
Replace %s format directives with %v for errors.
...
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
5d0e12327a
turning error into a warning log message
2018-09-26 13:53:57 -07:00
4eb2cdb120
inlining deleteNetwork into if statement
2018-09-24 14:04:01 -07:00
5e38bf4819
kvm2 driver: fixed documentation link in error text
2018-09-21 10:28:52 -07:00
34ee59192b
kvm2 driver: be more robust with creating of the network, don't delete the network if it is in use
2018-09-21 10:28:47 -07:00
b35e908dec
kvm2 driver: generate separate random MACs for default and private network NICs
2018-09-21 10:28:43 -07:00
c4ef7ad197
kvm2 driver: separated activating and creating of networks
2018-09-21 10:28:37 -07:00
d1995d24f0
kvm2 driver: fixed private network creation and setup
2018-09-21 10:28:33 -07:00
22ab50aa7e
Correct typo in the returned message
...
coundn't->couldn't
2018-09-04 05:49:04 -05:00
232080ae0c
Remove some more vendored k8s.
2018-07-26 08:23:21 -07:00
a4606583e4
remove all localkube references from code, change /var/lib/localkube to /var/lib/minikube
2018-07-24 12:36:42 -07:00
23fc22e532
Fix docs for kvm2
2018-07-23 09:02:33 -07:00
87d7a3208a
Update KVM driver installation instructions.
...
Move the latest instructions out of the comments and move old instructions into the comments.
2018-07-20 07:57:14 -07:00
268c932240
Add GPU support to minikube.
2018-07-08 22:25:48 -07:00
05161c1b18
Fixes https://github.com/kubernetes/minikube/issues/2274
2018-07-04 09:26:50 -07:00
0df67ee4af
Changes to make 'virsh console minikube' work.
2018-06-11 08:45:59 -07:00
ee73cbde6b
Added hyperkit options for enterprise VPN support
...
The purpose of these changes is to enhance Hyperkit support from the
minikube command line for better integration with enterprise networks
behind a VPN.
uuid: Provide VM UUID to restore MAC address (only supported with
Hyperkit driver).
vpnkitSock: Location of the VPNKit socket used for networking. If empty,
disables Hyperkit VPNKitSock, if 'auto' uses Docker for Mac
VPNKit connection, otherwise uses the specified VSock."
vsockPorts: List of guest VSock ports that should be exposed as sockets
on the host (Only supported on with hyperkit now).
Note:
tests pass but file:
`vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go`
has to be edited to correct an issue - not committed since this is in
the vendor directory.
2018-06-04 09:46:20 -07:00
8c6afecc88
Move the etc data directory to data/minikube to make cleanup safer.
2018-05-17 13:27:19 -07:00
b54950fb2b
Start the default network for the kvm2 driver.
2018-05-11 13:07:19 -07:00
6bb278a958
Typo fix: priviledges->privileges
...
priviledges->privileges
2018-05-03 12:06:25 +02:00
9ad5b4a190
Disable dnsmasq on minikube-net network for kvm driver
2018-04-20 07:40:43 -07:00
cc356e63c4
Miscellaneous none driver fixes.
2018-04-04 13:58:50 -07:00
ee58133538
kvm2: Switch to CPU passthrough mode by default
...
With passthrough mode we can enable KVM nesting for guests.
Fixes #2553
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
b08b8ab8ae
Revert "kvm: Passthrough host CPU in order to allow nesting"
...
This reverts commit 7a4babe1d6
2018-02-22 10:42:20 -08:00
3ddf9d65f6
kvm: Passthrough host CPU in order to allow nesting
...
Before this patch the virtual CPU was the stock qemu CPU, in the sense that
the virtual CPU features were set according to the default qemu CPU.
With this change the CPU features of the host will be copied at start to the
domain definition. This includes features like svm and vmx, which in turn allow
to run nested virtualization if the host is configured accordingly i.e.
`kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`.
To turn on nesting, a user has to specify `--kvm-cpu-model host-model` when
creating the VM.
Resolves #2553
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
23d9fde284
Fix none driver stop commands.
2018-02-15 11:51:37 -08:00
cebd704bd7
Issue #2416 : Added UUID to hyperkit driver section in minikube configuration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.
2018-01-11 09:41:35 -08:00
bc55b8b8be
Cleanup NFS Exports after stop and delete
2018-01-03 10:21:04 -08:00
59274b22da
Code review feedback.
2018-01-02 16:18:54 -08:00
e3f3727b4d
Move GetNetAddr.
...
The build constraints in vmnet.go cause issues.
2018-01-02 16:18:54 -08:00
7d9413ccd1
remove the hyperkit prefix so we can move this to other drivers as well with time and fix vendoring issue
2018-01-02 16:18:54 -08:00
e1903b7423
support NFS sharing with the hyperkit driver
2018-01-02 16:18:54 -08:00
5df299c7e9
Make other lifecycle commands work.
2018-01-02 12:01:37 -08:00
fcdd1404e8
Use the real GetIP function.
2018-01-02 12:01:37 -08:00
4077763003
Make none driver work with kubeadm
2018-01-02 12:01:37 -08:00
8f91c37bba
Properly support the "minikube-net" network.
2017-12-13 21:18:00 -08:00
56608e418d
kvm2: Set group executable bit on machine-specific directory and up
...
Ensure that the directories leading to the KVM image have enough
permission for libvirt/QEMU to traverse, especially in the case where
libvirt/QEMU group is set to to `kvm`/`users`.
2017-12-10 17:49:54 -08:00
fdf906cf3b
Add an error message when running hyperkit without permissions.
2017-11-26 17:31:01 -08:00
bc20281f1e
Update hyperkit go driver.
2017-11-20 11:52:20 -05:00
9fc8eed51d
Merge pull request #2076 from r2d4/kvm-mac
...
Use mac instead of hostname to find IP
2017-11-01 08:40:55 -07:00
2c2c45d7a6
DOM_SHUTDOWN should return state.Running
...
Technically, DOMAIN_SHUTDOWN just means that the VM is in the process
of shutting down. We should still return state.Running so that we
don't return from `minikube stop` before the domain is actually
stopped. This should fix a few flakes.
2017-10-23 11:23:58 -07:00
ea31492976
use consistent path for localkube.service
...
/usr/lib/systemd/system is not consistent across different distribution
/etc/systemd/system should be used.
See issue: #2098
2017-10-20 14:09:03 -07:00
a19f90fd91
import erorr
2017-10-19 16:23:47 -04:00
02f0d41c1d
Split out hyperkit into CGO needed stub
...
This allows us to use the hyperkit Driver struct in minikube, without
needing CGO_ENABLED=1. For the hyperkit driver binary, the
CGO_ENABLED=1 function will work.
2017-10-19 16:07:38 -04:00
b7012aefcc
Use mac instead of hostname to find IP
2017-10-19 09:16:24 -07:00
c6d2e491a3
Merge pull request #1774 from aaron-prindle/none-docker-rm-kill
...
Added command to remove and kill all kubernetes containers from docke…
2017-10-04 11:30:57 -07:00
10e6e6ade1
added cleanup for docker containers in none driver
2017-10-02 11:48:35 -07:00
547d22f638
Clean up unused files, add tar rules
2017-09-19 15:45:18 -07:00
ebbc34d2ba
Move drivers to pkg/drivers, share utils
...
Share most of the disk image setup between hyperkit and kvm drivers.
Move and remove a lot of shared configuration between all the in-tree
drivers: kvm, hyperkit, none.
2017-09-12 14:29:22 -07:00
53341aa30d
golint, go vet, etc. changes
2017-09-11 14:17:58 -07:00
48b165808c
Bring KVM driver in-tree
...
Add boilerplate
Review feedback
2017-08-28 11:52:35 -07:00
Medya Gh
Priya Wadhwa
vikkyomkar
Thomas Stromberg
Sharif Elgamal
Medya Ghazizadeh
Anders F Björklund
sayboras
Zhou Hao
cueo
u5surf
Jose Donizetti
Guangming Wang
Kyle Bai
Jituri, Pranav
balopat
bpopovschi
Alasdair Tran
Marcus Heese
AdamDang
dlorenc
Aaron Prindle
dlorenc
Rohit Agarwal
Luke Weber
seborama
Viktor Safronov
Fabian Deutsch
basp
Hugues Alary
Mohit Gupta
Matt Rickard
Zak B. Elep
Matt Rickard
Yisui Hu