kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
13,057 Commits
11 Branches
151 Tags
492 MiB
Commit Graph

90 Commits (0a0a47c2ba901b6f860a5c58a99b745f44301f90)

Author SHA1 Message Date
Daehyeok Mun 36d94a2d88 Migrate MachineName function. 
Migrate MachineName function from driver package to config package.
 2021-01-08 11:26:10 -08:00
Jituri, Pranav 0ae11fd5c8
fix linting error 2020-12-15 18:22:36 +05:30
Jituri, Pranav 6bbc5f986b
Enable Ingress Addon for Docker Windows 2020-11-21 16:01:06 +05:30
Evgeny Shmarnev db93039f9c Addressing comments 2020-11-12 13:45:33 +01:00
Thomas Stromberg e2fdc077f8 Use 6 minutes, to use the philosophy of doubling timeouts you hit 2020-10-21 09:54:01 -07:00
Thomas Stromberg 20d1645ce7 Wait up to 5 minutes for addon pods, improve error message 2020-10-21 09:44:39 -07:00
Priya Modali 8936a8c7f8 Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-13 09:08:27 -07:00
Sharif Elgamal b04610ef9b simplify addon code by fixing gcp-auth failure policy 2020-10-06 16:14:44 -07:00
Priya Modali 43ea47f4e0 Fixed merge conflicts. 2020-09-29 16:17:31 -07:00
Priya Modali 97d96bf925 Switching from glob library to klog library. 2020-09-29 15:49:41 -07:00
Sharif Elgamal ff051f9a33
Make sure gcp-auth addon can be enabled on startup (#9318) 
* fix documentation for gcp-auth addon

* make sure kube-system pods are up before enabling gcp-auth

* fix lint

* add failurePolicy for webhook

* only install addons if asked

* better comment

* slightly less hacky code

* defer addons properly

* simplify code for performance
 2020-09-29 13:29:14 -07:00
Thomas Strömberg fba4de74cf
Merge pull request #8787 from saltbo/master 
fix error usage for the WaitGroup in the pkg addons
 2020-09-01 16:21:51 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
Dean Coakley 9c23485dfb Remove list of alternative drivers 2020-07-29 09:40:43 +01:00
Dean Coakley 4b2974472d Improve error message text 2020-07-28 22:40:55 +01:00
Dean Coakley b27440d4ae Add warning for ingress addon with driver of none 2020-07-28 22:40:15 +01:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started 
(Addons) Create a new command in every retry
 2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682) 
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
 2020-07-21 14:25:58 -07:00
Shubham f42f79e56d (Addons) Create a new command in every retry 
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
 2020-07-21 21:20:24 +05:30
Ambor e00cf6c1e1 fix error usage for the WaitGroup in the pkg addons 2020-07-21 11:57:06 +08:00
Priya Wadhwa bd94872a10 add additional steps 2020-07-07 14:25:27 -04:00
Medya Gh e829341b9d improve logging 2020-06-26 15:12:15 -07:00
Medya Gh 64553e281b revert debugging 2020-06-26 15:11:03 -07:00
Medya Gh 742dcd6b00 add addon status verification for 3 addons 2020-06-26 15:08:38 -07:00
Medya Gh 66421a6492 wait for ingress pod be running 2020-06-26 14:22:17 -07:00
Medya Gh 52f4e130b5 lint 2020-06-26 13:20:31 -07:00
Medya Gh 5fbf197b18 remove unrelated changes 2020-06-26 13:20:31 -07:00
Medya Gh 96781c61a2 remove unrelated changes 2020-06-26 13:20:30 -07:00
Medya Gh 058a732909 ingress addon validate deployment after enable 2020-06-26 13:20:30 -07:00
Medya Gh c47854b8fd add validate ingress 2020-06-26 13:20:30 -07:00
Medya Gh a0c33f82c1 ingress addon wait for it 2020-06-26 13:20:30 -07:00
Kenta Iso ab58dca23d replace to metrics-server in case of `minikube start --addons heapster` 2020-06-13 01:07:16 +09:00
Kenta Iso 803461ddcf if the specified addon doesn't exist, skip enabling 2020-06-13 00:46:12 +09:00
Thomas Stromberg 6969200dd7 addons: fix initial retry delay, double maximum limit 2020-05-04 12:44:30 -07:00
Medya Ghazizadeh 825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon 
Add registry addon feature for docker on mac/windows
 2020-04-17 19:50:43 -07:00
Medya Ghazizadeh fe4fdeec6c
Merge pull request #7752 from medyagh/node_pressure_redo 
Check node pressure & new option "node_ready" for --wait flag
 2020-04-17 19:45:40 -07:00
Medya Gh 4e7429695d address review comments 2020-04-17 14:07:41 -07:00
Thomas Stromberg 3a5406f79e Unify client creation around kapi.Client 2020-04-17 09:58:14 -07:00
Alonyb bfa45ef79a delete unnecesary func 2020-04-16 19:49:26 -05:00
Medya Gh bb327e250d adjust try 2020-04-16 15:14:59 -07:00
Medya Gh 0687e2adc0 defer print addon 2020-04-16 13:39:59 -07:00
Medya Gh a023de61a7 defer printing enabling addons 2020-04-16 13:38:17 -07:00
Alonyb 62904e5dcc fix lint 2020-04-15 09:30:10 -05:00
Alonyb 338e61bd21 change output message icon 2020-04-11 13:31:51 -05:00
Alonyb 4f86c3e5c8 some adjustments 2020-04-11 00:56:34 -05:00
Alonyb 3bd143037b change output message 2020-04-10 18:49:54 -05:00
Alonyb 428d9ee911 add new addon 2020-04-10 14:45:43 -05:00
Thomas Strömberg bab824a830
Merge pull request #7559 from tstromberg/cert-err2 
make CommandRunner.Copy/Remove consistent across runners
 2020-04-09 17:31:37 -07:00
Thomas Stromberg bf784d8bf3 Refactor CommandRunner.Copy functions for consistency 2020-04-09 13:24:14 -07:00
Thomas Stromberg 1e8801ceb8 Make addons.Start thread-safe 2020-04-08 21:23:35 -07:00