Commit Graph

2335 Commits (0a0a47c2ba901b6f860a5c58a99b745f44301f90)

Author SHA1 Message Date
Priya Modali 97d96bf925 Switching from glob library to klog library. 2020-09-29 15:49:41 -07:00
Medya Gh b84dedc652 address review comments 2020-09-29 15:07:06 -07:00
Medya Gh b7780ec815 address review comments 2020-09-29 14:14:25 -07:00
Medya Gh f0f10d6135 first version 2020-09-29 14:14:24 -07:00
Priya Wadhwa a05dc6516b Revert bug in `minikube status`
When the cluster is Paused, `minikube status` currently says that it is `Running`. Reverting a change I made in a previous PR to take the status of the apiserver should fix this.
2020-09-29 16:56:15 -04:00
Anders F Björklund e6b510543e Don't trim whitespace while extracting strings
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.

But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
Sharif Elgamal 11cad2b3e6
Merge pull request #9321 from loftkun/removing-duplicate-command-additions
Remove duplicate command additions
2020-09-25 14:03:48 -07:00
Thomas Strömberg 75332f7c89
Merge pull request #8901 from bluestealth/MiB
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
Thomas Strömberg ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
loftkun 7a2cd0f459 Removing Duplicate Command Additions 2020-09-25 17:45:51 +09:00
Priya Wadhwa 3ee1eb029c Update test to use new exit code for insufficient storage 2020-09-24 14:09:46 -04:00
Sharif Elgamal fd44e0d8fb
Force dependency on exp to prevent dirty commit release binaries (#9309)
* force dependency for release purposes

* revert original idea and add loads of debugging

* hey more debugging cool

* fix debugging

* drilling down debugging

* revert to original solution

* fix comment
2020-09-23 15:00:03 -07:00
Medya Ghazizadeh 183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
Medya Ghazizadeh 07642cd7ef
Merge pull request #9300 from ilya-zuyev/gh8891_forbid_base_image_for_vm_drivers
Disable base image flag for vm drivers
2020-09-23 14:10:38 -05:00
Ilya Zuyev 887390194e Add more unit tests 2020-09-22 14:19:38 -07:00
Ilya Zuyev bf8ec63ca9 Simplify base-image flag validation 2020-09-22 14:10:47 -07:00
Ilya Zuyev 76d3c9d7bb Fix variable name (avoid collision with imported package) 2020-09-22 13:09:58 -07:00
Priya Wadhwa 3d547a937f Fix Makefile rule to build bot 2020-09-22 14:00:27 -04:00
Priya Wadhwa 3f44d470eb Add performance monitor code 2020-09-22 13:54:23 -04:00
Dominik Braun 8f4127b202 Use HOST_HOME_PERMISSION kind for insufficient permissions 2020-09-22 18:04:24 +02:00
Dominik Braun 603ae8fc6d Return ExHostPermission for insufficient config file permissions 2020-09-22 10:16:27 +02:00
Ilya Zuyev 6a60983679 Show invalid flag diagnostic message to user 2020-09-21 23:28:34 -07:00
Ilya Zuyev 6bf7ca3dd2 Validate --base-image flag and active driver combo 2020-09-21 23:06:54 -07:00
Predrag Rogic 9fbd2e94bd update-context: Automatically set the context as current/active in kubeconfig 2020-09-21 00:06:15 +01:00
Medya Ghazizadeh b9f3638f2a
Merge pull request #9233 from afbjorklund/nic-type
Fix copy/paste error in virtualbox nic-type help
2020-09-15 16:05:52 -07:00
Anders F Björklund 48d44221a9 Don't validate Docker storage driver for Podman
For podman, "overlay" and "overlay2" are the same
2020-09-13 22:28:17 +02:00
Anders F Björklund 37e521272c Fix copy/paste error in virtualbox nic-type help
It used type "host only" twice, instead of "nat".
2020-09-13 17:25:02 +02:00
Sharif Elgamal ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
Thomas Strömberg c4663b8417
Merge pull request #9181 from tstromberg/m1
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-08 14:25:13 -07:00
priyawadhwa b4400ad70a
Merge pull request #8904 from Xcalizorz/master
fixes(#8301): --help: bool flags which default to 'false' yield confusing output
2020-09-08 13:50:10 -04:00
Tacio Costa 4708f6215c fix: profile list shows paused clusters as Running 2020-09-05 18:37:24 -03:00
Thomas Stromberg f15fd81333 Add Docker Desktop instructions if memory is >minimum but <recommended 2020-09-03 11:39:14 -07:00
Thomas Stromberg 54443bd337 Update min*Mem constants to use MiB instead of MB 2020-09-03 11:34:40 -07:00
Asare Worae e20223d598 quote variables in GuestMountConflict warning 2020-09-03 18:39:31 +02:00
Asare Worae 4e772347d4 exit on existing cluster start with KiC driver mount configuration change 2020-09-03 18:25:10 +02:00
Asare Worae 229969aa54 fix grammer 2020-09-03 10:02:07 +02:00
Asare Worae 5ae5be7141 fixed misuse of template variable 2020-09-03 10:01:19 +02:00
Asare Worae 2b2220ac8b added warning for changing mount configuration with KiC dirver on existing cluster 2020-09-03 09:51:11 +02:00
Thomas Strömberg dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
Thomas Strömberg d1431fe0e5
Merge pull request #9167 from tstromberg/kubectl-advice
Simplify kubectl advice messaging
2020-09-02 14:12:17 -07:00
Sharif Elgamal 830af29223
Merge pull request #9144 from tstromberg/confusing-warning
Remove conflicting & inaccurate Docker Desktop memory warning
2020-09-02 14:01:33 -07:00
Thomas Stromberg 4e9a3975df Simplify kubectl advice messaging 2020-09-02 13:35:40 -07:00
Thomas Stromberg 0d4ef00210 Use out.T for a simpler layout 2020-09-02 10:56:06 -07:00
Thomas Stromberg 08d874a4a2 Reduce performance-advice message to a single line 2020-09-02 10:38:45 -07:00
Priya Wadhwa ea5af644ec fix merge conflict 2020-09-02 09:31:42 -04:00
vinu2003 2b8c48cc59 start: fixed the type value for kubectl version mismatch to warning 2020-09-02 21:17:13 +10:00
Zadjad Rezai eff63d7382 chore(#8301): Changes https-flag description 2020-09-02 10:24:12 +02:00
Thomas Strömberg dc5951451b
Merge pull request #8872 from kadern0/issue-8857
Running internal kubectl command when minikube is called as 'kubectl'
2020-09-01 22:44:44 -07:00
Thomas Strömberg d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
respect native-ssh flag
2020-09-01 22:37:37 -07:00
Michael Ryan Dempsey 1859274e8a
refactor conversion functions into util 2020-09-01 21:21:07 -07:00
Michael Ryan Dempsey ad1e2e2de5
Use same conversion logic for bytes -> MiB everywhere 2020-09-01 21:20:09 -07:00
Thomas Strömberg 8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
Thomas Stromberg f69c6c5773 Remove conflicting & possibly inaccurate Docker Desktop specific memory warning 2020-09-01 08:40:00 -07:00
Thomas Stromberg 8ef7410066 Shorten Docker memory warning 2020-08-30 21:04:10 -07:00
Thomas Stromberg cd91fb8470 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:20 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
vinu2003 ac604f25a1 feature: added shorthand for start command output option 2020-08-27 10:07:25 +10:00
Priya Wadhwa d634a85ff9 use daemon info so this works for docker and podman 2020-08-24 17:50:09 -04:00
Priya Wadhwa 535294e523 fixed merge conflict 2020-08-24 17:35:03 -04:00
Priya Wadhwa a767b64b41 fix merge conflict 2020-08-21 21:40:32 -04:00
Priya Wadhwa 88aece40d2 change name 2020-08-21 15:05:37 -04:00
Priya Wadhwa 97acf408e0 fix error wording 2020-08-21 13:34:06 -04:00
Medya Gh e9cfbd0098 add an new flag to stop command --keep-context-active 2020-08-21 10:27:28 -07:00
Priya Wadhwa acd6589c5d Remove debugging 2020-08-21 09:56:03 -04:00
Priya Wadhwa 44b93f4776 Change MemoryCapacity to StorageCapacity to be more accurate 2020-08-21 09:49:48 -04:00
Priya Wadhwa 482b2bf624 additional debugging 2020-08-20 17:23:04 -04:00
Thomas Strömberg 344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
Priya Wadhwa 7eda3a7711 Create new exit code for InsufficientStorage 2020-08-20 15:27:06 -04:00
Priya Wadhwa 83eba00d47 add deubgging 2020-08-20 14:42:55 -04:00
Anshul Sirur 6e8f596eac Fix --memory flag parsing in minikube start
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
Li Zhijian 906bcb9cab fix typo miniube
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')

Fixes: #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
Priya Wadhwa 1783cc2939 Make sure minikube status shows status name and details 2020-08-19 13:32:36 -04:00
Priya Wadhwa 3dba974535 Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
if there is insufficient storage. Output now looks like:

```
{
  "Name": "minikube",
  "StatusCode": 507,
  "StatusName": "InsufficientStorage",
  "StatusDetail": "/var is almost out of disk space",
  "Step": "Starting Node",
  "StepDetail": "Updating the running docker \"minikube\" container ...",
  "BinaryVersion": "v1.12.3",
  "Components": {
    "kubeconfig": {
      "Name": "kubeconfig",
      "StatusCode": 500,
      "StatusName": ""
    }
  },
  "Nodes": [
    {
      "Name": "minikube",
      "StatusCode": 507,
      "StatusName": "InsufficientStorage",
      "Components": {
        "apiserver": {
          "Name": "apiserver",
          "StatusCode": 405,
          "StatusName": "Stopped"
        },
        "kubelet": {
          "Name": "kubelet",
          "StatusCode": 405,
          "StatusName": "Stopped"
        }
      }
    }
  ]
}
```
2020-08-19 13:25:48 -04:00
Pablo Caderno 9708036592 Updated default cmd string when minikube is run as kubectl
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 21:20:50 +10:00
Pablo Caderno 10a3f2e2a8 Running internal kubectl command when minikube is called as 'kubectl'
Fixes issue #8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 20:52:58 +10:00
priyawadhwa 51110dbbe8
Merge pull request #8969 from priyawadhwa/cpu-limit
skip validations if --force is supplied
2020-08-11 18:16:13 -04:00
Priya Wadhwa f122deeaf3 suggest --force for k8s version 2020-08-11 15:42:05 -04:00
Priya Wadhwa 506279c585 change function name 2020-08-11 15:38:42 -04:00
Priya Wadhwa a69b41932c improve error handling 2020-08-11 14:56:19 -04:00
Priya Wadhwa 74309a83e6 include memory check 2020-08-11 14:22:10 -04:00
Priya Wadhwa 789dfca804 skip vaildations if --force is supplied 2020-08-11 14:16:40 -04:00
Medya Gh b0afc85327 dont fail on memory check if cpu and disk checks fail 2020-08-11 10:40:40 -07:00
Medya Gh 84d198d8b5 refresh cache if there was error 2020-08-11 10:40:40 -07:00
Medya Gh 5cb47d75af return list of errors for cached host info 2020-08-11 10:40:40 -07:00
Medya Gh 2b7aaa3f49 avoid duplicate warnings 2020-08-11 10:40:40 -07:00
Medya Ghazizadeh 8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
Pablo Caderno 9354d2c0e5 Removed extra flag add.
Set default value if not  specified by the user.

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
Medya Gh ab77860c5e fix typo 2020-08-10 16:21:58 -07:00
Medya Ghazizadeh 9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
Pablo Caderno 37a1d3bc0b Added startHostTimeout flag
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
Medya Gh e783af2bef fill up cpu memory if config is missing 2020-08-04 13:26:33 -07:00
Medya Gh e87400db53 addres review comments 2020-08-04 13:26:33 -07:00
Medya Gh b71a7dceca use cached hostinfo instead 2020-08-04 13:26:33 -07:00
Medya Gh d782f80e23 bring back check for dry run 2020-08-04 13:26:33 -07:00
Medya Gh e59a026450 update comments 2020-08-04 13:26:33 -07:00
Medya Gh 71394c43e7 advice user when they allocate too much memory 2020-08-04 13:26:33 -07:00
Sharif Elgamal 5923634095 don't set event log on deletion 2020-08-03 14:22:13 -07:00
Sharif Elgamal 7ef3a8c11a respect native-ssh flag 2020-08-03 09:48:30 -07:00
Sharif Elgamal 9b86b40536 misspelling 2020-07-30 22:16:32 -07:00
Sharif Elgamal 43d23b8937 change bad comment 2020-07-30 21:40:45 -07:00
Sharif Elgamal 6e9e0b7866 better message output 2020-07-30 16:43:59 -07:00
Sharif Elgamal 7a08028c1e fix lint 2020-07-30 15:21:43 -07:00
Sharif Elgamal 61583d6249 upgrade crio to 1.18.3, ubuntu to 20.04 and add terrible hack to fix restarts for cri-o 2020-07-30 15:11:30 -07:00
Ling Samuel bb57ae0c15
Ignore localhost proxy started with scheme. Fix start_test.
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-07-30 16:17:04 +08:00
Thomas Strömberg 47435d94a7
Merge pull request #8868 from tstromberg/minimal-transition-state
status: Add experimental cluster JSON status with state transition support
2020-07-29 16:00:39 -07:00
Thomas Stromberg 59d0d7335a Add HTTP-like status codes, remove unused fields 2020-07-29 13:57:06 -07:00
priyawadhwa 245e37dd07
Merge pull request #8589 from alonyb/w/cleanup-unittest-improved
add new method to clean
2020-07-29 14:43:04 -04:00
Thomas Stromberg 649b3789d9 lint error 2020-07-28 13:53:18 -07:00
Thomas Stromberg aa3d2a2a8a Improve handling of pause/unpause/stop/delete steps 2020-07-28 13:26:09 -07:00
Thomas Stromberg ac1f901160 Allow non-start steps 2020-07-28 13:07:37 -07:00
Thomas Stromberg c539c82406 Merge branch 'master' into minimal-transition-state 2020-07-28 11:53:33 -07:00
Thomas Stromberg e60cfa5d0d Minimum viable transition status implementation 2020-07-28 11:53:30 -07:00
Medya Gh 1f5fc25ae0 address review comments 2020-07-28 10:53:36 -07:00
Medya Gh 1eaa6b4306 only suggest to user to enable metric addon and don't autoeanble 2020-07-28 09:20:51 -07:00
Thomas Stromberg 448ec75c8c Add support for storing/retrieving transient status 2020-07-27 21:34:52 -07:00
Medya Ghazizadeh f07a63cfe9
Merge pull request #8838 from angyvolin/fix-doc-typo
fix doc typo
2020-07-27 10:58:01 -07:00
Pablo Caderno 8578e09d3f Enabling metrics addon when someone enables dashboard
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-07-27 08:43:41 +10:00
Andrii Volin 1070bb5267 fix doc typo 2020-07-25 12:26:37 +03:00
Priya Wadhwa 8ec8d1cd82 Set preload=false if not using overlay2 as docker storage driver 2020-07-24 13:42:15 -04:00
Asare Worae a31e359b01 fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver 2020-07-23 11:47:16 +02:00
Priya Wadhwa 6ee3954336 Add extra validation to json output test 2020-07-22 12:52:15 -04:00
Sharif Elgamal 280c2511f7
Merge pull request #8782 from sharifelgamal/regen-config
regenerate config on retry
2020-07-21 13:29:32 -07:00
Sharif Elgamal c4cad39fac properly regenerate config 2020-07-21 12:02:09 -07:00
Priya Wadhwa ae5f5216cb fix typo 2020-07-21 14:46:37 -04:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal f33ac4c221 regenerate config on retry 2020-07-20 15:26:18 -07:00
Thomas Stromberg 9546b1ebc6 Merge branch 'master' into kic-image-upgrade 2020-07-17 09:56:42 -07:00
Thomas Strömberg 46a4377498
Merge pull request #8738 from tstromberg/kic-image-upgrade2
Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade)
2020-07-17 09:56:27 -07:00
Thomas Stromberg 94e866affc Merge to master 2020-07-16 19:53:43 -07:00
Thomas Stromberg 2fd7492377 Guard against nil panics 2020-07-16 19:50:00 -07:00
Thomas Stromberg 7d7b9d6fb9 Move KicBaseImage adjustment to upgradeExistingConfig 2020-07-16 19:44:07 -07:00
Thomas Stromberg 78f7b3cc66 Add upgradeExistingConfig to upgrade legacy configurations 2020-07-16 19:36:50 -07:00
Thomas Stromberg 51cc365898 Handle case where VMDriver is set, but Driver is not 2020-07-16 19:35:44 -07:00
Thomas Stromberg 0bca9bb84e Fix v1.9.x upgrade by populating missing KicBaseImage configuration 2020-07-16 17:37:26 -07:00
Thomas Stromberg ccd3682116 Refactor upgrade tests 2020-07-16 17:34:46 -07:00
Thomas Stromberg fcc15fa353 Merge to master 2020-07-15 21:04:33 -07:00
Thomas Stromberg 14b4a54ba2 Merge to master 2020-07-15 21:03:49 -07:00
Medya Gh 13d37ff7aa adress review comments 2020-07-15 14:34:01 -07:00
Medya Gh b0e58a3688 rename to FullName 2020-07-15 14:27:06 -07:00
Medya Gh 8ecb483cb7 use cached error 2020-07-15 14:23:25 -07:00
Medya Gh b03ad456ef spell 2020-07-15 14:10:56 -07:00
Medya Gh de6c10526b move cacheDaemoninfo to oci package 2020-07-15 14:07:50 -07:00
Medya Gh dbfd16f21e add helper fucns for drivers 2020-07-14 15:02:54 -07:00
Medya Gh 9acc975e17 put back vadidateMemorySize 2020-07-14 13:43:43 -07:00
Medya Gh 41a1ba52e6 add cached kic system info 2020-07-14 13:40:13 -07:00
Medya Gh 03e9cb7909 exit with less than 1 cpus 2020-07-13 17:15:38 -07:00
Medya Gh b45fd2df8b docker podman drivers: warn if memory is above limit 2020-07-13 16:59:11 -07:00
Medya Gh e52cd9b366 use ds name 2020-07-13 13:29:06 -07:00
Medya Gh 29c99cc221 imrove advice when driver was auto-selected 2020-07-13 13:17:51 -07:00
Priya Wadhwa 3a290606db Merge branch 'master' of https://github.com/kubernetes/minikube into json-output 2020-07-10 19:12:50 -04:00
priyawadhwa 442bc138ce
Merge pull request #8676 from priyawadhwa/info
Add Infof function to out package
2020-07-10 17:08:30 -04:00
Medya Ghazizadeh 45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
Priya Wadhwa 589b6b0340 Add text option 2020-07-10 16:35:45 -04:00
Medya Ghazizadeh d19754b2ca
Merge pull request #8591 from sunny-b/prevent-duplicate-k8s-upgrade-msg
Prevent start cmd from logging multiple k8s upgrade messages
2020-07-10 10:45:12 -07:00
Medya Ghazizadeh 87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
priyawadhwa 7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
A few cleanup
2020-07-08 14:52:28 -04:00
Priya Wadhwa 290f48f98e Add Infof function to out package 2020-07-08 11:00:32 -04:00
Medya Ghazizadeh 1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
Priya Wadhwa f68716e2da Set up logic for steps 2020-07-06 15:12:13 -04:00
Priya Wadhwa 10ba39cd3c Add --output=json flag and hook it up to out package 2020-07-06 12:32:34 -04:00
James Lucktaylor 42dd86fcd3
Update feedback when validation fails. 2020-07-05 12:20:24 +01:00
Sharif Elgamal 84eea2f487 recreate hosts on failed provisioning if delete-on-failure is specified 2020-07-01 12:57:59 -07:00
Sharif Elgamal 66314d87f3 add unit test for docker-env with none shell 2020-07-01 10:59:23 -07:00
Sun-Li Beatteay f8e6ae6787 remove unnecessary comment 2020-06-30 20:01:13 -04:00
Sun-Li Beatteay de4adc6d00 create validateKubernetesVersion check and move validation logic 2020-06-30 19:59:12 -04:00
Sunny Beatteay 1529a0d761 prevent start cmd from logging multiple k8s upgrade messages 2020-06-30 18:25:28 -04:00
Asare Worae 52e19e1bc9 merge conflict typo 2020-06-30 10:11:06 +02:00
Asare Worae 7bcae732bf resolved merge conflicts 2020-06-30 10:00:52 +02:00
Medya Ghazizadeh 9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
Sunny Beatteay 28238150f5 ensure that 'crio' is used for k8s config 2020-06-29 19:52:30 -04:00
Medya Gh 3bc3ce95de refactor maybeExitWithAdvice 2020-06-29 14:38:37 -07:00
Medya Gh 08df5e2de3 add solution message if kbueadm is not executble on linux 2020-06-29 12:50:32 -07:00
Sunny Beatteay 9bcc587def update crio to cri-o in docs and help text 2020-06-29 14:11:20 -04:00
Sunny Beatteay 5f40f863a7 update docs 2020-06-28 20:43:12 -04:00
Sunny Beatteay 5da2fdd922 enable graceful exit if container runtime is misspelled 2020-06-28 18:57:03 -04:00
Ilya Danilkin b470860a5a
fix condition check for extraOpts validation 2020-06-28 22:35:40 +03:00
Ilya Danilkin ccffa40cfe
bsutil: extra-opts validation 2020-06-28 22:35:40 +03:00
Alonyb 23eff45faf add cleanup in another test 2020-06-28 11:34:28 -05:00
Alonyb c5021ead32 add err validation 2020-06-28 11:14:23 -05:00
Alonyb 5c7dd4d941 add new method to clean 2020-06-28 10:24:21 -05:00
Prasad Katti 42af47b909 Do not auto-set extra config that user wishes to override 2020-06-27 16:26:07 -07:00
Thomas Stromberg ffcb14a6b2 Add support for Cilium CNI (--cni=cilium) 2020-06-26 11:55:30 -07:00
Thomas Stromberg f901e638f2 Add support for Calico CNI (--cni=calico) 2020-06-26 11:21:15 -07:00
Thomas Strömberg ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
Thomas Stromberg 2a39d993ea Address lint comments, remove confusing multi-runner API 2020-06-25 14:36:39 -07:00
Asare Worae 134ec1b144 changed `--docker-volume` flag logic to work from `--mount-string` and `--mount` flags 2020-06-25 09:16:04 +02:00
Thomas Stromberg 9e95435e00 Add --cni flag, fix --network-plugin=kubenet 2020-06-23 20:10:25 -07:00
Medya Gh 0121b44175 add NeedsImprovement warnning for overlay kernel 2020-06-23 13:17:59 -07:00
Medya Ghazizadeh ce33161eef
Merge pull request #8528 from tstromberg/docker-not-required
docker-env: Avoid container suicide if Docker is not installed locally
2020-06-22 17:45:47 -07:00
Medya Ghazizadeh 3d09d8e6ae
Merge pull request #8521 from afbjorklund/kubectl-path-log
The logging of the kubectl path was broken
2020-06-22 14:37:39 -07:00
Thomas Stromberg 47942be198 docker-env: Avoid container suicide if docker is not in $PATH 2020-06-22 12:27:18 -07:00
Harkishen-Singh 30e6660925 Better informaation for using kubectl inside minikube
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

add kubectl install link

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

add alias tip to the minikube docs

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

remove debug statements

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-20 18:20:28 +05:30
Anders F Björklund fe6687386d The logging of the kubectl path was broken
After introducing the exec.Cmd parameter previously
2020-06-20 14:31:35 +02:00
Medya Ghazizadeh fe9e0e8950
Merge pull request #8506 from Harkishen-Singh/unset-docker-podman-env-vars-without-machine-running
Adds support for unsetting of env vars
2020-06-18 11:57:29 -07:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh d32b8d81fe improve solution message 2020-06-17 14:26:31 -07:00
Medya Gh bdf7c196a1 add detailed suggestions when created container exists 2020-06-17 14:09:51 -07:00
Medya Gh e25445dea9 capitalize the Desktop word 2020-06-17 11:51:43 -07:00
Harkishen-Singh 8d1e4e2d26 adds support for unsetting of environment variables without the need of running container-machine
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-17 23:54:00 +05:30
Medya Gh e3ef5f9a95 address review comments 2020-06-16 15:03:56 -07:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Gh 4caf260279 add cpu count limit error type for kic drivers 2020-06-16 13:21:56 -07:00
Li Zhijian 24c9ce079d cleanup TempDir properly
a TempDir is like /tmp/minipath255070191/.minikube

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
Thomas Stromberg c2e71996a8 Point multi-node *-env users to the registry addon 2020-06-15 12:38:28 -07:00
Kenta Iso 24b2a69981 fix disable heapster message 2020-06-13 01:06:57 +09:00
Kenta Iso d7a9721712 Avoid SIGSEGV when heapster addon will be disabled 2020-06-13 00:46:12 +09:00
Kenta Iso d76b58c3ae Add heapster alias to metrics-server addon 2020-06-13 00:46:12 +09:00
Thomas Strömberg db116c2689
Merge pull request #8428 from tstromberg/minikube-blacklist
Replace whitelist/blacklist with allow/deny
2020-06-11 07:18:02 -07:00
Medya Gh dd896b2569 add sudo -E to none docs 2020-06-10 17:03:40 -07:00
Thomas Stromberg bd1bdb3696 Use 'Allowed' instead of 'Allow' 2020-06-10 14:56:22 -07:00
Medya Ghazizadeh ff86a552bf
Merge pull request #8184 from radeksm/bugfix/cluster_name_in_status
Fix missing cluster node names in output of status command
2020-06-10 12:48:48 -07:00
Thomas Stromberg 09672520ea Merge branch 'master' into minikube-blacklist 2020-06-09 16:49:39 -07:00
priyawadhwa e2104b2f0f
Merge pull request #8417 from priyawadhwa/cloudshell
Enable support for offline kic
2020-06-09 13:40:53 -07:00
Thomas Stromberg a60c7d3d1d Replace whitelist/blacklist withallow/deny 2020-06-09 13:19:18 -07:00
Medya Ghazizadeh fa0812c8f0
Merge pull request #8285 from kadern0/issue-8237
Added option --all to stop all clusters
2020-06-09 13:02:35 -07:00
Pablo Caderno 325db092c3 Added option --all to stop all clusters
Related to #8237

Signed-off-by: kadern0 <kaderno@gmail.com>
2020-06-09 08:32:36 +10:00
Priya Wadhwa 1f6e140e00 try to save image as tarball on download-only 2020-06-04 12:24:07 -07:00
Medya Ghazizadeh 025ba11bce
Merge pull request #8329 from tstromberg/stacklog
Log stacks for slowjam analysis if STACKLOG_PATH is set
2020-06-04 11:49:02 -07:00
Tacio Costa 2f26c52c2d exit when minikube addons configure is called on a nonexistent cluster 2020-06-03 15:54:46 -03:00
Tacio Costa bbab9707da fix: minikube addons configure on a nonexistent cluster 2020-06-03 15:54:46 -03:00
Radoslaw Smigielski e9ca25fb03 Fix missing cluster name in output of status command 2020-05-31 07:07:22 +01:00
Thomas Stromberg 33c0ba9977 Log stacks for slowjam analysis if STACKLOG_PATH is set 2020-05-29 20:52:24 -07:00
priyawadhwa abba4b3db5
Merge pull request #8091 from priyawadhwa/open
Add support for timing per log and printing out timings per log to mkcmp
2020-05-29 13:52:47 -07:00
Thomas Strömberg a9359c0ba1
Merge pull request #8249 from SataQiu/fix-20200522
honor --image-repository even if --image-mirror-country is set
2020-05-29 12:39:05 -07:00
Medya Ghazizadeh 77419ee925
Merge pull request #8154 from priyawadhwa/kvm-flake
Upgrade oldest k8s version supported to 1.13
2020-05-28 21:18:01 +00:00
Priya Wadhwa 3b24e6fdbe Add info about --force 2020-05-28 13:59:50 -07:00
Sharif Elgamal 4f0613929f
Merge pull request #7973 from sharifelgamal/restart
Make sure multinode clusters can survive restarts
2020-05-27 17:41:57 -07:00
Sharif Elgamal 6f03adc8ac fix in start.go 2020-05-27 15:32:56 -07:00
Sharif Elgamal 7224064b23 respect native-ssh param properly 2020-05-27 15:19:32 -07:00
Sharif Elgamal 101f2da01d revert changes to node_add 2020-05-27 10:10:46 -07:00
Sharif Elgamal d0753347b5 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-27 09:58:22 -07:00
Sharif Elgamal b5167834d0 it works! and simpler 2020-05-27 09:58:03 -07:00
Medya Ghazizadeh ba9d1baf9d
Merge pull request #8279 from medyagh/test_ver_upgrade
fix parsing kubernetes version flag on an existing minikube
2020-05-27 00:13:11 +00:00
Medya Gh ab3710cc0b
fix parsing kubernetes version flag on an existing minikube 2020-05-26 16:20:07 -07:00
Medya Gh 6ff8c9a9ba review comments 2020-05-26 15:02:42 -07:00
Medya Gh 834a584142 combine info and warnning 2020-05-26 13:29:31 -07:00
Medya Gh 2437a521e4 address review comments 2020-05-26 13:27:01 -07:00
Medya Gh d24351a8c3 revert unrelated ode 2020-05-26 13:27:01 -07:00
Medya Gh 82b79d6e8b remove podman-env restart 2020-05-26 13:27:01 -07:00
Medya Gh 7e1a2a557b separate 2020-05-26 13:27:01 -07:00
Medya Gh 18e9055fb4 restart only what if needed 2020-05-26 13:27:01 -07:00
Medya Gh f43ac07b41 restart docker on docker-env to prevent IP cert problems 2020-05-26 13:27:01 -07:00
SataQiu 98b0258565 honor --image-repository even if --image-mirror-country is set 2020-05-22 15:11:02 +08:00
Medya Ghazizadeh f26ea0fcf2
Merge pull request #8238 from sharifelgamal/postmortem
allow minikube status to display for one node
2020-05-21 22:41:00 +00:00
Sharif Elgamal c8723ce59c Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-21 14:54:29 -07:00
Sharif Elgamal bde6624365 Merge branch 'postmortem' of github.com:sharifelgamal/minikube into restart 2020-05-21 14:54:21 -07:00
Sharif Elgamal 9fe9513c34 only use retrieval code for multinode clusters 2020-05-21 14:08:34 -07:00
Sharif Elgamal a7c49e47c1 allow minikube status to display for one node 2020-05-21 12:46:13 -07:00
kadern0 6189206367 Fixed error parsing old version "latest" or "stable"
Fixes #8210

Signed-off-by: kadern0 <kaderno@gmail.com>
2020-05-21 20:31:49 +10:00