1f5fc25ae0
address review comments
2020-07-28 10:53:36 -07:00
1eaa6b4306
only suggest to user to enable metric addon and don't autoeanble
2020-07-28 09:20:51 -07:00
448ec75c8c
Add support for storing/retrieving transient status
2020-07-27 21:34:52 -07:00
f07a63cfe9
Merge pull request #8838 from angyvolin/fix-doc-typo
...
fix doc typo
2020-07-27 10:58:01 -07:00
8578e09d3f
Enabling metrics addon when someone enables dashboard
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-07-27 08:43:41 +10:00
1070bb5267
fix doc typo
2020-07-25 12:26:37 +03:00
8ec8d1cd82
Set preload=false if not using overlay2 as docker storage driver
2020-07-24 13:42:15 -04:00
a31e359b01
fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver
2020-07-23 11:47:16 +02:00
6ee3954336
Add extra validation to json output test
2020-07-22 12:52:15 -04:00
280c2511f7
Merge pull request #8782 from sharifelgamal/regen-config
...
regenerate config on retry
2020-07-21 13:29:32 -07:00
c4cad39fac
properly regenerate config
2020-07-21 12:02:09 -07:00
ae5f5216cb
fix typo
2020-07-21 14:46:37 -04:00
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
f33ac4c221
regenerate config on retry
2020-07-20 15:26:18 -07:00
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
46a4377498
Merge pull request #8738 from tstromberg/kic-image-upgrade2
...
Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade)
2020-07-17 09:56:27 -07:00
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
2fd7492377
Guard against nil panics
2020-07-16 19:50:00 -07:00
7d7b9d6fb9
Move KicBaseImage adjustment to upgradeExistingConfig
2020-07-16 19:44:07 -07:00
78f7b3cc66
Add upgradeExistingConfig to upgrade legacy configurations
2020-07-16 19:36:50 -07:00
51cc365898
Handle case where VMDriver is set, but Driver is not
2020-07-16 19:35:44 -07:00
0bca9bb84e
Fix v1.9.x upgrade by populating missing KicBaseImage configuration
2020-07-16 17:37:26 -07:00
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
b03ad456ef
spell
2020-07-15 14:10:56 -07:00
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
dbfd16f21e
add helper fucns for drivers
2020-07-14 15:02:54 -07:00
9acc975e17
put back vadidateMemorySize
2020-07-14 13:43:43 -07:00
41a1ba52e6
add cached kic system info
2020-07-14 13:40:13 -07:00
03e9cb7909
exit with less than 1 cpus
2020-07-13 17:15:38 -07:00
b45fd2df8b
docker podman drivers: warn if memory is above limit
2020-07-13 16:59:11 -07:00
e52cd9b366
use ds name
2020-07-13 13:29:06 -07:00
29c99cc221
imrove advice when driver was auto-selected
2020-07-13 13:17:51 -07:00
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
442bc138ce
Merge pull request #8676 from priyawadhwa/info
...
Add Infof function to out package
2020-07-10 17:08:30 -04:00
45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
...
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
589b6b0340
Add text option
2020-07-10 16:35:45 -04:00
d19754b2ca
Merge pull request #8591 from sunny-b/prevent-duplicate-k8s-upgrade-msg
...
Prevent start cmd from logging multiple k8s upgrade messages
2020-07-10 10:45:12 -07:00
87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
...
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
...
A few cleanup
2020-07-08 14:52:28 -04:00
290f48f98e
Add Infof function to out package
2020-07-08 11:00:32 -04:00
1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
...
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
f68716e2da
Set up logic for steps
2020-07-06 15:12:13 -04:00
10ba39cd3c
Add --output=json flag and hook it up to out package
2020-07-06 12:32:34 -04:00
42dd86fcd3
Update feedback when validation fails.
2020-07-05 12:20:24 +01:00
84eea2f487
recreate hosts on failed provisioning if delete-on-failure is specified
2020-07-01 12:57:59 -07:00
66314d87f3
add unit test for docker-env with none shell
2020-07-01 10:59:23 -07:00
f8e6ae6787
remove unnecessary comment
2020-06-30 20:01:13 -04:00
de4adc6d00
create validateKubernetesVersion check and move validation logic
2020-06-30 19:59:12 -04:00
1529a0d761
prevent start cmd from logging multiple k8s upgrade messages
2020-06-30 18:25:28 -04:00
52e19e1bc9
merge conflict typo
2020-06-30 10:11:06 +02:00
7bcae732bf
resolved merge conflicts
2020-06-30 10:00:52 +02:00
9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
...
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
28238150f5
ensure that 'crio' is used for k8s config
2020-06-29 19:52:30 -04:00
3bc3ce95de
refactor maybeExitWithAdvice
2020-06-29 14:38:37 -07:00
08df5e2de3
add solution message if kbueadm is not executble on linux
2020-06-29 12:50:32 -07:00
9bcc587def
update crio to cri-o in docs and help text
2020-06-29 14:11:20 -04:00
5f40f863a7
update docs
2020-06-28 20:43:12 -04:00
5da2fdd922
enable graceful exit if container runtime is misspelled
2020-06-28 18:57:03 -04:00
b470860a5a
fix condition check for extraOpts validation
2020-06-28 22:35:40 +03:00
ccffa40cfe
bsutil: extra-opts validation
2020-06-28 22:35:40 +03:00
23eff45faf
add cleanup in another test
2020-06-28 11:34:28 -05:00
c5021ead32
add err validation
2020-06-28 11:14:23 -05:00
5c7dd4d941
add new method to clean
2020-06-28 10:24:21 -05:00
42af47b909
Do not auto-set extra config that user wishes to override
2020-06-27 16:26:07 -07:00
ffcb14a6b2
Add support for Cilium CNI (--cni=cilium)
2020-06-26 11:55:30 -07:00
f901e638f2
Add support for Calico CNI (--cni=calico)
2020-06-26 11:21:15 -07:00
ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
...
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
2a39d993ea
Address lint comments, remove confusing multi-runner API
2020-06-25 14:36:39 -07:00
134ec1b144
changed `--docker-volume` flag logic to work from `--mount-string` and `--mount` flags
2020-06-25 09:16:04 +02:00
9e95435e00
Add --cni flag, fix --network-plugin=kubenet
2020-06-23 20:10:25 -07:00
0121b44175
add NeedsImprovement warnning for overlay kernel
2020-06-23 13:17:59 -07:00
ce33161eef
Merge pull request #8528 from tstromberg/docker-not-required
...
docker-env: Avoid container suicide if Docker is not installed locally
2020-06-22 17:45:47 -07:00
3d09d8e6ae
Merge pull request #8521 from afbjorklund/kubectl-path-log
...
The logging of the kubectl path was broken
2020-06-22 14:37:39 -07:00
47942be198
docker-env: Avoid container suicide if docker is not in $PATH
2020-06-22 12:27:18 -07:00
30e6660925
Better informaation for using kubectl inside minikube
...
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
add kubectl install link
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
add alias tip to the minikube docs
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
remove debug statements
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-20 18:20:28 +05:30
fe6687386d
The logging of the kubectl path was broken
...
After introducing the exec.Cmd parameter previously
2020-06-20 14:31:35 +02:00
fe9e0e8950
Merge pull request #8506 from Harkishen-Singh/unset-docker-podman-env-vars-without-machine-running
...
Adds support for unsetting of env vars
2020-06-18 11:57:29 -07:00
e91e11eeba
address review comments
2020-06-17 18:32:11 -07:00
ca2d0f97ec
move advice to its own file
2020-06-17 15:07:17 -07:00
d32b8d81fe
improve solution message
2020-06-17 14:26:31 -07:00
bdf7c196a1
add detailed suggestions when created container exists
2020-06-17 14:09:51 -07:00
e25445dea9
capitalize the Desktop word
2020-06-17 11:51:43 -07:00
8d1e4e2d26
adds support for unsetting of environment variables without the need of running container-machine
...
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-17 23:54:00 +05:30
e3ef5f9a95
address review comments
2020-06-16 15:03:56 -07:00
56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
c2e71996a8
Point multi-node *-env users to the registry addon
2020-06-15 12:38:28 -07:00
24b2a69981
fix disable heapster message
2020-06-13 01:06:57 +09:00
d7a9721712
Avoid SIGSEGV when heapster addon will be disabled
2020-06-13 00:46:12 +09:00
d76b58c3ae
Add heapster alias to metrics-server addon
2020-06-13 00:46:12 +09:00
db116c2689
Merge pull request #8428 from tstromberg/minikube-blacklist
...
Replace whitelist/blacklist with allow/deny
2020-06-11 07:18:02 -07:00
dd896b2569
add sudo -E to none docs
2020-06-10 17:03:40 -07:00
bd1bdb3696
Use 'Allowed' instead of 'Allow'
2020-06-10 14:56:22 -07:00
ff86a552bf
Merge pull request #8184 from radeksm/bugfix/cluster_name_in_status
...
Fix missing cluster node names in output of status command
2020-06-10 12:48:48 -07:00
09672520ea
Merge branch 'master' into minikube-blacklist
2020-06-09 16:49:39 -07:00
e2104b2f0f
Merge pull request #8417 from priyawadhwa/cloudshell
...
Enable support for offline kic
2020-06-09 13:40:53 -07:00
a60c7d3d1d
Replace whitelist/blacklist withallow/deny
2020-06-09 13:19:18 -07:00
fa0812c8f0
Merge pull request #8285 from kadern0/issue-8237
...
Added option --all to stop all clusters
2020-06-09 13:02:35 -07:00
325db092c3
Added option --all to stop all clusters
...
Related to #8237
Signed-off-by: kadern0 <kaderno@gmail.com>
2020-06-09 08:32:36 +10:00
1f6e140e00
try to save image as tarball on download-only
2020-06-04 12:24:07 -07:00
025ba11bce
Merge pull request #8329 from tstromberg/stacklog
...
Log stacks for slowjam analysis if STACKLOG_PATH is set
2020-06-04 11:49:02 -07:00
2f26c52c2d
exit when minikube addons configure is called on a nonexistent cluster
2020-06-03 15:54:46 -03:00
bbab9707da
fix: minikube addons configure on a nonexistent cluster
2020-06-03 15:54:46 -03:00
e9ca25fb03
Fix missing cluster name in output of status command
2020-05-31 07:07:22 +01:00
33c0ba9977
Log stacks for slowjam analysis if STACKLOG_PATH is set
2020-05-29 20:52:24 -07:00
abba4b3db5
Merge pull request #8091 from priyawadhwa/open
...
Add support for timing per log and printing out timings per log to mkcmp
2020-05-29 13:52:47 -07:00
a9359c0ba1
Merge pull request #8249 from SataQiu/fix-20200522
...
honor --image-repository even if --image-mirror-country is set
2020-05-29 12:39:05 -07:00
77419ee925
Merge pull request #8154 from priyawadhwa/kvm-flake
...
Upgrade oldest k8s version supported to 1.13
2020-05-28 21:18:01 +00:00
3b24e6fdbe
Add info about --force
2020-05-28 13:59:50 -07:00
4f0613929f
Merge pull request #7973 from sharifelgamal/restart
...
Make sure multinode clusters can survive restarts
2020-05-27 17:41:57 -07:00
6f03adc8ac
fix in start.go
2020-05-27 15:32:56 -07:00
7224064b23
respect native-ssh param properly
2020-05-27 15:19:32 -07:00
101f2da01d
revert changes to node_add
2020-05-27 10:10:46 -07:00
d0753347b5
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-27 09:58:22 -07:00
b5167834d0
it works! and simpler
2020-05-27 09:58:03 -07:00
ba9d1baf9d
Merge pull request #8279 from medyagh/test_ver_upgrade
...
fix parsing kubernetes version flag on an existing minikube
2020-05-27 00:13:11 +00:00
ab3710cc0b
fix parsing kubernetes version flag on an existing minikube
2020-05-26 16:20:07 -07:00
6ff8c9a9ba
review comments
2020-05-26 15:02:42 -07:00
834a584142
combine info and warnning
2020-05-26 13:29:31 -07:00
2437a521e4
address review comments
2020-05-26 13:27:01 -07:00
d24351a8c3
revert unrelated ode
2020-05-26 13:27:01 -07:00
82b79d6e8b
remove podman-env restart
2020-05-26 13:27:01 -07:00
7e1a2a557b
separate
2020-05-26 13:27:01 -07:00
18e9055fb4
restart only what if needed
2020-05-26 13:27:01 -07:00
f43ac07b41
restart docker on docker-env to prevent IP cert problems
2020-05-26 13:27:01 -07:00
98b0258565
honor --image-repository even if --image-mirror-country is set
2020-05-22 15:11:02 +08:00
f26ea0fcf2
Merge pull request #8238 from sharifelgamal/postmortem
...
allow minikube status to display for one node
2020-05-21 22:41:00 +00:00
c8723ce59c
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-21 14:54:29 -07:00
bde6624365
Merge branch 'postmortem' of github.com:sharifelgamal/minikube into restart
2020-05-21 14:54:21 -07:00
9fe9513c34
only use retrieval code for multinode clusters
2020-05-21 14:08:34 -07:00
a7c49e47c1
allow minikube status to display for one node
2020-05-21 12:46:13 -07:00
6189206367
Fixed error parsing old version "latest" or "stable"
...
Fixes #8210
Signed-off-by: kadern0 <kaderno@gmail.com>
2020-05-21 20:31:49 +10:00
d5f9490ced
Merge branch 'node-delete-vol' of github.com:sharifelgamal/minikube into restart
2020-05-20 15:00:58 -07:00
01145c3c99
Merge branch 'master' of github.com:kubernetes/minikube into node-delete-vol
2020-05-20 14:59:31 -07:00
bbf4d66b48
delete docker volumes when deleting a single node
2020-05-20 14:59:03 -07:00
dd7e57e110
Merge branch 'restart' of github.com:sharifelgamal/minikube into restart
2020-05-20 13:14:17 -07:00
49cc6ae259
revert old unrelated changes:
2020-05-20 13:13:57 -07:00
70198d807d
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-20 12:55:07 -07:00
add572c1c9
Merge pull request #8216 from sharifelgamal/volume-del
...
multinode: delete worker volumes for docker driver
2020-05-20 00:43:19 +00:00
327ba9e1ab
Merge pull request #8198 from medyagh/fix_proxy
...
fix proxy env not being passed to docker engine
2020-05-19 23:59:19 +00:00
ee5696ffa4
Merge branch 'volume-del' of github.com:sharifelgamal/minikube into restart
2020-05-19 16:34:54 -07:00
6eb0200dae
delete worker node volums for docker driver
2020-05-19 16:32:48 -07:00
32bf4d46a7
add unique
2020-05-18 18:26:11 -07:00
2f2a8357a8
fix proxy envs not being passed to docker engine
2020-05-18 18:04:45 -07:00
9165e1a6ca
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-18 16:58:38 -07:00
faf11e2f05
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-18 11:55:07 -07:00
412cef3002
Merge branch 'master' of github.com:kubernetes/minikube into node-start
2020-05-18 11:52:57 -07:00
2754bb6319
Merge pull request #8095 from sharifelgamal/create-node
...
recreate existing control plane node correctly
2020-05-18 11:50:39 -07:00
02cee02721
Merge pull request #8143 from priyawadhwa/list
...
Add defaults subcommand to `minikube config`
2020-05-18 10:59:38 -07:00
6d12ca7e5c
Fix node start
2020-05-15 17:20:33 -07:00
009e056f8c
revert ip change
2020-05-15 15:39:52 -07:00
c1c1d15b96
Merge branch 'create-node' of github.com:sharifelgamal/minikube into create-node
2020-05-15 15:25:20 -07:00
1cc7404e76
swap to bool
2020-05-15 15:24:33 -07:00
56898dcd90
override nodes config properly
2020-05-15 14:50:30 -07:00
6d6bad6217
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-15 13:59:35 -07:00
9c17c9214d
respect kubernetes version passed into parameters even on existing cluster config
2020-05-15 13:11:42 -07:00
80ae2587a1
more debugging
2020-05-15 09:56:35 -07:00
9df04324a2
Merge branch 'master' of github.com:kubernetes/minikube into create-node
2020-05-15 09:16:31 -07:00
59de926bf1
updated --docker-volume flag description and ran docs generator
2020-05-15 12:03:56 +02:00
1909c4bb7c
add support for `--docker-volume` command line flag to mount host volumes on start
2020-05-15 11:44:24 +02:00
31339cb53b
do not modify existing config
2020-05-14 15:57:12 -07:00
21a552942a
fixes & debugging
2020-05-14 15:30:04 -07:00
d2a0f61cf0
swap condition
2020-05-14 14:53:29 -07:00
2e7d9d88ae
Merge pull request #8118 from afbjorklund/version-prefix
...
Improve handling of VersionPrefix in output
2020-05-14 19:41:39 +00:00
a4d872faee
Fix some minor gofmt and golint issues
...
So that "make gofmt" and "make golint" go green again
2020-05-14 07:50:29 +02:00
950110280d
Fix unit tests
2020-05-13 14:44:31 -07:00
b3d4750c05
Add support for --output json
2020-05-13 14:37:45 -07:00
208fb8a3c6
Add unit test
2020-05-13 14:29:28 -07:00
31525fe822
Add defaults subcommand to `minikube config`
...
`minikube config defaults PROPERTY_NAME` will print out all acceptable default values for that property.
Currently only works for `minikube config defaults driver` which looks like this on Mac:
```
$ minikube config defaults driver
* virtualbox
* parallels
* vmwarefusion
* hyperkit
* vmware
* docker
* podman
```
This will be useful for clients that depend on minikube, like IDE extensions.
2020-05-13 14:15:08 -07:00
5684c253b5
Merge branch 'master' of github.com:kubernetes/minikube into create-node
2020-05-13 09:24:35 -07:00
c14e7a5a71
Improve handling of VersionPrefix in output
2020-05-13 11:32:01 +02:00
c7f3a3d3cf
simplify code
2020-05-12 12:56:01 -07:00
fc4acc598a
recreate existing control plane node correctly
2020-05-12 12:12:57 -07:00
d7813e9199
ControlPaneEndpoint -> ControlPlaneEndpoint
2020-05-12 12:01:42 -07:00
6147ad350d
Add support for timing per log and printing out timings per log to mkcmp
2020-05-12 11:07:25 -07:00
562fd5b2df
improve node stop output
2020-05-11 21:59:03 -07:00
335379dc59
it works
2020-05-11 19:25:53 -07:00
afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
...
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
d4639c52b9
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-11 11:52:22 -07:00
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
3fa4b9164d
The podman volume prune does not support filter
2020-05-09 13:58:12 +02:00
9673b421df
Skip deleting leftovers if bin not available
...
Avoids spamming the log with extra drivers
2020-05-09 13:49:15 +02:00
c1be17346b
Also delete podman containers and volumes
...
When deleting all minikube profiles, that is
2020-05-09 13:41:06 +02:00
6bb8371459
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-08 13:53:20 -07:00
bf541b42c2
Merge pull request #8038 from tstromberg/kic-delete-prompt
...
Use the appropriate OCI for deletePossibleKicLeftOver when known
2020-05-08 00:02:44 +00:00
5e981137a4
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-07 16:13:25 -07:00
e06e180a52
Cite issue #8040 for TODO's
2020-05-07 16:00:08 -07:00
64e47992e4
Only delete leftovers for the appropriate OCI if known
2020-05-07 15:19:09 -07:00
eefcc04b36
Shorten long text
2020-05-07 14:14:10 -07:00
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
5ed946cc4c
fix minikube stop output
2020-05-06 14:41:43 -07:00
494710616b
let's change a bunch of stuff
2020-05-05 14:42:07 -07:00
bd2c4d8f6c
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-04 14:49:51 -07:00
e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
...
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
Medya Gh
Thomas Stromberg
Medya Ghazizadeh
Pablo Caderno
Andrii Volin
Priya Wadhwa
Asare Worae
Sharif Elgamal
James Lucktaylor
Sun-Li Beatteay
Sunny Beatteay
Ilya Danilkin
Alonyb
Prasad Katti
Harkishen-Singh
Anders F Björklund
Li Zhijian
Kenta Iso
Tacio Costa
Radoslaw Smigielski
Medya Gh
SataQiu