c090344bb4
More robust MAC address matching ( #19750 )
...
On darwin bootp uses non-standard MAC address format[1]:
"8e:1:99:9c:54:b1" instead of "8e:01:99:9c:54:b1". We fixed this by
trimming leading "0" in the string before looking up the IP address.
There are several issues with the current code:
- Fragile, will break if bootp changes the format (unlikely)
- Fixing the wrong place, the drivers should not care about the MAC
address format.
- The tests were confusing, showing that we can match standard MAC
addresses while the actual code could match only non-standard bootp
addresses.
- Logging wrong MAC address since we trimmed leading zeros before
logging
This change replace trimming leading zeros with parsing MAC address
strings and comparing the bytes. The test includes now both standard and
non-standard MAC addresses.
[1] https://openradar.appspot.com/FB15382970
2024-10-14 10:21:04 -07:00
8d17e2cbde
Move ExtractFile from hyperkit to drivers
...
So that it can be used in other drivers too
2024-08-20 12:39:57 -07:00
50e9147e4e
fix lint errors
2023-03-20 12:43:07 -07:00
8c12c40853
implement socket_vmnet
2022-10-03 15:14:36 -07:00
2e4ea3c259
replace MkdirTemp with t.TempDir in tests
2022-04-01 19:18:20 -07:00
1aa1f04e9b
remove old build tags
2022-03-30 16:43:29 -07:00
8c3a3537c0
remove reference to nonexistent file for hyperkit driver
2022-01-20 15:03:00 -08:00
694c9cc0ef
Bootloader ISO EFI Support
2021-12-07 15:56:07 -08:00
70022d9b2e
Move from deprecated ioutil to os and io packages
2021-10-08 08:57:19 +08:00
145f9fc9ab
run `go fmt`
2021-09-13 11:58:43 -07:00
ccf4af0997
change depricated golint to revive and fix lint issues
2021-08-12 18:11:16 -07:00
8f05ee00e1
Add ability to create extra disks on hyperkit vms
...
Add the ability to create and attach extra disks to hyperkit vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
fae67405e9
Update outdated moby/hyperkit package in minikube code
2021-03-05 22:27:23 -08:00
47ed4bc23c
update lint version
2020-07-24 14:45:15 -07:00
11674e830f
spell
2020-07-10 13:13:45 -07:00
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
d4b48e1e05
clean up after test dirs
2020-04-14 19:33:26 -07:00
a37ec2ecd7
Merge pull request #7189 from Hellcatlk/UnitTest
...
add unit test for pkg/drivers/hyperkit/iso.go
2020-04-09 04:22:58 -07:00
2e9054f495
add unit test for pkg/drivers/hyperkit/iso.go
...
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-03-25 11:08:27 +08:00
70c9304724
code review comments
2020-03-13 10:37:29 -07:00
67c7a7a81c
Reduce cyclometric complexity by refactoring
...
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
48d2ace5cc
Remove broken default disk size test that didn't make sense
2019-08-22 11:41:41 -07:00
a817bffab1
Remove all minikube dependencies from drivers ( #4933 )
...
* Remove all minikube dependencies in driver code
* removing all default config
* okay we need some defaults
* code comments
* hyperkit builds now
* sleep for an appropriate amount of time
* remove constant in favor of string
* try goproxy for travis
* try goproxy for travis
* try goproxy for travis
* let's not try goproxy for now
* let's try goproxy once again
* maybe use the correct url for the proxy
* fix go mod
2019-08-12 14:42:11 -07:00
99ac1a81e7
moving command runner to its own package
2019-07-04 16:31:07 -07:00
2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
...
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
4812761f05
Add gitCommitID to hyperkit version
2019-06-29 09:32:21 -03:00
931a0a557b
Add hyperkit version
2019-06-29 09:22:51 -03:00
7fe2247692
Improve hyperkit vm stop
2019-06-28 16:36:36 -07:00
6222e74267
Add hyperkit doc
2019-06-28 13:44:15 -07:00
380883dee3
Fix failing Hyperkit test
2019-06-26 01:45:12 +05:30
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
f8c5fad437
Mark as darwin only, to match network.go
2019-05-14 09:05:34 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
473f5983cb
Allow driver name to be com.docker.hyper, as seen in integration testing
2019-02-13 13:36:45 -08:00
4b875ddd7f
Run goimports
2019-02-13 13:35:28 -08:00
2045dc9ba4
Lint cleanup
2019-02-13 13:35:08 -08:00
888978c3a9
Improve VM re-use reliability: detect crashing and/or badly installed hyperkit
2019-02-12 13:58:18 -08:00
f346e5628b
Add logging around the DHCP discovery process
2019-02-12 13:57:02 -08:00
d57d8d1a1e
Fix broken tests: hyperkit driver format mismatch, console spacing mismatch
2019-02-08 13:58:02 -08:00
17c0244cf7
reverting unnecessary change
2019-01-28 17:28:57 -08:00
5af2f1eafc
formatting / removed extra comment
2019-01-28 13:47:24 -08:00
Nir Soffer
Anders F Björklund
Steven Powell
Sharif Elgamal
klaases
KallyDev
Medya Gh
Blaine Gardner
Daehyeok Mun
Li Zhijian
Thomas Strömberg
ZouYu
Medya Ghazizadeh
Jose Donizetti
Jituri, Pranav
balopat