Medya Gh
63f9bfbb61
addres review comments
2020-04-24 14:07:54 -07:00
Medya Gh
ef01ed481c
get rid of global CliRunner
2020-04-23 14:37:03 -07:00
Medya Gh
17f420cc71
warn slow part of cli runner
2020-04-23 01:23:49 -07:00
Medya Gh
038aef6b48
unexport warnIfSlow func
2020-04-23 00:33:40 -07:00
Medya Gh
8a0a210763
convert more funcs to use cli runner
2020-04-23 00:29:37 -07:00
Medya Gh
c6e1445ccb
convert more to cli runner
2020-04-23 00:12:41 -07:00
Medya Gh
b639c6112d
fix delete and add integeration test
2020-04-20 20:38:31 -07:00
Anders F Björklund
19be5619d6
Resource limits seem to work ok when not rootless
2020-04-19 09:45:16 +02:00
Anders F Björklund
024cd6b108
Use the same kind of named /var mount for podman
...
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
Anders F Björklund
8987b1067a
Also persist the kubelet and the cni state dirs
2020-04-19 09:45:16 +02:00
Anders F Björklund
223424652c
Also create and mount the container runtime dirs
2020-04-19 09:45:16 +02:00
Anders F Björklund
f57faf8036
Only remount the /var/lib/minikube directory
2020-04-19 09:45:16 +02:00
Anders F Björklund
22aa1aff22
Handle more state and status for the podman driver
2020-04-19 09:45:16 +02:00
Anders F Björklund
d7dc7bf7b2
The podman driver should not be run as root
...
Use sudo for the podman commands instead
Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Medya Gh
bf15f9a00c
fix build err
2020-04-16 16:20:04 -07:00
Medya Gh
934f900f16
improve kic start and kill
2020-04-16 16:10:44 -07:00
Medya Gh
34fafc783f
fine tune
2020-04-14 22:20:28 -07:00
Medya Gh
7303ccf07d
lint
2020-04-14 21:31:12 -07:00
Medya Gh
54aa958f01
use oci to delete
2020-04-14 20:51:18 -07:00
Medya Gh
b7f0bfc369
unconfine apparmor for kic
2020-04-13 16:44:17 -07:00
Priya Wadhwa
3a12fbd1f5
Fix spelling
2020-04-09 10:50:20 -07:00
Priya Wadhwa
70329bf51d
Code review comments
2020-04-08 13:44:04 -07:00
Priya Wadhwa
b509d69182
Extract preloaded tarball as soon as minikube volume is created
...
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.
This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
Medya Gh
a0263c2513
adjust more
2020-04-03 20:59:03 -07:00
Medya Gh
a62d611e0b
adjust kill time
2020-04-03 20:59:03 -07:00
Medya Gh
8f51d7de58
adjust warn if slow for ps and volume
2020-04-03 20:59:03 -07:00
Thomas Stromberg
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
Thomas Stromberg
2f2dccd30c
Remove test values
2020-03-26 14:05:02 -07:00
Thomas Stromberg
46f31480df
Make slow command detection consistent across kic/oci
2020-03-26 14:03:22 -07:00
Medya Ghazizadeh
f00f5ff600
remove extra if
2020-03-24 10:21:32 -07:00
Medya Gh
940baa09ea
fix comment
2020-03-24 07:31:22 -07:00
Medya Gh
41b16b1568
fail if container is not running
2020-03-24 07:27:07 -07:00
Medya Gh
83cc28e082
add logging for when container status is running
2020-03-24 07:11:22 -07:00
Thomas Stromberg
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
Thomas Stromberg
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
Thomas Stromberg
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
Medya Gh
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
Medya Gh
cb14468b44
english
2020-03-06 15:11:42 -08:00
Medya Gh
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
Medya Gh
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
Medya Gh
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
Medya Gh
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
Medya Gh
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
Sharif Elgamal
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
Medya Gh
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00
Medya Gh
6a62046e62
add warning and point to right docker
2020-03-04 10:22:20 -08:00
Sharif Elgamal
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
Sharif Elgamal
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
Medya Gh
8d0c41392b
continue instead of nest
2020-02-26 13:50:42 -08:00
Medya Gh
4709af55df
resolve review comments
2020-02-26 12:44:25 -08:00
Medya Gh
e8c85543f7
limit time waiting for delete
2020-02-26 10:57:46 -08:00
Medya Gh
30a38e5a9d
wrap error
2020-02-20 00:07:36 -08:00
Medya Gh
4fe9ca5f05
break done delete and prune into two funcs better error handling
2020-02-20 00:07:36 -08:00
Medya Gh
e1ffa5fb0f
return error instead of logging
2020-02-20 00:07:36 -08:00
Medya Gh
354ff6256d
improve comments
2020-02-20 00:07:36 -08:00
Medya Gh
6c94880149
dont list empty ones
2020-02-20 00:07:36 -08:00
Medya Gh
d84aa9f447
lint
2020-02-20 00:07:36 -08:00
Medya Gh
efd4aabde4
clean up containers first then delete volume
2020-02-20 00:07:35 -08:00
Medya Gh
a007c0790c
Delete volumes created by kic
2020-02-14 01:39:16 -08:00
Medya Gh
a4ee4186bd
create docker volumes explictily with a label
2020-02-14 01:01:53 -08:00
Medya Ghazizadeh
4c6b435f68
revert docker volume host path ( #6616 )
2020-02-13 10:57:23 -07:00
Medya Ghazizadeh
398c7ef00b
Add podman driver ( #6515 )
2020-02-12 19:11:44 -07:00
Medya Gh
4b9d15a34c
point to host docker
2020-02-04 16:09:43 -08:00
Medya Gh
0e5059ddd0
log warning if docker is stuck
2020-01-30 21:36:56 -08:00
Medya Gh
a6ec05e35a
unexport noderolekey
2020-01-30 21:05:51 -08:00
Medya Gh
968fe86869
unexport more funcs
2020-01-30 21:01:27 -08:00
Medya Gh
006c781fbc
remove unused kic code
2020-01-30 20:44:32 -08:00
Medya Gh
58b637b05f
delete all cleans up stale kic profiles
2020-01-30 16:42:14 -08:00
Medya Gh
8e0ffdf1cf
resolve conflict
2020-01-30 16:20:55 -08:00
Medya Gh
b3404a70e6
patch node refactor for kic
2020-01-24 19:03:50 -08:00
Medya Gh
c6c0046c57
let docker/podman choose hostbind port
2020-01-24 14:15:48 -08:00
Medya Ghazizadeh
19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
...
Experimental verison of kic
2020-01-10 00:42:01 -08:00
Medya Ghazizadeh
6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
...
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
Zhou Hao
7e0b89cc9d
code optimization
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
Medya Gh
77394db9aa
add Dockerfile for kic images
2020-01-07 13:54:00 -08:00
Medya Gh
ac97b51058
implement setup certs for kicbs
2020-01-07 13:52:47 -08:00
Medya Gh
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
Zhou Hao
c1859c44e3
kic/oci: parse all kind of states
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
Zhou Hao
ae61e56594
pkg/drivers/kic/oci: fix Status info
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
Zhou Hao
aa52255be0
pkg/drivers/kic/oci: delete TODO info
...
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜ minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜ minikube git:(oci-remove-todo) ✗ echo $?
125
So delete this TODO info.
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
Medya Gh
e1d5704170
get rid of default oci
2019-12-19 11:08:05 -08:00
Medya Gh
379bf2ac0c
fix boilerplate formats
2019-12-17 16:38:56 -08:00
Medya Gh
46df68ca4b
move cri to oci package
2019-12-17 16:04:03 -08:00
Medya Gh
d7273d36c9
Add kic driver
2019-12-17 15:18:31 -08:00