Kian-Meng Ang
bc03821826
Fix typos
2022-06-10 15:26:35 -07:00
Akihiro Suda
28fdc99086
Podman: fix `minikube delete` for Podman v4
...
The "minikube" network was not deleted due to the breaking change of
`podman network inspect` in Podman v4.
Fix issue 13861
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-03-30 18:29:14 +09:00
Akihiro Suda
323225483e
Support Rootless Docker
...
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/
Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.
Closes issue 10836 ("add support for rootless Docker").
Support for rootless Podman (issue 8719) is not covered in this commit.
---
Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
instead of `overlayfs` snapshotter
- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint
- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless
- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host
- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Medya Gh
89c7853601
bump go mod libs manually
2021-06-29 15:24:59 -04:00
Medya Gh
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
Ilya Zuyev
dcadd32624
Add comment, improve template
2021-05-14 14:38:29 -07:00
Ilya Zuyev
a1ae930d2f
Simplify the code
2021-05-06 11:17:43 -07:00
Ilya Zuyev
6e2eae0d0a
Simplify the code
2021-05-06 11:13:10 -07:00
Ilya Zuyev
f4e142d442
Simplify the code
2021-05-06 10:35:22 -07:00
Ilya Zuyev
8d2b811fcf
Remove debug logs
2021-05-05 22:01:21 -07:00
Ilya Zuyev
6cf6ba2ff2
Fix network settings parsing
2021-05-05 19:31:12 -07:00
Ilya Zuyev
829cc42a65
Fix network settings parsing
2021-05-05 19:11:56 -07:00
Ilya Zuyev
618d09ab76
Fix network settings parsing
2021-05-05 17:14:33 -07:00
Ilya Zuyev
01f76f7d4f
Add debug logs
2021-05-05 16:29:11 -07:00
Ilya Zuyev
adc53aa677
Fix error handling
2021-05-05 15:58:16 -07:00
Ilya Zuyev
61c1b301be
Fix linter errors
2021-05-05 15:31:11 -07:00
Ilya Zuyev
fe392b4233
When getting a gateway IP for podman container inspect per-network data as well
2021-05-05 15:09:46 -07:00
Anders F Björklund
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Ilya Zuyev
0f2c63881a
Merge branch 'master' into gh_9463_non_dev_dockerhost
2020-11-09 14:11:20 -08:00
Medya Gh
aa97aca2ff
make struct for netinfo
2020-10-23 13:45:25 -07:00
Medya Gh
94485d5a19
lint
2020-10-23 12:47:51 -07:00
Ilya Zuyev
89bf9ac01c
Update certs and API endpoints
2020-10-22 22:10:07 -07:00
Ilya Zuyev
eaa9ecfd31
Experiments
2020-10-22 13:41:01 -07:00
Priya Modali
43cc1a2581
Resolved merg conflicts.
2020-10-02 14:10:55 -07:00
Priya Modali
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
Medya Gh
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
Medya Gh
2766235a5c
try alternate if no network
2020-09-29 14:14:25 -07:00
Medya Gh
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
Anders F Björklund
af5d6d060b
Fix ForwardedPort for podman version 2.0.1 and up
...
Increasing Docker compatibility broke Podman v1
2020-09-13 22:17:36 +02:00
Priya Wadhwa
22b40e215a
revert static IP
2020-09-02 16:33:38 -04:00
Pablo Caderno
0408d3ba1a
Added code to inspect docker networks to get the bridgeID correctly
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-09-02 08:44:07 +10:00
Priya Wadhwa
bdb59c2598
lint
2020-08-12 12:56:07 -07:00
Priya Wadhwa
dfa05d714e
include gateway when creating custom network
2020-08-12 12:54:06 -07:00
Priya Wadhwa
af94e0a0c5
add logging
2020-08-12 10:57:48 -07:00
Priya Wadhwa
69d21df7c5
make sure we use custom network if it exists
2020-08-12 12:45:49 -04:00
Priya Wadhwa
3b5f973459
make sure we delete networks correctly
2020-08-12 12:36:57 -04:00
Priya Wadhwa
21789d8c4e
compile
2020-08-10 17:18:42 -04:00
Priya Wadhwa
dfcfd6f2f0
cleanup
2020-08-10 17:15:26 -04:00
Priya Wadhwa
5799b47ddb
Implement some checks and reorganize code
2020-08-10 17:04:41 -04:00
Jose Donizetti
c2175abcba
Add static ip to kic/docker
2020-07-18 18:19:53 -03:00
Anders F Björklund
14937e4677
Never use docker inspect, always provide the type
...
Should avoid errors like: map has no entry for key "State"
When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
Anders F Björklund
cc6506d2c9
Remove logging statement from containerGateway
2020-05-03 09:42:32 +02:00
Anders F Björklund
3531efda7b
Get the gateway by inspecting container network
2020-05-01 15:05:21 +02:00
Medya Gh
ef01ed481c
get rid of global CliRunner
2020-04-23 14:37:03 -07:00
Medya Gh
17f420cc71
warn slow part of cli runner
2020-04-23 01:23:49 -07:00
Medya Gh
c6e1445ccb
convert more to cli runner
2020-04-23 00:12:41 -07:00
Medya Gh
72baa1dad2
convert execs to cliRunner
2020-04-22 22:49:48 -07:00
vikkyomkar
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
Thomas Stromberg
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
Medya Gh
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00