Commit Graph

220 Commits (master)

Author SHA1 Message Date
Nir Soffer 5d4d03623b
drivers: Extract drivers/common package (#21266)
Move all files and packages which are not a driver to the drivers/common
package. This helps to understand the structure of the code.

While moving, move the iso_test.iso into testdata/test.iso to separate
code and test data.

While fixing the test iso path fix few bugs in the tests using wrong iso
path. The test failed because the iso path was wrong instead of issue
with source or destination path.

New directory structure:

    % tree -L1 pkg/drivers
    pkg/drivers
    ├── common
    ├── hyperkit
    ├── kic
    ├── krunkit
    ├── kvm
    ├── none
    ├── qemu
    ├── ssh
    └── vfkit
2025-08-08 22:50:57 -07:00
Tian 3cf1e63e21
build: address all lint issues by v2 (#20804)
* fix QF1011: could omit type *os.File from declaration; it will be inferred from the right-hand side

* fix QF1012: Use fmt.Fprintf(x, ...) instead of x.Write(fmt.Sprintf(...))

* fix QF1001: could apply De Morgan's law

* fix QF1003: could use tagged switch

* fix weakCond: suspicious ; nil check may not be enough, check for len (gocritic)

* fix docStub: silencing go lint doc-comment warnings is unadvised

* fix builtinShadow: shadowing of predeclared identifier: error

* fix importShadow: shadow of imported package

* fix nestingReduce: invert if cond, replace body with , move old body after the statement

* useless-break: useless break in case clause (revive)

* Clear the redundant content in golangci.yaml file
2025-05-23 17:31:28 -07:00
Predrag Rogic ad7fb3992c
support kubernetes ha cluster topology in minikube 2024-01-07 21:36:17 +00:00
Steven Powell a678fe11bd Add "no-limit" option to cpus & memory flags 2023-10-25 16:10:22 -07:00
Steven Powell 55b78ed5cf change gpus flag from bool to string 2023-10-05 17:18:30 -07:00
Steven Powell 311630cea9 fix gpus flag not getting passed to docker 2023-10-05 17:18:30 -07:00
Steven Powell 7f5fbf98fe Automate installing NVIDIA Container Toolkit w/ flag 2023-10-05 17:18:30 -07:00
Steven Powell 53b09081b4 Automate installing NVIDIA Container Toolkit 2023-10-05 17:18:28 -07:00
Steven Powell e6d95b8230 implement --static-ip flag 2023-01-04 10:27:00 -08:00
Christoph "criztovyl" Schulz 444f21fc71
Fix overwriting err
#14424 podman start minikube returned with exit code 125
2022-07-10 13:44:25 +02:00
Kian-Meng Ang bc03821826 Fix typos 2022-06-10 15:26:35 -07:00
Steven Powell 070e5335e0 remove unecessary icacls check 2022-03-31 15:46:37 -07:00
Sharif Elgamal 31d1fdae3b
Merge pull request #13730 from presztak/subnet_flag
Add 'subnet' flag for docker/podman driver
2022-03-30 16:02:54 -07:00
Steven Powell 535cd5201e improve icacls error messaging 2022-03-16 11:48:41 -07:00
Piotr Resztak f3c9198134 add support for 'subnet' flag 2022-03-15 21:42:09 +01:00
Medya Gh c24818d9b7 lint 2022-02-01 13:21:53 -08:00
James Yin 54be390bba fix: check err before preload 2021-11-03 15:27:15 +08:00
Andriy Dzikh f9f3ef9a09 Pass driverName into Preload and PreloadExists to report no preload for BareMetal. 2021-05-27 15:02:00 -07:00
Daehyeok Mun d6691e796c Add `Close() error` function into assets.CopyableFile
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Anders F Björklund f527fb675a Address security concerns with the go code
As flagged by the github code scanning
2021-04-12 20:38:21 +02:00
Anders F Björklund db3fd51194 Rename ListOptions to ListContainersOptions 2021-04-06 22:39:43 +02:00
Patrik Freij 3110bd15fc Lowercase minikube in information message 2021-03-05 15:50:52 +01:00
Patrik Freij 0d1d169bf6 Set non-local traffic message as a Tip message
To stay consistent with other messages. Also moved it above the warning
message regarding what IP is set as listen-address to make more sense in
the message flow.
2021-03-03 17:07:23 +01:00
Patrik Freij bb5bf9546c Add info message about not using it for production
To add more context to the warning message for --listen-address
2021-03-02 20:21:39 +01:00
Patrik Freij 9b5a96e76d Make warning more informative for --listen-address 2021-03-01 23:10:58 +01:00
Patrik Freij bad8561d0d Skip custom listenAddress if equal to default 2021-03-01 23:06:13 +01:00
Patrik Freij cb116e4c1c Add --listen-address for docker driver 2021-02-28 23:14:08 +01:00
Medya Gh 72135d70d9 add auto pause proxy 2021-02-24 12:30:06 -08:00
Priya Wadhwa a6372b35a3 Add 5 minute timeout to deleting leftover cvolumes and containers 2021-02-08 15:15:08 -08:00
Priya Wadhwa 55f496492c fix merge conflict 2020-12-16 10:37:51 -08:00
Thomas Strömberg f85bed1150
Merge pull request #9753 from blueelvis/'bug/9078-tunnel-windows-docker'
Fix minikube tunnel for Docker on Windows
2020-12-15 07:59:44 -08:00
Jituri, Pranav a8463f3453
fix linting errors 2020-12-15 18:25:10 +05:30
Jituri, Pranav ce17200bd8
address review comment 2020-12-15 18:09:43 +05:30
Anders F Björklund c3d0621d97 Only use sudo with the none driver when on linux 2020-12-10 21:07:10 +01:00
Jituri, Pranav 74cdda9e9a
Resolve review comments 2020-12-09 16:54:19 +05:30
Priya Wadhwa f373155d55 merge conflict 2020-12-03 10:56:41 -08:00
Anders F Björklund fee0f5310a Add private network implementation for podman
Most of it the same as docker, except for the options.

i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Jituri, Pranav 197f2a25ae
Removed unused debugging lines 2020-11-21 00:30:05 +05:30
Jituri, Pranav bf7b09f484
Fix permissions for key file on Windows 2020-11-21 00:27:19 +05:30
Ilya Zuyev c97cd912f1 Rename oci.RuntimeHost() -> oci.DaemonHost() 2020-10-30 13:44:34 -07:00
Ilya Zuyev 72b710af03 Fix warning about listening to 0.0.0.0 2020-10-30 13:41:06 -07:00
Ilya Zuyev acbdafa4e1 Fix func naming 2020-10-27 16:07:50 -07:00
Priya Wadhwa ea6ca08d67 Change flag name to --network and exit if used without docker driver 2020-10-26 11:52:26 -07:00
Priya Wadhwa 8b4c48143b implement --docker-network flag 2020-10-23 09:50:23 -07:00
Ilya Zuyev 89bf9ac01c Update certs and API endpoints 2020-10-22 22:10:07 -07:00
Ilya Zuyev eaa9ecfd31 Experiments 2020-10-22 13:41:01 -07:00
Ilya Zuyev 85d45be207 Fix docker-env command 2020-10-20 23:10:08 -07:00
Priya Modali ef2090ac31 Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-08 10:27:04 -07:00
Medya Ghazizadeh e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
Priya Modali 3703f69c25 Applying klogFlags set via cobra. 2020-10-06 11:20:51 -07:00