* remove un-needed gomod replaces
* add a make target gomodtidy
* update docs on using gomodtidy
* add automation to run go mod tidy on every push
* update contributing docs to be more helpful
* install gopogh if it is not installed in html_report
* addres PR reviews
* update docs headings
Using go workspace breaks iso build, and may affect the builds in
unwanted ways, bringing dependencies from the hack module into the
minikube module.
Remove the go.work file and add a replace directive to the hack module,
so it can access minikube packages from the local directory.
Some programs working directory was the source directory. With this
change all programs and scripts in the hack module are run from the
hack directory. Paths updated to the programs can find files in the
minikube root directory.
Some updaters and benchmarks are broken in master and are still broken
with this change.
These updates fail to pull non-existing images:
- make update-istio-operator-version
- make update-amd-gpu-device-plugin-version
These try to install try to install in /usr/local/bin with sudo and
neede rewrite:
- make cpu-benchmark-idle
- make cpu-benchmark-autopause
- make time-to-k8s-benchmark
* Refactored table rendering codes to support updated tablewriter v1.0.7
This commit makes all necessary code changes to maintain compatibility
with the new tablewriter version. The update includes several required modifications across multiple files.
Files modified:
- cmd/minikube/cmd/config/images.go
- cmd/minikube/cmd/config/addons_list.go
- cmd/minikube/cmd/config/profile_list.go
- hack/benchmark/time-to-k8s/chart.go
- hack/benchmark/time-to-k8s/cpu.go
- pkg/minikube/audit/row.go
- pkg/minikube/machine/cache_images.go
- pkg/minikube/perf/result_manager.go
- pkg/minikube/service/service.go
Now #20878 can be merged.
Addresses #20879
* The tablewriter package v1.0.7 renamed SetHeaders to SetHeader
* updated go mod and table.SetColumnAlignment([]int{0, 0, 0, 0})
* Changed syntax and added vendor to gitignore
* simplified version of tablewriter
* removed vendor
* fix addon_list
* fix images tablewrtier
* bump tablewriter for profile list
* go mod tidy
* bump tablewriter for chart
* bump tablewriter for cpu chart
* bump tablewriter for row
* bump tablewriter cache images
* bump tablewriter
* bump tablewriter
* revert file
* bump tablewritter
* fix unit test
* fix lint issues
* fix the integration test pipe char
* convert all tables to new pipe instead of asci pipe
* convert all tables to new pipe instead of asci pipe
* go mod tidy
* go work sync
---------
Co-authored-by: Medya Ghazizadeh <medya@google.com>
* add go work files since there hack mod uses root mod
* add toolchain
* change Makefile to run the updates using full path to use go.work file
* add comment make file and move generate license above
* add go-license to ignore to avoid making release commit dirty
* force hack module to use older tablewriter lib
* dont do gitignore
minikube-bot
Nir Soffer
dependabot[bot]
Medya Ghazizadeh
Medya Ghazizadeh
Victor Ubahakwe