kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Switch cross builds to use BUILD_IN_DOCKER 

minikube-linux-amd64 and minikube-darwin-amd64 cannot be cross built
natively on different platforms and must be built in the container.
pull/1656/head
Matt Rickard 2017-06-28 13:48:42 -07:00
parent 3ffc1e7b7f
commit f99888219f
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/contributors/releasing_minikube.md
View File

@ -40,7 +40,7 @@ Send a PR for the Makefile change and wait until it is merged. Once the commit
Run this command: Run this command:
```shell ```shell
make cross checksum BUILD_IN_DOCKER=y make cross checksum
``` ```
## Add the version to the releases.json file ## Add the version to the releases.json file

2
hack/jenkins/minikube_cross_build_and_upload.sh
View File

@ -38,7 +38,7 @@ fi
export GOPATH=~/go export GOPATH=~/go
# Build all platforms (Windows, Linux, OSX) # Build all platforms (Windows, Linux, OSX)
make cross BUILD_IN_DOCKER=y make cross
# Build the e2e test target for Darwin and Linux. We don't run tests on Windows yet. # Build the e2e test target for Darwin and Linux. We don't run tests on Windows yet.
# We build these on Linux, but run the tests on different platforms. # We build these on Linux, but run the tests on different platforms.

2
hack/jenkins/release_build_and_upload.sh
View File

@ -38,7 +38,7 @@ cat Makefile | grep "VERSION_MINOR ?=" | grep $VERSION_MINOR
cat Makefile | grep "VERSION_BUILD ?=" | grep $VERSION_BUILD cat Makefile | grep "VERSION_BUILD ?=" | grep $VERSION_BUILD
# Build and upload # Build and upload
make cross checksum BUILD_IN_DOCKER=y make cross checksum
gsutil cp out/minikube-linux-amd64 gs://$BUCKET/releases/$TAGNAME/ gsutil cp out/minikube-linux-amd64 gs://$BUCKET/releases/$TAGNAME/
gsutil cp out/minikube-linux-amd64.sha256 gs://$BUCKET/releases/$TAGNAME/ gsutil cp out/minikube-linux-amd64.sha256 gs://$BUCKET/releases/$TAGNAME/