kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

update.GHReleases: replace deprecated semver.Max with semver.Compare

pull/10569/head
Predrag Rogic 2021-02-22 17:22:13 +00:00
parent b09523131d
commit f80c8c9dc5
No known key found for this signature in database
GPG Key ID: F1FF5748C4855229
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hack/update/github.go
View File

@ -228,9 +228,13 @@ func GHReleases(ctx context.Context, owner, repo string) (stable, latest string,
// check if ver version is release (ie, 'v1.19.2') or pre-release (ie, 'v1.19.3-rc.0' or 'v1.19.0-beta.2') // check if ver version is release (ie, 'v1.19.2') or pre-release (ie, 'v1.19.3-rc.0' or 'v1.19.0-beta.2')
prerls := semver.Prerelease(ver) prerls := semver.Prerelease(ver)
if prerls == "" { if prerls == "" {
stable = semver.Max(ver, stable) if semver.Compare(ver, stable) == 1 {
stable = ver
}
} else if strings.HasPrefix(prerls, "-rc") || strings.HasPrefix(prerls, "-beta") { } else if strings.HasPrefix(prerls, "-rc") || strings.HasPrefix(prerls, "-beta") {
latest = semver.Max(ver, latest) if semver.Compare(ver, latest) == 1 {
latest = ver
}
} }
// make sure that latest >= stable // make sure that latest >= stable
if semver.Compare(latest, stable) == -1 { if semver.Compare(latest, stable) == -1 {