kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #11601 from spowelljr/fixLog 

Prevent misleading "save to tar file succeeded" message from being logged
pull/11610/head
Sharif Elgamal 2021-06-08 13:12:41 -07:00 committed by GitHub
parent 471207b1d8 b4cc318d85
commit f78f6afe16
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/minikube/image/cache.go
View File

@ -73,10 +73,10 @@ func SaveToDir(images []string, cacheDir string, overwrite bool) error {
dst = localpath.SanitizeCacheDir(dst) dst = localpath.SanitizeCacheDir(dst)
if err := saveToTarFile(image, dst, overwrite); err != nil { if err := saveToTarFile(image, dst, overwrite); err != nil {
if err == errCacheImageDoesntExist { if err == errCacheImageDoesntExist {
out.WarningT("The image you are trying to add {{.imageName}} doesn't exist!", out.V{"imageName": image}) out.WarningT("The image '{{.imageName}}' was not found; unable to add it to cache.", out.V{"imageName": image})
} else { return nil
return errors.Wrapf(err, "caching image %q", dst)
} }
return errors.Wrapf(err, "caching image %q", dst)
} }
klog.Infof("save to tar file %s -> %s succeeded", image, dst) klog.Infof("save to tar file %s -> %s succeeded", image, dst)
return nil return nil