From f71272ca7972bcd1adac90184f079e17f3d27e44 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Wed, 30 Sep 2020 17:22:45 -0700 Subject: [PATCH] don't allow profile name to be less than 2 characters --- cmd/minikube/cmd/start.go | 2 +- pkg/minikube/config/profile.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 8975cd787b..ff85c7ded0 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -155,7 +155,7 @@ func runStart(cmd *cobra.Command, args []string) { if !config.ProfileNameValid(ClusterFlagValue()) { out.WarningT("Profile name '{{.name}}' is not valid", out.V{"name": ClusterFlagValue()}) - exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 1 character, starting with alphanumeric.") + exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 2 character, starting with alphanumeric.") } existing, err := config.Load(ClusterFlagValue()) diff --git a/pkg/minikube/config/profile.go b/pkg/minikube/config/profile.go index b5baf5ed4f..f7e8c142db 100644 --- a/pkg/minikube/config/profile.go +++ b/pkg/minikube/config/profile.go @@ -90,8 +90,8 @@ func ProfileNameValid(name string) bool { const RestrictedNamePattern = `(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])` var validName = regexp.MustCompile(`^` + RestrictedNamePattern + `$`) - - return validName.MatchString(name) + // length needs to be more than 1 character because docker volume #9366 + return validName.MatchString(name) && len(name) > 1 } // ProfileNameInReservedKeywords checks if the profile is an internal keywords