From f345fe4b087bf5ad72b7455400c420275f3ddb9d Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 15 Feb 2019 09:11:46 -0800 Subject: [PATCH] Less warnings, consistent info messages --- pkg/minikube/cruntime/cri.go | 4 ++-- pkg/minikube/cruntime/docker.go | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/minikube/cruntime/cri.go b/pkg/minikube/cruntime/cri.go index b346b42803..ff9c8c52f2 100644 --- a/pkg/minikube/cruntime/cri.go +++ b/pkg/minikube/cruntime/cri.go @@ -43,18 +43,18 @@ func listCRIContainers(cr CommandRunner, filter string) ([]string, error) { // criCRIContainers kills a list of containers using crictl func killCRIContainers(cr CommandRunner, ids []string) error { if len(ids) == 0 { - glog.Warningf("KillContainers was called with an empty list of ids, nothing to do.") return nil } + glog.Infof("Killing containers: %s", ids) return cr.Run(fmt.Sprintf("sudo crictl rm %s", strings.Join(ids, " "))) } // stopCRIContainers stops containers using crictl func stopCRIContainers(cr CommandRunner, ids []string) error { if len(ids) == 0 { - glog.Warningf("StopContainers was called with an empty list of ids, nothing to do.") return nil } + glog.Infof("Stopping containers: %s", ids) return cr.Run(fmt.Sprintf("sudo crictl stop %s", strings.Join(ids, " "))) } diff --git a/pkg/minikube/cruntime/docker.go b/pkg/minikube/cruntime/docker.go index 5f80e723a0..4b1d02cb24 100644 --- a/pkg/minikube/cruntime/docker.go +++ b/pkg/minikube/cruntime/docker.go @@ -110,10 +110,9 @@ func (r *Docker) KillContainers(ids []string) error { // StopContainers stops a running container based on ID func (r *Docker) StopContainers(ids []string) error { if len(ids) == 0 { - glog.Warningf("StopContainers was called with an empty list of ids, nothing to do.") return nil } - glog.Infof("Killing containers: %s", ids) + glog.Infof("Stopping containers: %s", ids) return r.Runner.Run(fmt.Sprintf("docker stop %s", strings.Join(ids, " "))) }