From 0d33242daef60bd07e5b39fd6491e52d04eac207 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Wed, 9 Sep 2020 14:45:21 -0700 Subject: [PATCH 1/2] kic base release docs --- site/content/en/docs/contrib/releasing/binaries.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/site/content/en/docs/contrib/releasing/binaries.md b/site/content/en/docs/contrib/releasing/binaries.md index 3ceb045ee9..2a320004cd 100644 --- a/site/content/en/docs/contrib/releasing/binaries.md +++ b/site/content/en/docs/contrib/releasing/binaries.md @@ -20,6 +20,14 @@ description: > See [ISO release instructions]({{}}) +## Tag KIC base image + +for container drivers (docker,podman), if there has been any change in Dockerfile +(and there is a -snapshot image), should tag with latest release and push to gcr and docker hub and github packages. + +for example if you are releasing v0.0.13 and latest kicbase image is v0.0.12-snapshot +should tag v0.0.13 and change the [kic/types.go](https://github.com/medyagh/minikube/blob/635ff53a63e5bb1be4e1abb9067ebe502a16224e/pkg/drivers/kic/types.go#L29-L30) file as well. + ## Update Release Notes Run the following script from your local upstream repo copy to generate updated release notes: From 00dcaad4b0090db24682858d83a2711c9260b4a1 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Fri, 11 Sep 2020 18:46:53 -0700 Subject: [PATCH 2/2] dont not delete downloaded images --- .github/workflows/master.yml | 4 ++-- .github/workflows/pr.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 26a5cecc3c..5521378f3b 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -326,7 +326,7 @@ jobs: $docker_running = $? } Write-Output "Docker is running" - docker system prune -f -a + docker system prune -f - name: Info shell: powershell run: | @@ -464,7 +464,7 @@ jobs: $docker_running = $? } Write-Output "Docker is running" - docker system prune -f -a + docker system prune -f - name: Info continue-on-error: true shell: powershell diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 93d710d1e9..21cd5e5a04 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -324,7 +324,7 @@ jobs: $docker_running = $? } Write-Output "Docker is running" - docker system prune -f -a + docker system prune -f - name: Info shell: powershell run: | @@ -462,7 +462,7 @@ jobs: $docker_running = $? } Write-Output "Docker is running" - docker system prune -f -a + docker system prune -f - name: Info continue-on-error: true shell: powershell