From f0226e50a9bba25e9ee7722ee4c0229587d20c90 Mon Sep 17 00:00:00 2001 From: hex0punk Date: Thu, 29 Apr 2021 22:45:39 -0700 Subject: [PATCH] Revert "prevents a goroutine from being leaked in call to readByteWithTimeout" This reverts commit 8810120de61fde332f7579d55c5a43a3cb5557e6. --- cmd/minikube/cmd/dashboard.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/minikube/cmd/dashboard.go b/cmd/minikube/cmd/dashboard.go index 68fce8c86e..f1fa86d726 100644 --- a/cmd/minikube/cmd/dashboard.go +++ b/cmd/minikube/cmd/dashboard.go @@ -172,8 +172,8 @@ func kubectlProxy(kubectlVersion string, contextName string) (*exec.Cmd, string, // readByteWithTimeout returns a byte from a reader or an indicator that a timeout has occurred. func readByteWithTimeout(r io.ByteReader, timeout time.Duration) (byte, bool, error) { - bc := make(chan byte, 1) - ec := make(chan error, 1) + bc := make(chan byte) + ec := make(chan error) go func() { b, err := r.ReadByte() if err != nil {