diff --git a/enhancements/proposed/20201030-tracing/README.md b/enhancements/proposed/20201030-tracing/README.md index 767a529034..e327460b77 100644 --- a/enhancements/proposed/20201030-tracing/README.md +++ b/enhancements/proposed/20201030-tracing/README.md @@ -37,7 +37,7 @@ There are two pieces to the design: collecting the data and exporting the data. ### Collecting Data Luckily, we already have a lot of this infrastructure set up for JSON output. -We know when a new substep of `minikube start` has started, because we call it explictly via `register.SetStep`. +We know when a new substep of `minikube start` has started, because we call it explicitly via `register.SetStep`. We also know that substep has ended when a new substep begins. We can start new spans whenever `register.SetStep` is called, and thus collect tracing data. diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index 586827b86b..36de67a592 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -46,7 +46,6 @@ import ( "k8s.io/minikube/pkg/util/retry" "github.com/elazarl/goproxy" - "github.com/hashicorp/go-retryablehttp" "github.com/otiai10/copy" "github.com/phayes/freeport" "github.com/pkg/errors" @@ -85,7 +84,7 @@ func TestFunctional(t *testing.T) { {"CopySyncFile", setupFileSync}, // Set file for the file sync test case {"StartWithProxy", validateStartWithProxy}, // Set everything else up for success {"AuditLog", validateAuditAfterStart}, // check audit feature works - {"SoftStart", validateSoftStart}, // do a soft start. ensure config didnt change. + {"SoftStart", validateSoftStart}, // do a soft start. ensure config didn't change. {"KubeContext", validateKubeContext}, // Racy: must come immediately after "minikube start" {"KubectlGetPods", validateKubectlGetPods}, // Make sure apiserver is up {"CacheCmd", validateCacheCmd}, // Caches images needed for subsequent tests because of proxy