Merge pull request #14756 from minikube-bot/auto_bump_golint_version

bump golint version

Makefile

@@ -76,7 +76,7 @@ MINIKUBE_RELEASES_URL=https://github.com/kubernetes/minikube/releases/download
 KERNEL_VERSION ?= 5.10.57
 # latest from https://github.com/golangci/golangci-lint/releases 
 # update this only by running `make update-golint-version`
-GOLINT_VERSION ?= v1.47.2
+GOLINT_VERSION ?= v1.48.0
 # Limit number of default jobs, to avoid the CI builds running out of memory
 GOLINT_JOBS ?= 4
 # see https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint

deploy/minikube/release_sanity_test.go

@@ -46,6 +46,7 @@ func getSHAFromURL(url string) (string, error) {
 }
 
 // TestReleasesJSON checks if all *GA* releases
+//
 //	enlisted in https://storage.googleapis.com/minikube/releases.json
 //	are available to download and have correct hashsum
 func TestReleasesJSON(t *testing.T) {
@@ -57,6 +58,7 @@ func TestReleasesJSON(t *testing.T) {
 }
 
 // TestBetaReleasesJSON checks if all *BETA* releases
+//
 //	enlisted in https://storage.googleapis.com/minikube/releases-beta.json
 //	are available to download and have correct hashsum
 func TestBetaReleasesJSON(t *testing.T) {

hack/jenkins/test-flake-chart/compute_flake_rate.go

@@ -58,6 +58,7 @@ func main() {
 }
 
 // One entry of a test run.
+//
 //	Example: TestEntry {
 //		 name: "TestFunctional/parallel/LogsCmd",
 //	  environment: "Docker_Linux",

hack/update/golint_version/update_golint_version.go

@@ -62,7 +62,6 @@ func main() {
 	update.Apply(schema, data)
 }
 
-//
 // golintVersions returns stable version in semver format.
 func golintVersion(ctx context.Context, owner, repo string) (stable string, err error) {
 	// get Kubernetes versions from GitHub Releases

pkg/drivers/kic/oci/types.go

@@ -84,11 +84,13 @@ https://github.com/kubernetes/kubernetes/blob/063e7ff358fdc8b0916e6f39beedc0d025
 // names on disk as opposed to the int32 values, and the serlialzed field names
 // have been made closer to core/v1 VolumeMount field names
 // In yaml this looks like:
+//
 //	containerPath: /foo
 //	hostPath: /bar
 //	readOnly: true
 //	selinuxRelabel: false
 //	propagation: None
+//
 // Propagation may be one of: None, HostToContainer, Bidirectional
 type Mount struct {
 	// Path of the mount within the container.
@@ -158,6 +160,7 @@ func ParseMountString(spec string) (m Mount, err error) {
 
 // PortMapping specifies a host port mapped into a container port.
 // In yaml this looks like:
+//
 //	containerPort: 80
 //	hostPort: 8000
 //	listenAddress: 127.0.0.1

pkg/gvisor/enable.go

@@ -151,6 +151,7 @@ func downloadFileToDest(url, dest string) error {
 // Must write the following files:
 //  1. gvisor-containerd-shim.toml
 //  2. gvisor containerd config.toml
+//
 // and save the default version of config.toml
 func copyConfigFiles() error {
 	log.Printf("Storing default config.toml at %s", storedContainerdConfigTomlPath)

pkg/minikube/bootstrapper/bsutil/kubeadm_test.go

@@ -122,7 +122,8 @@ func recentReleases(n int) ([]string, error) {
 	return versions, nil
 }
 
-/**
+/*
+*
 This test case has only 1 thing to test and that is the
 networking/dnsDomain value
 */

pkg/minikube/cni/calico.go

@@ -29,6 +29,7 @@ import (
 )
 
 // https://docs.projectcalico.org/manifests/calico.yaml
+//
 //go:embed calico.yaml
 var calicoYaml string
 

pkg/minikube/image/image.go

@@ -302,6 +302,7 @@ func cleanImageCacheDir() error {
 
 // normalizeTagName automatically tag latest to image
 // Example:
+//
 //	nginx -> nginx:latest
 //	localhost:5000/nginx -> localhost:5000/nginx:latest
 //	localhost:5000/nginx:latest -> localhost:5000/nginx:latest

pkg/network/network.go

@@ -80,6 +80,7 @@ type Interface struct {
 // lookupInInterfaces iterates over all local network interfaces
 // and tries to match "ip" with associated networks
 // returns (network parameters, ip network, nil) if found
+//
 //	(nil, nil, nil) it nof
 //	(nil, nil, error) if any error happened
 func lookupInInterfaces(ip net.IP) (*Parameters, *net.IPNet, error) {
@@ -257,6 +258,7 @@ func FreeSubnet(startSubnet string, step, tries int) (*Parameters, error) {
 // reserveSubnet returns if subnet was successfully reserved for given period:
 //   - false, if it already has unexpired reservation
 //   - true, if new reservation was created or expired one renewed
+//
 // uses sync.Map to manage reservations thread-safe
 func reserveSubnet(subnet string, period time.Duration) bool {
 	// put 'zero' reservation{} Map value for subnet Map key

test/integration/start_stop_delete_test.go

@@ -445,9 +445,12 @@ func testPause(ctx context.Context, t *testing.T, profile string) {
 
 // Remove container-specific prefixes for naming consistency
 // for example in `docker` runtime we get this:
+//
 //		$ docker@minikube:~$ sudo crictl images -o json | grep dash
 //	         "kubernetesui/dashboard:vX.X.X"
+//
 // but for 'containerd' we get full name
+//
 //			$ docker@minikube:~$  sudo crictl images -o json | grep dash
 //	       	 "docker.io/kubernetesui/dashboard:vX.X.X"
 func trimImageName(name string) string {

translations/translations.go

@@ -19,5 +19,6 @@ package translations
 import "embed"
 
 // Translations contains all translation JSON files.
+//
 //go:embed *.json
 var Translations embed.FS