move all starts to new start func

test/integration/a_download_only_test.go

@@ -0,0 +1,42 @@
+// +build integration
+
+/*
+Copyright 2019 The Kubernetes Authors All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integration
+
+import (
+	"testing"
+	"time"
+)
+
+// TestDownloadOnly downloads ISOs also tests the --download-only option
+// Note this test runs before all tests (because of file name) and caches images for them
+func TestDownloadOnly(t *testing.T) {
+	p := t.Name()
+	if isTestNoneDriver() {
+		t.Skip()
+
+	}
+	mk := NewMinikubeRunner(t, p)
+	stdout, stderr, err := mk.StartWithStds(15*time.Minute, "--download-only")
+	if err != nil {
+		t.Fatalf("%s minikube start failed : %v\nstdout: %s\nstderr: %s", p, err, stdout, stderr)
+	}
+	// TODO: add test to check if files are downloaded
+
+	mk.RunCommand("delete", true)
+}

test/integration/containerd_test.go

@@ -95,7 +95,10 @@ func testGvisorRestart(t *testing.T) {
 	// TODO: @priyawadhwa to add test for stop as well
 	mk.RunCommand("delete", false)
 	mk.CheckStatus(state.None.String())
-	mk.Start()
+	stdout, stderr, err := mk.StartWithStds(15 * time.Minute)
+	if err != nil {
+		t.Fatalf("%s minikube start failed : %v\nstdout: %s\nstderr: %s", t.Name() err, stdout, stderr)
+	}
 	mk.CheckStatus(state.Running.String())
 
 	t.Log("waiting for gvisor controller to come up")

test/integration/iso_test.go

@@ -34,7 +34,10 @@ func TestISO(t *testing.T) {
 
 	mk := NewMinikubeRunner(t, p, "--wait=false")
 	mk.RunCommand("delete", false)
-	mk.Start()
+	stdout, stderr, err := mk.StartWithStds(15 * time.Minute)
+	if err != nil {
+		t.Fatalf("%s minikube start failed : %v\nstdout: %s\nstderr: %s", t.Name() err, stdout, stderr)
+	}
 
 	t.Run("permissions", testMountPermissions)
 	t.Run("packages", testPackages)

test/integration/persistence_test.go

@@ -64,7 +64,10 @@ func TestPersistence(t *testing.T) {
 		t.Fatalf("TestPersistence Failed to stop minikube : %v", err)
 	}
 
-	mk.Start()
+	stdout, stderr, err := mk.StartWithStds(15 * time.Minute)
+	if err != nil {
+		t.Fatalf("%s minikube start failed : %v\nstdout: %s\nstderr: %s", t.Name() err, stdout, stderr)
+	}
 	mk.CheckStatus(state.Running.String())
 
 	// Make sure the same things come up after we've restarted.

test/integration/proxy_test.go

@@ -104,7 +104,7 @@ func testProxyWarning(t *testing.T) {
 	mk := NewMinikubeRunner(t, p)
 	stdout, stderr, err := mk.StartWithStds(15 * time.Minute)
 	if err != nil {
-		t.Fatalf("TestProxy minikube start failed : %v\nstdout: %s\nstderr: %s", err, stdout, stderr)
+		t.Fatalf("%s minikube start failed : %v\nstdout: %s\nstderr: %s", t.Name() err, stdout, stderr)
 	}
 
 	msg := "Found network options:"