kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

kubeconfig_test: cleanup temp kubeconfig file 

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
pull/8505/head
Li Zhijian 2020-06-17 18:31:17 +08:00
parent 804e772efd
commit e6b905608d
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/minikube/kubeconfig/context_test.go
View File

@ -26,6 +26,7 @@ import (
func TestDeleteContext(t *testing.T) { func TestDeleteContext(t *testing.T) {
// See kubeconfig_test // See kubeconfig_test
fn := tempFile(t, kubeConfigWithoutHTTPS) fn := tempFile(t, kubeConfigWithoutHTTPS)
defer os.Remove(fn)
if err := DeleteContext("la-croix", fn); err != nil { if err := DeleteContext("la-croix", fn); err != nil {
t.Fatal(err) t.Fatal(err)
} }

3
pkg/minikube/kubeconfig/kubeconfig_test.go
View File

@ -263,6 +263,7 @@ func TestVerifyEndpoint(t *testing.T) {
t.Run(test.description, func(t *testing.T) { t.Run(test.description, func(t *testing.T) {
t.Parallel() t.Parallel()
configFilename := tempFile(t, test.existing) configFilename := tempFile(t, test.existing)
defer os.Remove(configFilename)
err := VerifyEndpoint("minikube", test.hostname, test.port, configFilename) err := VerifyEndpoint("minikube", test.hostname, test.port, configFilename)
if err != nil && !test.err { if err != nil && !test.err {
t.Errorf("Got unexpected error: %v", err) t.Errorf("Got unexpected error: %v", err)
@ -330,6 +331,7 @@ func TestUpdateIP(t *testing.T) {
t.Run(test.description, func(t *testing.T) { t.Run(test.description, func(t *testing.T) {
t.Parallel() t.Parallel()
configFilename := tempFile(t, test.existing) configFilename := tempFile(t, test.existing)
defer os.Remove(configFilename)
statusActual, err := UpdateEndpoint("minikube", test.hostname, test.port, configFilename) statusActual, err := UpdateEndpoint("minikube", test.hostname, test.port, configFilename)
if err != nil && !test.err { if err != nil && !test.err {
t.Errorf("Got unexpected error: %v", err) t.Errorf("Got unexpected error: %v", err)
@ -419,6 +421,7 @@ func Test_Endpoint(t *testing.T) {
for _, test := range tests { for _, test := range tests {
t.Run(test.description, func(t *testing.T) { t.Run(test.description, func(t *testing.T) {
configFilename := tempFile(t, test.cfg) configFilename := tempFile(t, test.cfg)
defer os.Remove(configFilename)
hostname, port, err := Endpoint("minikube", configFilename) hostname, port, err := Endpoint("minikube", configFilename)
if err != nil && !test.err { if err != nil && !test.err {
t.Errorf("Got unexpected error: %v", err) t.Errorf("Got unexpected error: %v", err)