From e108b0a1b3172873e7699fc3325d6b5f785c9df0 Mon Sep 17 00:00:00 2001
From: Steven Powell <spowellgrr@gmail.com>
Date: Tue, 20 Apr 2021 14:16:45 -0700
Subject: [PATCH] create tmp log file for testing

---
 pkg/minikube/out/out_test.go | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/pkg/minikube/out/out_test.go b/pkg/minikube/out/out_test.go
index a8d16b04fd..d97e928269 100644
--- a/pkg/minikube/out/out_test.go
+++ b/pkg/minikube/out/out_test.go
@@ -116,27 +116,42 @@ func TestErr(t *testing.T) {
 	}
 }
 
-func TestGetLatestLogPath(t *testing.T) {
+func createLogFile() (string, error) {
 	td := os.Getenv("TMPDIR")
 	if td == "" {
 		td = "/tmp/"
 	}
-	want := fmt.Sprintf("%sminikube_test_test_test.log", td)
-	f, err := os.Create(want)
+	name := fmt.Sprintf("%sminikube_test_test_test.log", td)
+	f, err := os.Create(name)
 	if err != nil {
-		t.Fatalf("failed to create file: %v", err)
+		return "", fmt.Errorf("failed to create log file: %v", err)
 	}
-	defer os.Remove(f.Name())
+
+	return f.Name(), nil
+}
+
+func TestGetLatestLogPath(t *testing.T) {
+	want, err := createLogFile()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.Remove(want)
 	got, err := getLatestLogFilePath()
 	if err != nil {
 		t.Fatalf("failed to get latest log file name: %v", err)
 	}
 	if got != want {
-		t.Errorf("getLatestLogFile() = %q; want %q", got, want)
+		t.Errorf("getLatestLogPath() = %q; want %q", got, want)
 	}
 }
 
 func TestDisplayLogLocationMessage(t *testing.T) {
+	filename, err := createLogFile()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.Remove(filename)
+
 	testCases := []struct {
 		args []string
 		want string
@@ -147,7 +162,7 @@ func TestDisplayLogLocationMessage(t *testing.T) {
 		},
 		{
 			[]string{"minikube", "status"},
-			"minikube",
+			filename,
 		},
 	}