kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix comments

pull/5649/head
Thomas Stromberg 2019-10-17 12:55:56 -07:00
parent 21aeec60ea
commit e008688239
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/integration/a_serial_tests.go
View File

@ -33,7 +33,6 @@ import (
"k8s.io/minikube/pkg/minikube/localpath" "k8s.io/minikube/pkg/minikube/localpath"
) )
// This test runs before others due to filename order.
func TestDownloadAndDeleteAll(t *testing.T) { func TestDownloadAndDeleteAll(t *testing.T) {
profile := UniqueProfileName("download") profile := UniqueProfileName("download")
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Minute) ctx, cancel := context.WithTimeout(context.Background(), 15*time.Minute)
@ -76,8 +75,8 @@ func TestDownloadAndDeleteAll(t *testing.T) {
} }
}) })
} }
// This is a weird place to test profile deletion, but this test is serial, and we have a profile to delete!
t.Run("DeleteAll", func(t *testing.T) { t.Run("DeleteAll", func(t *testing.T) {
// This is a weird place to test profile deletion, but this test is serial, and we have an unneccesary profile to delete!
rr, err := Run(t, exec.CommandContext(ctx, Target(), "delete", "--all")) rr, err := Run(t, exec.CommandContext(ctx, Target(), "delete", "--all"))
if err != nil { if err != nil {
t.Errorf("%s failed: %v", rr.Args, err) t.Errorf("%s failed: %v", rr.Args, err)