From dfd9f7a9d1fafa9fabae625d8deda4883a3a32fa Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 7 Apr 2020 03:06:44 -0700 Subject: [PATCH] handle Port 0 in configs --- cmd/minikube/cmd/start_flags.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cmd/minikube/cmd/start_flags.go b/cmd/minikube/cmd/start_flags.go index 092ecc5a3f..9262cb43b4 100644 --- a/cmd/minikube/cmd/start_flags.go +++ b/cmd/minikube/cmd/start_flags.go @@ -415,6 +415,14 @@ func updateExistingConfigFromFlags(cmd *cobra.Command, existing *config.ClusterC existing.KubernetesConfig.NodePort = viper.GetInt(apiServerPort) } + // pre minikube 1.9.2 cc.KubernetesConfig.NodePort was not populated. + // in minikube config there were two fields for api server port. + // one in cc.KubernetesConfig.NodePort and one in cc.Nodes.Port + // this makes sure api server port not be set as 0! + if existing.KubernetesConfig.NodePort == 0 { + existing.KubernetesConfig.NodePort = viper.GetInt(apiServerPort) + } + if cmd.Flags().Changed(dnsDomain) { existing.KubernetesConfig.DNSDomain = viper.GetString(dnsDomain) }