kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #21544 from medyagh/iso_fail_comment_fix 

ci: fix failed ISO not commenting on PR
pull/21645/head
Medya Ghazizadeh 2025-09-26 12:56:22 -07:00 committed by GitHub
parent 71227b25cd 3a8d719855
commit dfb4f364ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
hack/jenkins/build_iso.sh
View File

@ -65,16 +65,23 @@ else
export ISO_BUCKET export ISO_BUCKET
fi fi
make release-iso | tee iso-logs.txt if ! make release-iso 2>&1 | tee iso-logs.txt; then
# Abort with error message if above command failed # Exit of `make` (PIPESTATUS[0]); fallback to 1 if unavailable
ec=$? ec=${PIPESTATUS[0]:-1}
if [ $ec -gt 0 ]; then
if [ "$release" = false ]; then # Only comment on non-release; default release=false if unset
gh pr comment ${ghprbPullId} --body "Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed. if [[ ${release:-false} != "true" ]]; then
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit::7}/iso_build.txt body="$(cat <<'EOF'
" Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed for Commit ${ghprbActualCommit}
fi See the logs at:
exit $ec https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit::7}/iso_build.txt
EOF
"
gh pr comment "${ghprbPullId}" --body "$body"
fi
exit "$ec"
fi fi
git config user.name "minikube-bot" git config user.name "minikube-bot"