kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #16796 from lbogdan/feat/vmware-new-iso 

feat: add VMware driver support for new minikube ISO
pull/16872/head
Steven Powell 2023-07-12 13:47:35 -07:00 committed by GitHub
parent c3ef0bccb3 9502f96cae
commit de791e7e3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/minikube/cmd/start.go
View File

@ -303,7 +303,6 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing *
}
virtualBoxMacOS13PlusWarning(driverName)
vmwareUnsupported(driverName)
validateFlags(cmd, driverName)
validateUser(driverName)
if driverName == oci.Docker {
@ -411,16 +410,6 @@ func virtualBoxMacOS13PlusWarning(driverName string) {
`, out.V{"driver": suggestedDriver})
}
func vmwareUnsupported(driverName string) {
if !driver.IsVMware(driverName) {
return
}
exit.Message(reason.DrvUnsupported, `Due to security improvements to minikube the VMware driver is currently not supported. Available workarounds are to use a different driver or downgrade minikube to v1.29.0.
We are accepting community contributions to fix this, for more details on the issue see: https://github.com/kubernetes/minikube/issues/16221
`)
}
func validateBuiltImageVersion(r command.Runner, driverName string) {
if driver.IsNone(driverName) {
return

2
go.mod
View File

@ -235,7 +235,7 @@ replace (
github.com/Parallels/docker-machine-parallels/v2 => github.com/minikube-machine/machine-driver-parallels/v2 v2.0.1
github.com/briandowns/spinner => github.com/alonyb/spinner v1.12.7
github.com/docker/machine => github.com/minikube-machine/machine v0.0.0-20230610170757-350a83297593
github.com/machine-drivers/docker-machine-driver-vmware => github.com/minikube-machine/machine-driver-vmware v0.1.5
github.com/machine-drivers/docker-machine-driver-vmware => github.com/lbogdan/docker-machine-driver-vmware v0.2.0
github.com/samalba/dockerclient => github.com/sayboras/dockerclient v1.0.0
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.22.4
)

2
go.sum
View File

@ -1084,6 +1084,8 @@ github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
github.com/lbogdan/docker-machine-driver-vmware v0.2.0 h1:ew0GbsB9/TeQjPO3nWgivOmx7EakXeMbS5kvArvddOM=
github.com/lbogdan/docker-machine-driver-vmware v0.2.0/go.mod h1:HifYFOWR0bAMN4hWtaSADClogvtPy/jV0aRC5alhrKo=
github.com/leodido/go-urn v1.2.0/go.mod h1:+8+nEpDfqqsY+g338gtMEUOtuK+4dEMhiQEgxpxOKII=
github.com/linode/linodego v1.4.0/go.mod h1:PVsRxSlOiJyvG4/scTszpmZDTdgS+to3X6eS8pRrWI8=
github.com/linuxkit/virtsock v0.0.0-20201010232012-f8cee7dfc7a3/go.mod h1:3r6x7q95whyfWQpmGZTu3gk3v2YkMi05HEzl7Tf7YEo=