Merge pull request #200 from aaron-prindle/configure-ram

Added --memory flag to minikube start so that users can configure the…
pull/205/head
Aaron Prindle 2016-06-13 18:25:08 -07:00 committed by GitHub
commit d8d4382cdc
5 changed files with 13 additions and 3 deletions

View File

@ -34,6 +34,7 @@ import (
var ( var (
minikubeISO string minikubeISO string
memory int
vmDriver string vmDriver string
) )
@ -53,6 +54,7 @@ func runStart(cmd *cobra.Command, args []string) {
config := cluster.MachineConfig{ config := cluster.MachineConfig{
MinikubeISO: minikubeISO, MinikubeISO: minikubeISO,
Memory: memory,
VMDriver: vmDriver, VMDriver: vmDriver,
} }
@ -153,5 +155,6 @@ func setupKubeconfig(name, server, certAuth, cliCert, cliKey string) (activeCont
func init() { func init() {
startCmd.Flags().StringVarP(&minikubeISO, "iso-url", "", constants.DefaultIsoUrl, "Location of the minikube iso") startCmd.Flags().StringVarP(&minikubeISO, "iso-url", "", constants.DefaultIsoUrl, "Location of the minikube iso")
startCmd.Flags().StringVarP(&vmDriver, "vm-driver", "", constants.DefaultVMDriver, fmt.Sprintf("VM driver is one of: %v", constants.SupportedVMDrivers)) startCmd.Flags().StringVarP(&vmDriver, "vm-driver", "", constants.DefaultVMDriver, fmt.Sprintf("VM driver is one of: %v", constants.SupportedVMDrivers))
startCmd.Flags().IntVarP(&memory, "memory", "", constants.DefaultMemory, "Amount of RAM allocated to the minikube VM")
RootCmd.AddCommand(startCmd) RootCmd.AddCommand(startCmd)
} }

View File

@ -16,6 +16,7 @@ minikube start
``` ```
--iso-url="https://storage.googleapis.com/minikube/minikube-0.3.iso": Location of the minikube iso --iso-url="https://storage.googleapis.com/minikube/minikube-0.3.iso": Location of the minikube iso
--memory=1024: Amount of RAM allocated to the minikube VM
--vm-driver="virtualbox": VM driver is one of: [virtualbox vmwarefusion] --vm-driver="virtualbox": VM driver is one of: [virtualbox vmwarefusion]
``` ```

View File

@ -155,6 +155,7 @@ type sshAble interface {
// MachineConfig contains the parameters used to start a cluster. // MachineConfig contains the parameters used to start a cluster.
type MachineConfig struct { type MachineConfig struct {
MinikubeISO string MinikubeISO string
Memory int
VMDriver string VMDriver string
} }
@ -268,6 +269,7 @@ func createHost(api libmachine.API, config MachineConfig) (*host.Host, error) {
case "virtualbox": case "virtualbox":
d := virtualbox.NewDriver(constants.MachineName, constants.Minipath) d := virtualbox.NewDriver(constants.MachineName, constants.Minipath)
d.Boot2DockerURL = config.MinikubeISO d.Boot2DockerURL = config.MinikubeISO
d.Memory = config.Memory
driver = d driver = d
case "vmwarefusion": case "vmwarefusion":
driver = createVMwareFusionHost(config) driver = createVMwareFusionHost(config)

View File

@ -25,6 +25,7 @@ import (
func createVMwareFusionHost(config MachineConfig) drivers.Driver { func createVMwareFusionHost(config MachineConfig) drivers.Driver {
d := vmwarefusion.NewDriver(constants.MachineName, constants.Minipath).(*vmwarefusion.Driver) d := vmwarefusion.NewDriver(constants.MachineName, constants.Minipath).(*vmwarefusion.Driver)
d.Boot2DockerURL = config.MinikubeISO d.Boot2DockerURL = config.MinikubeISO
d.Memory = config.Memory
// TODO(philips): push these defaults upstream to fixup this driver // TODO(philips): push these defaults upstream to fixup this driver
d.CPU = 1 d.CPU = 1

View File

@ -45,14 +45,17 @@ var LogFlags = [...]string{
"vmodule", "vmodule",
} }
const DefaultIsoUrl = "https://storage.googleapis.com/minikube/minikube-0.3.iso"
const DefaultVMDriver = "virtualbox"
var SupportedVMDrivers = [...]string{ var SupportedVMDrivers = [...]string{
"virtualbox", "virtualbox",
"vmwarefusion", "vmwarefusion",
} }
const (
DefaultIsoUrl = "https://storage.googleapis.com/minikube/minikube-0.3.iso"
DefaultMemory = 1024
DefaultVMDriver = "virtualbox"
)
const ( const (
RemoteLocalKubeErrPath = "/var/log/localkube.err" RemoteLocalKubeErrPath = "/var/log/localkube.err"
RemoteLocalKubeOutPath = "/var/log/localkube.out" RemoteLocalKubeOutPath = "/var/log/localkube.out"