From d6acf7f4cbfb77ca2f401bfe2565291299b1bf79 Mon Sep 17 00:00:00 2001 From: Priya Wadhwa Date: Mon, 5 Oct 2020 11:49:28 -0400 Subject: [PATCH] fix issues --- pkg/drivers/kic/kic.go | 5 ++++- test/integration/status_test.go | 3 +-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/drivers/kic/kic.go b/pkg/drivers/kic/kic.go index f49bf1526a..8a896118b3 100644 --- a/pkg/drivers/kic/kic.go +++ b/pkg/drivers/kic/kic.go @@ -157,6 +157,9 @@ func (d *Driver) Create() error { glog.Infof("duration metric: took %f seconds to extract preloaded images to volume", time.Since(t).Seconds()) } }() + if pErr == oci.ErrInsufficientDockerStorage { + return pErr + } if err := oci.CreateContainerNode(params); err != nil { return errors.Wrap(err, "create kic node") @@ -167,7 +170,7 @@ func (d *Driver) Create() error { } waitForPreload.Wait() - return pErr + return nil } // prepareSSH will generate keys and copy to the container so minikube ssh works diff --git a/test/integration/status_test.go b/test/integration/status_test.go index b78bc737d4..15b8a702f8 100644 --- a/test/integration/status_test.go +++ b/test/integration/status_test.go @@ -30,7 +30,6 @@ import ( "k8s.io/minikube/cmd/minikube/cmd" "k8s.io/minikube/pkg/minikube/constants" "k8s.io/minikube/pkg/minikube/localpath" - "k8s.io/minikube/pkg/minikube/reason" ) func TestInsufficientStorage(t *testing.T) { @@ -85,7 +84,7 @@ func verifyClusterState(t *testing.T, contents []byte) { t.Fatalf("unmarshalling: %v", err) } // verify the status looks as we expect - if cs.StatusCode != reason.ExInsufficientStorage { + if cs.StatusCode != cmd.InsufficientStorage { t.Fatalf("incorrect status code: %v", cs.StatusCode) } if cs.StatusName != "InsufficientStorage" {