kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

don't run test on None; make sure docker/minikube are on PATH before running skaffold

pull/8779/head
Priya Wadhwa 2020-07-22 15:17:20 -04:00
parent 9627b586bf
commit d4a33b3f98
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/integration/skaffold_test.go
View File

@ -34,6 +34,9 @@ import (
)
func TestSkaffold(t *testing.T) {
if NoneDriver() {
t.Skip("none driver doesn't support `minikube docker-env`, which skaffold requires")
}
// can't use a unique profile, as skaffold only recognizes the
// profile name 'minikube' as a local cluster
profile := "minikube"
@ -53,16 +56,22 @@ func TestSkaffold(t *testing.T) {
if err != nil {
t.Fatalf("starting minikube: %v\n%s", err, rr.Output())
}
// make sure "skaffold run" exits without failure
cmd := exec.CommandContext(ctx, tf.Name(), "run", "--kube-context", profile, "--status-check=true", "--port-forward=false")
cmd.Dir = "testdata/skaffold"
// make sure minikube binary is in path so that skaffold can access it
abs, err := filepath.Abs(Target())
if err != nil {
t.Fatalf("absolute path to minikube binary: %v", err)
}
os.Setenv("PATH", fmt.Sprintf("%s:%s", os.Getenv("PATH"), filepath.Dir(abs)))
// make sure 'docker' and 'minikube' are on PATH
for _, binary := range []string{"minikube", "docker"} {
rr, err := Run(t, exec.CommandContext(ctx, "which", binary))
if err != nil {
t.Fatalf("'which %v' failed: check if %v is on PATH\n%v", binary, binary, rr.Output())
}
}
// make sure "skaffold run" exits without failure
cmd := exec.CommandContext(ctx, tf.Name(), "run", "--kube-context", profile, "--status-check=true", "--port-forward=false")
cmd.Dir = "testdata/skaffold"
rr, err = Run(t, cmd)
if err != nil {
t.Fatalf("error running skaffold: %v\n%s", err, rr.Output())