From d370a3e164485efcf295fcde723e2fe2ab941f31 Mon Sep 17 00:00:00 2001
From: Priya Wadhwa <priyawadhwa@google.com>
Date: Mon, 23 Nov 2020 12:56:48 -0800
Subject: [PATCH] fix up script

---
 hack/metrics/metrics.go                | 11 +++++------
 site/content/en/docs/commands/start.md |  1 +
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/hack/metrics/metrics.go b/hack/metrics/metrics.go
index 8a7582cada..ad8602beb2 100644
--- a/hack/metrics/metrics.go
+++ b/hack/metrics/metrics.go
@@ -42,7 +42,7 @@ const (
 )
 
 var (
-	// The task latency in milliseconds.
+	// The task latency in seconds
 	latencyS = stats.Float64("repl/start_time", "start time in seconds", "s")
 )
 
@@ -56,7 +56,7 @@ func main() {
 func execute() error {
 	projectID := os.Getenv(projectEnvVar)
 	if projectID == "" {
-		return nil, fmt.Errorf("GCP tracer requires a valid GCP project id set via the %s env variable", projectEnvVar)
+		return fmt.Errorf("metrics collector requires a valid GCP project id set via the %s env variable", projectEnvVar)
 	}
 
 	osMethod, err := tag.NewKey("os")
@@ -64,7 +64,7 @@ func execute() error {
 		return errors.Wrap(err, "new tag key")
 	}
 
-	ctx, err := tag.New(context.Background(), tag.Insert(osMethod, runtime.GOOS), tag.Insert(driverMethod, "docker"))
+	ctx, err := tag.New(context.Background(), tag.Insert(osMethod, runtime.GOOS))
 	if err != nil {
 		return errors.Wrap(err, "new tag")
 	}
@@ -102,17 +102,16 @@ func execute() error {
 	}
 	defer sd.StopMetricsExporter()
 
-	// Record 2p0 start time values
 	for {
 		st := minikubeStartTime(ctx)
 		fmt.Printf("Latency: %f\n", st)
 		stats.Record(ctx, latencyS.M(st))
-		time.Sleep(2 * time.Second)
+		time.Sleep(30 * time.Second)
 	}
 }
 
 func minikubeStartTime(ctx context.Context) (float64, error) {
-	defer deleteMinikube(ctx, profile)
+	defer deleteMinikube(ctx)
 
 	minikube := filepath.Join(os.Getenv("HOME"), "minikube/out/minikube")
 
diff --git a/site/content/en/docs/commands/start.md b/site/content/en/docs/commands/start.md
index 122f0b407e..2cc6dd0d8b 100644
--- a/site/content/en/docs/commands/start.md
+++ b/site/content/en/docs/commands/start.md
@@ -87,6 +87,7 @@ minikube start [flags]
       --preload                           If set, download tarball of preloaded images if available to improve start time. Defaults to true. (default true)
       --registry-mirror strings           Registry mirrors to pass to the Docker daemon
       --service-cluster-ip-range string   The CIDR to be used for service cluster IPs. (default "10.96.0.0/12")
+      --trace string                      Send trace events. Options include: [gcp]
       --uuid string                       Provide VM UUID to restore MAC address (hyperkit driver only)
       --vm                                Filter to use only VM Drivers
       --vm-driver driver                  DEPRECATED, use driver instead.